anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-09 18:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Some comments about a better way to do things.

Browse Source 
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22760 a592a061-630c-0410-9148-cb99ea01b6c8
This commit is contained in:
Richard Heck 2008-02-03 08:51:58 +00:00
parent f8e11caef7
commit d4a87d0dce
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/frontends/qt4/GuiToolbar.cpp
View File

@ -269,6 +269,13 @@ void GuiLayoutBox::set(docstring const & layout)
void GuiLayoutBox::addItemSort(QString const & item, bool sorted)
{
//FIXME
//Since we are only storing the text used for display, we have no choice
//below but to compare translated strings to figure out which layout the
//user wants. This is not ideal. A better way is the way module names are
//handled in GuiDocument: viz, the untranslated name can be associated
//with the item via QComboBox::setItemData(). It may be that this can
//even be done by passing: addItem(item, untransName).
int const end = count();
if (!sorted || end < 2 || item[0].category() != QChar::Letter_Uppercase) {
addItem(item);
@ -314,10 +321,8 @@ void GuiLayoutBox::updateContents(bool reset)
TextClass::const_iterator it = text_class_->begin();
TextClass::const_iterator const end = text_class_->end();
for (; it != end; ++it) {
// ignore obsolete entries
for (; it != end; ++it)
addItemSort(toqstr(translateIfPossible((*it)->name())), lyxrc.sort_layouts);
}
setCurrentIndex(0);
@ -343,6 +348,10 @@ void GuiLayoutBox::selected(const QString & str)
TextClass::const_iterator const end = text_class_->end();
for (; it != end; ++it) {
docstring const & itname = (*it)->name();
//FIXME Comparing translated strings is not ideal.
//This should be done the way module names are handled
//in GuiDocument: viz, the untranslated name should be
//associated with the item via QComboBox::setItemData().
if (translateIfPossible(itname) == name) {
FuncRequest const func(LFUN_LAYOUT, itname,
FuncRequest::TOOLBAR);