anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-22 01:59:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix race condition in processFuncRequestQueue

Browse Source 
The issue here was that the element was only removed from the queue
after the func request was processed, but within that process, other
function could access the queue, so the queue could even be empty
when this function finally wanted to remove the item.

Fixes: #10406.
This commit is contained in:
Juergen Spitzmueller 2018-02-10 15:35:12 +01:00
parent 454f56b5f2
commit dadec50a18
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/frontends/qt4/GuiApplication.cpp
View File

@ -2271,8 +2271,12 @@ void GuiApplication::processFuncRequestAsync(FuncRequest const & func)
void GuiApplication::processFuncRequestQueue()
{
while (!d->func_request_queue_.empty()) {
processFuncRequest(d->func_request_queue_.front());
// take the item from the stack _before_ processing the
// request in order to avoid race conditions from nested
// or parallel requests (see #10406)
FuncRequest const fr(d->func_request_queue_.front());
d->func_request_queue_.pop();
processFuncRequest(fr);
}
}