anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-22 10:00:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Let M-x give focus to minibuffer when it is already open

Browse Source 
(cherry picked from commit 65b0e84b54)
This commit is contained in:
Jean-Marc Lasgouttes 2016-08-19 14:53:31 +02:00
parent e0730fe070
commit e2489c1c31
5 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/frontends/qt4/GuiToolbar.cpp
View File

@ -324,9 +324,8 @@ void GuiToolbar::add(ToolbarItem const & item)
void GuiToolbar::update(int context)
{
if (visibility_ & Toolbars::AUTO) {
bool const was_visible = isVisible();
setVisible(visibility_ & context & Toolbars::ALLOWAUTO);
if (isVisible() && !was_visible && commandBuffer())
if (isVisible() && commandBuffer() && (context & Toolbars::MINIBUFFER_FOCUS))
commandBuffer()->setFocus();
}

7
src/frontends/qt4/GuiView.cpp
View File

@ -513,7 +513,7 @@ QSet<Buffer const *> GuiView::GuiViewPrivate::busyBuffers;
GuiView::GuiView(int id)
: d(*new GuiViewPrivate(this)), id_(id), closing_(false), busy_(0),
command_execute_(false)
command_execute_(false), minibuffer_focus_(false)
{
// GuiToolbars *must* be initialised before the menu bar.
normalSizedIcons(); // at least on Mac the default is 32 otherwise, which is huge
@ -1564,6 +1564,10 @@ void GuiView::updateToolbars()
context |= Toolbars::IPA;
if (command_execute_)
context |= Toolbars::MINIBUFFER;
if (minibuffer_focus_) {
context |= Toolbars::MINIBUFFER_FOCUS;
minibuffer_focus_ = false;
}
for (ToolbarMap::iterator it = d.toolbars_.begin(); it != end; ++it)
it->second->update(context);
@ -3655,6 +3659,7 @@ void GuiView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
case LFUN_COMMAND_EXECUTE: {
command_execute_ = true;
minibuffer_focus_ = true;
break;
}
case LFUN_DROP_LAYOUTS_CHOICE:

2
src/frontends/qt4/GuiView.h
View File

@ -454,6 +454,8 @@ private:
/// Request to open the command toolbar if it is "auto"
bool command_execute_;
/// Request to give focus to minibuffer
bool minibuffer_focus_;
};

3
src/frontends/qt4/Toolbars.h
View File

@ -108,9 +108,10 @@ public:
TABLE = 256, //< show when in table
REVIEW = 512, //< show when change tracking is enabled
MATHMACROTEMPLATE = 1024, //< show in math macro template
SAMEROW = 2048, //place to the current row, no new line
SAMEROW = 2048, //< place to the current row, no new line
IPA = 4096, //< show when in IPA inset
MINIBUFFER = 8192, //< show when command-execute has been invoked
MINIBUFFER_FOCUS = 16384, //< set focus to minibuffer
ALLOWAUTO = MATH | TABLE | REVIEW | MATHMACROTEMPLATE | IPA | MINIBUFFER
};

2
status.22x
View File

@ -86,6 +86,8 @@ What's new
- Remove extra whitespace around Preview and IPA insets (bug 10304).
- Let M-x give focus to minibuffer when it is already open.
* INTERNALS