anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-12-22 21:21:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix memory error detected by valgrind

Browse Source 
The assignment name = sub.str(1) reads from the first argument given to
regex_match(), but previously this was a temporary object which was already
out of scope. This did probably not matter much in practice, but invoked
undefined behaviour, and as we all know this is allowed ton format your hard
disk or kill to your cat, so better fix this.
This commit is contained in:
Georg Baum 2014-11-17 22:08:21 +01:00
parent f146bded7a
commit e5845fea49
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/LaTeX.cpp
View File

@ -666,8 +666,8 @@ int LaTeX::scanLogFile(TeXErrors & terr)
size_t len = j == string::npos size_t len = j == string::npos
? token.substr(i + 1).length() ? token.substr(i + 1).length()
: j - i - 1; : j - i - 1;
if (regex_match(token.substr(i + 1, len), string const substr = token.substr(i + 1, len);
sub, child_file)) { if (regex_match(substr, sub, child_file)) {
string const name = sub.str(1); string const name = sub.str(1);
child.push(make_pair(name, pnest)); child.push(make_pair(name, pnest));
i += len; i += len;