anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-25 10:58:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

use std::move() instead of copying when value is no longer used

Browse Source 
This is mainly to shut down coverity which nowadays nags on this.
I am not sure whether we really gain something in these cases.
This commit is contained in:
Juergen Spitzmueller 2024-09-07 12:50:27 +02:00
parent 458f39cc43
commit e685d31f5a
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/BufferView.cpp
View File

@ -1707,7 +1707,7 @@ void BufferView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
string label = dit.innerParagraph().getLabelForXRef(); string label = dit.innerParagraph().getLabelForXRef();
if (!label.empty()) { if (!label.empty()) {
// if the paragraph has a label, we refer to this // if the paragraph has a label, we refer to this
string const arg = (type.empty()) ? label : label + " " + type; string const arg = (type.empty()) ? move(label) : move(label) + " " + type;
lyx::dispatch(FuncRequest(LFUN_REFERENCE_INSERT, arg)); lyx::dispatch(FuncRequest(LFUN_REFERENCE_INSERT, arg));
break; break;
} else { } else {

2
src/Encoding.cpp
View File

@ -798,7 +798,7 @@ docstring Encodings::convertLaTeXCommands(docstring const & str, bool const lite
if (!cnvtd.empty()) { if (!cnvtd.empty()) {
// it did, so we'll take that bit and proceed with what's left // it did, so we'll take that bit and proceed with what's left
ret += cnvtd; ret += cnvtd;
val = rem; val = move(rem);
continue; continue;
} }
// it's a command of some sort // it's a command of some sort

2
src/insets/InsetNomencl.cpp
View File

@ -440,7 +440,7 @@ docstring nomenclWidest(Buffer const & buffer)
msymb.size(); msymb.size();
if (wx > w) { if (wx > w) {
w = wx; w = wx;
symb = symbol; symb = move(symbol);
} }
} }
} }