Revert "Remove 'premature optimization' that proved buggy"

This reverts commit 894ae19224.

Fixes bug 10996.
This commit is contained in:
Jean-Marc Lasgouttes 2018-01-27 12:03:09 +01:00
parent 8cc7fe1c4b
commit f27d2cfa30

View File

@ -834,6 +834,11 @@ bool TextMetrics::breakRow(Row & row, int const right_margin) const
// the width available for the row.
int const width = max_width_ - row.right_margin;
if (pos >= end || row.width() > width) {
row.endpos(end);
return need_new_row;
}
#if 0
//FIXME: As long as leftMargin() is not correctly implemented for
// MARGIN_RIGHT_ADDRESS_BOX, we should also not do this here.
@ -852,7 +857,10 @@ bool TextMetrics::breakRow(Row & row, int const right_margin) const
// or the end of the par, then build a representation of the row.
pos_type i = pos;
FontIterator fi = FontIterator(*this, par, row.pit(), pos);
while (i < end && row.width() <= width) {
do {
// this can happen for an empty row after a newline
if (i >= end)
break;
char_type c = par.getChar(i);
// The most special cases are handled first.
if (par.isInset(i)) {
@ -934,7 +942,7 @@ bool TextMetrics::breakRow(Row & row, int const right_margin) const
++i;
++fi;
}
} while (i < end && row.width() <= width);
row.finalizeLast();
row.endpos(i);