anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-12-22 13:18:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid dereferencing an iterator at the end

Browse Source 
Found by coverity, could lead to a crash with badly formed kmap file.
This commit is contained in:
Jean-Marc Lasgouttes 2017-03-09 14:26:17 +01:00
parent 4569010b66
commit f7ab893def
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Trans.cpp
View File

@ -280,17 +280,17 @@ int Trans::load(Lexer & lex)
&& it->second[1] == accent_2)
break;
}
// could not find accent2 on a key -- this should not happen.
if (it == end)
return -1;
docstring allowed;
if (!lex.next())
return -1;
allowed = lex.getDocString();
LYXERR(Debug::KBMAP, "allowed: " << to_utf8(allowed));
// FIXME Coverity
// This is being flagged because we could in principle fail
// ever to hit the break above, in which case we exit the loop
// when it == end. Then this crashes.
insertException(kmod_list_[accent_1].exception_list,
it->first, allowed, true, accent_2);
}