From f7fbd8c1abcd66fbec053290ead3afcb3a5e0f08 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?G=C3=BCnter=20Milde?= <milde@lyx.org>
Date: Wed, 27 Mar 2019 14:39:08 +0100
Subject: [PATCH] Hebrew shindot and shindot but work fine as postfix.

---
 .../latex/unicodesymbols/012-31-hebrew_he-thai.lyx     | 10 +++++-----
 lib/unicodesymbols                                     |  8 +++++---
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/autotests/export/latex/unicodesymbols/012-31-hebrew_he-thai.lyx b/autotests/export/latex/unicodesymbols/012-31-hebrew_he-thai.lyx
index 0fe2331d6c..76f4fc3dda 100644
--- a/autotests/export/latex/unicodesymbols/012-31-hebrew_he-thai.lyx
+++ b/autotests/export/latex/unicodesymbols/012-31-hebrew_he-thai.lyx
@@ -6,7 +6,7 @@
 \origin unavailable
 \textclass article
 \begin_preamble
-\usepackage{textalpha}
+
 \end_preamble
 \use_default_options false
 \maintain_unincluded_children false
@@ -15,8 +15,8 @@
 \inputencoding utf8
 \fontencoding auto
 \font_roman "lmodern" "default"
-\font_sans "lmss" "default"
-\font_typewriter "lmtt" "default"
+\font_sans "default" "default"
+\font_typewriter "default" "default"
 \font_math "auto" "auto"
 \font_default_family default
 \use_non_tex_fonts false
@@ -141,7 +141,7 @@ status open
 
 \end_inset
 
- אֻ אּ אֽ ־ 
+ אֻ בּ אֽ ־ 
 \begin_inset Branch na
 inverted 0
 status open
@@ -173,7 +173,7 @@ status open
 
 \end_inset
 
- אׁ אׂ ׃ 
+ שׁ שׂ ׃ 
 \begin_inset Branch na
 inverted 0
 status open
diff --git a/lib/unicodesymbols b/lib/unicodesymbols
index 5752216224..e08c013afe 100644
--- a/lib/unicodesymbols
+++ b/lib/unicodesymbols
@@ -1101,7 +1101,8 @@
 # 12 Hebrew
 #
 #0x0591 ""               "" "combining,force" "" "" # HEBREW ACCENT ETNAHTA
-#			 
+# Fixme: Placement of the "nikud" (vowel) signs is bad.
+# Maybe try ideas from https://www.culturestrings.org/typography/culmusx/ ?
 0x05b0 "\\sheva"	 "" "combining,force" "" "" # HEBREW POINT SHEVA
 0x05b1 "\\hatafsegol" 	 "" "combining,force" "" "" # HEBREW POINT HATAF SEGOL
 0x05b2 "\\hatafpatah"	 "" "combining,force" "" "" # HEBREW POINT HATAF PATAH
@@ -1119,8 +1120,9 @@
 0x05be "\\maqaf"         "" "force=cp1255;utf8;utf8-cjk" "" "" # HEBREW PUNCTUATION MAQAF
 #0x05bf ""                "" "combining,force" "" "" # HEBREW POINT RAFE
 #0x05c0 ""                "" "" "" ""    	     # HEBREW PUNCTUATION PASEQ
-0x05c1 "\\shindot"       "" "combining,force" "" "" # HEBREW POINT SHIN DOT
-0x05c2 "\\sindot"        "" "combining,force" "" "" # HEBREW POINT SIN DOT
+# shindot and shindot are actually combining unicode characters but work fine as postfix
+0x05c1 "\\shindot"       "" "force=cp1255;utf8;utf8-cjk" "" "" # HEBREW POINT SHIN DOT
+0x05c2 "\\sindot"        "" "force=cp1255;utf8;utf8-cjk" "" "" # HEBREW POINT SIN DOT
 0x05c3 "\\sofpasuq"      "" "force=cp1255;utf8;utf8-cjk" "" "" # HEBREW PUNCTUATION SOF PASUQ
 #0x05c4 ""                "" "combining,force" "" "" # HEBREW MARK UPPER DOT
 #0x05c5 ""                "" "combining,force" "" "" # HEBREW MARK LOWER DOT