Georg Baum
b24664b0ac
Remove unused variables found by cppcheck
...
There are still a few warnings of the kind
(style) Variable 'x' is assigned a value that is never used.
since I did not touch code where I was not sure whether there might be a real
bug, and I kept some for symmetry reasons as well.
2015-09-20 21:39:59 +02:00
Richard Heck
fdbe775b9f
This is the result of an audit of all static variables, looking
...
for possible thread conflicts, of the sort Georg resolved at
6a30211f
. I have made static variables const where possible,
and marked cases that looked potentially problematic with the
comment:
// FIXME THREAD
Many of these definitely are vulnerable to concurrent access, such
as the static variables declared at the start of output_latex.cpp.
Suppose, e.g., we were outputting latex and also displaying the
source of a different document.
I'd appreciate it if others could grep for "FIXME THREAD" and see
if some of these are harmless, or what.
2014-04-21 11:51:57 -04:00
Julien Rioux
26568ce1e2
Fix the file filters for InsetInclude.
...
Add an empty filter for listings and verbatim includes. This will
display as the standard string "All files (*)".
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@39673 a592a061-630c-0410-9148-cb99ea01b6c8
2011-09-13 20:43:06 +00:00
Richard Heck
82d6524298
Fix bug #7540 . Patch based upon one added to bug report by Max Funk.
...
Basically, patch adds routine that calcuates relative paths to parent
rather than child directories.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38915 a592a061-630c-0410-9148-cb99ea01b6c8
2011-06-01 13:18:08 +00:00
Vincent van Ravesteijn
c5b9664476
Remove the name parameter from string2params and params2string. We can always derive the name with insetName(params.code()).
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35891 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-29 00:25:28 +00:00
Pavel Sanda
adbc064959
Camelize another slot
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@29808 a592a061-630c-0410-9148-cb99ea01b6c8
2009-05-23 09:06:50 +00:00
Vincent van Ravesteijn
0de1e7730f
Fix bug #4510 : GuiInclude->Edit marks master as changed.
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@29129 a592a061-630c-0410-9148-cb99ea01b6c8
2009-04-06 20:10:13 +00:00
André Pönitz
1fc477efac
thrid attempt at changing the naming pattern of the intermediated 'mocced' files
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@27420 a592a061-630c-0410-9148-cb99ea01b6c8
2008-11-14 14:28:50 +00:00
Jürgen Spitzmüller
3ddfec9ae0
* GuiInclude.cpp:
...
- prevent assertion (listings parameters can have non-ascii chars)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26632 a592a061-630c-0410-9148-cb99ea01b6c8
2008-09-30 06:51:08 +00:00
Richard Heck
dc9146d250
Patch from Vincent van Ravesteijn.
...
I noticed that for instance the Hyperlink Dialog loses all information when clicking on the main buffer. The same occurs with the Include Child Document Dialog and probably also others.
Do you agree on this being less intuitive ? If so, I included a small patch that will fix this for the two dialogs mentioned. I just adapted them to the design of the GuiGraphics Dialog.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26096 a592a061-630c-0410-9148-cb99ea01b6c8
2008-08-08 15:29:26 +00:00
Jürgen Spitzmüller
1458cd52b7
* implement "inset-edit" in InsetInclude.
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24528 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-27 18:03:21 +00:00
André Pönitz
b271b9f0f6
compile fix
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24406 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-21 06:36:06 +00:00
André Pönitz
aff97fe9b5
move the filefilter stuff closer to the only place where it is used
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24395 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-20 19:56:01 +00:00
André Pönitz
5158ef3ee9
merge GuiCommand into its users.
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24376 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-20 09:24:14 +00:00
Richard Heck
8a69ffd3bf
Complete the removal of the embedding stuff. Maybe. It's hard to be sure we got everything, but this does compile, and it seems to work at least reasonably well. Any problems should of course be reported to the list.
...
For the record, this developer is sorry that the problems with this code were not noticed much earlier. It's not fun to do so much work and then have it all reverted.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24373 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-20 03:08:11 +00:00
Bo Peng
2fd9be2143
Embedding: disinfect GuiInclude.cpp, GuiExternal.cpp, and GuiGraphics.cpp
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24317 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-17 18:19:17 +00:00
Richard Heck
66a94937c3
EmbeddedFile::enable() should take a reference instead of a pointer.
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24055 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-29 23:32:52 +00:00
Bo Peng
ded962802e
Embedding: prepare params()[embed] in GuiInclude rather than InsetInclude
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23708 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-13 14:16:47 +00:00
André Pönitz
990df4924a
more of that
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23497 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-06 00:07:19 +00:00
André Pönitz
88293cbcfb
a few more docstring<->QString conversions
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23493 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-05 23:10:53 +00:00
Abdelrazak Younes
ba76bf5eb8
header cleanup
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23048 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-17 20:47:04 +00:00
Abdelrazak Younes
9f3c7cf1ea
Factorize closeEvent() for GuiDialog based dialogs.
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23045 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-17 20:16:14 +00:00
Abdelrazak Younes
6bb94129d8
Factorize out the way window titles are handled.
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22784 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-05 12:43:19 +00:00
Bo Peng
f52b73747f
Embedding: saving inzip name to .lyx file so that embedded files can always be found under different operating systems (even lyx versions). yet to be tested under windows
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22486 a592a061-630c-0410-9148-cb99ea01b6c8
2008-01-10 23:39:58 +00:00
Bo Peng
c81fd7337d
Embedding: add embedding support for InsetInclude. (params["embed"] is added)
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22441 a592a061-630c-0410-9148-cb99ea01b6c8
2008-01-08 16:35:43 +00:00
Abdelrazak Younes
b89cc942eb
'using namespace lyx::support' instead of 'using support::xxx'
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22103 a592a061-630c-0410-9148-cb99ea01b6c8
2007-12-12 18:57:56 +00:00
Abdelrazak Younes
9383f4c3c6
'using namespace std' instead of 'using std::xxx'
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22097 a592a061-630c-0410-9148-cb99ea01b6c8
2007-12-12 10:16:00 +00:00
André Pönitz
9d0ea8aeff
Move debug.{cpp,h}, Messages.{cpp,h} and gettext.{cpp,h} to support/.
...
Now support/* should have no dependencies on src/* anymore.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21851 a592a061-630c-0410-9148-cb99ea01b6c8
2007-11-29 07:04:28 +00:00
Abdelrazak Younes
42015a8ebd
Transfer some more dialog related code from core to frontend:
...
- LFUN_INSET_APPLY handling goes to GuiView.
- Dialog needs a GuiView instead of a LyXView.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21734 a592a061-630c-0410-9148-cb99ea01b6c8
2007-11-23 09:44:02 +00:00
André Pönitz
77821e11c1
merge helper files;
...
remove duplicated lyx::frontend::setAutoTextCB(QCheckBox*, QLineEdit*, LengthCombo*)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21455 a592a061-630c-0410-9148-cb99ea01b6c8
2007-11-05 22:20:23 +00:00
Richard Heck
a0a04e4886
Make GuiRef and GuiInclude subclasses of GuiCommand.
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21264 a592a061-630c-0410-9148-cb99ea01b6c8
2007-10-29 16:51:07 +00:00
André Pönitz
9be03a87f9
start some work on file dialogs
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21238 a592a061-630c-0410-9148-cb99ea01b6c8
2007-10-28 16:32:20 +00:00
Richard Heck
dc45268132
Fix compilation problem due to same static variable in different files.
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21207 a592a061-630c-0410-9148-cb99ea01b6c8
2007-10-25 21:39:47 +00:00
Richard Heck
2f4d0ae27e
Remove methods marked for removal from InsetCommandParams. Yeah, we can do that now. ;-)
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21154 a592a061-630c-0410-9148-cb99ea01b6c8
2007-10-23 18:51:04 +00:00
Richard Heck
4064d2c468
InsetInclude becomes an InsetCommand.
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21149 a592a061-630c-0410-9148-cb99ea01b6c8
2007-10-23 15:02:15 +00:00
André Pönitz
f762cbf3c6
mainly cosmetics
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21079 a592a061-630c-0410-9148-cb99ea01b6c8
2007-10-20 10:03:45 +00:00
Richard Heck
e158e07c29
InsetCommandParams() now takes an InsetCode rather than a string.
...
These changes are just adaptations to the new signature.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21072 a592a061-630c-0410-9148-cb99ea01b6c8
2007-10-19 17:22:55 +00:00
André Pönitz
a02653e4dd
isome more FileName shuffling
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21048 a592a061-630c-0410-9148-cb99ea01b6c8
2007-10-18 23:03:51 +00:00
André Pönitz
6f3cdf8da8
move Controller inheritance further up the tree
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@20870 a592a061-630c-0410-9148-cb99ea01b6c8
2007-10-09 19:34:27 +00:00
André Pönitz
035ec3b14e
next one
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@20780 a592a061-630c-0410-9148-cb99ea01b6c8
2007-10-06 12:03:13 +00:00
André Pönitz
470aba2a0e
cosmetics
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@20217 a592a061-630c-0410-9148-cb99ea01b6c8
2007-09-11 18:33:42 +00:00
André Pönitz
34492a9d03
less functions
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@20216 a592a061-630c-0410-9148-cb99ea01b6c8
2007-09-11 17:06:15 +00:00
André Pönitz
94e61a3bc9
shuffle some frontend stuff around. merge controller(base) and "Kernel". Make frontend::Dialog pure virtual
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@20202 a592a061-630c-0410-9148-cb99ea01b6c8
2007-09-10 22:32:59 +00:00
Edwin Leuven
2ec54cfde7
more frontend cleanup
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@20172 a592a061-630c-0410-9148-cb99ea01b6c8
2007-09-09 15:56:58 +00:00
André Pönitz
c9ea6e6eef
the fun begins....
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@20077 a592a061-630c-0410-9148-cb99ea01b6c8
2007-09-05 20:33:29 +00:00
André Pönitz
9a95d2a936
rename a few view functions from foo() to fooView()
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@20024 a592a061-630c-0410-9148-cb99ea01b6c8
2007-09-03 20:28:26 +00:00
André Pönitz
212386be8a
merge ButtonController and its view (Qt2BC in this case)
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@20018 a592a061-630c-0410-9148-cb99ea01b6c8
2007-09-03 05:59:32 +00:00
André Pönitz
904fd84bba
all CheckedWidgets are line edits...
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@19988 a592a061-630c-0410-9148-cb99ea01b6c8
2007-09-02 08:19:43 +00:00
André Pönitz
fc36725282
Merge QController into individual dialogs. Also various cleanup
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@19961 a592a061-630c-0410-9148-cb99ea01b6c8
2007-08-31 22:16:11 +00:00
André Pönitz
a1cec91afa
move our stuff off the Q* namespace
...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@19935 a592a061-630c-0410-9148-cb99ea01b6c8
2007-08-31 05:53:55 +00:00