False positive rate of hints is quite high. Although the includes can be
technically removed (due to other includes) they logically belong to the
header.
- First, the comment for isBufferDependent is corrected. It seems that the actual use of this function differs from the comment. As the comment said, I decided to close all dialogs that were buffer dependent, but this didn't seem to be correct for the view source pan, the outliner, and find-and-replace.
- Second, the dialogs that are buffer dependent are now closed, but dockviews are not, except for the spellchecker pane, which really depends on an open buffer, but I can't test that.
So, please test whether the spellchecker dockviewed window behaves as one expects.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@34291 a592a061-630c-0410-9148-cb99ea01b6c8
This new attempt replace the previous attempt with InsetDialog which was still too tight with the older framework.
Status:
float, ert, box, info: migrated
vspace: migrated but buggy. To be fixed later.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33480 a592a061-630c-0410-9148-cb99ea01b6c8
- transfer ans simplify a bit the CheckedLineEdit class from ButtonController.
* InsetDialog:
- Pimpl private data
- applyView(): now a slot, check widget before applying.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33350 a592a061-630c-0410-9148-cb99ea01b6c8
This way we get rid of pop-uping of widgets when ~/.config/LyX is re-created
and yet we still have title and enabling status correct when widgets are
restored from session.
Some details in bug #5082.
This is candidate for branch too.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@30144 a592a061-630c-0410-9148-cb99ea01b6c8
This change makes it possible (at long last!) to go to the work area, do some edition and then come back to the SpellChecker. We probably need a [Continue] button.
* Buffer::nextWord(): go back a bit to return the current word.
* SpellChecker and Dialog: get rid of the complicated, useless exitEarly() handling.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@29092 a592a061-630c-0410-9148-cb99ea01b6c8
* InsetInfo::validate(): new method for checking dispatch argument. Not implemented yet.
* GuiInfo: remove non working code and rework the dialog following my vision of an ideal info dialog :-) not every thing works yet.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@25153 a592a061-630c-0410-9148-cb99ea01b6c8
* GuiDialog now inherits DialogView. GuiDialog is only there to bring the ButtonController archaeological interface; any new dialog should inherit DialogView and any new dock widget should inherit DockView.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22049 a592a061-630c-0410-9148-cb99ea01b6c8
The problem was that name_ was a const pointer and the pointer pointed to nothing after leaving the ctor.
Andre': <docstring> is included in every dialog anyway via GuiDialog.h -> InsetCommandParams.h -> docstring.h"; so this change won't affect compilation time.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22012 a592a061-630c-0410-9148-cb99ea01b6c8
- LFUN_INSET_APPLY handling goes to GuiView.
- Dialog needs a GuiView instead of a LyXView.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21734 a592a061-630c-0410-9148-cb99ea01b6c8
