Commit Graph

47090 Commits

Author SHA1 Message Date
Juergen Spitzmueller
fd78a25a7c Only issue currentWorkareaChanged() if the work area really changed.
(this function can be called repeatedly while the work area doesn't
change any further)
2024-06-23 14:52:02 +02:00
Juergen Spitzmueller
026c4bd726 Fixup [152811a27d242/lyxgit]
tabBarClicked() should really only reset focus if a click in a different
TabBarGroup happened. And no need to issue workAreaChanged() again.

This has lead to extra and erroneous focus changes (see #12954)
2024-06-23 14:47:43 +02:00
Juergen Spitzmueller
8659924abd \cprotect amendment
\cprotect'ed insets do not need forced local font switch; in fact files
with this break in compilation. E.g. a caption with an URL containing
the char '#' and caption text set to a secondary language.
2024-06-22 13:38:47 +02:00
Jean-Marc Lasgouttes
45dce93af7 redoParagraph: avoid extra cache accesses
To this end, CoordCacheBase::add returns true when a change was made.
This uses the return value of std::unordered_map::insert.
2024-06-21 17:02:13 +02:00
Jean-Marc Lasgouttes
608929a857 Rename DocumentCLass:plainInsetLayout() to InsetLayout::undefined()
This makes the code easier to understand.
2024-06-20 18:29:41 +02:00
Jean-Marc Lasgouttes
c4531741a9 Fix cursor when undoing accept/reject all changes
Before this change, the whole document would remain selected.

This relies on the new UndoGroupHelper constructor introduced at e7b1ee47.
2024-06-20 18:02:33 +02:00
Jean-Marc Lasgouttes
e7b1ee47ea Add a constructor of UndoGroupHelper that uses a CursorData parameter
This aloows to se the the `before' cursor of the undo group.

Not used for now.
2024-06-20 17:52:19 +02:00
Jean-Marc Lasgouttes
f643057779 Remove useless cursor parameter to global undo actions
Add a Cursor-less version of Undo::recordUndoBufferParams (we don't
use an optional arument to avoir #includ'ing Cursor.h).

The version with CursorData parameter has been kept for the case of
local dictionary lfuns that have some kind of locality.

Remove Cursor argument to Undo::recordUndoFullBuffer().
2024-06-20 17:25:25 +02:00
Jean-Marc Lasgouttes
c7c16fe9fa Remove trailing underscore on members x and y of Point class.
These members are not private.
2024-06-20 16:37:05 +02:00
Jean-Marc Lasgouttes
b78d2a4eda Add missing override keyword 2024-06-19 15:05:45 +02:00
Enrico Forestieri
66ef66ca0d Avoid bogus warnings when configuring for Qt6
Recent versions of qmake complain loudly when the locale
does not explicitley specify the utf8 codeset. Specifically,
the configure script exports LC_ALL=C and that implies the
ascii codeset. Previously, this was silently changed to utf8,
whereas now we get a warning for each qmake invocation.
So, explicitly set utf8 before calling qmake.
2024-06-18 21:56:15 +02:00
Jean-Marc Lasgouttes
c263463cad Move DrawStrategy enum to update_flags.h.
Introduce new drawStrategy() and drawStrategyDescription() methods to
frontend::Application.

Show the current draw strategy in About dialog.
2024-06-18 18:26:34 +02:00
José Matos
95a7440b0e Sort and format comments
The last code change shuffled the comments out of place
2024-06-18 10:52:05 +01:00
José Matos
44e0940d75 Order imports
This is similar to what we have in C++ code where we order the standard
includes to be easier to read.

This is a readability change only.
2024-06-18 10:25:52 +01:00
José Matos
5abe42f6d3 Tweak ruff configuration
Add I - isort rules (order of imports);
Ignore line too long warnings.
2024-06-18 10:24:09 +01:00
Enrico Forestieri
fe64db4b70 Add xcb lib if x11extras is detected
In this case we use directly some xcb api outside of the Qt framework
and hence we have to add the xcb library by ourselves.
2024-06-17 21:57:24 +02:00
Jean-Marc Lasgouttes
5d76b4bb8f Support qmake with Qt5 too
This extends the support of qmake to Qt5. Currently, the other
configuration methods are tried if qmake fails, but a message is
printed.

A nice goal would be to get rid of those legacy methods (pkg-config,
plain autoconf-style), if this proves possible.
2024-06-17 17:09:04 +02:00
José Matos
4534a20f1a Fix functions that used functions but did not defined it
The functions were selected from the parser files where document is
always defined.

The only case was this code was used was on document.warning.

Since our documents are well formed this code was never active and thus
the reason why we did not saw this before.

One possible solution to assure that these type of errors do not occur
is to make the convention that all the functions in lyx2lyx_tools have
as the first argument document.
2024-06-17 11:31:10 +01:00
Scott Kostyshak
1a87c5313d Adapt to deprecation of \DeclareCollectionInstance
Change LaTeX output of smallLetterFrac. For more information, see:

  https://tex.stackexchange.com/questions/720579/do-i-need-to-replace-declarecollectioninstance-after-recent-package-change/

This fixes 44 failing tests from 074-76-letterlike-numberforms-arrows.lyx
that started failing after a tlmgr update around 2024-06-04.
2024-06-16 11:50:34 -04:00
Juergen Spitzmueller
9d3bd6a3a2 more indentation fixes 2024-06-16 16:16:59 +02:00
Juergen Spitzmueller
c243126eb4 GuiDocument: do not ask switch-back question on document closing 2024-06-16 15:54:50 +02:00
Juergen Spitzmueller
3fa2623ca0 Fix indentation 2024-06-16 15:54:50 +02:00
Juergen Spitzmueller
3d78d8734d Fix indentation 2024-06-16 15:54:50 +02:00
José Matos
160ac7242e Remove undisclosed imports (from xxx import *)
This was the last example in this directory.
2024-06-16 07:45:43 +01:00
José Matos
b80ccaa417 Add common pattern in linter exclusion list
# ambiguous-variable-name (E741)

Derived from the **pycodestyle** linter.

## What it does
Checks for the use of the characters 'l', 'O', or 'I' as variable names.

## Why is this bad?
In some fonts, these characters are indistinguishable from the
numerals one and zero. When tempted to use 'l', use 'L' instead.

## Reason to ignore in LyX?
With appropriated fonts that is not an issue. In our case we just use
the 'l', in particular in the context of iterators: 'i', 'j', 'k', 'l'.
2024-06-16 07:34:34 +01:00
Juergen Spitzmueller
0fc8ee5ace Prevent division by zero
Fixes crash reported at
https://marc.info/?l=lyx-users&m=171842978728676
2024-06-15 14:48:37 +02:00
Juergen Spitzmueller
9fff7bdd5a de/UserGuide: updates 2024-06-15 14:29:26 +02:00
José Matos
a0a5892ae8 Fix code
Run "ruff check --fix"

Remove unneeded imports;
Reword code to make clear the "not in" operator;
Put imports in its own line (readability);
2024-06-15 11:26:28 +01:00
José Matos
b4db3ea137 Reformat lyx2lyx code using ruff 2024-06-15 10:06:06 +01:00
José Matos
aaef6d2693 Add pyproject.toml file to manage some options for tools
This file is only relevant for tools that use it, in development, and so
it is not supposed to be installed. It does not harm but there is no
purpose.
2024-06-15 10:04:31 +01:00
Pavel Sanda
1e5c366d53 Add comment from dev list. 2024-06-14 22:40:22 +02:00
Pavel Sanda
e5b027759c * UG - note about gnuplot from Tobias Hilbricht 2024-06-14 21:18:29 +02:00
Daniel Ramoeller
92aeaf5d73 Fix depth bar optics 2024-06-14 16:28:04 +02:00
José Matos
ef5f142b9a Update python requirements notice in INSTALL 2024-06-13 10:44:56 +01:00
Juergen Spitzmueller
ea1f3099cf update tex2lyx tests 2024-06-13 07:49:32 +02:00
Udi Fogiel
3854086e59 Remove hebrew letter document class
The only difference from regular letter is the alignment of
"Send To Address" layout, but it no longer reflect the output
corrctly, probably because LyX revert the alignment of layouts
in RTL context now.
2024-06-11 21:14:27 +03:00
Jean-Marc Lasgouttes
b54d352075 InsetMathMacoTemplate: recompute metrics on editXY too
This inset can change dimensions when edited (like macros can).
Therefore Update::SinglePar should be set with editXY() like it is
already set for edit().
2024-06-11 17:04:58 +02:00
Jean-Marc Lasgouttes
f48cf46101 Add "full" drawing strategy
With this patch, 3 draw strategies (set in prefs with
\draw_strategy partial|backingstore|full) are available:

- "partial": only draw the parts of text that have changed since last
  paint event (default for X11 and windows)

- "backingstore": the same, but drawing happens on an offspring
  pixmap; this breaks subpixel rendering (default for Wayland and
  macOS)

- "full": the screen is fully redrawn at each paint event and should
  therefore always be correct; this is presumably slower but
  introducing it will allow to test it.

This would deserve a proper UI eventually.
2024-06-11 15:17:22 +02:00
Kornel Benko
9ace073cc5 Update sk.po 2024-06-11 13:27:46 +02:00
Jean-Marc Lasgouttes
30338ec6b3 Remove debug code that is not very useful as it is. 2024-06-10 20:33:27 +02:00
Alexander Dunlap
8c501308c3 FindAdv: Omitting cursor advance at start of search if in mathed.
Fixes #13070 Advanced S&R does not find math symbols at start of document
2024-06-10 14:46:07 +02:00
Udi Fogiel
a5749b9c1f Fix change tracking colors with RTL languages (#12923) 2024-06-10 15:19:08 +03:00
Udi Fogiel
ee43584140 Fix greyedout with RTL languages (#8647) 2024-06-10 15:03:05 +03:00
José Matos
c92b481a44 Reformat imports for easier reading
This is in line with the current hints for better readability:

* one import per line;
* order the imports alphabetically to be easier to search;

Take the chance to remove unused imports.
2024-06-10 12:05:03 +01:00
José Matos
aeee6b373e Update generate contributions to Python 3+ 2024-06-10 11:43:04 +01:00
José Matos
04ecabef60 Update Python scripts to Python 3+
Remove support for Python 2

Use formatted strings where appropriated
2024-06-10 11:29:56 +01:00
José Matos
f9ec4186d7 Update lyx2lyx folder to Python 3+
Remove support for Python 2
Take advantage of new features (euphemism) not possible before due to
python 2 compatibility
2024-06-10 10:55:40 +01:00
José Matos
df0e337684 Update configure.py to Python3+
Remove Python 2 support

This simplifies the code and allows to use other more modern features,
like formatted strings, that were not possible while keeping Python 2
compatibility.
2024-06-10 10:38:28 +01:00
José Matos
b86059ee6d Update build time Python requirement to 2.8 (cmake edition) 2024-06-10 10:33:33 +01:00
José Matos
1d2f8b94cb Update Python build time requirement to 3.8 2024-06-10 10:10:39 +01:00