Richard Kimberly Heck
1e904625b2
Remove functors in PreviewLoader.cpp.
...
Also fix some warnings.
2020-05-13 13:33:27 -04:00
Jean-Marc Lasgouttes
c756749991
Revert "Get rid of lyx::next uses for RandomAccessList"
...
This is not ready (see #11861 ).
This reverts commit 6d97e39934
.
2020-05-13 10:45:25 +02:00
Juergen Spitzmueller
2663e3845e
Move \PassOptionsToPackage before the first package loaded
...
Fixes #11862
2020-05-13 08:48:08 +02:00
Jean-Marc Lasgouttes
e52af39864
Avoid a warning
2020-05-12 17:42:50 +02:00
Jean-Marc Lasgouttes
6d97e39934
Get rid of lyx::next uses for RandomAccessList
...
These uses are inefficient (a loop really) and require that pit_type
is ptrdiff_t.
Instead, RandomAccesslist::constIterator is renamed to iterator_at and
a version adding a non-const iterator is added.
lyx::next and lyx::prev are removed, and std::prev is used in the few
places where the code requires it (for no good reason IMO).
2020-05-12 17:29:21 +02:00
Richard Kimberly Heck
b1a0f7ac54
Fix typo (from Thibaut)
2020-05-08 13:32:08 -04:00
Richard Kimberly Heck
195c0bfbad
Rename some routines
2020-05-05 11:19:21 -04:00
Richard Kimberly Heck
5989160154
Remove functors in IndicesList.cpp.
2020-05-05 11:19:21 -04:00
Richard Kimberly Heck
958958453f
Replace functors in Format.cpp.
2020-05-05 11:16:28 -04:00
Richard Kimberly Heck
7f875d7dac
Replace functor in BranchList
2020-05-05 11:16:24 -04:00
Richard Kimberly Heck
c506f304bc
Fix a number of issues that were stopping compilation with MSVC 19.
...
Patch from Thibaut Cuvelier, modified slightly by me (mostly for style).
2020-05-04 19:45:58 -04:00
Richard Kimberly Heck
91265c1f46
Missing include according to VC19
2020-05-04 14:19:29 -04:00
Richard Kimberly Heck
d6a7ec506e
s/requires_/required_/ for code consistency
2020-05-04 14:05:44 -04:00
Richard Kimberly Heck
3b09ef61a6
Fix remaining (I think) requires keyword issues.
2020-05-04 13:46:01 -04:00
Scott Kostyshak
23abb5aaa3
Fix commented out code
...
Since the if condition changed at af4ee1a4
, the "else" in the
comment needed correction.
2020-05-04 09:27:35 -04:00
Scott Kostyshak
af4ee1a487
Only set dummy X11 selection if we do not own it
...
Before, we would continually set the selection to the empty string,
to maintain ownership. This causes problems with clipboard managers
GPaste and CopyQ. Further, in theory this should have better
performance since checking ownership should be faster than setting.
A disadvantage of this change is that the timestamp of the selection
will be old at this point in the code. However, when the selection
is requested, we put the selection contents at that point so the
selection timestamp should be accurate then. Further, the selection
contents are not accurate at this point in the code (they are just
the empty string), so it is not clear whether having an accurate
timestamp is beneficial.
Fixes #11715 .
2020-05-04 08:58:56 -04:00
Juergen Spitzmueller
210c4aa9a2
Use translated GUI name of counter in button label
2020-05-04 09:28:07 +02:00
Juergen Spitzmueller
5171b7ea6c
Keep sort order of counter actions
2020-05-04 09:22:35 +02:00
Richard Kimberly Heck
5f5cb7eea7
Fix warnings by using size_t as the loop variable.
2020-05-03 15:02:40 -04:00
Richard Kimberly Heck
e8800373e6
is_utf8 is always passed a char.
2020-05-03 15:02:25 -04:00
Juergen Spitzmueller
eebc0d8cf5
Add missing l7n flag
2020-05-03 13:36:34 +02:00
Juergen Spitzmueller
fba67710d8
Make counter items translatable and sort properly
2020-05-03 09:44:55 +02:00
Juergen Spitzmueller
6e5f90f72f
Fix capitalization
...
We use sentence casing in combo boxes.
2020-05-03 09:13:41 +02:00
Juergen Spitzmueller
cd2c0dcc81
Re-fix layout
...
Also improve some strings, and fix capitalization
2020-05-03 09:13:13 +02:00
Richard Kimberly Heck
9e4709e4de
Avoid a copy
2020-05-03 02:52:56 -04:00
Richard Kimberly Heck
3b2bcef455
Fix some warnings.
2020-05-03 02:46:11 -04:00
Richard Kimberly Heck
99948beff8
Remove unused files.
2020-05-03 02:32:29 -04:00
Richard Kimberly Heck
16e7f26cec
requires is a keyword in C++2a
2020-05-03 02:18:17 -04:00
Richard Kimberly Heck
a38408419c
Remove obsolete comment.
...
We assert (or worse) if pos < 0.
2020-05-03 00:51:01 -04:00
Richard Kimberly Heck
0f4b60c642
GuiNames for float counters.
2020-05-02 23:17:17 -04:00
Richard Kimberly Heck
9bcb243ec6
Increment layout format.
2020-05-02 23:17:16 -04:00
Richard Kimberly Heck
666f90cdbb
Use GuiNames for counters.
2020-05-02 23:17:16 -04:00
Richard Kimberly Heck
c37500050d
More polishing of counter dialog. Thanks to Jürgen for help.
...
Also, remove the 'display value' option. We will move this to InsetInfo
at some point.
2020-05-02 20:33:03 -04:00
Juergen Spitzmueller
3d630f49c4
Fix broken mark with multiple citations
...
Patch by Patrick De Visschere (modified by me)
2020-05-02 08:55:58 +02:00
Richard Kimberly Heck
8a4bb40c7e
Fix typo.
2020-05-01 19:47:50 -04:00
Richard Kimberly Heck
bc4ca12ab5
Polish the counter UI a bit and add some to the documentation.
2020-05-01 19:03:54 -04:00
Juergen Spitzmueller
4d3a08bf86
Fix build with qt4
2020-05-01 10:17:04 +02:00
Juergen Spitzmueller
a05b3228bc
Fix Ui layouts.
2020-05-01 10:10:27 +02:00
Richard Kimberly Heck
de40b09474
Fix thinkos for counter value type
2020-04-30 23:46:18 -04:00
Richard Kimberly Heck
cb9102f986
Update tex2lyx references.
2020-04-30 23:21:34 -04:00
Richard Kimberly Heck
9a147255df
GUI for new counter inset.
2020-04-30 23:11:59 -04:00
Richard Kimberly Heck
9a1b26a156
Format and reversion code for new counter inset.
2020-04-30 23:11:59 -04:00
Richard Kimberly Heck
684d27c0fb
New counter manipulation inset.
...
This inset allows counters to be set, reset, saved, restored, etc,
both in the LyX GUI and in the output; optionally, the effect can be
limited to the GUI. Of course, LaTeX provides means for doing all of
these things, so they could previously be done with ERT, as far as
the output is concerned. But there was no mechanism for manipulating
counters in the GUI and none for other output formats.
2020-04-30 23:09:36 -04:00
Jean-Marc Lasgouttes
7035e230ca
Avoid some more copies in range-based for loops
...
This triggers warnings with clang++ 10.
2020-04-28 15:28:51 +02:00
Jean-Marc Lasgouttes
a85c48de5a
Do not for copies in range-based for loops.
...
Spotted by clang++ 10.
2020-04-28 13:27:50 +02:00
Richard Kimberly Heck
1344caa67a
Fix problem with c67b6be77
noted by JMarc.
2020-04-26 16:10:50 -04:00
Richard Kimberly Heck
c94a97e36c
Fix declaration
2020-04-26 03:37:20 -04:00
Richard Kimberly Heck
491c966436
Remove unnecessary friendship. Thanks Scott!
2020-04-26 03:16:44 -04:00
Richard Kimberly Heck
7b9dc7bc9e
Revert last three commits.
...
There are other issues here. The big one is in TextMetrics::getPitNearY,
where -1 is used as a 'special' return value for pit.
2020-04-26 03:09:27 -04:00
Richard Kimberly Heck
c92b4f27ec
Fix compilation problem
2020-04-26 03:04:06 -04:00