Commit Graph

79 Commits

Author SHA1 Message Date
Jean-Marc Lasgouttes
f3656600f9 Use UndoGroupHelper to track undo group lifetime 2017-11-29 14:55:56 +01:00
Richard Heck
75bfed5507 Fix trailing whitespace in cpp files. 2017-07-03 13:53:14 -04:00
Guillaume Munch
bb344452c8 Consistency of ellipses across the UI
Use the function support:truncateWithEllipsis() to shorten a docstring with
... at the end. Actually we use U+2026 HORIZONTAL ELLIPSIS instead of "..." when
automatically shortening strings. This is to be consistent with Qt's own
truncation and is much nicer on the screen.

This includes the bugs #9575 and #9572 regarding broken text elision in the
outliner.

Known issues (non-regressions):

* TocBackend::updateItem() should be rewritten to update all TOCs. (#8386)

* "..." should be replaced with … everywhere else on the interface (including
  translation strings).

* We should prefer to rely on QFontMetrics::elidedText() to truncate strings
  with an ellipsis whenever possible, or an equivalent for the buffer view
  dependent on the font metrics. See the warning in src/support/lstrings.h.
2015-10-05 21:16:16 +01:00
Georg Baum
7adc6125f7 Fix missing symbols in math completer
The math icons for the symbol image in the math completer were hardcoded to the
command names. This is wrong for some icons for various reasons, e.g. the case
insensitivity of windows file systems. Therefore we have to use the replacement
list which is also used for the toolbar icons. Bug #3538 is not closed because
of this problem, but IMHO it has nothing to do with this bug, it is a more
general one.
2015-02-14 20:32:25 +01:00
Pavel Sanda
4c0ef38200 Header cleanup cont. 2013-05-19 18:07:53 -07:00
Richard Heck
1b1f8dd235 Audit all the LASSERT calls, and try to do something sensible at
each failure.

There are several places I was not sure what to do. These are marked
by comments beginning "LASSERT:" so they can be found easily. At the
moment, they are at:

Author.cpp:105: // LASSERT: What should we do here?
Author.cpp:121: // LASSERT: What should we do here?
Buffer.cpp:4525:        // LASSERT: Is it safe to continue here, or should we just return?
Cursor.cpp:345:         // LASSERT: Is it safe to continue here, or should we return?
Cursor.cpp:403:         // LASSERT: Is it safe to continue here, or should we return?
Cursor.cpp:1143:                // LASSERT: There have been several bugs around this code, that seem
CursorSlice.cpp:83:     // LASSERT: This should only ever be called from an InsetMath.
CursorSlice.cpp:92:     // LASSERT: This should only ever be called from an InsetMath.
LayoutFile.cpp:303:                     // LASSERT: Why would this fail?
Text.cpp:995:           // LASSERT: Is it safe to continue here?
2013-04-25 17:27:10 -04:00
Stephan Witt
141fbb6f8c Prepare LyX code to compile and link with Qt5:
* some functionality is in new modules now
  new header locations and library names: QtConcurrent and QtWidgets
* method setResizeMode is renamed to setSectionResizeMode
* deprecated QAbstractItemModel::reset() is dropped now
* platform specific code like QApplication::syncX() is not common anymore
* QString::fromAscii() is dropped now
* some QDesktopServices methods has been moved to QStandardPaths
2013-02-03 19:26:21 +01:00
Pavel Sanda
e43f9d3bbd Revert a6e42e5079.
Removing debug.h makes debugging via lyxerr<< twice as hard.
2012-06-28 20:52:20 +02:00
Uwe Stöhr
a6e42e5079 removed unused includes
these files don't use the debug.h and also don't contain commented out debug code
2012-06-26 22:41:53 +02:00
Richard Heck
8cabbae616 The Cursor argument here was not being used, so there is no need
for the indirection.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@40339 a592a061-630c-0410-9148-cb99ea01b6c8
2011-12-02 22:44:38 +00:00
Richard Heck
8c69aca339 Add constness in several places.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@40338 a592a061-630c-0410-9148-cb99ea01b6c8
2011-12-02 22:41:33 +00:00
Richard Heck
8b6d6eecfd Remove unused optional argument.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@40337 a592a061-630c-0410-9148-cb99ea01b6c8
2011-12-02 22:27:14 +00:00
Abdelrazak Younes
52ef90c2cf GuiWorkArea: Move private stuff to GuiWorkArea_Private.h.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@39872 a592a061-630c-0410-9148-cb99ea01b6c8
2011-10-16 22:48:26 +00:00
Enrico Forestieri
6159350368 Limit fix for bug #6063 to math insets and only when inline completion
is disabled in math.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@39337 a592a061-630c-0410-9148-cb99ea01b6c8
2011-07-18 08:10:20 +00:00
Jean-Marc Lasgouttes
940ab1261b Fix part of bug #7072 by opening undo groups as needed.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@36597 a592a061-630c-0410-9148-cb99ea01b6c8
2010-11-29 16:38:13 +00:00
Vincent van Ravesteijn
e52a8ba627 Revert r32909: make input completion case sensitive again.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35864 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-27 08:45:21 +00:00
Richard Heck
6a80ce62ca DispatchResult::update() ==> DispatchResult::screenUpdate()
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35631 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-13 17:28:55 +00:00
Uwe Stöhr
7d68833dc9 remove unused include of FuncRequest
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35189 a592a061-630c-0410-9148-cb99ea01b6c8
2010-08-24 03:07:09 +00:00
Richard Heck
0e14f379f3 Rename a couple routines. This will avoid confusion with a forthcoming
patch.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@34816 a592a061-630c-0410-9148-cb99ea01b6c8
2010-07-08 20:04:35 +00:00
Richard Heck
cd78e02a24 Minor code cleanup.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@34636 a592a061-630c-0410-9148-cb99ea01b6c8
2010-06-09 15:14:22 +00:00
Vincent van Ravesteijn
8156884090 Make Cursor::disp_ private as it should be.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@34144 a592a061-630c-0410-9148-cb99ea01b6c8
2010-04-15 17:34:34 +00:00
Vincent van Ravesteijn
834115c920 Fix bug #6552: Crash when inserting TeX-code in math mode and scrolling
Avoid an assertion when accessing the CoordCache while the Inset is in a paragraph which is not visible on screen.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33582 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 15:59:08 +00:00
Abdelrazak Younes
377cdd5f6c Transfer LyXfunc code to GuiApplication::dispatch() and getStatus(). Now
a lot of simplification is possible. Except some instability period...


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33389 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-09 16:11:13 +00:00
Vincent van Ravesteijn
ecc2b2f2e0 Make the auto-completion case-insensitive.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@32909 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-09 14:16:42 +00:00
Enrico Forestieri
d2e8e53bb1 Fix bug #6063: Keylogger lyx::lyxbreaker: Crash in Math.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@30497 a592a061-630c-0410-9148-cb99ea01b6c8
2009-07-12 10:52:28 +00:00
André Pönitz
6192345f60 add Buffer * member to DocIterator
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@27603 a592a061-630c-0410-9148-cb99ea01b6c8
2008-11-17 11:46:07 +00:00
Stefan Schimanski
ac14102b79 * complete-accept directly completes if the completion is unique
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@27564 a592a061-630c-0410-9148-cb99ea01b6c8
2008-11-16 17:02:40 +00:00
Stefan Schimanski
f54ef5c173 * open popup on complete-accept if there is a completion available
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@27561 a592a061-630c-0410-9148-cb99ea01b6c8
2008-11-16 16:34:16 +00:00
André Pönitz
1fc477efac thrid attempt at changing the naming pattern of the intermediated 'mocced' files
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@27420 a592a061-630c-0410-9148-cb99ea01b6c8
2008-11-14 14:28:50 +00:00
Abdelrazak Younes
6a8219c190 Paragraph:
- constify some parameters
- getFontSettings():
- getFirstFontSettings(): return a const ref instead of a copy. This brings a consistent 4% improvement in LateX generation. Might speedup rtl handling too.



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26957 a592a061-630c-0410-9148-cb99ea01b6c8
2008-10-19 07:03:44 +00:00
Dov Feldstern
140958f4a3 this entire method can now be removed (thanks for pointing this out, Bernhard!)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@25120 a592a061-630c-0410-9148-cb99ea01b6c8
2008-06-04 21:05:27 +00:00
Dov Feldstern
6fb8b95a28 whitespace
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@25119 a592a061-630c-0410-9148-cb99ea01b6c8
2008-06-04 19:52:16 +00:00
Dov Feldstern
dba608e1d7 fix completion painting for RTL (inline completion and completion list)
see http://permalink.gmane.org/gmane.editors.lyx.devel/107923 for an 
explanation, though note that this patch is more extensive than the one
attached there


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@25118 a592a061-630c-0410-9148-cb99ea01b6c8
2008-06-04 19:45:26 +00:00
Bernhard Roider
0d4ab86261 Fix item delegate for qt 4.2:
In the completion-listbox rtl-Text does not work like it does for newer qt and icons are not displayed for math symbols.
The rtl handling is incorrect atm but now it works the same way for all versions of qt.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@25108 a592a061-630c-0410-9148-cb99ea01b6c8
2008-06-03 22:00:47 +00:00
Pavel Sanda
e8b84b9cfb from_utf8(fromqstr -> qstring_to_ucs4 .
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24619 a592a061-630c-0410-9148-cb99ea01b6c8
2008-05-05 17:04:02 +00:00
Jean-Marc Lasgouttes
9b4a26a252 rename assert.h to lassert.h
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24559 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-30 08:26:40 +00:00
André Pönitz
5d61ceb81d fix #4758
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24416 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-21 19:12:15 +00:00
André Pönitz
7f461f4392 infrastructure for 'graceful asserts'
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24216 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-10 21:49:34 +00:00
André Pönitz
8d52dfee32 A hack to prevents an additional redraw when the scrollbar pops up
when creating/loading a document.
This regularily happens on documents with more than one page.



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24138 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-06 11:52:11 +00:00
André Pönitz
f2c9b56fb4 cosmetics/#include cleanup
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23747 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-15 00:22:54 +00:00
Stefan Schimanski
3225232f86 * fix wrong slot name
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23488 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-05 20:34:09 +00:00
Stefan Schimanski
cdf8979160 * cosmetic
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23485 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-05 19:00:26 +00:00
Stefan Schimanski
9c05593876 * rich text item delegate to draw the layout filter as underline
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23472 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-05 12:00:56 +00:00
Stefan Schimanski
de518abff5 * even setModel can trigger focus events. So move also those into
asynchronous handlers.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23438 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-04 12:44:48 +00:00
Stefan Schimanski
a90096d4d5 * cosmetic
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23425 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-04 09:43:42 +00:00
Stefan Schimanski
b4466b63f6 * fix another crash due to the redraw opti-/minimization during
completion. We have to show and hide the popup asynchronously with a
singleshot timer. Otherwise it might trigger accesses to the coord
cache although the metrics have not been done yet.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23424 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-04 09:43:32 +00:00
Stefan Schimanski
a4b2404cb1 * work around for the bad memory of the treeview about the column width
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23423 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-04 09:43:16 +00:00
Stefan Schimanski
f847fb64f8 * Hide popup asynchronously because we might be here inside of
LFUN dispatchers. Hiding a popup can trigger a focus event on the
  workarea which then redisplays the cursor. But the metrics are not
  yet up to date such that the coord cache has not all insets yet. The
  cursorPos methods would triggers asserts in the coord cache then.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23416 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-03 15:44:08 +00:00
Stefan Schimanski
7406991fd4 * fix assert with 4.2.x when setting a null item delegate on an item view.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23414 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-03 15:10:48 +00:00
Stefan Schimanski
5d0e49d4dc * fix a memory corruption due to sligtly different semantics of btree iterators:
// We use the key() method here, and not something like it->first
       // because the btree only returns (iterator-) temporary value pairs.
       // If we returned the first component of those here, we get an
       // invalid reference and therefore strange crashes.
       return it.key();

* This should fix the completion for Windows users hopefully.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23321 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-28 14:46:47 +00:00