Commit Graph

24069 Commits

Author SHA1 Message Date
Richard Heck
56d89dbff9 This is worth having here anyway.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33703 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 18:43:10 +00:00
Richard Heck
0bddd759d7 Another try at #6522. This works here, for the most part, with no ill
effects that I can see. That said, I believe there is still a crash you
could get. I'll explain in a moment.

Since we may run into this kind of thing again, let me explain why this
is necessary. The problem was that resetting the model was causing a
signal to be emitted that the current index had changed, which was
triggering an update of the Buffer, eventually. I'm not sure why this
did not happen in Qt 4.5, but in Qt 4.6, you have to call
beginResetModel() before doing anything, so that the combo box will
remember its previous setting. Then you can change the data; then you
can call endResetModel(). This will attempt to restore the previous
setting. Only if it cannot do so will currentIndexChanged() be emitted.

You can see, therefore, that if whatever the user did caused the current
setting to become invalid---e.g., she deleted the only footnote---then
the signal will be emitted and LyX will still crash. Still, that is a
fair bit better than presently.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33702 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 18:41:28 +00:00
Vincent van Ravesteijn
039807ed28 Adjust some messages and constify a variable.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33701 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 17:03:53 +00:00
Vincent van Ravesteijn
f225a6d8b6 Remove superfluous std::.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33700 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 17:01:40 +00:00
Vincent van Ravesteijn
16c74c7f25 Add a comment.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33699 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 17:01:08 +00:00
Vincent van Ravesteijn
a866d2e1a9 Add missing continue. I guess I found this when running latex with a symbol file with some windows encoding or line-ends.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33698 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 16:58:20 +00:00
Vincent van Ravesteijn
5d60104a69 Whitespace.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33697 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 16:57:01 +00:00
Vincent van Ravesteijn
cd5d57e504 Do not use const char *.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33696 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 16:56:13 +00:00
Vincent van Ravesteijn
ab5c1c7408 Initialize number_index and unit_index in isValidGlueLength(). This is now the same as in isValidLength(), so I assume it's OK.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33695 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 16:35:40 +00:00
Vincent van Ravesteijn
6200f4852b Small simplification and remove unneeded std::.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33694 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 15:11:31 +00:00
Vincent van Ravesteijn
fd507aecf4 Fix typos.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33693 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 15:09:44 +00:00
Vincent van Ravesteijn
f23a2ccb58 Fix bug #6488: Avoid a null pointer when accessing documentBufferView when there is none.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33692 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 14:46:28 +00:00
Pavel Sanda
b9f89e8eb6 * Announce
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33691 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 07:31:33 +00:00
Jean-Marc Lasgouttes
b8bbd7aea9 Cleanup InsetTabular::getStatus
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33690 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-09 23:04:59 +00:00
Jean-Marc Lasgouttes
19031e2345 Restore some sanaity in InsetInfo lfuns (bug #6580)
The context menu is wrong, I do not know why.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33689 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-09 23:04:35 +00:00
Edwin Leuven
684def2036 simplify
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33688 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-09 19:21:32 +00:00
Edwin Leuven
93830fd28d avoid crash when calling inset_modify with cursor not in table
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33687 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-09 19:07:54 +00:00
Richard Heck
42a2a0f289 Cheap fix for #6554. When we save a Buffer to a new location, we check
the included insets and make sure that the files they reference are
still where they are supposed to be.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33686 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-09 03:25:47 +00:00
Richard Heck
4a07f1d0e2 Unused variable.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33684 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 20:54:31 +00:00
Richard Heck
d70f91a380 Line length, again.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33683 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 20:48:48 +00:00
Richard Heck
6f624ab79b Change updateLayout() to updateDocumentClass(), since that is what it
does.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33682 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 20:37:11 +00:00
Richard Heck
2cb20b211c Line length.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33681 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 20:22:37 +00:00
Richard Heck
c653974e9d Revert r33630 and do something more sensible.
I don't think this fixes the underlying problem, but I think that
problem is very extensive. Fixing it would involve a re-thinking of
where and how we call updateBuffer()---the old updateLabels().

This fix also reveals another problem with the TOC, again due to the
early call of on_typeCO_currentIndexChanged(). But that problem is a
slightly different one, I think.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33680 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 19:52:48 +00:00
Richard Heck
8a6b77bfe1 Introduce isBufferValid() method now, that returns true also for cloned
Buffers. Use it, as well.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33679 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 19:07:05 +00:00
Richard Heck
a2e06a3c15 Eliminate redundancy.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33678 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 19:06:28 +00:00
Richard Heck
821cffab63 s/isBufferValid/isBufferLoaded/
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33677 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 18:57:42 +00:00
Richard Heck
5a4e241df4 Cloned buffers routinely have their parents reset.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33676 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 14:56:49 +00:00
Richard Heck
13746b6d82 Micro-optimization.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33675 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 14:55:33 +00:00
Richard Heck
b1d5168109 Fix bug #6516. Under no circumstances do we want to try to reload a
child document from within the export thread.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33674 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 14:25:32 +00:00
Richard Heck
da4a77c4ae Whoops. Wrong version.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33673 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 13:36:51 +00:00
Richard Heck
e4d8746461 Minor fixup.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33672 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 13:34:32 +00:00
Abdelrazak Younes
27657b3b75 isValidGlueLength(): fix gcc warning and cleanup.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33671 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 13:33:47 +00:00
Richard Heck
45287844fa Add sanity check. This partially fixes a crash related to saving master
documents to new locations.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33670 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 13:26:08 +00:00
Richard Heck
483c891705 Spellcheck related bugfix from John McCabe-Dansted:
PrefSpellchecker disables the "Spellchecker Engine:" selector if
theSpellChecker() reports that no spell checking engine is selected.
This means that if we have not already selected a spell checking
engine we cannot select one now. I think this problem can be
reproduced by first compiling and running LyX without spellchecking
support and then compiling and running LyX with spellchecking support.

In any case it is clear that we should be able to select a
spellchecking engine if one is available, so I propose the attached
patch. This patch fixed the problem on my machine.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33669 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 13:22:56 +00:00
Richard Heck
60034997d9 Make sure the model exists before we access it.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33668 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 12:42:18 +00:00
Peter Kümmel
92ebfe89e7 no Q_EMIT in older Qt versions
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33667 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 09:35:10 +00:00
Edwin Leuven
f7ef9c3e6e lil' cleanup
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33666 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 04:08:11 +00:00
Edwin Leuven
f313bd6a90 erratum to r33628
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33665 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 04:04:56 +00:00
Jürgen Spitzmüller
316b332ec7 * es.po: update (by Ignacio).
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33664 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-07 18:20:04 +00:00
Edwin Leuven
ece4da2f01 fix cursor position(ing)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33663 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-07 17:33:33 +00:00
Peter Kümmel
97651ca03c Use one place to generate current time string, increase resolution to ms
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33662 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-07 11:55:14 +00:00
Peter Kümmel
257dce79d9 cmake: fix merge build
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33661 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-07 11:28:57 +00:00
Peter Kümmel
3a5d681a9b cmake: fix merge build
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33660 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-07 11:03:23 +00:00
Jürgen Spitzmüller
0ba07aa57d * RELEASE_NOTES:
- some notes on the spellchecker/thesaurus changes and requirements.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33656 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-07 09:29:33 +00:00
Enrico Forestieri
6acdfc7698 Update the cygwin requirements.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33655 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-07 01:00:58 +00:00
Enrico Forestieri
a951aec809 Was forgetting this.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33654 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-06 23:04:39 +00:00
Enrico Forestieri
5c3bd0443b Update README.Cygwin
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33653 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-06 22:38:47 +00:00
Enrico Forestieri
47a2f125a4 Update it.po
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33652 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-06 21:14:01 +00:00
Abdelrazak Younes
b8390b5e2c Try to restore longtable dialog to a semi functional state. This Dialog is really horrible, disabling/enabling a checkbox depending on the cursor position is very unintuitive... We need some edit boxes to show which rows are header/footer/etc without having to move the cursor first. That would be my next step newt week.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33651 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-06 19:08:10 +00:00
Pavel Sanda
e1ce86214b * NEWS - add skeleton for 1.6.0 at least
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33650 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-06 18:51:36 +00:00