Commit Graph

94 Commits

Author SHA1 Message Date
Jean-Marc Lasgouttes
a756403301 "Performance" fixes suggested by cppcheck
While cppcheck did not turn out any suspicious error messages, using
the "performance" flag highlighted several nitpicks in three categories
 * do not use it++ for iterators, ++it is better
 * do not use size() to test for emptyness, empty() is here
 * do not use "const T" as a function parameter, "const & T" is better

I doubt that any of these is a real performance problem, but the code is cleaner anyway.
2012-05-28 22:42:44 +02:00
Georg Baum
9fe72c3501 Move readBB_from_PSFile() out of support (no code change),
since it soon will need to use the Formats class.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@40757 a592a061-630c-0410-9148-cb99ea01b6c8
2012-02-15 20:50:52 +00:00
Richard Heck
82d6524298 Fix bug #7540. Patch based upon one added to bug report by Max Funk.
Basically, patch adds routine that calcuates relative paths to parent
rather than child directories.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38915 a592a061-630c-0410-9148-cb99ea01b6c8
2011-06-01 13:18:08 +00:00
Pavel Sanda
aef9d84e83 Disentangle various "in"s
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@36613 a592a061-630c-0410-9148-cb99ea01b6c8
2010-11-30 00:55:34 +00:00
Jean-Marc Lasgouttes
60445ede53 remove unused headers
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35129 a592a061-630c-0410-9148-cb99ea01b6c8
2010-08-12 09:38:22 +00:00
Pavel Sanda
61fa96cbae Dialog::bufferFilepath -> Dialog::bufferFilePath
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@34241 a592a061-630c-0410-9148-cb99ea01b6c8
2010-04-21 01:19:30 +00:00
Pavel Sanda
9d43d32240 DocFileName.outputFilename -> DocFileName.outputFileName
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@34238 a592a061-630c-0410-9148-cb99ea01b6c8
2010-04-21 01:19:25 +00:00
Pavel Sanda
62ca7f3ae5 Proper camel case for FileName.absFilename
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@34234 a592a061-630c-0410-9148-cb99ea01b6c8
2010-04-21 01:19:09 +00:00
Pavel Sanda
90ce0c669f This is still needed for keyboard focus
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31878 a592a061-630c-0410-9148-cb99ea01b6c8
2009-11-06 15:56:15 +00:00
Pavel Sanda
5db67312e8 Fix bug #3852.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31874 a592a061-630c-0410-9148-cb99ea01b6c8
2009-11-06 15:22:17 +00:00
Jean-Marc Lasgouttes
0e5695f933 fix another warning
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@30518 a592a061-630c-0410-9148-cb99ea01b6c8
2009-07-12 17:54:35 +00:00
Jean-Marc Lasgouttes
91d7e3b191 (try 2) fix a couple warnings after the number localization patch
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@30517 a592a061-630c-0410-9148-cb99ea01b6c8
2009-07-12 17:32:23 +00:00
Jean-Marc Lasgouttes
c355edfb6d revert r30515: too many files there
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@30516 a592a061-630c-0410-9148-cb99ea01b6c8
2009-07-12 17:30:56 +00:00
Jean-Marc Lasgouttes
834bfe5e21 fix a couple warnings after the number localization patch
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@30515 a592a061-630c-0410-9148-cb99ea01b6c8
2009-07-12 17:28:46 +00:00
Jürgen Spitzmüller
52d9b45b0c Add support for number localization in the GUI (using Qt's locale facilities).
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@30511 a592a061-630c-0410-9148-cb99ea01b6c8
2009-07-12 15:44:26 +00:00
Jürgen Spitzmüller
660ce9aab6 stickToCodingConventions.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@29807 a592a061-630c-0410-9148-cb99ea01b6c8
2009-05-23 08:01:38 +00:00
Jürgen Spitzmüller
9f48cc9137 whitespace.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@29778 a592a061-630c-0410-9148-cb99ea01b6c8
2009-05-22 16:00:29 +00:00
Jean-Marc Lasgouttes
29117ed909 compilation warning: unused parameter
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@28509 a592a061-630c-0410-9148-cb99ea01b6c8
2009-02-16 10:05:40 +00:00
Jean-Marc Lasgouttes
26751d83ee Move the half baked code that guesses whether to default on metric or
imperial units in only one place (instead of thousands of slightly different
copies). Functionally equivalent.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@28380 a592a061-630c-0410-9148-cb99ea01b6c8
2009-02-06 21:24:13 +00:00
Jürgen Spitzmüller
933ab5545c * InsetGraphics.{cpp.h}:
- add possibility to count graphics group members.

* GuiGraphics.{cpp, h}:
	- warning message if a deserted group is going to be dissolved

* GraphicsUI.ui:
	- terminology.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@28198 a592a061-630c-0410-9148-cb99ea01b6c8
2009-01-17 08:02:52 +00:00
Pavel Sanda
5a6cdebbf2 Now not needed
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@28186 a592a061-630c-0410-9148-cb99ea01b6c8
2009-01-16 15:58:42 +00:00
Jürgen Spitzmüller
be4beae809 * GuiGraphics.cpp:
- remove redundant line.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@28185 a592a061-630c-0410-9148-cb99ea01b6c8
2009-01-16 15:39:29 +00:00
Jürgen Spitzmüller
c248ed757b * GuiGraphics.{cpp,h}:
* GraphicsUi.ui:
	- polish UI for graphics groups.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@28184 a592a061-630c-0410-9148-cb99ea01b6c8
2009-01-16 14:54:25 +00:00
Jürgen Spitzmüller
94442d8b30 * qt_helpers.{cpp,h}:
- get rid of function lengthAutoToWidgets, which was only used by GuiGraphics
	- new variant of lengthToWidgets that takes a docstring

* Validator.{cpp,h}:
	- the auto text in the Auto validators are customizable

* GuiGraphics.cpp:
	- make the "auto" string translatable

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@28165 a592a061-630c-0410-9148-cb99ea01b6c8
2009-01-14 17:53:31 +00:00
Pavel Sanda
5701383b40 Add editable combobox for groups in graphics dialogs as discussed in
http://www.mail-archive.com/lyx-users@lists.lyx.org/msg70194.html


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@28160 a592a061-630c-0410-9148-cb99ea01b6c8
2009-01-14 15:10:15 +00:00
Pavel Sanda
da24e05566 Cosmetics
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@28137 a592a061-630c-0410-9148-cb99ea01b6c8
2009-01-13 21:09:47 +00:00
André Pönitz
f1cba8ff64 more latin1..utf8 schanges. all of src/* should be utf8 now
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@27425 a592a061-630c-0410-9148-cb99ea01b6c8
2008-11-14 15:58:50 +00:00
André Pönitz
1fc477efac thrid attempt at changing the naming pattern of the intermediated 'mocced' files
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@27420 a592a061-630c-0410-9148-cb99ea01b6c8
2008-11-14 14:28:50 +00:00
Jean-Marc Lasgouttes
6cd921678b move code to unify graphics groups from GuiGraphics to InsetGraphics
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26540 a592a061-630c-0410-9148-cb99ea01b6c8
2008-09-25 13:24:52 +00:00
Jean-Marc Lasgouttes
efb2fb3e53 create a proper undo group before unifying graphics group (crystal clear, isn t it?)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26508 a592a061-630c-0410-9148-cb99ea01b6c8
2008-09-23 21:57:23 +00:00
Abdelrazak Younes
4a1be58591 - Simplify prefs, graphics and external display options which are now true or false.
- the display combo in the prefs, external and graphics dialogs are gone
- the lyxrc display_graphics option now overrides any local inset display option
- The external template format has a new tag: Preview
- format incremented to 337


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@25245 a592a061-630c-0410-9148-cb99ea01b6c8
2008-06-13 07:34:55 +00:00
Pavel Sanda
5b99af2237 Fix button enabling for graphics input.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24947 a592a061-630c-0410-9148-cb99ea01b6c8
2008-05-26 17:56:48 +00:00
Pavel Sanda
13e42a8c73 Introduce groups for graphics insets. That includes:
- GuiGraphics dialog field for setup new groups.
- Graphics context menu for assigning to certain group.
- Fileformat change for groupId field in Graphics inset.
- Undo mechanism added to inset-apply, for catching changes
  in preference dialog.
- Qt designer 4.4 used now.



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24644 a592a061-630c-0410-9148-cb99ea01b6c8
2008-05-06 21:13:09 +00:00
Abdelrazak Younes
99b12faae4 Fix 4603 for GuiGraphics. I guess most GuiDialog based dialog need fixing...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24643 a592a061-630c-0410-9148-cb99ea01b6c8
2008-05-06 15:18:50 +00:00
Pavel Sanda
14257be476 Squelch annoying debug dump.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24630 a592a061-630c-0410-9148-cb99ea01b6c8
2008-05-06 09:55:12 +00:00
André Pönitz
b271b9f0f6 compile fix
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24406 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-21 06:36:06 +00:00
André Pönitz
a657380659 cosmetics
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24397 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-20 21:05:35 +00:00
André Pönitz
aff97fe9b5 move the filefilter stuff closer to the only place where it is used
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24395 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-20 19:56:01 +00:00
Richard Heck
2d9a818f37 Fix bug 4772, which was revealed by the removal of the embedding stuff. But the bug itself traces to r22188.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24394 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-20 17:59:14 +00:00
Richard Heck
8a69ffd3bf Complete the removal of the embedding stuff. Maybe. It's hard to be sure we got everything, but this does compile, and it seems to work at least reasonably well. Any problems should of course be reported to the list.
For the record, this developer is sorry that the problems with this code were not noticed much earlier. It's not fun to do so much work and then have it all reverted.



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24373 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-20 03:08:11 +00:00
André Pönitz
05f321db17 cosmetics
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24331 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-18 19:17:11 +00:00
André Pönitz
d307a338da cosmetics
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24330 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-18 18:53:43 +00:00
Bo Peng
2fd9be2143 Embedding: disinfect GuiInclude.cpp, GuiExternal.cpp, and GuiGraphics.cpp
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24317 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-17 18:19:17 +00:00
Richard Heck
66a94937c3 EmbeddedFile::enable() should take a reference instead of a pointer.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24055 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-29 23:32:52 +00:00
André Pönitz
f9b81e51e9 remove remaining MailInsets.
please check your favourite insets, I am sure I broke _something_...



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24006 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-27 22:26:24 +00:00
Jürgen Spitzmüller
c6007086b1 * src/frontends/qt4/GuiGraphics.{cpp,h}:
* src/frontends/qt4/ui/GraphicsUi.ui:
	- now that we have a context menu to edit graphics, remove the Edit button
	  from the dialog, as discussed in this thread:
	  http://marc.info/?l=lyx-devel&m=118344997913166&w=2

The same should be done for other insets that have an edit function.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23911 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-24 09:32:34 +00:00
Bo Peng
dc177e2546 Embedding: move file validation from InsetGraphics to GuiGraphics
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23709 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-13 16:49:04 +00:00
André Pönitz
8be59017cf cosmetics
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23553 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-08 08:20:36 +00:00
André Pönitz
990df4924a more of that
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23497 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-06 00:07:19 +00:00
Jürgen Spitzmüller
ac1977018b ** subfig support **
* src/Buffer.cpp:
* development/FORMAT:
	- bump format to 316.

* src/insets/InsetFloat.{cpp, h}:
	- let nested floats be subfloats
	  NOTE: docbook support is missing.
* src/insets/InsetCaption.{cpp, h}:
	- handle subfigure captions
* src/insets/InsetGraphics.cpp:
* src/insets/InsetGraphicsParams.{cpp, h}:
	- remove old subfigure support

* lib/chkconfig.ltx:
* lib/doc/LaTeXConfig.lyx:
	- check for subfig instead of subfigure.

* lib/lyx2lyx/LyX.py:
* lib/lyx2lyx/lyx_1_6.py:
	- conversion/reversion routines for subfig -> subfloats
	  NOTE: the reversion routine still has bugs.

* src/Counters.{cpp, h}: 
	- add identifiers for subfloats

* src/LaTeXFeatures.{cpp, h}:
	- support for subfig

* src/TextClass.cpp:
	- set up subfloat counter for all custom floats.

* src/frontends/qt4/GuiGraphics.cpp:
* src/frontends/qt4/ui/GrahicsUi.ui:
	- remove subfigure UI.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23381 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-02 11:30:50 +00:00