Commit Graph

29217 Commits

Author SHA1 Message Date
Alexander Dunlap
415932359a FindAdv: Omitting cursor advance at start of search if in mathed.
Fixes #13070 Advanced S&R does not find math symbols at start of document

(Should be cherry-pick of 8c501308, but due to merge conflicts its done
manually)
2024-06-10 20:08:39 +02:00
Udi Fogiel
f04ffb2513 Fix change tracking colors with RTL languages (#12923)
(cherry picked from commit a5749b9c1f)
2024-06-10 15:20:16 +03:00
Udi Fogiel
ecbe5d263d Fix greyedout with RTL languages (#8647)
(cherry picked from commit ee43584140)
2024-06-10 15:09:00 +03:00
Daniel Ramoeller
259c89f45e Extend tab context menu features
Add

- Close Other Tabs
- Close Tabs to Left/Right
- Move Tab to Start/End
- Show Enclosing Folder

to the tabs context menus.

Fix for bug #11963

(cherry picked from commit a114f12868)
2024-06-09 13:50:10 -04:00
Richard Kimberly Heck
3c909daeea Merge branch '2.4.x' into 2.4.1-devel 2024-06-09 13:13:12 -04:00
Enrico Forestieri
4acc6e36e3 Fix textstyle-update handling in mathed
The code was expecting that all properties were specified
in the argument and not only some. Simply do not process
those properties not specified in the argument.

(cherry picked from commit afb70c905b)
2024-06-09 13:10:15 -04:00
Juergen Spitzmueller
5a69b8a184 Return false on invalid input in Font::fromString()
Fixes crash with invalid font-update lfun

(cherry picked from commit 2a9648fc4c)
2024-06-09 13:10:05 -04:00
Richard Kimberly Heck
4bd03197d1 Fix table crash reported on Windows.
(cherry picked from commit 3e796c680a)
2024-06-07 15:59:38 -04:00
Juergen Spitzmueller
d4bd0f9b1e Strip quotes from PackageOptions. Amends a77c84a0b4
(cherry picked from commit 1449fbf9ae)
2024-06-06 19:00:34 +02:00
Jean-Marc Lasgouttes
312dacb7f3 Fixup 39c7199a: the code did not do what it was supposed to
(cherry picked from commit 92ef555abd)
2024-06-06 18:22:26 +02:00
Jean-Marc Lasgouttes
13a6be1f9c Do not draw appendix lines below en of document
This bug is pretty old, but it was not visible because the grey area
below the document would overwrite it.

It would be better to close the frame at the end of the document, but
this is for later.

(cherry picked from commit 7acfbe0fcc)
(cherry picked from commit c96d3a0340)
2024-06-06 18:18:02 +02:00
Udi-Fogiel
41f080c5ef avoid adding redundant preamble to double column hebrew documents (#12919) 2024-06-03 21:05:20 +03:00
Juergen Spitzmueller
c0df9e193c Show full inset context-menu when clicking on text part of collapsible (#10370)
Re-fix this since #12907 has been resolved

(cherry picked from commit 7a85b1b7ca)
2024-06-03 17:58:09 +02:00
Richard Kimberly Heck
90ab21e0e9 Fix table crash reported on Windows.
(cherry picked from commit 3e796c680a)
2024-06-03 11:39:42 -04:00
Kornel Benko
5fdbd2cf32 Adv. F&R: strange dialog text
Fixes #12997
Added 'Scope' to better indicate the searched area.
2024-06-03 08:23:35 +02:00
Richard Kimberly Heck
63b23ce288 Fix bug #13066
Patch from Lorenzo

(cherry picked from commit 0c70f340c0)
2024-06-02 23:08:05 -04:00
Richard Kimberly Heck
701c763221 Merge branch '2.4.x' into 2.4.1-devel 2024-06-02 21:49:54 -04:00
Richard Kimberly Heck
1d7c8325f2 Put new citation after selected item rather than at end of list.
Fixes bug #12940.

Patch from Daniel.

(cherry picked from commit 40ae8644f9)
2024-06-02 20:54:46 -04:00
Thibaut Cuvelier
37a865762b XHTML: export paragraph IDs also for list items, but not for the opening tag of the list.
The IDs are used to link to specific elements (for instance, the User's guide nomenclature).

The beginning of the list (<ul> or <ol>) has the same magic ID as the first item of the list.
2024-06-02 11:59:41 +02:00
Thibaut Cuvelier
c5b1ce5f37 Make comment clearer. 2024-06-02 11:59:18 +02:00
Thibaut Cuvelier
b3d911ef57 InsetInfo: no need to output + explicitly in a shortcut, it is already contained in the sequence. 2024-06-02 11:59:13 +02:00
Jean-Marc Lasgouttes
342a0f5438 Fix display of math hull inset in RTL context
The inversion of margin was done in the wrong way for RTL support.

(cherry picked from commit b469c142ad)
2024-06-01 21:47:53 +02:00
Richard Kimberly Heck
c97375e46d Fix bug #12934
(cherry picked from commit 6484dce51b)
2024-06-01 13:05:42 -04:00
Jean-Marc Lasgouttes
2699a58cd7 Set buffer when creating a MathData from parts of another one
This is triggered by selecting part of an equation under Xcb platform
(x11). Indeed, the current selection has to be sent to the X11 server
and BufferView::requestSelection() is called. Eventually
cap::grabSelection() is the function that creates this partial
MathData object.

Fixes ticket #12947.

(cherry picked from commit ed2f3cb9cf)
2024-06-01 18:45:43 +02:00
Jean-Marc Lasgouttes
76188dcdf1 Try to make sure that math insets have a properly set buffer_ member
Set the buffer of contents that is added to a MathData object through
MathData::insert() (both versions)
MathData::push_back()
asArray()

Also in math macros, initialize look_ with the relevant buffer.

This reduces the number of insets hat do not have a proper buffer.

See #13050 for discussion of this issue.

(cherry picked from commit f3c5ff9cb7)
2024-06-01 18:45:43 +02:00
Richard Kimberly Heck
d780091990 Fix bug #11796.
Toolbars are now locked by default. Unlocked state should be saved
by Qt as a session variable.

Patch from Daniel.

(cherry picked from commit 42a8463aab)
2024-06-01 12:45:19 -04:00
Richard Kimberly Heck
26ab818033 Fix bug #8856.
Show values of cross-references in tooltips.

(cherry picked from commit 2a1c3dce57)
2024-06-01 12:37:05 -04:00
Richard Kimberly Heck
b78bcc2eb2 Fix bug #12981
(cherry picked from commit 61181a3977)
2024-06-01 11:59:39 -04:00
Juergen Spitzmueller
91e90a7c1c Reset require_fresh_start_ after buffer has been viewed/exported
The LFUN buffer-reset-export states to start afresh the export for the
next run, but in fact, the boolean was never reset, so that this was
done for all subsequent runs unless the buffer had been closed and
reopened.

Now the lfun does what it states and only acts on the next pass.

(cherry picked from commit e1cb15ee5d)
2024-06-01 11:39:04 -04:00
Kornel Benko
3235e41e1f Amend 6c3447c8: FindAdv: sometimes a space is added on some math symbols
Restrict the removing to math insets

(cherry picked from commit f248b003a9)
2024-06-01 13:40:56 +02:00
Kornel Benko
fca59304da FindAdv: sometimes a space is added on some math symbols
For example '\int '.
Should fix regression #13070
Spotted  by Alexander Dunlap

(cherry picked from commit 4730ec78f5)
(cherry picked from commit 6c3447c8a6)
2024-06-01 13:40:08 +02:00
Kornel Benko
4bdc7b74ed Amend 4730ec78: FindAdv: sometimes a space is added on some math symbols
Restrict the removing to math insets
2024-05-31 09:09:56 +02:00
Kornel Benko
4730ec78f5 FindAdv: sometimes a space is added on some math symbols
For example '\int '.
Should fix regression #13070
Spotted  by Alexander Dunlap
2024-05-29 14:09:20 +02:00
Juergen Spitzmueller
cc77602066 InsetNote: pass on inset-modify lfuns addressed at other insets (#13068)
(cherry picked from commit ae1ddcbda0)
2024-05-24 10:46:01 -04:00
Juergen Spitzmueller
712baff7b6 Address Qt 6.7 deprecation warning
(cherry picked from commit 44633c7f72)
2024-05-20 17:59:51 +02:00
Juergen Spitzmueller
26834b7a07 Initialize is_long_tabular before updateIndexes() (which employs it)
(cherry picked from commit 10b5f03d95)
2024-05-20 17:59:30 +02:00
Richard Kimberly Heck
39c7199afc Return a reference, not a copy.
Stupid mistake from 2009. Thanks to Scott and JMarc for tracking
it down.

(cherry picked from commit de5f63eeb3)
2024-05-19 18:30:56 -04:00
Juergen Spitzmueller
8f65ae16e1 Amend 207eaeee90
The upstream encoding needs to be updated after this routine
(see comment in OutputParams.h:183ff.)

(cherry picked from commit 2d95f8fc16)
2024-05-16 17:05:54 +02:00
Juergen Spitzmueller
576d3836cf Amend a716fb96b5
(cherry picked from commit af59551b1b)
2024-05-15 13:33:18 +02:00
Juergen Spitzmueller
176ecba630 NeedCProtect -1 also for InsetLayouts
(cherry picked from commit a716fb96b5)
2024-05-15 13:32:47 +02:00
Juergen Spitzmueller
0af7259025 Introduce NeedCProtect -1 layout option
It turns out beamer frame does not allow \cprotect and errors if it is
used. Hence we need to prevent it in this context entirely.

(cherry picked from commit 207eaeee90)
(cherry picked from commit f05fd78754)
2024-05-15 13:25:03 +02:00
Juergen Spitzmueller
f05fd78754 Introduce NeedCProtect -1 layout option
It turns out beamer frame does not allow \cprotect and errors if it is
used. Hence we need to prevent it in this context entirely.

(cherry picked from commit 207eaeee90)
2024-05-12 19:02:59 +02:00
Juergen Spitzmueller
8b0546dfe7 Consider CT in dash mechanism (#13062)
(cherry picked from commit fe4f0dbf0b)
2024-05-11 13:02:39 -04:00
Jean-Marc Lasgouttes
13a34d6cd1 Set buffer_ correctly when inseting a math macro over a selection
The code that handles this special macro insertion (in
Cursor::mathMacroClose())) is very weird: it inserts the contents of
the macro _after_ the macro and later, since the macro is 'greedy', it
will eat this contents and put it in its first macro cell.

Does it make sense to you? It does not ake sense to me either. Anyway,
this is the point where one should make sure that the buffer is set.

Fixes ticket #12682.

(cherry picked from commit b45a957929)
2024-04-25 20:27:36 +02:00
Jean-Marc Lasgouttes
21096f696a Sanitize cursors after a buffer has been reloaded
When a buffer is reloaded, its content may remain the same, but the
memory allocation is new, so that the inset pointers in cursors are
now wrong. This requires to sanitize the cursors held by the buffer
views.

Before the biginset branch, some full metrics computation call that is
now removed probably did that as a side effect. Now we have to be more
precise.

To this effect, introduce WorkAreaManager::sanitizeCursors() and use
it in Buffer::reload().

(cherry picked from commit c1fd622c51)
2024-04-22 11:35:15 +02:00
Juergen Spitzmueller
237b0404ff Handle the case of outdated chkconfig.ltx in user directory
(cherry picked from commit b8ff824a4f)
2024-04-21 09:36:21 +02:00
José Matos
cc75da1c3e Convert $${python} placeholder for graphic conversions
(cherry picked from commit cdcaf0e7b6)
2024-04-20 20:20:21 +01:00
Stephan Witt
5554fe9aeb #13049 add window activation for preferences to avoid it be hidden by main window on mac after alert prompts
(cherry picked from commit 4c1db7cad8)
2024-04-19 14:01:41 +02:00
Jean-Marc Lasgouttes
c9f5f34fd7 Always repaint the gray area below main inset
Now that SingleParUpdate does not always lead to a full screen update
when the height of the paragraph changes (see new behavior of
updateMatrics(bool)), it is necessary to make sure that the grey area
below the main page is always repainted.

(cherry picked from commit 1a11abe439)
2024-04-18 16:46:38 +02:00
Jean-Marc Lasgouttes
15eef6a2c7 Do not compute metrics at each preview when loading file
With the branch-test.lyx file from #12297, loading takes forever when
previews are activated. This is because each preview element causes a
full screen metrics recomputation.

This commit just skips these calls and only does one when all previews
have been obtained. As a result, computing the previews takes 1 second
instead of 25 seconds on branch-test.lyx.

Part of bug #12297.

(cherry picked from commit 2449693301)
2024-04-18 16:45:58 +02:00