Commit Graph

20414 Commits

Author SHA1 Message Date
Dov Feldstern
4056f0ddb1 fix a visual cursor edge-case:
Only when an LTR paragraph *ends with* an RTL chunk of text, movement was 
incorrect in two ways:

1. After moving into the pargraph from the end, and then trying to move towards
the beginning of the paragraph, the cursor would immediately jump to the 
previous pargraph.

2. If the cursor were placed inside the RTL text, and then we would move left
towards the beginning of the paragraph, upon reaching the end (beginning?) of
the RTL chunk, cursor would jump to the end of the paragraph, and then continue
as in (1).

(Same thing, of course, with the reverse situation, i.e., RTL paragraph ending
with LTR text).

We now deal with both of these cases correctly.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23173 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-24 01:45:51 +00:00
Stefan Schimanski
b313333c1a * setItemDelegate does not free the old delegate. So we better only create one instance and reuse that.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23172 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-24 00:49:57 +00:00
Richard Heck
14b7f34818 Fix drawing error on Linux, apprently caused by creation of static global instance of QItemDelegate. Fix due to STS.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23171 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-24 00:38:54 +00:00
André Pönitz
e05e2b6b19 (temporarily) add a Buffer * Inset::buffer_ membert
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23170 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 22:32:33 +00:00
André Pönitz
30fff63257 compile fix
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23169 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 22:21:03 +00:00
Richard Heck
8e9410b3d0 After a hiatus, I'm returning to the rewrite of InsetCommandParams, the purpose of all of this being to make things more flexible, with the ultimate goal being biblatex support and a kind of InsetCommandFlex that will allow user-definable such things. The next step, really, is to fix up CiteEngine so that we can have different sets of parameters for InsetCitation depending upon what engine is in use. (Something like this also needs doing with InsetInclude.)
This patch reworks the machinery that holds information about what parameters there are and what their values are. There's enough flexibility here that true keyval support ought to be fairly easy at this point. I'll have a peek at that shortly.



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23168 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 22:01:02 +00:00
Stefan Schimanski
c207a8fe0b * don't forget InsetMathMBox, which is only compiled with cmake
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23167 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 21:59:38 +00:00
Bernhard Roider
52ccb98354 Fix crash due to recursive function call when a counter references itself.
e.g.:

Counter
    Name                 Version
    LabelString          "\theVersion.0"
End


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23166 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 20:38:57 +00:00
Uwe Stöhr
21a3cd14d2 Extended.lyx: update by Hartmut
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23165 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 18:13:19 +00:00
Stefan Schimanski
323e3b0207 * Moved std::sets out of Buffer.h to reduce overall LyX compile time
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23163 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 18:11:35 +00:00
Abdelrazak Younes
ee4dcf105a fix crash on quit with Ctr-Q. Patch by Horst Schirmeier (see http://bugzilla.lyx.org/show_bug.cgi?id=4572)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23162 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 18:10:52 +00:00
André Pönitz
0fb8f3fba1 mostly s/Paragraph::layout(...)/Paragraph::setLayout(...)/
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23159 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 16:45:38 +00:00
Uwe Stöhr
4a7b0625b3 SCons update
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23157 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 16:40:16 +00:00
André Pönitz
b306e9a2e1 Replace the text class shared ptr by good old index-into-global-list.
Also a few cosmetical changes where I xould not resist.

Would be nice if the 'modules people' could verify that their baby 
is strill alive... 



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23154 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 11:36:15 +00:00
Richard Heck
0e48a81cc1 Cosmetics.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23153 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 03:48:57 +00:00
Stefan Schimanski
ab8a1b0e70 * fix backspace at paragraph end. The inline completion should stay on screen.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23152 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 03:15:34 +00:00
Stefan Schimanski
b7782d1973 * cleaned up word dimension calculation of completion. There is still a bug with RTL which moves the popup to left when completing.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23151 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 03:15:05 +00:00
Stefan Schimanski
919e9a80eb * proper cursor position RTL text with inline completion
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23150 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 03:14:33 +00:00
Stefan Schimanski
f2837e7bcb * remove debug output
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23149 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-23 03:13:54 +00:00
Stefan Schimanski
37b79f1039 * allow on position more at the row end for the completion
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23148 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 23:40:36 +00:00
Stefan Schimanski
86f6347b77 * Qt does not reverse RTL strings for us. So it's a bit more complicated to get the popup right: we need a QItemDeletate for this.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23147 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 23:15:27 +00:00
Stefan Schimanski
5cc36c8c70 * another step for rtl completion: the popup is shown in the right direction. Still the right cursor position is missing. This also causes the popup to use a wrong position.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23146 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 21:57:57 +00:00
Stefan Schimanski
3cdfa1708f * the bidi array drives me crazy. It only holds the current row. So better check that our position is in that row.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23145 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 21:57:45 +00:00
Stefan Schimanski
0d7ca9cdc3 * inlineCompletionVPos is only used locally. So define it there.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23144 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 21:57:33 +00:00
Stefan Schimanski
8c2149d3aa * following Andre's advice to rename the method into
createCompletionList. This makes the ownership of the returned
  object clear.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23143 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 21:11:19 +00:00
Stefan Schimanski
426c4bf356 * some more relicts of the unfinished favorite handling for math completion
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23142 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 21:11:05 +00:00
Stefan Schimanski
67a9667232 * comments
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23141 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 20:45:42 +00:00
Stefan Schimanski
8527a08903 * simplify notifyCursorLeaves logic: We now only call it from strategic
places, i.e.
  - BufferView::setMouseCursor,
  - BufferView::mouseEventDispatch
  - LyXFunc::dispatch
  Before it was called from several dispatch handlers in the middle of the
  dispatch process. Because the cursor might get invalidated, this is
  not a good idea. We had plenty of crashes and odd behaviours because
  of this as nobody really understood those cases.

  This fixes (at least) #2069 and #4163.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23140 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 20:45:18 +00:00
Stefan Schimanski
90a88ba87d * correct parsing of unknown math environment (fixes http://bugzilla.lyx.org/show_bug.cgi?id=4573)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23139 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 20:04:38 +00:00
Abdelrazak Younes
21489f6a29 GuiView::dispatch(): Fix cut&paste bug.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23138 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 17:36:40 +00:00
Richard Heck
3257f3e066 Line length.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23137 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 16:26:40 +00:00
Richard Heck
2812202c2b Move the enum into InsetLayout.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23136 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 16:24:55 +00:00
Richard Heck
2c357c1d23 This should be the last of the commits refactoring the InsetLayout code.
This one just moves the Decoration enum into InsetLayout, changing the names
to avoid possible conflicts now that it is in the lyx namespace.



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23135 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 16:15:21 +00:00
Richard Heck
561466d45d Sort table.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23134 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 16:12:36 +00:00
Stefan Schimanski
f5fdd7cdab * cosmetic
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23133 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 15:38:26 +00:00
Stefan Schimanski
f614d46ca1 * cosmetic
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23132 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 15:26:52 +00:00
Stefan Schimanski
7b0ea48d31 * first step to proper RTL support of the completion. The cursor is still wrong.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23130 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 14:05:27 +00:00
Stefan Schimanski
aa532e094f * once is enough
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23129 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 14:05:06 +00:00
Abdelrazak Younes
a19557baf7 Text::setCursor(): make sure an update is asked if the current cursor is not visible.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23128 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 12:27:56 +00:00
Abdelrazak Younes
2ed1153c8c Text::dispatch(): Make sure the cursor is visible before doing anything.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23127 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 12:22:28 +00:00
Abdelrazak Younes
6564e9bb4e Fix this bug:
1. scroll a bit so that the cursor is not visible anymore
2. hit the keyboard arrow keys to move the cursor or type something

The problem was that TextMetrics::parMetric() automatically creates a new parmetrics on const access. This was needed in the old architecture but I don't think anymore.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23126 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 11:07:41 +00:00
Jean-Marc Lasgouttes
38a1df7cd4 disable annoying debug messages
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23125 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 10:30:46 +00:00
Jean-Marc Lasgouttes
e744d0e989 sort lyxrc keywords table
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23124 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 10:25:12 +00:00
Jean-Marc Lasgouttes
8b342f0478 compilation fix for tex2lyx
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23123 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 10:16:18 +00:00
Stefan Schimanski
4dc36f2380 * no need for QStyleOptionViewItemV3
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23122 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 10:15:28 +00:00
Abdelrazak Younes
27de158157 Fix tex2lyx compilation.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23121 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 09:23:47 +00:00
Stefan Schimanski
ab6ec965fd * stdlib-debug out of range fix
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23120 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 09:00:22 +00:00
Richard Heck
7889ccc0eb More headers.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23119 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 03:39:10 +00:00
Richard Heck
b032a9d7ba Headers.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23118 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 03:34:03 +00:00
Richard Heck
20cf42b741 This is the second commit in the process of making InsetLayout a real class.
Here, we move TextClass::readInsetLayout() to InsetLayout::read().


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23117 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-22 03:27:42 +00:00