24559 Commits

Author SHA1 Message Date
Jean-Marc Lasgouttes
546a6a2a31 Do not draw inactive math corners when they have mathbg color
By default, inactive math corners are invisible. In practice they are
annoying because they are visible when selecting text, and they can
also overwrite some parts of the equation.

The code in Inset::drawMarkers2, which is only used for maths, is
moved to InsetMathHull. Moreover, the inactive corners are not drawn
when they have the same color as the math background. A better way to
achieve this would be to set the color to transparent, but we do not
support this yet.

(cherry picked from commit 68614e9783382b6267fc9ce32ed45bc2477007dd)
2017-12-23 19:53:58 +01:00
Jean-Marc Lasgouttes
92f320ff4a Reintroduce the spacing around delimiters
This spacing was wrongly removed at 361bd53b as part of the
introduction of proper spacing between elements, but it only introduces
some breathing space around the delimiters. This will not be necessary
anymore when/if we use proper delimiters from the cmex10 font.

(cherry picked from commit 4cb5cc0c7de7cb5dbaaf14328e5a82e1cfe5a6ca)
2017-12-23 19:48:06 +01:00
Jean-Marc Lasgouttes
87d291ee23 Handle properly undo groups in embedded work areas
When a buffer is in an embedded work area (adv. find&replace), it is
not found by BufferList:::exists(), and therefore the undo group
created in GuiApplication::dispatch and in the handling of
LFUN_COMMAND_SEQUENCE will not be closed.. Crashes can ensue, as
described in Ubuntu bug:
https://bugs.launchpad.net/bugs/1737429

The solution is to introduce BufferList::isInternal and act on it.

Fixes bug #10847.

(cherry picked from commit 8b107f0490e61b4390e925f08d21661ef50d6f49)
2017-12-23 19:21:12 +01:00
Juergen Spitzmueller
2b927cbc2e Fix typo.
This had the effect that for file dialogs supposed to use two buttons,
only the second one was displayed, while file dialogs supposed to use
one button did not have a button at all.

Candidate for 2.3.x and 2.2.x.

(cherry picked from commit 74607702a585fd68bdf6b9cda668421a4ed06f3e)
2017-12-20 19:04:26 +01:00
Juergen Spitzmueller
63af581324 Do not rely on babel quotation macros for encodings other than [O]T1
Babel falls back to OT1 in these cases, which gives wrong output got the
guillemots

Fixes: #10947
(cherry picked from commit 64b94f81be52de33553cda5db85d824de2119a3c)
2017-12-18 12:40:44 +01:00
Juergen Spitzmueller
f337a55327 Amend d56a5447f306
LaTeX only breaks after dashes (even though unicode suggests optional
line breaks also before em dashes).

(cherry picked from commit 1371dbb24063b613cb8914a521b90a47d74f0472)
2017-12-17 19:25:54 +01:00
Juergen Spitzmueller
c527035b70 Consistent output of breakable/non-breakable dashes on all TeX engines.
Fixes: #10839
(cherry picked from commit d56a5447f30688286c1fe19f3b51225f4b586b3e)
2017-12-17 19:24:46 +01:00
Uwe Stöhr
50c83973a6 Buffer.cpp: reference oasis in https link 2017-12-17 02:41:51 +01:00
Uwe Stöhr
e73164e25d tex2lyx: support to detect https:// links
- Preamble.cpp: use the occasion to backport JMarcs recent compiler warning fixe
2017-12-17 02:28:54 +01:00
Uwe Stöhr
998d39fa28 GuiPrintNomencl.h: fix bug #10819 also for 2.3.x 2017-12-17 02:01:49 +01:00
Juergen Spitzmueller
132726e84a Missing "icon" in description of "info-insert"-function
(cherry picked from commit 7821cb713375588e3ed65b4e13dd9e8066ab08a8)
2017-12-09 09:53:43 +01:00
Juergen Spitzmueller
1bd4223554 nomenclWidest(): take (proper) formatting into account. 2017-12-04 10:24:02 +01:00
Juergen Spitzmueller
798b7126ef Fix thinko from b68701c4da93a6f0f
(cherry picked from commit 938c44590cb643029ce47694edf7ab3949a800a2)
2017-12-03 11:37:33 +01:00
Enrico Forestieri
4e753bdc3f Avoid asserting when reading the session file
Fixes #10824.

(cherry picked from commit f84acc0e3441d09c0b5026f97c3e4cbbc0067256)
2017-12-02 21:37:02 +01:00
Scott Kostyshak
e3494c2f3a Set array length from int const
(cherry picked from commit b3f7eb6af37bcef01976a22ba422c289371365f4)
2017-12-02 13:17:36 -05:00
Juergen Spitzmueller
a4aee2a090 Escape (makeindex) special chars in nomencl if !literate
Fixes: #10825
(cherry picked from commit b68701c4da93a6f0ff618f5554b76c48373a3ac8)
2017-12-02 09:59:41 +01:00
Juergen Spitzmueller
225253dfc6 Implement l7n for nomenclature.
(cherry picked from commit 718a353b49d903f3e50c895a29f20f8970db2d06)
2017-12-01 10:19:30 +01:00
Juergen Spitzmueller
7c8d167f8e Longtable: only output the caption contents in a caption row.
Fixes: #10791
(cherry picked from commit 538b38f78c76a56bec7e6cec0314d8f4e0f1e415)
2017-11-20 19:51:32 +01:00
Juergen Spitzmueller
3561caa3a1 Fix footnote output in description item
Fixes: #9387
(cherry picked from commit aaa61500896ef00087b146fd41ee88ea16dd0f1d)
2017-11-20 09:50:23 +01:00
Juergen Spitzmueller
55bc365872 Allow footnotes in floating tables via tablefootnote package
See #808.

(cherry picked from commit 5017a0a1c635ed8da2b1fce5e240d0e297cf1aaf)
2017-11-20 09:49:36 +01:00
Juergen Spitzmueller
c2d121f663 Fix footnote output in tables outside floats and longtable header/footer
Fixes: #808 (sic!), #5869
(cherry picked from commit 3affde3957ff29fb0543478e072427616eb9b049)
2017-11-20 09:49:10 +01:00
Juergen Spitzmueller
7920a12065 Disable non-functional table rotation for longtables
In the long run, proper longtable rotation via [pdf]lscape should
be implemented.

See #9194

(cherry picked from commit 84f7dafe891483e0314e2a08c0ddd8cf0063902d)
2017-11-20 09:37:01 +01:00
Juergen Spitzmueller
1a8873d7be InsetExternal: update renderer after preview status change
This fixes a crash when changing instant preview prefs while
document with previewed external inset is opened.

Fixes: #10785
(cherry picked from commit 0842e22f4551e84dbf24259c65994c760fc22925)
2017-11-12 18:31:00 +01:00
Juergen Spitzmueller
fadb93ae68 Collapsable -> Collapsible (part 5)
Preferences update and prefs2prefs routine.

This was forgotten in the process.
2017-11-02 16:51:23 +01:00
Enrico Forestieri
43a6fe8375 Fix #10778 (issue with CJK and language nesting)
When using CJK, don't try to close a language that was never
opened before, such as when it is the main language.

(cherry picked from commit 7e51b5f30196fa0679a7c3c32dc75bca91520f32)
2017-11-02 11:07:11 +01:00
Juergen Spitzmueller
8f98423e92 Enable OK/Apply buttons when resetting to class defaults.
(cherry picked from commit b851a349b6f303824f329a5dc854827f66828764)
2017-11-01 23:09:59 +01:00
Enrico Forestieri
8be0ec0db5 Fix issue with change-tracked deleted display math
- If a display math not starting a new paragraph is deleted, the
  current \lyxdeleted macro (if any) must be closed and a new one
  started, otherwise the display math will be shifted up.

- Use \linewidth instead of \columnwidth because the former will adapt
  to the reduced horizontal width in list environments, avoiding shifting
  to the right the diplay math.

(cherry picked from commit 7f23ca912c5e92bf30bdc05b6d801082f6643e8e)
2017-10-25 19:51:14 +02:00
Juergen Spitzmueller
a81a0c5534 Implement ParamInfo::HANDLING_LTRIM and use it to ltrim InsetBibitem
output

See #9847.

(cherry picked from commit 76f49fad78db5ed768db163feef4e3b3c062228f)
2017-10-23 09:07:22 +02:00
Juergen Spitzmueller
d088f7f03f Do not add deleted text to inset button label.
Fixes: #10775
(cherry picked from commit 70b0df85c80120e0a0eeaa9e3fec721d91d53849)
2017-10-23 08:26:01 +02:00
Guillaume MM
25678dae12 Fix math mode for InsetMathMacro on output
After 6642152e, user macros were no longer wrapped in \ensuremath. In 2.2 and
before, InsetMathMacro behaved as follow:

* Textmode global symbols are wrapped in \text when in math.

* Other global symbols, and user macros, are wrapped in \ensuremath when in
  text.

* Undefined macros (ERT) are wrapped neither in \text nor in \ensuremath.

This is also consistent with the documentation of MathEnsurer in
mathed/MathStream.h.

This patch defines InsetMathMacro::currentMode() accordingly (respectively
TEXT_MODE, MATH_MODE and UNDECIDED_MODE) and uses it to determine the output.

After this patch, there is a mismatch between screen and pdf output for user
macros in \text. This is not a regression wrt 2.2 and is because linearization
does not satisfy currentMode() currently.

(cherry picked from commit 767f0df18fcd61611de1d1e10e0fd1867479fb59)
2017-10-23 00:07:08 +02:00
Enrico Forestieri
8f7b40955c Account for shadowed system macros
Part of #10694.

(cherry picked from commit d58d3f677442fc8b2ee2454a1da8f5eedd8b95ac)
2017-10-22 23:15:56 +02:00
Enrico Forestieri
5a3201a8c4 Speed up exit time
Instantiating a single QSettings and using it for each ui element
can significantly shorten the time required to save the various
states at exit. The speed up can be better appreciated on *nix,
where the settings are saved on disk, rather than on Windows where
they are held in memory (in the registry).

(cherry picked from commit 3b43fbfbb18cc4535aba3fd77c6a3cf21835dafa)
2017-10-18 13:38:16 +02:00
Juergen Spitzmueller
4947476da8 Do not scan BibTeX files multiple times in a collectBibKeys() procedure.
Scanning is rather slow, so this improves performance in specific
situations (multiple inclusion of larger files in master/child or
chapterbib context)

(cherry picked from commit 88a0666d6c039decfbd0da0dee6c9b4ba4923806)
2017-10-18 12:21:29 +02:00
Richard Heck
ffd175b99f Use of div for labels causes validation errors. See #8843.
(cherry picked from commit b8206a0832ff4a6d8da8a71b6058d65d721bd0e8)
2017-10-16 21:41:30 -04:00
Richard Heck
1bef592999 Revert "ABOVE and CENTERED labels need special treatment."
This reverts commit 08bf9781ee86ea7fe2c9f3a0d670cad92807a017.
2017-10-16 21:37:59 -04:00
Juergen Spitzmueller
a59301eaff Collapsable -> Collapsible (part 2)
The current spelling is not strictly wrong, but flagged as unusual or
historical by some authorities. It is also found fault with many
spell checkers. Thus we decided to move to the more standard "-ible"
form once and for all.

See #10678 for discussion

This part covers the most tricky part: the internal naming.
Translations and layouts will follow.

This will all also all be backported to 2.3.x, for the sake of backwards
compatibility (cherry-picking).

(cherry picked from commit c466baaa5b99e44ea25616556bd0918197f4b54c)
2017-10-16 11:24:41 +02:00
Juergen Spitzmueller
e040ccb0e8 Collapsable -> Collapsible (part 1)
The current spelling is not strictly wrong, but flagged as unusual or
historical by some authorities. It is also found fault with many
spell checkers. Thus we decided to move to the more standard "-ible"
form once and for all.

See #10678 for discussion

This part only covers the usage in comments and the like. More to follow.

This will all also all be backported to 2.3.x, for the sake of backwards
compatibility (cherry-picking).

(cherry picked from commit 648ddd25eca045f34569405aca15c5d638bbb723)
2017-10-16 11:22:13 +02:00
Richard Heck
402d41b82d Revert "Fix bug #8782."
This caused slowness on undo and redo that was reported at
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg202292.html

This reverts commit 02847641a8b97a57d1866120bb446427e0bda7a4.
2017-10-15 20:56:25 -04:00
Enrico Forestieri
2e253eab0f Fix issue with regular expressions
At least with gcc 6.4, if the first parameter passed to
regex_match() is afterward changed, the second one gets
corrupted. This is avoided by using a temporary string.

(cherry picked from commit c16ccdb5fd25a14c096ef9dfa68975c77377bf41)
2017-10-15 15:42:39 +02:00
Juergen Spitzmueller
88c285219b Fix PDF output of clipped graphics with recent graphics package
The previous redirection of the senseless option "bb" to "viewport" in
PDFLaTeX output has been removed in a recent graphics package update.

This breaks documents, since clipped graphics silently stop displaying.

This change restores the previous output by using "viewport" instaed of
"bb" for non-PS/DVI output, while leaving PS/DVI untouched (where "bb"
and "viewport" behave differently.

Fixes: #7910
2017-10-13 08:28:26 +02:00
Jean-Marc Lasgouttes
80983a3553 Do not forget to set cursor current font when selecting
Fix several unreleated cases where the `selecting' code path did not
reset cursor font correctly. This leads to a caret that does not have
the correct size, and can cause caret droppings with the new display
scheme.

(cherry picked from commit 88d0390724c60410dd680a2528eab5c91b1252ce)
2017-10-12 21:13:55 +02:00
Enrico Forestieri
b79d07f4a5 Fix issue with language switch in Arguments insets
In some insets such as Arguments, a local language switch has to be
used. However, if the language inside the inset was set to be equal
to the outer language, the code decided not to switch language. But
then got confused and tried to close a switch that was never opened.
This patch forces the switch even if the outer language is the same.

(cherry picked from commit ce4f39d414a26edcf54c1e24d6142e6b929586d7)
2017-10-12 00:02:54 +02:00
Richard Heck
da7f539358 Reset cursor before beginning reload sequence.
(cherry picked from commit af381a2fb25df71b43668fa46ba9b6395f266751)
2017-10-08 23:07:13 -04:00
Kornel Benko
a506c6b73b Cmake build: Only use the new lyxconvert on MAC 2017-10-03 22:14:37 +02:00
Kornel Benko
9da29ac788 Add suffixed lyxconvert to cmake build.
This should amend f93ec4a, but is not tested on apple
2017-10-03 22:09:57 +02:00
Stephan Witt
c75d9bf7c4 Add Qt-based fallback-converter for Mac to compensate missing ImageMagick convert utility
(cherry picked from commit f93ec4a1f41b70a4607ff355e19f4721f9338028)
2017-10-03 20:10:29 +02:00
Jean-Marc Lasgouttes
cda56c0dc3 Avoid empty space above the top of the document
If the height of the first row of the document has become smaller (for
example when it contains an image which size has shrunk), that the
anchor offset has to be adapted so that there is not a large blank
space at the top of the document.

(cherry picked from commit d6aecbda0f5929ab04805ac6e19cd48f3c4a059b)
2017-09-28 13:57:36 +02:00
Juergen Spitzmueller
4f50cbcfe4 Fix crash when closing master with children and grandchildren
In some cases, it is possible that the BufferPositionMap has
dangling pointers. We thus check whether the Buffer is loaded
before accessing it.

Fixes: #10766
2017-09-28 09:06:33 +02:00
Juergen Spitzmueller
745b43784c Whitespace cosmetics 2017-09-27 18:05:58 +02:00
Jean-Marc Lasgouttes
f2f7ea9edc Do not apply mathindent to inline math insets
(cherry picked from commit 040e9d32a6c1f69c444ed6593e67f96829f8052f)
2017-09-24 22:55:06 +02:00