24881 Commits

Author SHA1 Message Date
Jean-Marc Lasgouttes
93893396e4 Initialize properly class member
Spotted by coverity.

(cherry picked from commit 2ba00ecb7bf00b5f6a22f2f6ae23c4c9127e8a93)
2018-01-19 09:33:53 +01:00
Juergen Spitzmueller
b0868e6eb1 Use qt4-compatible connect() syntax.
Signed-off-by: Juergen Spitzmueller <spitz@lyx.org>
(cherry picked from commit aab58fed6b140e1629d7c4c4f7becbf5b3e74160)
2018-01-19 09:33:06 +01:00
Guillaume MM
789617b818 Install a new compressor
A brand new event compressor based on Kuba Ober's cleverly simple
solution: <https://stackoverflow.com/a/21006207>.

Fix #9362, #9461, #9933: Lyx suddenly gets keyboard keys wrong, and
deadlocks

Fix #9790: LyX should perform key event compression (for improving the
remote X connections one would also need to implement
Qt::WA_KeyCompression)

Fix #10516: slowness on repeated arrow keys with IBus and Qt5

Patch pulled from
https://github.com/gadmm/lyx-unstable/commit/bf5a1efb0db5bfc2b

Signed-off-by: Juergen Spitzmueller <spitz@lyx.org>
(cherry picked from commit 43e4b8073445d147be353013e3a7e081e11653ba)
2018-01-19 09:32:32 +01:00
Jean-Marc Lasgouttes
9bec4b8a0a Fix repaint of unselected branch
This works around a TextMetrics issue where Row::beg/end_margin_sel
are sometimes not reset correctly when there is no selection on the
row.

In master a fix for this problem has been done at 654cded1. Here we
prefer a much simpler work around that fixes the symptom.

Fixes bug #10972.
2018-01-16 09:37:30 +01:00
Jean-Marc Lasgouttes
894ae19224 Remove 'premature optimization' that proved buggy
At some time it seemed like a good idea in breakRow() to return early
when the row was bound to be empty. It turns out that this creates two
symptoms:

* empty paragraphs will not have an end of paragraph marker

* since row width is not correctly computed in this case, caret ghosts
  can appear in master.

This commit removes the oprimization and replace the do {} while()
construct to a straightforward while() {}.

Related to bug #10952.

(cherry picked from commit 76f0a3dd4ee5c7958c6dea79628ef8c2ac2c59bd)
2018-01-15 09:49:10 +01:00
Juergen Spitzmueller
9b603d90c8 Fix loop while separating
getMaxDepthAfter() gives wrong result here.

Fixes: #10979

Signed-off-by: Juergen Spitzmueller <spitz@lyx.org>
(cherry picked from commit bceaa7f92971f62014da43557815479d40adf551)
2018-01-13 10:01:44 +01:00
Juergen Spitzmueller
9e8d702d63 Fix Null-checking issue detected by Coverity.
(cherry picked from commit 974553d8583954aa7741c4dc0ce83f9ca812b03b)
2018-01-12 10:31:40 +01:00
Pavel Sanda
f91e77d18e RCS: commit undo allowed only in unlocked state. 2018-01-11 23:47:41 +01:00
Juergen Spitzmueller
70d580fea7 Mark follow-up paragraphs in a paragraph group as nested.
This gives a more consistent indication of what belongs to an environment
(and semantically, such paragraphs are synonymous to nested standard
paragraphs)

Addresses part of #9261.
2018-01-07 10:38:30 +01:00
Jean-Marc Lasgouttes
572b29b139 Update buffer when an inset or an INFO inset has bee inserted
This is important for info inset, since if updateBuffer needs to be
run in redoParagraph (for the macro code), crashes can happen.

Fixes bug #10944.

(cherry picked from commit 806f40dbd4e861e3def104f26a8b70ed8c3ba386)
2018-01-06 15:08:42 +01:00
Guillaume MM
225d47f298 Fix preview with a nested preview not being shown (#10795)
Regression at db581113.

(cherry picked from commit 94c65074e029937b549f5ed5af1001fadbe408be)
2018-01-06 02:58:36 -05:00
Richard Heck
b92ddb0362 Fix bug #10951.
The Buffer member for the remembered definition_ was not being set.

(cherry picked from commit f130f7713fae326daa05795a5bf4761d33aee649)
2018-01-04 15:26:57 -05:00
Juergen Spitzmueller
cf97ec4a21 Do note attempt to nest more than possible.
(cherry picked from commit 32efb914384392426a4d909d1650edff727d8f15)
2018-01-04 18:40:26 +01:00
Juergen Spitzmueller
7668633b94 Properly handle color none.
Fixes: #5870
(cherry picked from commit 9a1eeb8cbbf078aca6e95a554a76dc622a8d39f1)
2018-01-04 08:23:04 +01:00
Juergen Spitzmueller
d3ca12a5c2 Disable useless environment-split function at the core.
(cherry picked from commit f965d23633916387cd48d228380f4a3172e61c2f)
2018-01-03 13:19:24 +01:00
Juergen Spitzmueller
1b2dd66f78 Use the command-alternatives sequence as defined in menus.bind
Otherwise, the shortcut is not displayed in the menu.

(cherry picked from commit 7d2764fb9ed708c36c636c88ce40149988f3b941)
2018-01-03 11:00:47 +01:00
Juergen Spitzmueller
d60fa7f501 Prepend "Insert " in the context menu for environment separators.
(cherry picked from commit 8f86feb26087305625cef3e66afabcdcb91a4057)
2018-01-01 13:42:38 +01:00
Juergen Spitzmueller
92613ac63c Implement environment-split before and previous
Possibility to add an environment before the current one and to append
and environment from outside the nesting scope.

This commit includes all fixes that went in during testing these
functions in master. It also moves the menu items from Edit to Insert.
2018-01-01 12:34:39 +01:00
Juergen Spitzmueller
8ad7b0caea Add ignoresep option to layout lfun
This does not force the cursor in a separator paragraph to endpos.

This is needed for environment-split.
2018-01-01 12:31:31 +01:00
Juergen Spitzmueller
12bd7352fd Implement auto-nesting.
Now layouts can specify other layouts that should be nested in and
after the current one (if the layout is switched from the current one
and if it follows a paragraph in the current one).

This is particularly useful for things such as the beamer frames, where
particular layouts are practically always nested.

This is a backport from master, including all fixes.
2018-01-01 12:30:34 +01:00
Juergen Spitzmueller
438b067b5a Properly implement IsTocCaption for Arguments in standard TOC
Fixes: #10631

Candidate for 2.3.x.

(cherry picked from commit 3a4b233dbd9810608ad1d79a1d866c8ab3ce2f29)
2017-12-30 11:02:49 +01:00
Juergen Spitzmueller
196032f79f Fix footnotes in table with RevTeX4
These classes come with their own working implementation of table
footnotes, so we are not supposed to use the tablefootnote or
footnote package.

Also add missing outliner name.

(cherry picked from commit dfaa4e9466fd0e5bf22bf55965a26e86a767cfa7)
2017-12-28 10:07:56 +01:00
Jean-Marc Lasgouttes
546a6a2a31 Do not draw inactive math corners when they have mathbg color
By default, inactive math corners are invisible. In practice they are
annoying because they are visible when selecting text, and they can
also overwrite some parts of the equation.

The code in Inset::drawMarkers2, which is only used for maths, is
moved to InsetMathHull. Moreover, the inactive corners are not drawn
when they have the same color as the math background. A better way to
achieve this would be to set the color to transparent, but we do not
support this yet.

(cherry picked from commit 68614e9783382b6267fc9ce32ed45bc2477007dd)
2017-12-23 19:53:58 +01:00
Jean-Marc Lasgouttes
92f320ff4a Reintroduce the spacing around delimiters
This spacing was wrongly removed at 361bd53b as part of the
introduction of proper spacing between elements, but it only introduces
some breathing space around the delimiters. This will not be necessary
anymore when/if we use proper delimiters from the cmex10 font.

(cherry picked from commit 4cb5cc0c7de7cb5dbaaf14328e5a82e1cfe5a6ca)
2017-12-23 19:48:06 +01:00
Jean-Marc Lasgouttes
87d291ee23 Handle properly undo groups in embedded work areas
When a buffer is in an embedded work area (adv. find&replace), it is
not found by BufferList:::exists(), and therefore the undo group
created in GuiApplication::dispatch and in the handling of
LFUN_COMMAND_SEQUENCE will not be closed.. Crashes can ensue, as
described in Ubuntu bug:
https://bugs.launchpad.net/bugs/1737429

The solution is to introduce BufferList::isInternal and act on it.

Fixes bug #10847.

(cherry picked from commit 8b107f0490e61b4390e925f08d21661ef50d6f49)
2017-12-23 19:21:12 +01:00
Juergen Spitzmueller
2b927cbc2e Fix typo.
This had the effect that for file dialogs supposed to use two buttons,
only the second one was displayed, while file dialogs supposed to use
one button did not have a button at all.

Candidate for 2.3.x and 2.2.x.

(cherry picked from commit 74607702a585fd68bdf6b9cda668421a4ed06f3e)
2017-12-20 19:04:26 +01:00
Juergen Spitzmueller
63af581324 Do not rely on babel quotation macros for encodings other than [O]T1
Babel falls back to OT1 in these cases, which gives wrong output got the
guillemots

Fixes: #10947
(cherry picked from commit 64b94f81be52de33553cda5db85d824de2119a3c)
2017-12-18 12:40:44 +01:00
Juergen Spitzmueller
f337a55327 Amend d56a5447f306
LaTeX only breaks after dashes (even though unicode suggests optional
line breaks also before em dashes).

(cherry picked from commit 1371dbb24063b613cb8914a521b90a47d74f0472)
2017-12-17 19:25:54 +01:00
Juergen Spitzmueller
c527035b70 Consistent output of breakable/non-breakable dashes on all TeX engines.
Fixes: #10839
(cherry picked from commit d56a5447f30688286c1fe19f3b51225f4b586b3e)
2017-12-17 19:24:46 +01:00
Uwe Stöhr
50c83973a6 Buffer.cpp: reference oasis in https link 2017-12-17 02:41:51 +01:00
Uwe Stöhr
e73164e25d tex2lyx: support to detect https:// links
- Preamble.cpp: use the occasion to backport JMarcs recent compiler warning fixe
2017-12-17 02:28:54 +01:00
Uwe Stöhr
998d39fa28 GuiPrintNomencl.h: fix bug #10819 also for 2.3.x 2017-12-17 02:01:49 +01:00
Juergen Spitzmueller
132726e84a Missing "icon" in description of "info-insert"-function
(cherry picked from commit 7821cb713375588e3ed65b4e13dd9e8066ab08a8)
2017-12-09 09:53:43 +01:00
Juergen Spitzmueller
1bd4223554 nomenclWidest(): take (proper) formatting into account. 2017-12-04 10:24:02 +01:00
Juergen Spitzmueller
798b7126ef Fix thinko from b68701c4da93a6f0f
(cherry picked from commit 938c44590cb643029ce47694edf7ab3949a800a2)
2017-12-03 11:37:33 +01:00
Enrico Forestieri
4e753bdc3f Avoid asserting when reading the session file
Fixes #10824.

(cherry picked from commit f84acc0e3441d09c0b5026f97c3e4cbbc0067256)
2017-12-02 21:37:02 +01:00
Scott Kostyshak
e3494c2f3a Set array length from int const
(cherry picked from commit b3f7eb6af37bcef01976a22ba422c289371365f4)
2017-12-02 13:17:36 -05:00
Juergen Spitzmueller
a4aee2a090 Escape (makeindex) special chars in nomencl if !literate
Fixes: #10825
(cherry picked from commit b68701c4da93a6f0ff618f5554b76c48373a3ac8)
2017-12-02 09:59:41 +01:00
Juergen Spitzmueller
225253dfc6 Implement l7n for nomenclature.
(cherry picked from commit 718a353b49d903f3e50c895a29f20f8970db2d06)
2017-12-01 10:19:30 +01:00
Juergen Spitzmueller
7c8d167f8e Longtable: only output the caption contents in a caption row.
Fixes: #10791
(cherry picked from commit 538b38f78c76a56bec7e6cec0314d8f4e0f1e415)
2017-11-20 19:51:32 +01:00
Juergen Spitzmueller
3561caa3a1 Fix footnote output in description item
Fixes: #9387
(cherry picked from commit aaa61500896ef00087b146fd41ee88ea16dd0f1d)
2017-11-20 09:50:23 +01:00
Juergen Spitzmueller
55bc365872 Allow footnotes in floating tables via tablefootnote package
See #808.

(cherry picked from commit 5017a0a1c635ed8da2b1fce5e240d0e297cf1aaf)
2017-11-20 09:49:36 +01:00
Juergen Spitzmueller
c2d121f663 Fix footnote output in tables outside floats and longtable header/footer
Fixes: #808 (sic!), #5869
(cherry picked from commit 3affde3957ff29fb0543478e072427616eb9b049)
2017-11-20 09:49:10 +01:00
Juergen Spitzmueller
7920a12065 Disable non-functional table rotation for longtables
In the long run, proper longtable rotation via [pdf]lscape should
be implemented.

See #9194

(cherry picked from commit 84f7dafe891483e0314e2a08c0ddd8cf0063902d)
2017-11-20 09:37:01 +01:00
Juergen Spitzmueller
1a8873d7be InsetExternal: update renderer after preview status change
This fixes a crash when changing instant preview prefs while
document with previewed external inset is opened.

Fixes: #10785
(cherry picked from commit 0842e22f4551e84dbf24259c65994c760fc22925)
2017-11-12 18:31:00 +01:00
Juergen Spitzmueller
fadb93ae68 Collapsable -> Collapsible (part 5)
Preferences update and prefs2prefs routine.

This was forgotten in the process.
2017-11-02 16:51:23 +01:00
Enrico Forestieri
43a6fe8375 Fix #10778 (issue with CJK and language nesting)
When using CJK, don't try to close a language that was never
opened before, such as when it is the main language.

(cherry picked from commit 7e51b5f30196fa0679a7c3c32dc75bca91520f32)
2017-11-02 11:07:11 +01:00
Juergen Spitzmueller
8f98423e92 Enable OK/Apply buttons when resetting to class defaults.
(cherry picked from commit b851a349b6f303824f329a5dc854827f66828764)
2017-11-01 23:09:59 +01:00
Enrico Forestieri
8be0ec0db5 Fix issue with change-tracked deleted display math
- If a display math not starting a new paragraph is deleted, the
  current \lyxdeleted macro (if any) must be closed and a new one
  started, otherwise the display math will be shifted up.

- Use \linewidth instead of \columnwidth because the former will adapt
  to the reduced horizontal width in list environments, avoiding shifting
  to the right the diplay math.

(cherry picked from commit 7f23ca912c5e92bf30bdc05b6d801082f6643e8e)
2017-10-25 19:51:14 +02:00
Juergen Spitzmueller
a81a0c5534 Implement ParamInfo::HANDLING_LTRIM and use it to ltrim InsetBibitem
output

See #9847.

(cherry picked from commit 76f49fad78db5ed768db163feef4e3b3c062228f)
2017-10-23 09:07:22 +02:00