Commit Graph

6623 Commits

Author SHA1 Message Date
Tommaso Cucinotta
57aa866a1c Fixed issues in backward search in various corner cases (fixed #6482 and #6596).
Now, when scope includes multiple documents, the switch_buffer LFUN is only issues if buffer actually changes.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33812 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-20 13:59:46 +00:00
Richard Heck
d0434b96e8 Since we don't do anything if the cursor isn't in view, do that test
first.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33803 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-19 16:11:58 +00:00
Jürgen Spitzmüller
f91cd9d255 fix bug #6513.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33800 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-19 13:35:32 +00:00
Abdelrazak Younes
44fb52d1a2 Fix potential bug affecting export and preview with threads.
QThreadPool::maxThreadCount() defaults in general to 2 on single or
dual-processor. This is clearly not enough in a time where we use
threads for document preview and/or export. 20 should be OK.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33790 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-18 12:42:34 +00:00
Tommaso Cucinotta
e74f4b1d8b No more auto math toolbars while in regexp mode (addressing #6471).
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33787 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-17 13:37:15 +00:00
Uwe Stöhr
317192fa1f PrefLatexUi.ui: fix alignment and spacing of the text edit fields
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33783 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-17 01:02:21 +00:00
Uwe Stöhr
96f16d62f8 PrintNomenclUi.ui: fix a typo, spotted by Ignacio
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33775 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-16 21:51:39 +00:00
Abdelrazak Younes
545d7bb431 white space.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33750 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-15 16:26:09 +00:00
Pavel Sanda
21f2ad3701 Parametrize position of version string
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33745 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-15 12:39:06 +00:00
Pavel Sanda
8ffc79cf63 Honour lyxrc.show_banner again
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33744 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-15 12:18:21 +00:00
Jürgen Spitzmüller
c23fe9abfe * GuiSpellchecker.cpp:
- prevent null pointer (bug 6586)

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33743 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-15 10:03:02 +00:00
Richard Heck
5e0de68db5 Minor cleanup, and some const-ness.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33734 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-13 16:55:59 +00:00
Pavel Sanda
9be4767f27 Fix Error dialog. Patch from Richard and Abdel.
http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg158649.html
http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg158658.html


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33732 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-13 11:39:50 +00:00
Vincent van Ravesteijn
7d30e34b08 Fix bug #6462: Out-of-bounds index in GuiErrorList::goTo when new buffer is active.
Cache the buffer and errorList in the GuiErrorList dialog. Now, we can check whether the active buffer is also the buffer for which the errors are shown. We switch back to the correct buffer, when one clicks on an item or clicks "View complete log".

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33726 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-12 15:06:13 +00:00
Vincent van Ravesteijn
2ef545a250 Fix bug #6397: use GUIfied strings in the error dialog.
Forward port of r33408 (commit by Juergen).

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33725 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-12 13:47:28 +00:00
Uwe Stöhr
1f907d16d1 GuiWorkArea.cpp: remove unused include of MetricsInfo.h
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33722 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-12 00:27:12 +00:00
Vincent van Ravesteijn
cabde10fa3 Adjust the window settings for MacOSX.
- No more Drawers,
- ProgressView and SourceView are docked at the bottom,
- SpellChecker, FindAndReplace and Outline are floating by default, but dockable.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33716 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-11 19:33:08 +00:00
Vincent van Ravesteijn
c5e0708f88 Add Qt version info to the About dialog in the DEVEL_VERSION.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33715 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-11 18:31:01 +00:00
Vincent van Ravesteijn
d8bb69e74e Fix bug #5735: Modifying a keyboard shortcut function entry clashes with its own shortcut key combination definition.
- Trim the saved lfun because there is a space added in the textfield,
- check whether the action has changed before signaling that the shortcut already exists.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33713 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-11 17:34:59 +00:00
Abdelrazak Younes
2a3f27a80c Code simplification.
TocTypeModel is not needed outside TocModel.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33707 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 21:00:34 +00:00
Richard Heck
56d89dbff9 This is worth having here anyway.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33703 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 18:43:10 +00:00
Richard Heck
0bddd759d7 Another try at #6522. This works here, for the most part, with no ill
effects that I can see. That said, I believe there is still a crash you
could get. I'll explain in a moment.

Since we may run into this kind of thing again, let me explain why this
is necessary. The problem was that resetting the model was causing a
signal to be emitted that the current index had changed, which was
triggering an update of the Buffer, eventually. I'm not sure why this
did not happen in Qt 4.5, but in Qt 4.6, you have to call
beginResetModel() before doing anything, so that the combo box will
remember its previous setting. Then you can change the data; then you
can call endResetModel(). This will attempt to restore the previous
setting. Only if it cannot do so will currentIndexChanged() be emitted.

You can see, therefore, that if whatever the user did caused the current
setting to become invalid---e.g., she deleted the only footnote---then
the signal will be emitted and LyX will still crash. Still, that is a
fair bit better than presently.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33702 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 18:41:28 +00:00
Vincent van Ravesteijn
f23a2ccb58 Fix bug #6488: Avoid a null pointer when accessing documentBufferView when there is none.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33692 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-10 14:46:28 +00:00
Richard Heck
42a2a0f289 Cheap fix for #6554. When we save a Buffer to a new location, we check
the included insets and make sure that the files they reference are
still where they are supposed to be.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33686 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-09 03:25:47 +00:00
Richard Heck
d70f91a380 Line length, again.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33683 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 20:48:48 +00:00
Richard Heck
c653974e9d Revert r33630 and do something more sensible.
I don't think this fixes the underlying problem, but I think that
problem is very extensive. Fixing it would involve a re-thinking of
where and how we call updateBuffer()---the old updateLabels().

This fix also reveals another problem with the TOC, again due to the
early call of on_typeCO_currentIndexChanged(). But that problem is a
slightly different one, I think.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33680 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 19:52:48 +00:00
Richard Heck
483c891705 Spellcheck related bugfix from John McCabe-Dansted:
PrefSpellchecker disables the "Spellchecker Engine:" selector if
theSpellChecker() reports that no spell checking engine is selected.
This means that if we have not already selected a spell checking
engine we cannot select one now. I think this problem can be
reproduced by first compiling and running LyX without spellchecking
support and then compiling and running LyX with spellchecking support.

In any case it is clear that we should be able to select a
spellchecking engine if one is available, so I propose the attached
patch. This patch fixed the problem on my machine.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33669 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 13:22:56 +00:00
Richard Heck
60034997d9 Make sure the model exists before we access it.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33668 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 12:42:18 +00:00
Peter Kümmel
92ebfe89e7 no Q_EMIT in older Qt versions
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33667 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-08 09:35:10 +00:00
Peter Kümmel
97651ca03c Use one place to generate current time string, increase resolution to ms
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33662 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-07 11:55:14 +00:00
Abdelrazak Younes
b8390b5e2c Try to restore longtable dialog to a semi functional state. This Dialog is really horrible, disabling/enabling a checkbox depending on the cursor position is very unintuitive... We need some edit boxes to show which rows are header/footer/etc without having to move the cursor first. That would be my next step newt week.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33651 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-06 19:08:10 +00:00
Pavel Sanda
a7b921aeeb Fix unsafe use of fixed width arrays.
Fix crash when MathMatrix has more than 80 columns

Patch from John McCabe-Dansted, approved from Andre.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33641 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-06 14:57:16 +00:00
Richard Heck
1fcc1c0f18 Fix bug 6522 and its relatives in trunk. I am not absolutely sure this
is right, though. Someone please check.

The problem, in branch, was that (in Qt 4.6.x, anyway) the call to
reset() eventually triggers the on_typeCO_currentIndexChanged() method,
which eventually leads to GuiView::setFocus(), which leads to
GuiWorkArea::focusInEvent(), which tries to start the cursor, whose
position hasn't been updated yet, from what I can see.

The problem in trunk is similar. The crash happens, I think, because,
while we are in the middle of resetting the model, the same method is
triggered, which leads us to try to access the model while we are in the
middle of resetting it.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33630 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-05 20:47:50 +00:00
Peter Kümmel
d58b4ead47 fix bug 6578, use tabs
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33627 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-05 18:07:05 +00:00
Pavel Sanda
59c980e6e5 Start preparations for alpha
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33623 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-05 08:05:20 +00:00
Richard Heck
afb8365d82 Some cleanup for the Floating class.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33617 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-04 13:42:05 +00:00
Richard Heck
d65020b293 s/updateLabels/updateBuffer/g, per a suggestion of Abdel's.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33613 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-03 22:13:45 +00:00
Abdelrazak Younes
81d2d239c3 Document Settings: fix Float placement dialog. The float type is not
needed here.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33602 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-01 09:03:15 +00:00
Jürgen Spitzmüller
4def0c2a52 * Menus.cpp: add accelerator to "More Languages ..."
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33591 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-28 10:23:06 +00:00
Jürgen Spitzmüller
5c6c8dc25f " Menus.cpp: sort languages. Based on a patch by John McCabe-Dansted.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33590 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-28 10:06:05 +00:00
Richard Heck
3906792378 We were doing this twice, and I think there's also a bug here, namely,
that we weren't re-enabling if we returned early.

Someone tell me if this is wrong.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33585 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 19:56:08 +00:00
Richard Heck
805231ccbe This can just take a FuncCode.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33584 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 19:51:06 +00:00
Richard Heck
c127d83b66 A little cleanup while perusing TocWidget....
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33583 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 19:48:20 +00:00
Vincent van Ravesteijn
834115c920 Fix bug #6552: Crash when inserting TeX-code in math mode and scrolling
Avoid an assertion when accessing the CoordCache while the Inset is in a paragraph which is not visible on screen.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33582 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 15:59:08 +00:00
Jean-Marc Lasgouttes
6d671bf5f2 Fix compilation with qt 4.2: QString::operator[] returns a QCharRef,
which is supposedly like a QChar... except that some methods like isUpper 
were forgotten in the process.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33580 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 14:46:42 +00:00
Vincent van Ravesteijn
4aeca63887 Fix bug #6464: Crash when exiting LyX from second window when first window has changed buffer.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33579 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 14:07:21 +00:00
Jürgen Spitzmüller
f31298fd7c * GuiSpellchecker.cpp:
- fix bug #6561 (null pointer).

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33578 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 13:34:36 +00:00
Jürgen Spitzmüller
9f67cede58 Menus.cpp: priorize capitals as language accelerators.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33566 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-25 12:56:12 +00:00
Jürgen Spitzmüller
ea6b96dfc5 * Menus.cpp: hide Language item if only one language is used.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33565 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-25 12:46:16 +00:00
Jean-Marc Lasgouttes
04336d45d8 fix compilation with qt 4.2
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33563 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-25 11:35:41 +00:00