Juergen Spitzmueller
633013453e
Factor out Paragraph::isPartOfTextSequence
...
Amends 045c25cf76
2021-10-31 09:26:57 +01:00
Juergen Spitzmueller
045c25cf76
Prevent unneeded (and wrong) \noindent
...
* When a paragraph is logically empty (only contains stuff which is not
part of the text sequence
* In centered paragraphs
2021-10-30 14:19:46 +02:00
Juergen Spitzmueller
f3002d1cf4
Get rid of some more fragile index reliances
2021-10-29 17:52:25 +02:00
Jean-Marc Lasgouttes
110445e3e2
Rename BufferView::updateScrollbar to show what does
...
Only parameters are updated, not the scrollbar itself.
2021-10-29 17:45:51 +02:00
Juergen Spitzmueller
47b394f2c5
Amend [5c055034/lyxgit]
...
Relying on indexes is too fragile here
2021-10-29 17:06:11 +02:00
Jean-Marc Lasgouttes
5c055034c2
Fixup b0c102cfb
: make it possible to select medskip as parskip
...
Some new parskip possibilities had been added, but the check for
custom length index had not bee updated.
This code is very fragile.
Related to bug #10968 .
2021-10-29 16:41:00 +02:00
Juergen Spitzmueller
61fb295e46
Disable language selector in LyXFiles dialog if no file is selected ( #12412 )
2021-10-29 13:17:50 +02:00
Jean-Marc Lasgouttes
2c50f0cd77
An assert to hopefully please coverity
2021-10-29 12:39:50 +02:00
Yuriy Skalko
54028c3eea
Mark inverted branch insets
2021-10-27 00:56:06 +03:00
Stephan Witt
436620a881
#12201 force open document in tabs on Mac when user preference is Always
2021-10-23 13:34:18 +02:00
Jean-Marc Lasgouttes
85f030a031
Let Tab go out of inset when no cycling is possible
...
Adapted patch from Enrico by adding S-Tab handling.
Fixes bug #11085
2021-10-21 22:42:40 +02:00
Jean-Marc Lasgouttes
2f236b01e0
Make sure that language is "latex" in InsetArgument when pass-thru.
...
The code that determine whether an InsetArgument is passThru is
complex and lives in updateBuffer.
This patch factors out the code in a new init method and calls it also
in doInsetInsert when inserting a InsetArgument.
Fixes bug #12143 .
2021-10-21 19:14:06 +02:00
Pavel Sanda
6770fe5f38
* better wording
2021-10-21 16:01:57 +02:00
Pavel Sanda
985f7c9316
Improve error msg.
2021-10-21 15:20:28 +02:00
Juergen Spitzmueller
b55aea6776
Prevent unneeded cprotection in branches ( #12378 )
2021-10-21 10:27:05 +02:00
Thibaut Cuvelier
279e0a6839
DocBook: use the new refactorings in InsetText.
...
InsetText::docbookRenderAsImage directly used Qt to compute hashes, use the same code as support/FileName (now living in support/filetools).
2021-10-19 09:15:44 +02:00
Thibaut Cuvelier
0b5e940723
Refactor file-name sanitisation.
...
For now, this is only used in FileName, because it does not change the semantics of DocFileName::mangledFileName.
2021-10-19 09:15:44 +02:00
Thibaut Cuvelier
789a537182
Refactor computing hashes.
...
For now, this is only used in FileName, because it does not change the semantics of DocFileName::mangledFileName.
2021-10-19 09:15:44 +02:00
Jean-Marc Lasgouttes
40ee8d2a1a
Reset inline completion after undo/redo
...
Fixes bug #12383 .
2021-10-18 17:36:27 +02:00
Jean-Marc Lasgouttes
ada713a881
Revert "Update correctly completion after undo"
...
This reverts commit 06acb7f806
.
2021-10-18 17:35:48 +02:00
Enrico Forestieri
e8b366d4d6
Amend 771f30e9
for cmake
2021-10-17 19:17:01 +02:00
Enrico Forestieri
3048878eab
Amend 47f1fec9
...
Also account for cmake
2021-10-17 18:32:50 +02:00
Juergen Spitzmueller
3543626182
Do not change bibliography processor to default if it is not found
...
Rather than that, keep it with a warning that it is not available.
Fallback procedure (which maintains security measures) is done in
the conversion step.
This prevents document properties being silently changed on sharing.
2021-10-17 17:14:14 +02:00
Juergen Spitzmueller
f350072565
Provide proper fallback if a bibliography processor is not found
...
Check for appropriate fallbacks and warn user if the requested
bibliography processor is unavailable.
2021-10-17 17:14:14 +02:00
Enrico Forestieri
771f30e946
Enable QWindowsMimeMetafile with Qt6
...
The QWinMime class has been removed in Qt6 but the functionality
is still present. However, one has to allow inclusion of private
headers and register the mime handling to the QWindowsApplication
native interface.
2021-10-17 15:06:05 +02:00
Thibaut Cuvelier
21366155e4
DocBook: use a hash to determine the file names for generated images.
...
This way, the file names no more change without a reason.
2021-10-16 22:41:38 +02:00
Thibaut Cuvelier
33668e3a30
DocBook: export the preview images to the right format.
...
"docbook" is not the same as "docbook5", maybe it would be better to have an enumeration instead of strings.
2021-10-16 22:41:38 +02:00
Thibaut Cuvelier
e0830592f0
DocBook: wrong type of XML tag.
...
imagedata should have been a compound tag, because it should have no content, only its attributes are relevant (instead of a start-end pair of tags).
2021-10-16 22:41:38 +02:00
Jean-Marc Lasgouttes
a29ced5577
Get rid of std::iterator
...
clang's libc++ 13 tells us that it is deprecated in C++17.
Fortunately, we do not need it after all.
2021-10-15 18:13:09 +02:00
Jean-Marc Lasgouttes
d99502d915
Remove variable that is not used
...
Spotted by clang++ 13.
2021-10-15 15:49:40 +02:00
Jean-Marc Lasgouttes
5f4890721b
Improve display of META_INSET in status bar.
2021-10-15 11:11:57 +02:00
Scott Kostyshak
1c70d98fc1
Fix sign-compare warning
...
Fix warning comparing long int to long unsigned int.
2021-10-14 23:50:08 -04:00
Pavel Sanda
f7de009b17
Guard against possible referencing null.
...
Those checks might not be needed, but it's not self obvious from
the surrounding code. Because we already experienced crash from
similar change (cf 1c1c83eced
), let's be prudent here.
If you know that these pointers can't be null from broader context
feel free to remove the guards.
Introduced by 24926b2e23
, fix 104fdcc9be
not backported
but now fixed by 1c1c83eced
in 2.3.
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg216414.html
2021-10-14 22:28:43 +02:00
Jean-Marc Lasgouttes
06acb7f806
Update correctly completion after undo
...
This is take #2 after reverting e59aee458
.
Request the completer to rebuild a completion after undo/redo.
Fixes #12383 .
2021-10-14 16:39:33 +02:00
Jean-Marc Lasgouttes
91c5061d26
Revert "Reset inline completion after undo/redo"
...
Try a solution closer to other code instead.
This reverts commit e59aee4580
.
2021-10-14 16:26:21 +02:00
Thibaut Cuvelier
7652747e26
DocBook: generate images for layouts that request it.
2021-10-13 19:26:49 +02:00
Thibaut Cuvelier
3502f5c999
Factor out the generation of the code to create a preview.
...
This will be soon reused in InsetText to generate images for DocBook.
2021-10-13 19:26:49 +02:00
Thibaut Cuvelier
b5533a24f4
Typos and comment improvements.
2021-10-13 19:26:49 +02:00
Thibaut Cuvelier
46b8101800
Factor out the list of macro definitions for InsetPreview.
...
This will be soon reused in InsetText to generate images for DocBook.
2021-10-13 19:26:49 +02:00
Thibaut Cuvelier
48a507694e
DocBook: add assertion to help debugging.
2021-10-13 19:26:49 +02:00
Thibaut Cuvelier
82bca97379
DocBook: overall structure for rendered insets.
2021-10-13 19:26:49 +02:00
Thibaut Cuvelier
5c735ce880
DocBook: don't use a surrounding <para> for rendered insets.
2021-10-13 19:26:49 +02:00
Thibaut Cuvelier
e93e50bf56
DocBook: add the DocBookRenderAsImage tag.
2021-10-13 19:26:48 +02:00
Stephan Witt
b59eed3846
#12368 correct spelling of toolbars visibility check function name
2021-10-13 18:11:37 +02:00
Jean-Marc Lasgouttes
e59aee4580
Reset inline completion after undo/redo
...
Fixes bug #12383 .
2021-10-12 15:45:04 +02:00
Jean-Marc Lasgouttes
c242b25364
Work around compilation warning
...
Clang 12 (at least) misses the fact that tag is always initialized,
because the if/else sequence does cover all cases.
Initialize the variable although it is not required. It does not hurt
at least.
2021-10-11 14:51:28 +02:00
Jean-Marc Lasgouttes
a5f1b15858
Make CoordCache assertions less annoying.
2021-10-09 12:25:29 +02:00
Jean-Marc Lasgouttes
0fff65a16a
Avoid duplicate checks in CoordCache
...
The code is written in such a way that the elements are searched
several times. This can be expensive when there are a lots of insets
in the document.
Concerning the sanity checks, they are now conditionned on the
presence of assertion.
Related to bug #12297 .
2021-10-08 18:17:19 +02:00
Jean-Marc Lasgouttes
e5bb491e2e
Reduce the number of accesses to coord cache when drawing a math row
...
Each of these accesses is somewhat costly when using large branches
with lots of maths
Related to bug #12297 .
2021-10-08 18:17:19 +02:00
Jean-Marc Lasgouttes
e09158efee
Use unordered maps to store inset and math rows geometry.
...
Simply using unordered_map instead of map makes a big difference for
documents with lots of math insets in one text inset.
Related to bug #12297 .
2021-10-08 18:17:19 +02:00