Commit Graph

25054 Commits

Author SHA1 Message Date
Juergen Spitzmueller
89d42a68f5 Disable bookmarksopenlevel SL when bookmarksopen is false
Fixes #11289

(cherry picked from commit f2243a3bc7)
2020-05-18 09:15:56 +02:00
Richard Kimberly Heck
1741eb9c2c Fix bug #11456.
Add cancel button and take no action if we're canceled.

(cherry picked from commit 2de99c5dd9)
2020-05-18 00:30:13 -04:00
Juergen Spitzmueller
af4e5aefe0 Check class options for uncodable glyphs
Fixes #11865

(cherry picked from commit 11dc817e9d)
2020-05-16 09:05:36 +02:00
Juergen Spitzmueller
991ef3840e Assign InsetBibtex to appropriate toc level
Fixes #11863

(cherry picked from commit 92ba05c53b)
2020-05-16 09:02:55 +02:00
Juergen Spitzmueller
119d38bedf Move \PassOptionsToPackage before the first package loaded
Fixes #11862

(cherry picked from commit 2663e3845e)
2020-05-14 09:18:16 +02:00
Richard Kimberly Heck
94c2466c4c Fix bug #11864 2020-05-13 14:44:08 -04:00
Scott Kostyshak
7a158055fe Only set dummy X11 selection if we do not own it
Before, we would continually set the selection to the empty string,
to maintain ownership. This causes problems with clipboard managers
GPaste and CopyQ. Further, in theory this should have better
performance since checking ownership should be faster than setting.

A disadvantage of this change is that the timestamp of the selection
will be old at this point in the code. However, when the selection
is requested, we put the selection contents at that point so the
selection timestamp should be accurate then. Further, the selection
contents are not accurate at this point in the code (they are just
the empty string), so it is not clear whether having an accurate
timestamp is beneficial.

Fixes #11715.

(cherry picked from commit af4ee1a487)
(cherry picked from commit 23abb5aaa3)
2020-05-06 08:29:00 -04:00
Juergen Spitzmueller
584550a732 Remap typographical apostrophe from Hunspell to plain apostrophe (#11832)
(cherry picked from commit ca28c9866a)
2020-05-04 23:40:18 -04:00
Richard Kimberly Heck
b4e613828e Fix bug #11787.
Make sure we are actually at the end of the document before issuing
\maketitle because we are at the end of the document.

(cherry picked from commit 7af6575cf6)
2020-05-04 23:30:52 -04:00
Jean-Marc Lasgouttes
e47834104a Adopt a 'belt and braces' approach to bidi forcing
There are two techniques that I know of for forcing the direction of a
string, regardlessly of whether its contents is naturally LtR, RtL or
undecided.

1/ The unicode LTR/LTR override characters. This is supposed to be the
   clean way, however, it does not seem to work with Qt 5.14 (see
   #11691).

2/ The undocumented QTextLayout::setFlags method. This is used
   internally and allows to pass the (undocumented) flags
   Qt::TextForceRightToLeft and Qt::TextForceLeftToRight. This was
   used until we had issues with Qt 5.11 (see #11284).

In order to get the best of both worlds, this patch allows to enable
those two methods separately, and actually enables both at the same
time by default!

Fixes bug #11691.

(cherry picked from commit 4d6041a7b6)
2020-04-29 22:55:25 +02:00
Juergen Spitzmueller
a80ecb3820 Improve reporting of undefined control sequences in preamble
Fixes #11844

(cherry picked from commit 05c7c65d93)
2020-04-19 17:32:33 +02:00
Juergen Spitzmueller
f3f0b53ba6 Reset failedtoload_ bool when include inset params are changed (#11842)
(cherry picked from commit d9b884341c)
2020-04-18 07:59:23 +02:00
Juergen Spitzmueller
e41c790f91 Fix tablefootnote loading order (#11841)
(cherry picked from commit 5bc66b5f45)
2020-04-18 07:40:45 +02:00
Jean-Marc Lasgouttes
8bb317c8db Fix embarassing crash caused by debug message
After commit 6a936d63, the helpful debug message tries to display
non-existing elements and crashes the program :(

Fix by radical simplification of the message.

Part of bug #11777.

(cherry picked from commit b5d6caac41)
2020-04-17 10:41:50 +02:00
Jean-Marc Lasgouttes
cc5d3bd9f4 Do not try to put cursor after space if no space was kept
The logic was wrong and could cause crashes

Fixes bug #11777.
2020-04-17 10:40:54 +02:00
Richard Kimberly Heck
f293de29d9 Make it nicer, thanks to JMarc
(cherry picked from commit 86a4c79dc4)
2020-04-16 21:12:30 -04:00
Richard Kimberly Heck
d1feeaaf2d Fix bug #11635
(cherry picked from commit 46f1f6f1cb)
2020-04-16 17:20:14 -04:00
Jean-Marc Lasgouttes
b7f6b979d0 Do not compute caret geometry when we are not ready to do so.
This avoid crashes with invalid cache.

Fixes bug #11763.
2020-04-09 12:51:38 +02:00
Richard Kimberly Heck
1264934898 Fix bug #11817.
Preserve line spacing when breaking a paragraph at the beginning.

(cherry picked from commit f7065fa22e)
2020-04-08 17:28:10 -04:00
Juergen Spitzmueller
97516cf2f4 Fix quotation marks in PDF TOC
(cherry picked from commit c0adb03a7a)
2020-04-06 16:41:21 +02:00
Juergen Spitzmueller
aede56fa20 Strip polyglossia options from pdf string
Fixes #11813

(cherry picked from commit f9999039ac)
2020-04-05 17:29:04 +02:00
Juergen Spitzmueller
3d0dd488c3 Disable append-column with gathered
Fixes #11812

(cherry picked from commit ed137ee435)
2020-04-05 17:18:15 +02:00
Jean-Marc Lasgouttes
ee7c607b5e Avoid bleeding of inset background outside of inset
As a consequence of fix e64ea357 to ticket #10797, we draw a bit too
much of the inset background outside of the inset (visible for insets
with colored background). #10797 is a ticket that triggers when the
cursor has a width larger than 1.

This patch limits the problems in two respects

* nothing is done on the left, since the cursor width only expands on
  the right.

* on the right, the extra width is limited to cursor width.

Fixes bug #11786.

(cherry picked from commit eb92f74d1f)
2020-04-03 19:02:29 +02:00
Richard Kimberly Heck
df2abff913 Remove newlines from shortcut LFUNs.
(cherry picked from commit c5c1683024)
2020-03-28 15:26:40 -04:00
Juergen Spitzmueller
76e71c5fdd Add hint to warning.
(cherry picked from commit 957e8669c7)
2020-03-26 07:52:37 +01:00
Juergen Spitzmueller
ee69752d61 Fix warning message
(cherry picked from commit c77be6146b)
2020-03-26 07:52:22 +01:00
Juergen Spitzmueller
e1c29a0510 Check character encodability with pass-thru in command insets
Fixes: #11584
(cherry picked from commit ebc2b1295a)
2020-03-26 07:52:01 +01:00
Juergen Spitzmueller
cca83a320b Don't omit ZERO WIDTH NON-JOINER on clipboard paste
Fixes #11790

(cherry picked from commit 7b3404fcab)
2020-03-23 17:25:04 +01:00
Richard Kimberly Heck
7c0cbe68bc Fix bug #11748.
Track the last chosen citation style when we clear the entries.

(cherry picked from commit 64f7da961a)
2020-03-17 02:01:37 -04:00
Richard Kimberly Heck
429d2171b1 Fix bug #11780.
The preamble snippets are for LaTeX and do not need to be output
with HTML.

(cherry picked from commit f044d3a359)
2020-03-14 19:19:04 -04:00
Juergen Spitzmueller
48cb1aa3b7 Fix UI quirk in IncludeOnly settings
Fixes #11564

(cherry picked from commit b568a49593)
2020-03-13 08:45:45 +01:00
Richard Kimberly Heck
2ece10f327 Fix problem with validation when using InsetLayout.
(cherry picked from commit 2e444dd657)
2020-02-26 22:30:34 -05:00
Richard Kimberly Heck
0be206c976 Fix bug #11737.
We need to use the FileName methods when moving or removing a file,
so that refresh() gets called.

No status entry since this will be in 2.3.4.3.

(cherry picked from commit d930913898)
2020-02-13 00:06:17 -05:00
Stephan Witt
058283515a Fix a crash with uninitialized buffer member of MathData
See the details here: https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg210294.html
2020-02-08 16:33:51 +01:00
Juergen Spitzmueller
6617d492e8 Properly resize columns of child document table widget 2020-02-08 09:27:21 +01:00
Juergen Spitzmueller
b2604aa840 Fix encoding inheritance with CJKUtf8 as custom document encoding
Fixes #11579
2020-02-07 16:18:47 +01:00
Richard Kimberly Heck
e60d5df4b3 Don't need to remove the file if it doesn't exist. (This would cause a five second delay in that case.)
(cherry picked from commit 5188f0fcff)
2020-02-06 13:54:13 -05:00
Juergen Spitzmueller
b0a2868938 Ignore geometry-related settings if the class provides geometry
Fixes #11724

(cherry picked from commit dce9e44a14)
2020-01-29 16:06:44 +01:00
Enrico Forestieri
15949fc99a Fix bug #11716
Force closing and reopening of \lyxdeleted after deleted
display math so that the following deleted text can be
correctly striked out.
2020-01-27 11:21:26 +01:00
Juergen Spitzmueller
81af6062cb Fix backspace deletion of selected items with change tracking
Move cursor at beginning of selection after deletion. Else backspace
operation gets stuck in a loop (tries to remove the selection again
and again).

This also fixes backspace deletion of insets with confirmDeletion() == true.

Fixes #11630

(cherry picked from commit adfd38e4ef)
2020-01-27 08:42:11 +01:00
Juergen Spitzmueller
2deabd0fbd Fix issues with tilde in inputpath
Fixes #11699

(cherry picked from commit a426b33067)
2020-01-27 08:32:11 +01:00
Juergen Spitzmueller
878efbaf62 Re-fix #11146 with recent LaTeX
(cherry picked from commit e75fa6f3ac)
2020-01-27 08:29:12 +01:00
Jean-Marc Lasgouttes
b7c098c3fa Avoid blinking change tracking cur for math inset.
Since there is a margin above and below the inset, there is no problem
for putting it higher.

Fixes bug #11684.

(cherry picked from commit bf7f4d716c)
2020-01-26 23:17:55 +01:00
Jean-Marc Lasgouttes
b7ec3d8515 Do not check again and again for non existing files
If the file of an InsetInclude does not exist, loadIfNeeded will try
again and again to look for it. This is very bad for files with many
include insets, especially on windows.

Fixes bug #11656.

(cherry picked from commit aeed6fb8fa)
2020-01-10 11:24:24 +01:00
Jean-Marc Lasgouttes
440271540f Disable inset-dissolve in table cells
This is better than making sure that the inset has exactly one cell.

In the future, inset-dissolve could be extended to dissolve all the
cells contents in the enclosing text.

Note that this check does not appear in mathed, and using dissolve in
e.g. fraction inset may lead to data loss (only current cell contents
is preserved).

(cherry picked from commit 5ac3b88007)
2019-12-30 13:32:24 +01:00
Juergen Spitzmueller
631e42f68b Fix crash with polyglossia and intitle commands when lang_auto_end is false
(cherry picked from commit ed44bc9b12)
2019-11-21 09:37:05 +01:00
Jean-Marc Lasgouttes
0310dcb19e Revert "Set buffer when expanding macro"
This patch is not ready yet. Moreover, change the assertion in
InsetMathGrid::colAlign to a simple test.

As a consequence, math split inset might show a bad alignment in some
situations.

This reverts commit d3fd915662.
2019-11-16 12:04:09 +01:00
Jean-Marc Lasgouttes
aaf96b3025 Use backing store also with wayland platform
Like with macOS, the Wayland compositor seems to require a
backingstore when doing partial updates like we do.

This extends the mechanism that has been introduced for macOS. This
has to be done at run time, not compile time.

Fixes bug #11692.

(cherry picked from commit 575761c665)
2019-11-07 12:40:40 +01:00
Pavel Sanda
69031bb2ce Make branch compilable in C++98 mode again. 2019-11-06 09:53:28 +01:00
Juergen Spitzmueller
8ed8aeac92 Add line break in message 2019-10-31 10:41:55 +01:00