Juergen Spitzmueller
e7c5b8aecc
Fixup polyglossia-languages test file
...
* Branch Kazakh as it is now babel-only
* Setup fonts for Chinese via fontspec
* Setup proper fonts for Japanese
* Use proper Japanese language variant
2024-09-15 15:09:08 +02:00
Juergen Spitzmueller
5c5b488c88
Fix Spanish ModernCV example
2024-09-15 13:53:41 +02:00
Juergen Spitzmueller
08c5b8b8b2
Set appropriate system fonts for Chinese docs
2024-09-15 13:32:10 +02:00
Jean-Marc Lasgouttes
928f9514a8
More places where DocumentClassPtr should not be copied
...
Spotted by COverity scan.
2024-09-14 20:40:53 +02:00
Jean-Marc Lasgouttes
8c76a9fc3d
Pass sigPtr object as const reference too
...
Spotted by Coverity scan.
2024-09-14 20:36:04 +02:00
Jean-Marc Lasgouttes
980f91d12e
Pass SocketCallback object as const reference
...
Spotted by Coverity scan.
2024-09-14 20:19:34 +02:00
Juergen Spitzmueller
52157c9318
Set appropriate tt font that supports CJK
...
The actual font should be discussed. This one is OSS and works well:
https://github.com/adobe-fonts/source-han-code-jp
2024-09-14 14:46:29 +02:00
Juergen Spitzmueller
7340fe5d65
Fixup some more Japanese templates
...
All of these rely on non-polyglossia language support
2024-09-14 14:43:43 +02:00
Juergen Spitzmueller
80fdb6ba42
Fixup Japanese Article template
...
This one relies on its own language support
2024-09-14 14:38:47 +02:00
Juergen Spitzmueller
250cb1401d
Fixup Japanese Feynman example
...
Polyglossia is loaded after the user preamble
2024-09-14 14:36:18 +02:00
Juergen Spitzmueller
6d06f5fa55
Fixup Japanese Article example
...
This one relies on its own language support
2024-09-14 14:29:31 +02:00
Juergen Spitzmueller
c167bc90f5
Fixup test file for texF tests
...
Use proper fonts basically (the rest is format conversion)
2024-09-14 12:48:57 +02:00
Juergen Spitzmueller
30f170ea26
Revert "use std::move() instead of copying when value is no longer used"
...
This reverts commit e685d31f5a
.
2024-09-14 10:59:13 +02:00
Juergen Spitzmueller
3a1c8897b1
Revert "Fix compiler warning"
...
This reverts commit 0a75854038
.
2024-09-14 10:59:08 +02:00
Jean-Marc Lasgouttes
375aba7b5d
Transform CoordCache::check/checkDim in ASSERT_DIM/POS macros
...
This makes it more obvious to the reader that these are actually
assertions, and should help Coverity scan too.
2024-09-13 15:44:33 +02:00
Jean-Marc Lasgouttes
3af0bad22a
Pass shared_ptr<> arguments by const reference
...
These arguments are not expensive to copy. However, it makes sense to
pass such pointers by const reference when they are just intended for
reading.
Some reading about this issue is here:
https://www.internalpointers.com/post/move-smart-pointers-and-out-functions-modern-c
Fixes some Coverity scan defects.
2024-09-13 14:54:43 +02:00
Jean-Marc Lasgouttes
58ee4c9ec7
Pass DocumentClassConstPtr arguments by const reference
...
This arguments are shared_ptr objects, so they are not expensive to
copy. However, it makes sense to pass such pointers by const reference
when they are just intended for reading.
Some reading about this issue is here:
https://www.internalpointers.com/post/move-smart-pointers-and-out-functions-modern-c
Fixes some Coverity scan defects.
2024-09-13 14:16:21 +02:00
Jean-Marc Lasgouttes
3649cea9e5
Make two parameters const references
2024-09-13 11:27:00 +02:00
Jean-Marc Lasgouttes
ffca6730d6
Fix uninitialized variable
...
Spotted by Coverity scan.
2024-09-13 11:21:19 +02:00
Jean-Marc Lasgouttes
9f40eaee15
Do not use rand() to set a BranchList id
...
Use a simple counting instead, beecause Coverity complains that rand()
is not safe, and counting is siimpler anyway.
2024-09-13 11:09:30 +02:00
Jean-Marc Lasgouttes
9b3c28178c
Make string parameter a const reference
...
Spotted by Coverity scan.
2024-09-13 10:27:24 +02:00
Jean-Marc Lasgouttes
8e181e992d
Avoid a couple of copies.
...
Spotted by Coverity scan.
2024-09-12 18:33:45 +02:00
Jean-Marc Lasgouttes
7a99ef7fbb
Make docstring parameters const references
...
Spotted by Coverity scan.
2024-09-12 18:28:26 +02:00
Jean-Marc Lasgouttes
b743870d71
Graph::getReachable(): pass a parameter by const reference
...
Spotted by coverity.
2024-09-12 18:20:43 +02:00
Jean-Marc Lasgouttes
b1bbf64a28
Avoid a copy
...
Spotted by Coverity scan.
2024-09-12 18:05:50 +02:00
Jean-Marc Lasgouttes
cc40330e00
Avoid a couple of copies
...
Spotted by Coverity scan.
2024-09-12 17:59:41 +02:00
Jean-Marc Lasgouttes
91f3f27545
GuiWorkArea: pass KeySymbol parameters as const references
...
Spotted by Coverity scan.
2024-09-12 17:52:57 +02:00
Jean-Marc Lasgouttes
8ea9c2da03
Avoid a couple copies in Trans::addDeadKeys().
...
Spotted by Coverity scan.
2024-09-12 17:24:32 +02:00
Jean-Marc Lasgouttes
7946dfacfa
TransState::addkey() pass parameter by const reference
...
Spotted by Coverity scan.
2024-09-12 16:54:02 +02:00
Jean-Marc Lasgouttes
eeb84bce17
Pass three string parameters by address
...
Spoted by Coverity scan.
2024-09-11 17:33:52 +02:00
Jean-Marc Lasgouttes
13b05102f2
Pass a docstring parameter by address
...
Spotted by Coverity scan.
2024-09-11 17:30:33 +02:00
Jean-Marc Lasgouttes
e6930ffec8
Pass a pair of docstring arguments by address
...
Spotted by Coverity scan.
2024-09-11 17:25:03 +02:00
Jean-Marc Lasgouttes
851e59cd26
Avoid an unnecessary string copy
...
Spotted by Coverity scan.
2024-09-11 17:08:45 +02:00
Jean-Marc Lasgouttes
a47d66df34
Pass arguments by address in convert() templates
...
The situation of the convert<>() template was a mess: the header
announced that template specializations passed strings by address (my
doing long ago), but the code would just define versions that upass
strings by value.
The solution is to pass all values by address. This works very well,
_except_ when the value is a string litteral.
Defining the templates thus requires a bit of work.
Spotted by Coverity scan.
2024-09-11 16:43:26 +02:00
Jean-Marc Lasgouttes
291d2db18e
Fix linking of test programs in support/.
2024-09-11 16:42:41 +02:00
Jean-Marc Lasgouttes
100075c890
Pass parameters of constructor by address
...
Spotted by Coverity scan.
2024-09-11 16:25:45 +02:00
Jean-Marc Lasgouttes
951cb62f47
Fixup 716e20ae
: revert useless part
2024-09-11 13:37:32 +02:00
Jean-Marc Lasgouttes
716e20ae1b
Limit the number of iterations for some tabular features in math
...
Try to please Coverity scan.
2024-09-11 13:29:20 +02:00
Jean-Marc Lasgouttes
3f5b836aa9
Make some code that handle authors more readable
...
Create accssors authodmap() in BufferParams.
Use [] operator instead of find().
Hopefully this will avoid to confuse Coverity scan.
2024-09-10 15:32:49 +02:00
Udi Fogiel
54601b5578
update test
2024-09-10 15:44:42 +03:00
Scott Kostyshak
7fb059bce4
Whitespace
2024-09-10 14:23:37 +02:00
Udi Fogiel
abd35bc33c
fix jlreq abstract layout and adapt Chinese docs for unicode engines
...
jlreq layout defined the abstract environment to be boxed
in the preamble. Doing any kind of typesetting before
all the setup has finished is error prone and may lead to
wrong output (wrong fonts for example). The correct
place to put the abstract code is right before \maketitle.
The Chinese docs loaded the ctex package in case system fonts
were used. Now, with the new support for languages with babel
and polyglossia it is no longer necessary and creates collisions.
2024-09-10 15:17:07 +03:00
Jürgen Spitzmüller
498135ef38
Do not push options to \babelprovide which do not make sense there
...
Should fix a couple of tests
2024-09-10 13:58:33 +02:00
Thibaut Cuvelier
e1efc70959
Add a comment for Python binary names.
2024-09-09 23:32:07 +02:00
Jean-Marc Lasgouttes
2ea95fa71b
Improve coverity modeling
...
This tells coverity that these functions terminate the program.
2024-09-09 17:50:01 +02:00
Jean-Marc Lasgouttes
f4c02d670b
Do not forget to reset stream after std::hex
...
Spotted by Coverity scan.
2024-09-09 17:49:20 +02:00
Jean-Marc Lasgouttes
6687b34c07
Do not handle special case where buffer == NULL
...
If it is so, we have already crashed in isBranchSelected() above.
(and hopefully, buffer_ is never null these days).
Spotted by Coverity scan.
2024-09-09 15:52:01 +02:00
Jean-Marc Lasgouttes
ffde470363
Do not access current_view_ if it is NULL
...
Spotted by Coverity scan.
2024-09-09 15:35:57 +02:00
Jean-Marc Lasgouttes
3d323412ad
Initialize client's name in main()
...
Initializing clientName at declaration time is not a good idea.
Spotted by Coverity scan.
2024-09-09 15:33:02 +02:00
Jean-Marc Lasgouttes
12d771c43f
Fixup b8cdfd1e1d
: fix thinko
...
Spotted by Coverity.
2024-09-09 15:19:25 +02:00