anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-11-30 05:12:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
43,346 Commits 31 Branches 172 Tags 619 MiB
8117172d8a
Commit Graph

27529 Commits

Author SHA1 Message Date
Richard Kimberly Heck
2405788d84 Style 2020-12-18 14:56:18 -05:00
Richard Kimberly Heck
73e7cfb26a Const 2020-12-18 14:55:58 -05:00
Richard Kimberly Heck
68e60f95d3 Remove unused file output 2020-12-18 14:51:56 -05:00
Richard Kimberly Heck
fd4d546d5b Comment 2020-12-18 14:50:13 -05:00
Richard Kimberly Heck
bd306ae118 Style 2020-12-18 14:37:58 -05:00
Richard Kimberly Heck
81be2e8a9b Use right style for private member 2020-12-18 14:30:21 -05:00
Jean-Marc Lasgouttes
005f69de23 Fix crash after b0937fb9. 
Now the cursor is not left inside color inset, so it is not needed to
pop_back.

Fix bug #12035.
 2020-12-17 22:04:46 +01:00
Juergen Spitzmueller
f661469734 Implement sane UI for switching tristate toolbars (#6364) 
Also fix toolbar toggling with AllowAuto which was broken since
a long time.
 2020-12-17 10:15:18 +01:00
Juergen Spitzmueller
7e11cb2b37 Whitespace 2020-12-17 10:10:56 +01:00
Kornel Benko
b3d4271e78 Adv-Find: Try to use some more unicode chars (instead of latex macros) 2020-12-15 18:08:02 +01:00
Jean-Marc Lasgouttes
3950f05497 Take label width into account for SubLabel insets 
The drawing of the label should not go further than inset width.

Fixes bug #12046.
 2020-12-15 15:25:07 +01:00
Jean-Marc Lasgouttes
209a3ce618 Dialog.h and DialogFactory.h are not moc-able 2020-12-15 11:53:06 +01:00
Juergen Spitzmueller
9bf3a5a778 Add some documentation 2020-12-15 09:52:52 +01:00
Juergen Spitzmueller
1a0b842e66 Do not close spellchecker after "Replace All" (#11310) 
Wrong use of wrapAround here
 2020-12-15 09:46:32 +01:00
Juergen Spitzmueller
34c166f45f One more nullptr 2020-12-15 08:53:41 +01:00
Juergen Spitzmueller
ece5b8818d More readable latex color (on button and workarea) in dark mode 2020-12-15 08:53:06 +01:00
Juergen Spitzmueller
47de618de8 Fix nullptr warning 2020-12-15 08:36:17 +01:00
Richard Kimberly Heck
5e6c5f407a Fix thinko 2020-12-14 23:40:28 -05:00
Kornel Benko
d384136ff9 Find-Adv: A try to handle cyrillic chars also in regexp-mode 2020-12-14 20:43:39 +01:00
Juergen Spitzmueller
2d553ec5b9 Amend 24b71d30d5 (#12048) 2020-12-14 14:19:08 +01:00
Pavel Sanda
2db26ff522 Compile on older gcc. 2020-12-14 00:01:05 +01:00
Yuriy Skalko
bda4570400 Use new signal library nod instead of boost::signals2 
Thanks Enrico for updating autotools files.
 2020-12-13 23:11:19 +02:00
Juergen Spitzmueller
148748b0c2 Make InsetInfo math/IPA icons visible in dark mode 
This does not show the real colors, but the icons are at least readable.
 2020-12-13 09:51:32 +01:00
Juergen Spitzmueller
e6e30caca5 Do not forceLTR in InsetHyperlink (#12044) 
This can also be RTL text
 2020-12-13 05:54:48 +01:00
Juergen Spitzmueller
39a28b4b27 Whitespace 2020-12-13 05:08:11 +01:00
Juergen Spitzmueller
33fb7ed258 Ditch deprecation warning 2020-12-12 14:16:34 +01:00
Juergen Spitzmueller
882f06121b Use semantic latex and math colors for dark theme icon overlay 2020-12-12 10:56:51 +01:00
Juergen Spitzmueller
704331fdcd Add dark theme colors to semantic colors (#8325) 2020-12-12 10:56:05 +01:00
Stephan Witt
7b41faabae amend 99b1488f0e - on Mac the include is needed 2020-12-11 18:42:04 +01:00
Juergen Spitzmueller
91026711ae Introduce semantic label colors 
This allows customization e.g. in dark mode and is a prerequisite
for color theming

Part of #8325
 2020-12-11 11:44:45 +01:00
Juergen Spitzmueller
a06cdfa073 Adapt math and IPA panels to dark theme (#5636) 2020-12-11 09:08:41 +01:00
Juergen Spitzmueller
b2ab394832 Remove unused function 2020-12-11 09:08:10 +01:00
Yuriy Skalko
9348c5c635 Use to_string instead of boost::lexical_cast 2020-12-10 20:14:40 +02:00
Yuriy Skalko
5999dd96e6 Remove unnecessary c_str 2020-12-10 20:14:31 +02:00
Jean-Marc Lasgouttes
69c46c56fe Preserve paragraph depth when dissolving. 
It turns out that makeSameLayout() does more than we want.

Fixes bug #11981.
 2020-12-10 18:34:07 +01:00
Kornel Benko
2d2e2f1c6d Adv-Search: Use some free unicodes as replacement for searched spaces 
Without this, it is difficult to find backslashed macros if in regexp-mode.
 2020-12-10 11:36:09 +01:00
Juergen Spitzmueller
f9b817676a Search ipa image dir befor top dir 
Else the unknown icon is found before the proper icon.

This unbreaks IPA panel top icons
 2020-12-10 07:08:04 +01:00
Jean-Marc Lasgouttes
d9c39232ac Reduce the amount of needed boost headers 
boost/signals2.hpp is a convenience header, it seems that
boost/signals2/signal.hpp is enough for our needs.

This allows to get rid of 6MiB of header files in 3rdparty/boost (and
probably to speed-up compilation).
 2020-12-09 14:50:18 +01:00
Jean-Marc Lasgouttes
99fb1c7003 Overhaul (no)limits support 
- Add limits support to InsetMathScript
- Add limits support to InsetMathClass
- Fix bug where limits changing is disabled in inline math

Now the MathData objects remember whether they are in diaply mode.

Fixes bug #12045.
 2020-12-09 14:10:17 +01:00
Pavel Sanda
a222a2eab6 Hint message when .lyx dir can not be created. 
Useful for scripts running without standard homedir environments,
cf https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=816173
 2020-12-08 09:53:38 +01:00
Jean-Marc Lasgouttes
1dcb08104c Make spellchecker work in read-only document 
Mistakes are visible but word replacement is disabled. Disable relevant
widgets depending on the situation.

Move updateView code to SpellcheckerWidget::Private.
 2020-12-07 18:33:45 +01:00
Yuriy Skalko
ccbfd22f56 Move implementation details to constructors. Amend 78f457796c 2020-12-06 20:51:11 +02:00
Pavel Sanda
2f3d0653b3 Fix compilation 2020-12-06 18:37:38 +01:00
Yuriy Skalko
3e7ccc367a Use range-based for loops 2020-12-06 18:26:56 +02:00
Yuriy Skalko
e292dd70bf More enums & includes refactoring 2020-12-06 18:26:41 +02:00
Juergen Spitzmueller
b57b4a3e12 Clarify documentation if "Keep change markup on paste" pref 2020-12-06 17:04:17 +01:00
Richard Kimberly Heck
842fd8a74d Use LOCK in all cases 2020-12-06 10:57:20 -05:00
Yuriy Skalko
78f457796c Implement proper Dialog factory instead of implicit link-time dependencies 2020-12-06 17:37:39 +02:00
Juergen Spitzmueller
22193601bf Always mark pasted stuff as changed with ct on 
independent of "Keep change tracking markup on copy and paste" pref.

Probably addresses #11973
 2020-12-06 10:00:47 +01:00
Richard Kimberly Heck
c978137f99 Disable Edit Externally for read-only Buffers. 2020-12-06 00:14:23 -05:00
Richard Kimberly Heck
16834a32ad Use LOCK symbol with Minimalistic decoration, too. 
In that case, we force a button with just the lock.
 2020-12-05 21:25:05 -05:00
Richard Kimberly Heck
877a46f7b0 Use a lock symbol to indicate when an inset is being edited externally. 
Good idea from Scott.
 2020-12-05 21:16:17 -05:00
Richard Kimberly Heck
ad887798c9 Renaming 2020-12-05 20:30:45 -05:00
Richard Kimberly Heck
742348262e Fix bug #12033. 
Silly mistake: Only considered the parent, not grandparents, etc.
 2020-12-05 20:30:45 -05:00
Richard Kimberly Heck
41216228c0 Change name in source files 2020-12-05 17:17:02 -05:00
Thibaut Cuvelier
0c5e10f36b This should fix a few type-conversion warnings. 2020-12-05 22:52:41 +01:00
Richard Kimberly Heck
d31891c6bf Use LaTeXName of counter in LaTeX output. 
Fixes an oversight noticed by Scott.
 2020-12-05 16:46:33 -05:00
Richard Kimberly Heck
ae2ce7a86a LaTeXName tag for counters. Layout format change. 2020-12-05 16:46:33 -05:00
Jean-Marc Lasgouttes
4f8cfca117 Update handling of read-only for Thesaurus 
Remove dummy calls to ButtonController::addReadOnly().

Properly disable stuff for read-only documents.

Streamline code.
 2020-12-05 20:27:46 +01:00
Jean-Marc Lasgouttes
f02311241a Make Merge Changes dialog work in read only. 
Make LFUN_CHANGES_MERGE active in read-only documents.

Remove dummy call to ButtonController::addReadonly and replace with
proper code.
 2020-12-05 19:53:30 +01:00
Jean-Marc Lasgouttes
e561358be9 Move stuff 2020-12-05 19:45:09 +01:00
Pavel Sanda
b670990bc1 Improve VCS error message when RCS is not installed. 
User's report that it takes time to realize what package
is 'ci' part of, so we can give a hint for the initial
file registration.
 2020-12-04 18:16:44 +01:00
Jean-Marc Lasgouttes
c30b0aac4b Disable some Adv F&R widgets for read-only documents 2020-12-03 18:04:23 +01:00
Jean-Marc Lasgouttes
24b71d30d5 Fix disabling of widgets for (simple) Search dialog 
This allows to remove the calls to ButtonController::addReadonly,
which are placebo since 78ade7e6.
 2020-12-03 15:44:55 +01:00
Juergen Spitzmueller
e3f7f18440 amend a204dbe934 2020-12-03 14:51:05 +01:00
Juergen Spitzmueller
a04d30a650 tex2lyx: prevent \; \: and \! to be converted in tipa and algorithm 
These commands have special meanings there.
 2020-12-03 14:49:01 +01:00
Juergen Spitzmueller
a204dbe934 Escape backslash in comments 2020-12-03 14:47:34 +01:00
Juergen Spitzmueller
c93d5d76fa tex2lyx: support all space type in texted 2020-12-03 11:12:55 +01:00
Juergen Spitzmueller
de2be5bdaa Recent LaTeX includes all math and text spaces 
amsmath no longer required here.
 2020-12-03 10:49:18 +01:00
Juergen Spitzmueller
7b6bb23b87 Move dummy bool a bit closer to context 2020-12-03 08:50:43 +01:00
Juergen Spitzmueller
4a13a29042 Add empty line after last \bibitem in bibliography (#12041) 2020-12-03 07:46:39 +01:00
Yuriy Skalko
9cb98136ce Cleanup headers 2020-12-03 00:38:27 +02:00
Yuriy Skalko
efaffb897d Simplify InsetMathGrid structs 2020-12-03 00:38:18 +02:00
Yuriy Skalko
1dd676bed1 Simplify FuncRequest constructors 2020-12-03 00:38:12 +02:00
Yuriy Skalko
e0f553b941 Fix warnings and use range-based loop 2020-12-03 00:38:05 +02:00
Juergen Spitzmueller
0424f297b8 Update tex2lyx tests 2020-12-02 17:01:21 +01:00
Juergen Spitzmueller
e9cbd69f6e Implement Hungarian quotation marks style (#12040) 
File format change
 2020-12-02 17:00:40 +01:00
Juergen Spitzmueller
b2ca2d1e3a Fix listpreamble breakage by 6f643e52d4 2020-12-02 15:25:14 +01:00
Juergen Spitzmueller
fedd9bf4d0 Do not reset font in preview inset 2020-12-02 15:03:21 +01:00
Juergen Spitzmueller
560d2df70c Capitalization fixes 2020-12-02 14:52:51 +01:00
Juergen Spitzmueller
098c16f153 Assure \par is output when needed with fontswitch 2020-12-02 14:32:05 +01:00
Juergen Spitzmueller
95fed10131 Exclude insets without output from fontswitch_insets 2020-12-02 14:31:26 +01:00
Jean-Marc Lasgouttes
f41ca959fd Reduce top/bottom margin for Adv F&R workareas 2020-12-01 12:01:20 +01:00
Jean-Marc Lasgouttes
26135330bc Simplify GuiWorkarea::Private constructor 
Also use the newly introduced platformName() for Qt4.
 2020-12-01 11:26:01 +01:00
Yuriy Skalko
c0a5987181 Better naming for enums 2020-12-01 00:46:21 +02:00
Yuriy Skalko
890ca6df7b Refactor KernelDocType enum 2020-12-01 00:46:16 +02:00
Yuriy Skalko
6354ad60b4 Refactor InsetQuotes.h enums 2020-12-01 00:46:09 +02:00
Yuriy Skalko
66403b4449 Remove useless breaks 2020-12-01 00:46:02 +02:00
Pavel Sanda
2ab39fe121 Fix compilation on older gccs. 2020-11-30 12:21:56 +01:00
Yuriy Skalko
ec5c7b905b Move Inset.h include from .h to .cpp 2020-11-30 13:05:08 +02:00
Yuriy Skalko
ecf62a8f21 Refactor OutputParams 
Now all Inset hierarchy uses OutputParams.h included in Inset.h.
Forward declare some enums to reduce header dependencies.
 2020-11-30 13:05:03 +02:00
Yuriy Skalko
19f5aa58aa Simplify DocIterator 2020-11-30 13:04:58 +02:00
Yuriy Skalko
99b1488f0e Cleanup included headers 2020-11-30 13:04:54 +02:00
Enrico Forestieri
0d204c4e87 Fix compilation on cygwin 2020-11-30 11:32:35 +01:00
Kornel Benko
a171c651a6 Revert "Amend 3093789e for cmake build" 
This reverts commit b3d43404f4.
 2020-11-30 10:19:22 +01:00
Yuriy Skalko
89d05890bf Simplify KeyModifier 2020-11-30 10:44:28 +02:00
Thibaut Cuvelier
877806f208 DocBook: implement SciPoster. 2020-11-29 22:54:03 +01:00
Thibaut Cuvelier
59acb375d1 DocBook: add layout parameters to control the special case and argument positioning. 
Only for flex insets.

Also add similar checks in InsetText to avoid bibliographies in paragraphs.
 2020-11-29 22:54:03 +01:00
Thibaut Cuvelier
a8de4d3296 DocBook: clean the special-case code. 2020-11-29 22:54:02 +01:00
Yuriy Skalko
7779316e6c Include standard <regex> 2020-11-29 15:27:28 +02:00
Kornel Benko
b3d43404f4 Amend 3093789e for cmake build 2020-11-29 10:04:54 +01:00
Yuriy Skalko
075ae38ec9 Use correct std header 2020-11-29 10:49:59 +02:00
Yuriy Skalko
00d07d6732 Remove unused Counters::copy 2020-11-29 00:25:27 +02:00
Yuriy Skalko
9b0cd3c970 Fix buffer over-read on last Unicode code points 2020-11-29 00:25:24 +02:00
Yuriy Skalko
ad7c5568cd Make InsetIterator compatible with range-based loops 2020-11-29 00:25:19 +02:00
Yuriy Skalko
813eb0f9f7 Cleanup included headers 2020-11-29 00:25:14 +02:00
Yuriy Skalko
e97daf9e13 Use range-based loops 2020-11-29 00:25:09 +02:00
Jean-Marc Lasgouttes
3093789e8d remove most traces of boost::regex 
1/ remove boost regex code from 3rdparty/boost. Only the cmake stuff remains.

2/ remove traces of BOOST_LIB since there is no need anymore to
   compile boost stuff.

3/ remove traces of boost regexp in config/lyxinclude.m4 and INSTALL

4/ require gcc 4.9 as minimal version in autoconf.

Unfortunately, the net gain is only 10% of included boost size (now 21M).
 2020-11-28 19:59:17 +01:00
Thibaut Cuvelier
a6cc62f6ee DocBook: ignore fonts in ERT. 
Also, mark a Slides test as passing, because it is valid DocBook (but not really useful).
 2020-11-28 05:15:34 +01:00
Thibaut Cuvelier
633a617841 DocBook: implement Copernicus. 
Includes a fix when wrappers are used with empty paragraphs. The logic is probably wrong if two legit wrapped paragraphs have one empty paragraph in the middle. This is only for slightly convoluted cases... Wrapping decisions should rather be taken for a series of paragraphs at once, but it would be more complex to implement and would only solve very peculiar cases like these ones.
 2020-11-28 04:56:19 +01:00
Thibaut Cuvelier
14cfcf00cb DocBook: implement AEA and APA. 2020-11-28 00:51:35 +01:00
Thibaut Cuvelier
7437a6ce3c DocBook: fix regression in floats. 
Also implement a valid filler for tables.
 2020-11-27 23:44:48 +01:00
Thibaut Cuvelier
dfb1ad85fa amend bd9dce3749 
Fix warning, add a comment while I'm there
 2020-11-27 17:59:35 +01:00
Yuriy Skalko
f3ec89cfa1 Always use std::regex 
Since now minimum supported GCC is 4.9.
 2020-11-27 12:39:59 +02:00
Yuriy Skalko
fdefff1108 Fix signed integer overflow on x = 0, detected by GCC sanitizer 2020-11-27 12:17:22 +02:00
Yuriy Skalko
8793c2eed9 Replace ;; 2020-11-27 12:16:54 +02:00
Yuriy Skalko
59e2becdd8 Use iround function, amend c0ce79452f 2020-11-27 12:16:50 +02:00
Yuriy Skalko
8cb728c2d7 Constify 2020-11-27 12:16:45 +02:00
Yuriy Skalko
816512879d Use to_string function 2020-11-27 12:16:41 +02:00
Yuriy Skalko
6a21ec854b Move several common types to support/types.h 2020-11-27 12:16:22 +02:00
Jean-Marc Lasgouttes
4b15d64f51 Remove deprecated enum value with Qt5 2020-11-27 10:23:49 +01:00
Thibaut Cuvelier
bd9dce3749 DocBook: bug fixes for JASA. 
Includes more consistent behaviour for bibliographies in appendix (do the same as LyX shows the user, i.e. bibliography in appendix).
 2020-11-27 05:53:46 +01:00
Thibaut Cuvelier
3f07ae9083 DocBook: for empty figures, output a message. 
This ensures that this part of the DocBook file is valid.
 2020-11-27 05:19:27 +01:00
Thibaut Cuvelier
6201158e5d DocBook: fix appendices. 2020-11-27 02:50:03 +01:00
Thibaut Cuvelier
587f1f5571 DocBook: implement Mathematical Monthly. 2020-11-27 01:54:00 +01:00
Thibaut Cuvelier
46d90b3415 amend dae0640436 
Fix a warning in the code.
 2020-11-26 23:33:03 +01:00
Scott Kostyshak
9649e80c44 Fix Clang warning about struct/class mismatch 
CaretGeometry is defined as a struct, but was forward-declared as a
class. Now we forward-declare as a struct. This addresses the
following Clang warning (that does not appear with GCC):

src/frontends/CaretGeometry.h:27:1: warning: 'CaretGeometry' defined
as a struct here but previously declared as a class; this is valid,
but may result in linker errors under the Microsoft C++ ABI
[-Wmismatched-tags]
 2020-11-26 13:51:12 -05:00
Jean-Marc Lasgouttes
c68be9a9be Improve some debug messages 
The current code did not give much information.

I am not sure why the <<FontInfo operator is not defined in
FontInfo.h, but I figured that it was not necessary to understand that
now.
 2020-11-26 11:09:17 +01:00
Thibaut Cuvelier
eaf9460909 DocBook: make empty bibliographies empty. 
Even though this means that there is no output tag.
 2020-11-26 06:55:49 +01:00
Thibaut Cuvelier
ed6fbdd249 DocBook: implement Kluwer. 
Includes an assertion fix that only occurred with this example.
 2020-11-26 06:41:13 +01:00
Thibaut Cuvelier
dae0640436 DocBook: implement REVTeX. 
Improvements to abstract detection: it can now contain lists or anything with a higher depth.

Implement video floats.
 2020-11-26 06:22:27 +01:00
Yuriy Skalko
11434df35d Fix warnings regarding switches on enum values 2020-11-25 23:16:56 +02:00
Yuriy Skalko
0a8d3c9887 Fix loop variable, amend d8e8a93a58 2020-11-25 23:16:51 +02:00
Yuriy Skalko
43477730a4 Better PNG detection in guessFormatFromContents 2020-11-25 23:16:45 +02:00
Scott Kostyshak
c81bb47e49 Catch exception if LaTeX fails for child preview 
The exception is raised when an included file fails to export
because e.g. it is from a newer version of LyX or because an
intermediate command such as knitr fails.

The exception was introduced at 1a374a93 so that the export of a
document exits with error if an included document exports with
error.

This commit catches the exception when the LaTeX is asked for in
order to generate a preview of the included file.
 2020-11-25 15:34:58 -05:00
Yuriy Skalko
8e60182f58 Simplify InsetQuotes constructors 2020-11-25 02:43:43 +02:00
Yuriy Skalko
fe0ea7bff7 Add default TransformID enum value 2020-11-25 02:43:35 +02:00
Yuriy Skalko
b3be47765b Fix memory leak 2020-11-25 02:43:26 +02:00
Yuriy Skalko
43b16548b4 Cleanup headers 2020-11-25 02:43:16 +02:00
Richard Kimberly Heck
2ae77d5091 Only set buffer if it is not null. 
Yuriy found these specific problems. They do not cause a crash, but
they are not good.
 2020-11-24 17:07:16 -05:00
Richard Kimberly Heck
5691b89858 nullptr 2020-11-24 17:07:16 -05:00
Jean-Marc Lasgouttes
8673c5ac28 Forgot this. 2020-11-24 21:20:25 +01:00
Jean-Marc Lasgouttes
1b3ffa6627 Rewrite (again!) the code for caret drawing 
The caret geometry is now computed in BufferView as a list of shapes
(caret, horizontal l-shape if needed, completion triangle if needed)
kept in a variable of type CaretGeometry.

The code in WorkArea.cpp only has to draw these shapes. The
CaretWidget (which never was a widget) in GuiWorkArea.cpp is gone
now.

As a consequence, the bounding box for the cursor is known precisely
and therefore rows should be repainted correctly now. This avoids
caret droppings.

Fixes bug #12024.
 2020-11-24 20:12:42 +01:00
Juergen Spitzmueller
4487af367c Do not \cprotect \textcolor 
Fixes #12034
 2020-11-24 15:19:56 +01:00
Kornel Benko
be50eb507f Adv-Find: Add handling for \cdot (at least if using format-search 2020-11-23 21:55:13 +01:00
Jean-Marc Lasgouttes
7a28258d32 (almost) Proper fix for caret droppings 
Try to find the most inner row that is overwritten by the caret. This
allows to replace the hack in TextMetrics::draw, which did not really
work.

Note that there are still issues with emphasized caret at the
beginning of inset, which will require some code reorganisation.

Fixes current recipe of bug #12024.
 2020-11-21 20:00:26 +01:00
Jean-Marc Lasgouttes
d53b44273c Compilation fix 2020-11-21 19:54:43 +01:00
Jean-Marc Lasgouttes
ba8ca0e384 Correct caret position from the start 2020-11-21 19:39:48 +01:00
Yuriy Skalko
8dfe07b5b5 Use std::any when compiler supports C++17 or later 2020-11-21 20:32:51 +02:00
Yuriy Skalko
cbad214cdd Refactor checksum calculation 2020-11-21 20:32:43 +02:00
Yuriy Skalko
0b1e0b8610 Remove unused headers 2020-11-21 20:32:30 +02:00
Yuriy Skalko
7ca2f2b58d Use range-based loops 2020-11-21 20:32:16 +02:00
Jean-Marc Lasgouttes
2d27d033a6 Typo and reformatting 2020-11-21 19:13:29 +01:00
Pavel Sanda
4eb791ff18 Erase white frame in fullscreen mode. 
Since Qt 5.9.4 one can't set negative margins unless explicitely
allowed by a new flag. This brought back the white frame in
fullscreen mode.

https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg214002.html
 2020-11-21 16:02:54 +01:00
Yuriy Skalko
916ceeba12 Simplify Length 2020-11-21 00:32:47 +02:00
Yuriy Skalko
2941bc0198 Add more override specifiers 2020-11-21 00:32:40 +02:00
Yuriy Skalko
09eba40418 Remove unused header 2020-11-21 00:32:35 +02:00
Thibaut Cuvelier
2bbfc726c4 amend 2c6537ff for C++11 compatibility 2020-11-20 21:59:22 +01:00
Thibaut Cuvelier
1176fab1d4 DocBook: make InsetText respect tag types. 2020-11-20 18:41:03 +01:00
Thibaut Cuvelier
3a02251bfa XML: move higher-level tag-opening and closing functions to xml namespace. 2020-11-20 18:41:03 +01:00
Thibaut Cuvelier
0fe3d05344 XML: add tag-type information in XML tags. It is not yet used. 2020-11-20 18:41:03 +01:00
Thibaut Cuvelier
f426e458c4 DocBook: InsetText supports items and wrappers. 2020-11-20 18:41:02 +01:00
Thibaut Cuvelier
2c6537ff66 DocBook: ensure that <info>-related insets in the abstract are not generated in the abstract. 
This helps generate more conformant DocBook files.

Also implement wrapper tags for InsetText.
 2020-11-20 18:41:02 +01:00
Kornel Benko
5474c3fb4b Missing '{' 2020-11-20 16:32:51 +01:00
Jean-Marc Lasgouttes
d8e8a93a58 Use range-based loops in GuiView 2020-11-20 15:14:21 +01:00
Yuriy Skalko
b56a64a8ef Typo 2020-11-20 15:57:34 +02:00
Yuriy Skalko
f953d88c88 Simplify constructors 2020-11-20 15:57:26 +02:00
Jean-Marc Lasgouttes
a877cdb196 Do not set language from keyboard in passthru setting 2020-11-20 13:49:26 +01:00
Jean-Marc Lasgouttes
875b1def4f Take right margin into account for text inset width 
This is particularly important for contents in RtL languages, where
the right margin may contain the paragraph indentation, or
itemize/enumeration symbols.

Fixes bug #12030.
 2020-11-17 17:51:43 +01:00
Thibaut Cuvelier
c6fe1fbe5f DocBook: implement svglobal. 2020-11-16 20:15:34 +01:00
Yuriy Skalko
888ff9c114 Amend 9b1dc338b2. Fix compilation in GCC 4.9 2020-11-15 22:41:38 +02:00
Thibaut Cuvelier
dc94abf039 DocBook: specific fix for Localization_Test.lyx. 
In one paragraph, there was both a float and a list of floats in a paragraph: the list of floats has no DocBook output, so that there should be no surrounding <para>.
 2020-11-15 19:04:21 +01:00
Thibaut Cuvelier
0ed820fa0b DocBook: fix for nomenclature xml:id and glossary paragraphs. 
Previously, the xml:id's were not consistent among <glossterm> in the text and <glossentry> in the glossary.
 2020-11-15 18:43:58 +01:00
Sam Crawley
f457a32a13 Fix issue in running compare from the command line 
Because Compare uses threads, we need to make sure it is finished when a
compare is executed from the command line. This was a problem for command
sequences, because the next command would start running before the compare
was done, and the buffer with differences was available.

So this commit adds the "run-blocking" parameter when using
LFUN_DIALOG_SHOW to run a Compare. When calling Compare with run-sync, the
LFUN will wait for the compare worker thread to finish before returning and
possibly running the next command.
 2020-11-15 10:35:28 +01:00
Thibaut Cuvelier
46cbd6d234 DocBook: refactor code about retrieving captions and labels. 
There was already an existing method in InsetCaptionable for captions, but not yet for labels. It was at least already useful at two places, that's why I moved it to InsetCaptionable.
 2020-11-15 04:03:04 +01:00
Thibaut Cuvelier
c4bbff8ecb DocBook: fix handling of listings with titles. 
Also implement a code path for inline listings.
 2020-11-15 04:03:04 +01:00
Thibaut Cuvelier
46daa3865b DocBook: missing support for customisation of layouts in inset arguments. 2020-11-15 04:03:04 +01:00
Thibaut Cuvelier
6bc04367cf DocBook: add support for IGNORE tags. 
These paragraphs will simply have no output (no enclosing DocBook tag, no content). This change is as backward-compatible as possible: without this commit, the paragraphs will be output, but in an <IGNORE> tag (not much more can be achieved without this). It is mostly made for metadata and formatting instructions. (As opposed to NONE, which corresponds to outputting the paragraph without enclosing DocBook tag.)
 2020-11-15 04:03:04 +01:00
Jean-Marc Lasgouttes
222a317dd2 Store correctly the window position with Wayland 
To do this, hard-coded test for xcb had to be replaced with a call to
platformName(). Since this method does not exist in Qt4, we emulate
it.

Note that Qt5 uses xcb bindings for X11 system, while Qt4 relies on
older X11 bindings. We return platorm == "qt4x11" in this case.

Fixes bug #11746.
 2020-11-14 17:55:59 +01:00
Yuriy Skalko
9b1dc338b2 Simplify Changers 2020-11-12 14:22:00 +02:00
Thibaut Cuvelier
14887dda1c DocBook: implement achemso. 2020-11-12 03:18:03 +01:00
Richard Kimberly Heck
fdd0a6f849 Revert "Improve structure of updateMacros" 
The problem here is that the check against TEXT_CODE only
catches InsetText, and not its subclasses. Same for the check
against MATH_HULL_CODE. So there is reason not to check codes
here.

This reverts commit 5a54ccfa87.
 2020-11-11 11:26:11 -05:00
Jean-Marc Lasgouttes
63300c3ba8 Fixup aeb51be9: set current font correctly when editing inset 
When using InsetText::edit(), invoke Cursor::setCurrentFont (note that
editXY does it already). It is a good idea in general, especially
after commit 411333fa95, which sets languagecorrectly in ERT.

This allows to comment out (again!) the trick added to fix ticket #9042.
 2020-11-10 15:43:48 +01:00
Jean-Marc Lasgouttes
411333fa95 Make sure that Cursor::setCurrentFont sets LaTeX language in ERT&friends 
Fix issue when language is set to document language instead of
latex_language in ERT and pass thru layouts.

To trigger the issue
1/ select all in a ERT inset
2/ type "abc"
3/ look at code in code preview pane

==> result: the "a" is in document language, the "bc" in LaTeX language
(as should be)
 2020-11-10 14:09:31 +01:00
Yuriy Skalko
437fef65aa Simplify operator== for ParConstIterator 
Comment out it while it is unused.
 2020-11-08 23:29:20 +02:00
Yuriy Skalko
589e780e15 Whitespace & renaming 2020-11-06 21:34:02 +02:00
Yuriy Skalko
01e673635b MacroData refactoring 2020-11-06 21:33:56 +02:00
Yuriy Skalko
5a54ccfa87 Improve structure of updateMacros 2020-11-06 21:33:41 +02:00
Richard Kimberly Heck
97ecf71016 Remove dead comment 2020-11-06 11:30:07 -05:00
Richard Kimberly Heck
5bd498c56d Move trivial constructors into header. Remove unimplemented one. 2020-11-06 11:30:07 -05:00
Thibaut Cuvelier
1766bff806 DocBook: remove special options from InsetGraphics.cpp 
This was not really a useful attribute for DocBook, or it must be parsed beforehand.
 2020-11-05 05:35:34 +01:00
Thibaut Cuvelier
85a8664ba5 MathML: make InsetMathXArrow generate valid XML entities when required. 
Before this, it only supported HTML entities.
 2020-11-05 02:18:47 +01:00
Thibaut Cuvelier
7f8d0fd7b7 DocBook: ensure that tables do not get wrapped in a paragraph. 2020-11-05 02:03:34 +01:00
Thibaut Cuvelier
307aefef89 DocBook: don't consider bridgeheads for abstracts. 2020-11-05 00:02:59 +01:00
Jean-Marc Lasgouttes
4094afaf2e Indentation 2020-11-03 15:12:20 +01:00
Richard Kimberly Heck
060c3de2f0 StepMasterCounter --> StepParentCounter 2020-11-02 17:36:58 -05:00
Richard Kimberly Heck
fba1c434e5 Revert "Fix a number of signedness warnings" 
This reverts commit e8a28c33c5.

I was not aware that we used negative numbers for author IDs!
 2020-11-02 17:09:59 -05:00
Richard Kimberly Heck
39f997048e Remove 'slave' terminology from Counters.cpp. 
And with it, 'master'. That is less problematic by itself (so I'm not
worried about 'master document'), but here it doesn't make a lot of
sense without 'slave'.
 2020-11-02 17:09:59 -05:00
Yuriy Skalko
8a25741ccd Use default member initialization in OutputParams 2020-11-02 20:30:01 +02:00
Richard Kimberly Heck
e8a28c33c5 Fix a number of signedness warnings 2020-11-02 12:03:37 -05:00
Richard Kimberly Heck
cfd19d86be whitespace and style 2020-11-02 11:45:09 -05:00
Richard Kimberly Heck
2945bc356e whitespace 2020-11-02 11:38:52 -05:00
Yuriy Skalko
c7d0ba0f26 Simplify bformat 2020-11-02 11:54:40 +02:00
Thibaut Cuvelier
ebfdac4fa3 DocBook: implement svmult. 
More generally, ensures that paragraphs in abstracts do not have something else configured.

A major problem in making the layout more useful is that article titles are not supposed to be in TOC.
 2020-11-02 04:30:39 +01:00
Richard Kimberly Heck
679ce23ddc Some constness, following Yuriy 2020-11-01 17:37:28 -05:00
Yuriy Skalko
1fdcd7bf14 Constify LaTeXFont 2020-11-01 22:25:08 +02:00
Yuriy Skalko
81a5e7927b Use default member initialization 2020-11-01 22:25:03 +02:00
Yuriy Skalko
6f514da5fd Use bool literals 2020-11-01 22:24:48 +02:00
Yuriy Skalko
9c47e736f8 Constify InsetQuotesParams 2020-11-01 22:24:31 +02:00
Yuriy Skalko
d38eddb397 Match header/source function argument naming 2020-11-01 22:23:44 +02:00
Yuriy Skalko
5061db891c Use const references 2020-11-01 22:23:26 +02:00
Yuriy Skalko
6e65967e15 Use default member initialization in InsetLayout 2020-11-01 22:22:50 +02:00
Yuriy Skalko
dbe35af542 Simplify with std::map::insert 2020-11-01 22:22:27 +02:00
Richard Kimberly Heck
ca3077b40b Change the logic of the indentation setting. 
The option here is to NOT indent the paragraph, so make that clear.
As it was, we would set "Indent" to false in the case of paragraphs
that do not permit indentation and then write that, uselessly, to the
LyX file if we wrote any other option (and then keep writing it, even
if other options were removed). Now, we will write it only if it's been
explicitly set.
 2020-10-30 13:34:36 -04:00
Richard Kimberly Heck
3b4b047576 Fix warning 2020-10-30 13:26:48 -04:00
Thibaut Cuvelier
df0ea858ed DocBook: use the same normalisation for biblio IDs and their references. 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
da6e999fc6 DocBook: more robust list implementation. 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
6843bc5a38 DocBook: ensure to have paragraphs in <sidebar>. 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
30572880ba DocBook: fix an issue where parts of list in abstract were duplicated. 
Excerpt from export/latex/lyxbugs-resolved/9633-languagenesting_enumerate_and_lyxcode.
 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
661c5d256b DocBook: support for <info> tags in inner sections. 
Previously, this code only worked correctly for the root tag.
 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
4405f0164a DocBook: implement algorithm floats. 
Now that https://github.com/docbook/docbook/pull/185 has been merged into DocBook 5.2.
 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
f2b7f8a089 DocBook: generate chapter metadata in <info>, for Springer mono. 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
b816cb0f3c DocBook: don't consider sectioning items that shouldn't be in TOC for anything section-related. 2020-10-30 01:59:34 +01:00
Thibaut Cuvelier
149e1ccc02 DocBook: add DocBookSection parameter for styles that define new sections and implement argument parameters; improve Springer support. 
For elements that should behave like sections (for now, mostly prefaces).

A second paragraph of PartBacktext can only wreak havok: it should start a section, and nothing else (otherwise, it's a real nightmare to implement).
 2020-10-30 01:59:34 +01:00
Richard Kimberly Heck
cc1d3b78c9 Const 2020-10-29 18:25:33 -04:00
Yuriy Skalko
b8737e898c Simplify DispatchResult ctors 2020-10-29 15:52:38 +02:00
Yuriy Skalko
d8ead7debf Use nullptr 2020-10-29 15:52:33 +02:00
Yuriy Skalko
524073d09f Move HullType functions declared in InsetMath.h into InsetMath.cpp 2020-10-29 15:52:28 +02:00
Yuriy Skalko
f1926251c0 Move Windows-specific stuff into os_win32.h 2020-10-25 19:59:03 +02:00
Yuriy Skalko
10272e4747 Move include of own header to the top. Fix dependencies 2020-10-25 19:58:57 +02:00
Yuriy Skalko
4ece87c324 Fix obsoleted Qt values 
All new values exist in Qt 4.8.7.
 2020-10-25 09:28:46 +02:00
Yuriy Skalko
1b508fff03 Small refactorings 2020-10-25 09:28:41 +02:00
Yuriy Skalko
a7018252b7 Constify 2020-10-25 09:28:34 +02:00
Jean-Marc Lasgouttes
21422dd652 Replace QFontMetrics::width() by horizontalAdvance() in Qt>=5.11 
The method horizontalAdvance() replaces width() starting with Qt 5.11.
To handle this, all direct calls to QFontMetrics::width() are replaced
by calls to GuiFontMetrics::width(), and the code for
GuiFontMetrics::width(QChar) uses horizontalAdvance on newer Qt
versions.
 2020-10-24 19:52:18 +02:00
Yuriy Skalko
69f838bbf3 Fix isSpace for docstring 2020-10-24 18:55:05 +03:00
Pavel Sanda
8af747c9d9 Revert da8b5de97 because of MSVC 2017. 
In GCC `min` is defined via including <vector>.
 2020-10-24 12:06:54 +02:00
Enrico Forestieri
d2d33a6a1f Fix compilation on cygwin 2020-10-23 15:00:23 +02:00
Yuriy Skalko
c928714b0b Unify naming of menu items 2020-10-23 10:23:01 +03:00
Jean-Marc Lasgouttes
2395522aa7 Revert "Do not set language from keyboard in passthru setting" 
This reverts commit d94bd07264.
 2020-10-21 18:50:31 +02:00
Jean-Marc Lasgouttes
526b4b0d79 Revert "Fix compilation mess in d94bd0726" 
This reverts commit abaf2e9bda.
 2020-10-21 18:50:10 +02:00
Jean-Marc Lasgouttes
abaf2e9bda Fix compilation mess in d94bd0726 2020-10-21 18:37:22 +02:00
Jean-Marc Lasgouttes
d94bd07264 Do not set language from keyboard in passthru setting 2020-10-21 18:09:31 +02:00
Pavel Sanda
5d0b1b640b Make master compilable again with older gcc. 2020-10-21 00:01:03 +02:00
Yuriy Skalko
196d9caeb0 Clean includes using the output of iwyu tool 2020-10-20 11:38:55 +03:00
Thibaut Cuvelier
d1b9af3b1d DocBook: fix file inclusion. 
Previously, nothing was output. Special care was needed for when new paragraphs should be open (this work is probably not finished yet).
 2020-10-20 02:34:02 +02:00
Yuriy Skalko
af29f02dd8 Reduce includes in header files (2) 2020-10-19 18:01:17 +03:00
Yuriy Skalko
d25c10ed81 Remove duplicate and unused header includes in .cpp files 2020-10-19 18:01:11 +03:00
Yuriy Skalko
fa6ac23e1c Reduce includes in header files 2020-10-19 17:33:51 +03:00
Yuriy Skalko
65c88f0a0a Remove redundant const & for primitive types 2020-10-19 12:50:07 +03:00
Thibaut Cuvelier
7be7026386 DocBook: generalise detection of "special cases" to check all insets of a paragraph. 
This will catch cases where there are multiple listings in a single paragraph, for instance.

The new code is also less brittle (checks on lyxCode instead of generated LaTeX or names).
 2020-10-18 08:23:37 +02:00
Thibaut Cuvelier
739735ab73 DocBook: output inline equations in their own paragraph if they are the only inset of the paragraph. 
It's invalid to have an <inlineequation> outside a paragraph. Another solution would have been to change InsetMathHull::docbook to generate an <informalequation>, but that function would have required more knowledge about its context than now.

Need more tests to determine if <inlineequation> should only be output for hullSimple or in more cases like:

		const static std::set<HullType> inlineHulls = {
				hullUnknown,
				hullNone,
				hullSimple,
				hullEquation,
				hullMultline,
				hullGather,
				hullRegexp
		};
 2020-10-18 08:23:36 +02:00
Jean-Marc Lasgouttes
c286cad565 Reset caret size when inserting text over a selection 2020-10-17 20:29:16 +02:00
Scott Kostyshak
1e3ef3c6e2 Update tex2lyx tests after the format change 
The diff consists of only the format number, which is expected since
there is no instance of "\nopagebreak" in the .tex files.
 2020-10-16 23:06:15 -04:00
Yuriy Skalko
b5cb23a92a Remove unused headers in output_xhtml.h 2020-10-16 23:05:54 +03:00
Yuriy Skalko
a3eeb8a4b5 Clean math headers 2020-10-16 23:05:46 +03:00
Thibaut Cuvelier
0ba9b7c0c8 DocBook: fix an assertion/crash. 2020-10-16 17:02:24 +02:00
Yuriy Skalko
84365fc946 Move Author.h, Format.h from BufferParams.h 2020-10-16 08:02:51 +03:00
Yuriy Skalko
4c8d262996 Const refactor 2020-10-16 08:02:51 +03:00
Yuriy Skalko
ce0e192689 Move Cursor.h from TocWidget.h 2020-10-16 08:02:51 +03:00
Yuriy Skalko
fbefdb10a5 Move Cursor.h from Clipboard.h 2020-10-16 08:02:51 +03:00
Yuriy Skalko
7f40bb2b2d Clean output_latex 2020-10-16 08:02:51 +03:00
Yuriy Skalko
65db7b31ad Clean Cursor and CursorSlice 2020-10-16 08:02:51 +03:00
Yuriy Skalko
61bc850c27 Remove CutAndPaste.h from Trans.cpp 2020-10-16 08:02:51 +03:00
Yuriy Skalko
bea9d2f3f7 Clean includes in TextMetrics.cpp 2020-10-16 08:02:51 +03:00
Yuriy Skalko
da56091c2a Clean includes in buffer_funcs.cpp 2020-10-16 08:02:51 +03:00
Thibaut Cuvelier
170866986c Amend 82ea3d6 
Test was done on the wrong data structure: the title is almost the only element ending up in shouldBeInInfo, it is never inmustBeInInfo.
 2020-10-16 04:30:41 +02:00
Yuriy Skalko
36c8e06cf1 Move Dimension.h from InsetIPA.h 2020-10-15 19:26:16 +03:00
Yuriy Skalko
5ac65d1532 Move BufferParams.h from Language.h 2020-10-15 19:25:37 +03:00
Yuriy Skalko
87d19e1068 Remove BufferParams.h from BiblioInfo.h 2020-10-15 19:25:19 +03:00
Daniel Ramoeller
d5fe3337c6 Cleanup CutAndPaste.cpp 2020-10-15 10:24:00 +02:00
Richard Kimberly Heck
1f22a2520a Fix linking problem by adding convert from string to unsigned long long. 2020-10-14 22:28:10 -04:00
Pavel Sanda
c0f9309300 Move <fstream> from support/gzstream.h 2020-10-14 15:12:48 +02:00
Pavel Sanda
644c1d3453 Move docstream.h from output_xhtml.h 2020-10-14 15:06:12 +02:00
Pavel Sanda
560ff6d40d Move MetricsInfo.h from InsetMathSize.h 2020-10-14 14:58:18 +02:00
Pavel Sanda
2b02b73f4a Move <QTimer> from TocWidget.h 2020-10-14 14:48:41 +02:00
Pavel Sanda
bd33601512 Move <QTimer> from GuiViewSource.h 2020-10-14 14:37:38 +02:00
Pavel Sanda
85eec10e4b Move <QKeyEvent> from DockView.h 2020-10-14 14:35:29 +02:00
Pavel Sanda
61824e057e Move GuiView.h from DockView.h 2020-10-14 14:28:47 +02:00
Pavel Sanda
57703d51c6 <QCloseEvent> DialogView.h -> DialogView.cpp 2020-10-14 13:57:30 +02:00
Pavel Sanda
f1b147cc97 include "GuiView.h": DialogView.h -> DialogView.cpp 2020-10-14 13:53:40 +02:00
Pavel Sanda
10fafd3bfe <map> ParagraphMetrics.h -> TextMetrics.h 2020-10-14 13:14:58 +02:00
Pavel Sanda
da8b5de973 Move <algorithm> from DocIterator.h 2020-10-14 13:01:30 +02:00
Richard Kimberly Heck
b7f632ca1c Fix bug #12002. 
Patch from Daniel.
 2020-10-13 19:51:27 -04:00
Richard Kimberly Heck
1ff2de387d Whitespace 2020-10-13 18:26:13 -04:00
Richard Kimberly Heck
28ae543a2a Fix signed-ness warnings 2020-10-13 18:24:03 -04:00
Pavel Sanda
0ea9df7467 Add inset for \nopagebreak. 
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg213388.html
 2020-10-13 19:13:59 +02:00
Jean-Marc Lasgouttes
c516c86d19 Make cursor width depend on current font 
This makes the cursor more visible wrt current font.

Moreover make the cursor width scalable by default.
 2020-10-13 17:27:52 +02:00
Jean-Marc Lasgouttes
310c94c48c Fix display of caret completion indicator 
The zooming algorithm based on caret width was deeply flawed. It is
not replaced with a formula based on caret height.

Fixes bug #12000.
 2020-10-13 17:09:33 +02:00
Yuriy Skalko
2a594d3e90 Remove unused forward declarations 2020-10-13 09:57:36 +03:00
Thibaut Cuvelier
769578eac6 Fix typos in filetools.cpp. 2020-10-13 00:33:05 +02:00
Thibaut Cuvelier
82ea3d67ec DocBook: documents must have a title. 2020-10-12 19:26:37 +02:00
Thibaut Cuvelier
92b9c82dea Fix compilation on Visual C++. 
Without this patch, there would be errors like these (warnings turned into errors):

D:\LyX\lyx-unstable\src\frontends\qt\GuiView.cpp(2413): error C4101: 'e': unreferenced local variable
D:\LyX\lyx-unstable\src\frontends\qt\GuiView.cpp(4879): error C4101: 'ex': unreferenced local variable
 2020-10-12 19:21:58 +02:00
Yuriy Skalko
cb52dd2e42 Add override in VCBackend 2020-10-12 15:14:55 +02:00
Yuriy Skalko
238fd9ac50 Right exception rethrowing 2020-10-12 15:14:55 +02:00
Yuriy Skalko
919a06718a Constify 2020-10-12 15:06:16 +02:00
Richard Kimberly Heck
2dc4277452 Const 2020-10-10 17:12:50 -04:00
Richard Kimberly Heck
b28bd27932 Fix warning 2020-10-10 17:12:50 -04:00
Yuriy Skalko
7d38a4d126 Loop refactoring 2020-10-09 09:04:20 +03:00
Richard Kimberly Heck
b511d8d93e Use 'delete' for unimplemented constructors. 
Thanks Yuriy!
 2020-10-07 11:05:54 -04:00
Thibaut Cuvelier
0bd2978ac9 DocBook: add DocBookInnerTag and family. 
This allows old DocBook documents to be valid when output.
 2020-10-07 06:05:22 +02:00
Thibaut Cuvelier
6a0e93f162 Amend 249d899 
Non-ASCII characters make std::isspace crash, but not lyx::isSpace.
 2020-10-07 04:49:20 +02:00
Richard Kimberly Heck
3d46cc302b Use explicit default syntax (C++11). 
Thanks to Jos'e for noticing this option.
 2020-10-06 20:31:11 -04:00
Richard Kimberly Heck
0f417f2a06 Fix some warnings 2020-10-06 12:27:28 -04:00
Richard Kimberly Heck
bff97ba76d Explicit InsetTableCell copy constructor 2020-10-06 12:20:31 -04:00
Pavel Sanda
ffbcac3dde Add few examples for lineno options. 
It's actually pretty hard to get that from the manual.
 2020-10-06 15:05:11 +02:00
Thibaut Cuvelier
249d899298 DocBook: clean output when fonts span over text that ends with a space 2020-10-05 16:22:58 +02:00
Jean-Marc Lasgouttes
c46f3b8f31 remove unused variable 2020-10-05 15:11:51 +02:00
Yuriy Skalko
c5ae08f0b8 Amend efc0877f 
Add the last `override`s.
 2020-10-05 15:03:13 +02:00
Yuriy Skalko
fe85162a29 Refactoring 2020-10-05 14:55:00 +02:00
Yuriy Skalko
d82adc625b Amend efc0877f 
Add more `override` specifiers. Replace `throw()` to `noexcept`.
 2020-10-05 09:37:15 +02:00
Yuriy Skalko
14b0da28c2 Amend efc0877f 2020-10-03 21:17:17 +02:00
Yuriy Skalko
715b8cda54 Refactoring based on cppcheck suggestions 2020-10-03 13:39:51 +02:00
Kornel Benko
a43d8501a2 Do not use runparams.nice == true while exporting to docbook5 
The setting implies that the variable external_in_tmpdir is set to false.
If a lyx-file includes external material for spreadsheet,
the conversion results are in tmpdir.
The routine doSubstitution() (insets/ExternalSupport.cpp:188) therefore
does nothing for the entry $$Contents because it uses wrong path.
 2020-10-03 13:28:26 +02:00
Yuriy Skalko
efc0877f8f Add override specifiers to improve code maintainability 2020-10-03 12:43:48 +02:00
Juergen Spitzmueller
2330b4ce9c Never mark references in inactive insets broken 
This is the sledgehammer (and the only) way to omit broken refs if the
target is in an (or the same) inactive inset as well.
 2020-10-03 08:54:06 +02:00
Richard Kimberly Heck
2afc68ede2 Whitespace 2020-10-02 13:11:28 -04:00
Jean-Marc Lasgouttes
dd65a97b55 Pass parameters as const references when possible 
Fixes some cppcheck warnings.
 2020-10-02 18:56:01 +02:00
Jean-Marc Lasgouttes
4d9a2c2e59 Fixup f96b99dc: do not initialize cache too late 2020-10-02 12:17:57 +02:00
Jean-Marc Lasgouttes
a97b384b07 Fixup f96b99dc: thinko 
Setting the res value and returning from the function at the same time
does not make sense. After reflection, it is the "return" that shall
go.

No idea what effect it had.
 2020-10-02 12:06:32 +02:00
Juergen Spitzmueller
8b155ce957 Refactoring 2020-10-02 08:30:31 +02:00
Juergen Spitzmueller
720179947e tex2lyx: properly set textclass if no class is given 
(snippets without \documentclass and no forced class)
 2020-10-02 08:17:45 +02:00
Jean-Marc Lasgouttes
e16b9e8d22 Remove non-const version of ParagraphMetrics::getRow 
Constify a bit TextMetrics::isRTLBoundary().
 2020-10-01 14:58:18 +02:00
Jean-Marc Lasgouttes
a2b754b10b Fixup 7d965319: reset cursor font at a finer level 2020-10-01 14:19:09 +02:00
Jean-Marc Lasgouttes
7f1b1729b4 Cleanup the caret geometry code 
Intended changes:

* code is shorter and cleaner

* caret scales better with zoom when cursor_width=0: completion
  indicator, l-shaped cursor...

Details:

* Rename BufferView::getPosAndHeight to getPosAndDim because ascent is
  needed too and width could in the future be set depending on font.

* Get rid of rect_ in CaretWidget and record a Dimension (and y value) instead.
  Remove also caret_width_ and slant_, replace rtl_ with dir.

* Make CaretWidget members public and lose the trailing _.

* change CaretWidget::update to read its parameters from current bufferview.
 2020-10-01 13:17:01 +02:00
Jean-Marc Lasgouttes
7d96531909 Fix bug where cursor size is not reset correctly. 
A couple of calls to setCurrentFont fix the issue, but there has to be
more cases to catch. I am not sure why it used to work.
 2020-10-01 12:44:38 +02:00
Jean-Marc Lasgouttes
f9aadae290 Get rid of helper Text::previousWord(), used only once 2020-09-29 10:15:31 +02:00
Richard Kimberly Heck
a41bcb3701 Error message 2020-09-28 22:45:44 -04:00
Richard Kimberly Heck
003a267764 We really do not want id to change 2020-09-28 22:20:22 -04:00
Richard Kimberly Heck
594401912b Fix minor annoyance with previous commit. 
When validating local layout, in particular, we create a dummy text TextClass
and so are not necessarily modifying previously declared material. Hence, we
get a spurious (but harmless) "Incomplete argument definition!" warning. This
suppresses it, but to do that we need to propogate the ReadType.
 2020-09-28 22:07:08 -04:00
Richard Kimberly Heck
6f643e52d4 Allow argument definitions in layout files to modify existing ones. 
This is what layout re-definitions do in all other cases.
 2020-09-28 22:06:11 -04:00
Richard Kimberly Heck
54a72663ae Move defaults into struct definition 2020-09-28 21:30:40 -04:00
Pavel Sanda
ad475adfd3 amend 6d6fc761be 2020-09-28 16:44:12 +02:00
Pavel Sanda
6d6fc761be Qt4 compilable again 2020-09-28 16:34:42 +02:00
Yuriy Skalko
e47092044b Use real italic slope for slanted caret 2020-09-28 14:30:05 +02:00
Juergen Spitzmueller
b38500353c Amend 448e5efab4 
Only set langClosed to true if it really has been closed.
 2020-09-26 12:12:09 +02:00
Enrico Forestieri
f0807a604c Use correct bounding box when exporting from command line 
Without GUI an image is not available even if it is actually cached.
In this case we load the image for obtaining its dimensions in order
to correct the clipping bounding box.

This amends 380f34a1.
 2020-09-25 20:58:40 +02:00
Enrico Forestieri
a8572c1358 Correct comment 2020-09-25 12:11:10 +02:00
Enrico Forestieri
9b1763cd42 Do not correct clipping bounding box for vector formats 
This amends 380f34a1 that only took into account the postscript format.
 2020-09-25 12:01:57 +02:00
Jean-Marc Lasgouttes
967f4d661e Remove default parameter of UndoGroupHelper constructor 
This can lead to mistakes. If no buffer is required at the beginning,
it is better to pass 'nullptr' explicitly.

Fix a case of missing parameter in GuiCompleter (introduced at
f3656600). This avoids some spurious "There is no group open (creating
one)" messages.
 2020-09-23 17:33:17 +02:00
Jean-Marc Lasgouttes
32b688225d Do not use a fake row to compute completion dimension 
The code in TextMetrics::completionPosAndDim is needlessly complicated.

1/ It is easier to rely directly on Text::getWord() rather than on the
   helper previousWord().

2/ Using a fake row to compute completion height is overkill. A
   simpler solution is proposed here.

No intended effect. These changes prepare the fix to ticket #11818.
 2020-09-22 15:11:08 +02:00
Juergen Spitzmueller
b814c4fda7 Fix unnecessary cprotect 2020-09-20 08:45:42 +02:00
Thibaut Cuvelier
da67bde61a Revert "XHTML: remove DOCTYPE, as the document is then understood as HTML4/XHTML1, and not XHTML5." 
This reverts commit c8e2c17a: this makes some browsers unable to understand basic HTML entities.
 2020-09-20 01:35:14 +02:00
Thibaut Cuvelier
44a7d2bc88 DocBook: adapt code for older GCC. 2020-09-19 23:55:07 +02:00
Thibaut Cuvelier
b5adcec28a XHTML: fix for encodings in attributes (patch by Kornel) 2020-09-19 20:43:42 +02:00
Thibaut Cuvelier
c83fd0eb06 XHTML sections: saner code to close the section. 
It only caused troubles in corner cases...
 2020-09-19 20:43:42 +02:00
Thibaut Cuvelier
a85b4b88ed XHTML sections: only filter out things that are not Sectioning, not based on the level. 2020-09-19 20:43:42 +02:00
Thibaut Cuvelier
0dfa240209 XHTML: restore sections. 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
15dbc2b9ab Revert "XHTML: remove <section> support." 
This reverts commit 52216b73
 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
c8e2c17a58 XHTML: remove DOCTYPE, as the document is then understood as HTML4/XHTML1, and not XHTML5. 2020-09-19 20:43:41 +02:00
Thibaut Cuvelier
92ad86dacc XHTML: remove <section> support. 2020-09-19 20:43:41 +02:00