anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-12-28 06:49:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
46,084 Commits 31 Branches 172 Tags 630 MiB
92209fb6b8
Commit Graph

9975 Commits

Author SHA1 Message Date
Enrico Forestieri
1cbcb30353 Fix assertion when canceling file dialog 
Without this patch, when a file has to be loaded (for example,
after "Document->Settings->Local Class" or "Insert->Graphics")
and the file dialog is canceled, both Qt5 and Qt6 assert:
ASSERT failure in QList::at: "index out of range"
 2023-09-02 18:15:09 +02:00
Jean-Marc Lasgouttes
e651e15a99 Improve caret position when splitting a view 
The old code only worked for toplevel cursors and did not show current cursor.
Note that the two windows do not have exactly the same offset.

Fixes bug #12689.
 2023-09-02 17:21:03 +02:00
Juergen Spitzmueller
aaae3ad5cc Remove redundant code and clarify strings 2023-09-02 14:28:33 +02:00
Juergen Spitzmueller
58e36a27b6 Doc additions by Pavel 2023-08-30 15:40:16 +02:00
Juergen Spitzmueller
4dc9e0c4e6 Improve CITATION_OPEN 
* The lyxpaperview script now only provides the paths and let us do the opening
* We use our own viewers for local files rather than QDesktopServices

Plus several minor improvements and code cleanup
 2023-08-30 15:30:29 +02:00
Juergen Spitzmueller
2195543188 Add message dialog to LFUN_CITATION_OPEN chain 
This addresses security concerns.
 2023-08-29 14:43:59 +02:00
Enrico Forestieri
c088cc4413 Fix detection of xcb during configure 
The QT_FEATURE_xcb macro is not in the private headers anymore.
They keep changing APIs...
 2023-08-28 10:52:08 +02:00
Juergen Spitzmueller
53f4f8c103 Change "library directory" to "system directory" (#12709) 2023-08-26 12:03:20 +02:00
Juergen Spitzmueller
7057a45587 Add accelerator 2023-08-26 11:44:00 +02:00
Richard Kimberly Heck
344dc1f822 Polish formatted reference patch, and add documentation. 2023-08-25 15:24:13 -04:00
Pavel Sanda
2e32e2c123 Revert UI fix for two digit numbers. It actually does not work. 
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg220179.html
 2023-08-25 18:52:27 +02:00
Richard Kimberly Heck
2ad57dcb6b Preview formatted references in the work area. 
Patch from Daniel Ramoeller <d.lyx@web.de>, fixed up by RKH.
 2023-08-24 21:24:31 -04:00
Pavel Sanda
06198fbe18 Alow two digit number of remembered files in ui. 
Reported by Dan.
 2023-08-22 22:02:32 +02:00
Stephan Witt
d409555bda Amend change 5c8e3a5f0d - correct include directives 2023-08-18 12:52:25 +02:00
Juergen Spitzmueller
5c8e3a5f0d Remove Qt < 5.2 conditionals and special code 
We require Qt 5.2 at least for LyX 2.4
 2023-08-18 09:04:12 +02:00
Richard Kimberly Heck
a6b83b7444 Make code a bit easier to read 2023-08-16 18:52:04 -04:00
Richard Kimberly Heck
b828da02f8 Slight rearrangement 2023-08-16 18:38:19 -04:00
Richard Kimberly Heck
62483d102d Whitespace and range 2023-08-16 18:22:11 -04:00
Juergen Spitzmueller
71693280c3 Improve usability of quotation mark selection (#12872) 2023-08-15 20:21:32 +02:00
Pavel Sanda
5936076181 Fix crash when calling dialog-show with bogus names (#12873). 2023-08-14 23:54:47 +02:00
Juergen Spitzmueller
f050fd9626 Fix cursor navigation in error dialog (#12876) 2023-08-14 18:44:10 +02:00
Juergen Spitzmueller
a03c442a62 GuiCitation: consider filter on dialog creation (#12869) 2023-08-11 12:04:26 +02:00
Juergen Spitzmueller
4676a50944 Amend dcde026446 
Add missing options update at dialog contruction
 2023-08-11 11:44:35 +02:00
Udi Fogiel
dcde026446 disable-default-font-options LyX does not output any LaTeX code when adding optinos to the font, so we should disable adding options to fonts in that situation. 2023-08-11 11:21:22 +02:00
Juergen Spitzmueller
f75f73a402 Fix InsertTableWidget interference with tooltip geometry on Qt6 (#12776) 
The current method played badly with Qt6 on wayland
 2023-08-10 16:43:06 +02:00
Scott Kostyshak
cc951cd411 Comments 2023-08-10 06:17:29 -04:00
Daniel Ramoeller
a2310d04f4 Keep cursor position when splitting 
Fix for #12689
 2023-08-10 06:10:08 -04:00
Stephan Witt
d656e01172 #12626 disable Ok button of shortcut editor when LFUN is empty 2023-08-06 00:28:50 +02:00
Stephan Witt
49fe82ec8d #10740 fix focus problems with color picker on Mac 
- closing the color picker focuses the wrong (main) window
- to return focus to correct (parent) window it has to be activated explicitly
 2023-08-05 15:24:33 +02:00
Stephan Witt
65ec100f6a #12576 improved file name chooser implementation for GUI dialogs 
- code reorganization to move the file name chooser methods in GuiDialog class
- on Mac add explicit raise of the current dialog window on close of the file browser to work around the bug 12576
 2023-08-05 08:56:35 +02:00
Stephan Witt
550c79215b #12001 make message boxes modal on Mac 2023-08-02 18:00:02 +02:00
Richard Kimberly Heck
04fc48d790 New RefFormat tag for counters, and PrettyFormat for floats. 
Layout format updated to 104.
 2023-07-28 17:37:13 -04:00
Richard Kimberly Heck
1ea8b272a0 Polish 2023-07-28 17:13:12 -04:00
Richard Kimberly Heck
ae5b4367d1 Fix bug #12235: Select text in search field on opening. 
Patch slightly modified from one by Daniel.
 2023-07-28 12:07:23 -04:00
Richard Kimberly Heck
a13fb42a03 Add FIXME for bug #12828 2023-07-27 18:13:42 -04:00
Richard Kimberly Heck
2224e85030 Make Alt-escape work for search as well 2023-07-26 16:52:30 -04:00
Richard Kimberly Heck
926ae84921 Use Alt-Escape to float and unfloat dock widgets. 
For some reason, redocking is not working for me at all. This
key seems free.
 2023-07-26 14:26:02 -04:00
Alexander Dunlap
c609e9cbcf Display equation/theorem numbers in insert cross reference dialog. 
Fixes bug #11466,
 2023-07-26 13:35:42 -04:00
Juergen Spitzmueller
6d167e94f4 Add accelerators 2023-07-24 10:33:20 +02:00
Juergen Spitzmueller
d212013bd7 Fix casing 2023-07-24 10:26:57 +02:00
Jean-Marc Lasgouttes
c8c589353a Detect when one tries to bind a lfun to a prefix of longer commands 
Change KeyMap::getBinding to return FuncRequest::prefix in this case.

Add handling of this case in PrefShortcuts::validateNewShortcut.

What does not seem to work is that if, for example, accent-acute is
bound to M-s (which is a prefix for size-related bindings), and then
the binding is removed, the functions are not visibly restored.

Part of bug #10131.
 2023-07-22 00:01:34 +02:00
Juergen Spitzmueller
649cb30963 Another tiny correction (not yet ideal) 2023-07-18 18:11:59 +02:00
Juergen Spitzmueller
7640d1fbf5 Remove bogus condition and add comments 2023-07-18 17:55:08 +02:00
Juergen Spitzmueller
eadc8ab147 LaTeXHighlighter: handle grouped values with commas in keyval options 2023-07-18 17:35:48 +02:00
Juergen Spitzmueller
9e308ddb03 Improve keyval highlighter 2023-07-18 17:05:56 +02:00
Juergen Spitzmueller
6603ae2242 Support option snippets in the LaTeXHighlighter 2023-07-18 15:13:48 +02:00
Stephan Witt
c4195defe6 #12818 amend last change b924db72c5 - use c++ 11 compiler compatible code 2023-07-16 17:11:38 +02:00
Stephan Witt
b924db72c5 #12818 correct evaluation of message box result info 
The help page of int QMessageBox::exec() (​https://doc.qt.io/qt-6/qmessagebox.html#exec) says:
When using a QMessageBox with standard buttons, this function returns a StandardButton value indicating the standard button that was clicked.
When using QMessageBox with custom buttons, this function returns an opaque value; use clickedButton() to determine which button was clicked.
 2023-07-16 16:49:02 +02:00
Jean-Marc Lasgouttes
386a2ddca1 Cache the value of FontMetrics::xHeight() 
This value is computed for the metrics of *every* Mathdata and hotspot
says that it counts for 9% of total on math-heavy "branch-test.lyx"
file. I am not sure that real world agrees with that, but profiling
shows that Qt itself does not cache the value.

Part of reinvestigation of #12297.
 2023-07-15 23:32:59 +02:00
Jean-Marc Lasgouttes
a3db9a667f Outline: swap order of up and down arrows 
The order is more natural now.

See discussion in #12809.
 2023-07-06 17:47:08 +02:00
Pavel Sanda
fb43449c80 Hide multi-keystroke accelerators in Mac menu (bug 12693). 
Patch from Juergen.
 2023-07-05 20:45:26 +02:00
Daniel Ramoeller
28a9124241 Fix combined zoom widget on windows (bug #12803). 2023-07-04 19:08:51 +02:00
Pavel Sanda
9d8bef017b Add bug reference. 2023-07-03 23:54:34 +02:00
Juergen Spitzmueller
d5a9699794 Fix inset context menu offset with keyboard (#12811) 2023-07-03 16:28:38 +02:00
Scott Kostyshak
f14384ff91 Add "override" to fix warning 
Otherwise we get the following warning:

src/frontends/qt/InsertTableWidget.h:44:7: error: 'hideEvent' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
        void hideEvent(QHideEvent * event);
             ^

Amends ca5a75b2.
 2023-06-19 14:52:45 -04:00
Daniel Ramoeller
ca5a75b23e Properly uncheck insert table toolbutton 
Fix for bug #12801
 2023-06-18 12:20:35 +02:00
Daniel Ramoeller
c13c959974 Fix margins and spacing of InsetParamsUI 
Fix for bug #12244.
 2023-06-15 04:18:36 -04:00
Daniel Ramoeller
7371a99256 Fix for HiDPI logo in About 
Fix for #12322.
 2023-06-13 09:56:48 -04:00
Pavel Sanda
152811a27d Activate work area by tab click. 
Fix for #11835.
Patch by Daniel Ramoeller.
 2023-06-13 12:11:11 +02:00
Yuriy Skalko
2475a6a616 Move Fullscreen preferences from Editing>Control section into Look & Feel>User Interface section 2023-06-13 11:28:31 +02:00
Pavel Sanda
afb918bf78 Fix for #12681. 
Number Paste Recent menus entries as in toolbar.
Slightly improved patch from Daniel Ramoeller.
 2023-06-13 10:07:56 +02:00
Juergen Spitzmueller
833f8c148e Limit QEvent::ApplicationPaletteChange casing to Mac 
This is not needed on Linux and dramatically slows down runtime mode
change
 2023-06-11 12:43:30 +02:00
Juergen Spitzmueller
3af906e9f3 Fix crash on OS-switch of dark/light mode (#12786) 
At least for Mac and Linux. Windows needs testing and possibly its
own fix.
 2023-06-10 08:30:31 +02:00
Juergen Spitzmueller
92f211d6b4 Replace deprecated function 
activateWindow() is available back to Qt4 (at least)
 2023-05-17 08:56:12 +02:00
Stephan Witt
ac286e54b7 #12769 correct line width based painting of wavy underline 
With very tiny fonts the line width is 0 and the loop to construct the wavy line never ends.
 2023-05-15 07:06:44 +02:00
Juergen Spitzmueller
90d40eb95e Add labels to encoding variant combo 2023-05-13 18:38:33 +02:00
Juergen Spitzmueller
75f628aec0 Replace removed signal 
The used one has been removed from Qt6
 2023-05-12 09:46:38 +02:00
Juergen Spitzmueller
120ba1d3ec Do not attempt to read bitmap icon with svg renderer 
Pavel, this should cure your woes
 2023-05-12 09:39:20 +02:00
Juergen Spitzmueller
0a040d18ad Some layout fixes 
Layout was too squeezed and didn't properly expand on longer (l7n) strings
 2023-05-11 17:46:16 +02:00
Pavel Sanda
918146addd Fix DocBook case 2023-05-11 15:29:14 +02:00
Jean-Marc Lasgouttes
6fbc8c6352 Fixup 7f1b1729: restore lazy caret handling 
For some reason, the code that should have been put in
updateCaretGeometry() went to resetCaret(). I do not see how that made
sense.

I am not totally sure what the consequences of the patch are, though.
It just "looks right".
 2023-05-11 10:13:27 +02:00
Pavel Sanda
16da5ef010 * LanguageUi.ui - change layout. 
This pane is responsible for horizontal excess size (at least in CZ
translation) of document settings panel. The reason is second encoding combo
which get very lengthy (there are actually 3 of them).
This patch moves them to separate line.

Beware, touching this panel is headache.
Qt Designer (5.15.2) does not know even how to load this ui
file correctly and it's impossible to move unicodeEncodingCO.
When breaking layout this CO is mysteriously deleted.

Finally I gave up and simply edited file in vim to get COs to the new row.
 2023-05-09 20:33:42 +02:00
Pavel Sanda
75d731c9d8 * OutputUi.ui - Reorganize Output pane so it takes less vertical space. 2023-05-09 19:06:26 +02:00
Pavel Sanda
20b45cf028 * Document prefs: rename Format -> Output 2023-05-09 19:05:31 +02:00
Pavel Sanda
c3613f1f17 * PrefDocHandlingUi.ui - add naming for emergency file 2023-05-09 18:35:00 +02:00
Jean-Marc Lasgouttes
e454deba2c Revert "Move Fullscreen preferences from Editing>Control section into Look & Feel>User Interface section" 
I pushed it by mistake.

This reverts commit 4d31e20d7d.
 2023-05-05 21:23:21 +02:00
Yuriy Skalko
4d31e20d7d Move Fullscreen preferences from Editing>Control section into Look & Feel>User Interface section 2023-05-05 19:21:37 +02:00
Jean-Marc Lasgouttes
21dcb4782f Never not show caret when window does not have focus 
A non blinking cursor could appear when hovering on inset button.

Fixes bug #12762.
 2023-05-03 12:22:52 +02:00
Jean-Marc Lasgouttes
89db357cd6 Code factoring: introduce BufferView::busy() 
The WorkArea should not have to look at details of the undo stack.
No change intended.
 2023-05-03 11:57:31 +02:00
Daniel Ramoeller
dfc3db773a Fixup 89394bcd: handle cursor keys from keypad 
Due to a macOS peculiarity, it is necessary to handle KeypadModifier.
We do it unconditionnally, although only macOS seems to be affected.

"Note: On macOS, [...] The KeypadModifier value will also be set when
an arrow key is pressed as the arrow keys are considered part of the
keypad." (​https://doc.qt.io/qt-6/qt.html#KeyboardModifier-enum)

Related to bug #12572.
 2023-05-03 11:25:06 +02:00
Enrico Forestieri
17b24cf480 Re-enable QWindowsMimeMetafile with Qt6 
Qt 6.5.0 has dropped support for the QWindowsMime class
in favor of a new QWindowsMimeConverter class. They say:
  "If you have implementations of QWindowsMime or QMacMime in Qt 5,
   then those will almost directly translate to the new APIs but
   require less boiler-plate code to register the converters with Qt."
This may be true, but in practice they break binary compatibility with
previous versions. If you used the QWindowsMime class until Qt 6.4 by
using boiler-plate code to register the converters with Qt, you now
need to modify the sources and recompile. Fantastic!
 2023-04-28 23:34:01 +02:00
Pavel Sanda
c6a190d480 Centralize use of "all files" wildcard in dialogs so it's consistent. 2023-04-28 21:59:37 +02:00
Pavel Sanda
a42a57a0b6 Increase hint verbosity, otherwise difficult to understand. 2023-04-27 21:24:49 +02:00
Pavel Sanda
7f614397ed typo 2023-04-14 10:53:37 +02:00
Juergen Spitzmueller
3a02e477a0 Sync doc CT settings with dialog-external change of status (#12703) 2023-03-21 10:24:34 +01:00
Juergen Spitzmueller
5ad6cbb1d8 Fix signal order (#12712) 2023-03-18 15:58:04 +01:00
Jean-Marc Lasgouttes
98b5a16793 Fix completion in math when inline completion was not yet shown (take 2) 
Better version of b4211ef2: we handle the case of a unique completion early.

Fixes bug #12674.
 2023-03-16 11:58:49 +01:00
Jean-Marc Lasgouttes
fb1c4494ea Revert "Fix completion in math when inline completion was not yet shown" 
A better fix is in the works.

This reverts commit b4211ef206.
 2023-03-16 11:58:49 +01:00
Jean-Marc Lasgouttes
05469a053f revert/fixup 309f8f4b: setFilterRegularExpression was introduced in Qt 5.12. 2023-03-12 13:05:58 +01:00
Juergen Spitzmueller
7cde89ece7 Remobe static icon sizing which seems to play bad with HiDpi 2023-03-11 18:30:44 +01:00
Juergen Spitzmueller
466e6eb613 Remove workaround for Qt version which is no longer supported 2023-03-11 16:43:08 +01:00
Juergen Spitzmueller
31a197d88c Fix signals 2023-03-11 16:25:25 +01:00
Juergen Spitzmueller
548c5ba92d Two more icon scale fixes 2023-03-11 16:10:52 +01:00
Juergen Spitzmueller
8863d6d785 Properly scale some icons for HiDPI (#12695) 2023-03-11 14:49:07 +01:00
Yuriy Skalko
2b6b20ff69 Include QScreen header to fix compilation with Qt 5.14 
Needed after e2e1fd6ea9.
 2023-03-10 09:18:59 +01:00
Daniel Ramoeller
2ed5b4a705 Fix text color of "file changed on disk" notification 
Adjusts the label color of the notification to the background.

Fix for #12690.
 2023-03-09 16:13:00 +01:00
Pavel Sanda
4cccec60ca Improve tooltip. 2023-03-09 10:23:46 +01:00
Juergen Spitzmueller
c227a4af41 Check for invalid indexes in Module selection 
This should fix crashes when moving with pressed mouse buttons on
category nods
 2023-03-08 08:24:38 +01:00
Jean-Marc Lasgouttes
e2e1fd6ea9 QDesktopWidget is not required in Qt5, the Qt6 code works 2023-03-05 21:54:08 +01:00
Jean-Marc Lasgouttes
9156843ec2 QWidget::setContentsMargins is supported in Qt5 2023-03-05 21:37:01 +01:00