Commit Graph

30 Commits

Author SHA1 Message Date
Vincent van Ravesteijn
f65f5be6d7 Fix bug #6451 (last part): Crash when interacting with buffer-dependent dialog with no buffer open.
- First, the comment for isBufferDependent is corrected. It seems that the actual use of this function differs from the comment. As the comment said, I decided to close all dialogs that were buffer dependent, but this didn't seem to be correct for the view source pan, the outliner, and find-and-replace.

- Second, the dialogs that are buffer dependent are now closed, but dockviews are not, except for the spellchecker pane, which really depends on an open buffer, but I can't test that. 

So, please test whether the spellchecker dockviewed window behaves as one expects.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@34291 a592a061-630c-0410-9148-cb99ea01b6c8
2010-04-26 02:12:10 +00:00
Pavel Sanda
61fa96cbae Dialog::bufferFilepath -> Dialog::bufferFilePath
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@34241 a592a061-630c-0410-9148-cb99ea01b6c8
2010-04-21 01:19:30 +00:00
Abdelrazak Younes
bbda43a400 Attempt to simplify as much as possible Inset parameter dialog creation. We now just need an ui file and a class that inherits InsetParamsWidget and implement 4 methods. Then InsetParamsDialog will take care of the rest. InsetParamsDialog has 2 running mode: "immediate apply" and "Restore/OK/Close" which is the default; I hope this is enough to satisfy all users. The checkbox status might be saved later in session settings.
This new attempt replace the previous attempt with InsetDialog which was still too tight with the older framework.
Status:
float, ert, box, info: migrated
vspace: migrated but buggy. To be fixed later.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33480 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-15 23:17:45 +00:00
Abdelrazak Younes
d77a22e2f9 Today is a sad day, LyXView has passed over... long live GuiView!
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33393 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-09 17:06:40 +00:00
Abdelrazak Younes
3e5ed356c0 Dialog: move method to protected area
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33352 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-07 21:06:43 +00:00
Abdelrazak Younes
1c188f022c * Dialog:
- transfer ans simplify a bit the CheckedLineEdit class from ButtonController.

* InsetDialog:
- Pimpl private data
- applyView(): now a slot, check widget before applying.



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33350 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-07 20:25:53 +00:00
Pavel Sanda
a45c849f3b Refactorize GuiView::showView.
This way we get rid of pop-uping of widgets when ~/.config/LyX is re-created
and yet we still have title and enabling status correct when widgets are
restored from session.
Some details in bug #5082.

This is candidate for branch too.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@30144 a592a061-630c-0410-9148-cb99ea01b6c8
2009-06-16 17:22:43 +00:00
Abdelrazak Younes
193074b384 Spellchecker: More simplifications.
This change makes it possible (at long last!) to go to the work area, do some edition and then come back to the SpellChecker. We probably need a [Continue] button.

* Buffer::nextWord(): go back a bit to return the current word.

* SpellChecker and Dialog: get rid of the complicated, useless exitEarly() handling.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@29092 a592a061-630c-0410-9148-cb99ea01b6c8
2009-04-04 17:25:14 +00:00
Abdelrazak Younes
6f798773a5 Dialogs: discourage non const access to lyxview().
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26622 a592a061-630c-0410-9148-cb99ea01b6c8
2008-09-29 11:01:53 +00:00
Abdelrazak Younes
53acfb8351 Dialogs: discourage non const access to buffer() and bufferview().
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26620 a592a061-630c-0410-9148-cb99ea01b6c8
2008-09-29 10:52:17 +00:00
Richard Heck
ea6aed5b8b Remove invalid comment.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26125 a592a061-630c-0410-9148-cb99ea01b6c8
2008-08-12 21:56:07 +00:00
Abdelrazak Younes
42cb86adb9 Fix initial focus problem with outline and view-source panes.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@25213 a592a061-630c-0410-9148-cb99ea01b6c8
2008-06-09 14:52:38 +00:00
Abdelrazak Younes
062bec11d0 * Dialog::inset(): make it const.
* InsetInfo::validate(): new method for checking dispatch argument. Not implemented yet.

* GuiInfo: remove non working code and rework the dialog following my vision of an ideal info dialog :-) not every thing works yet.



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@25153 a592a061-630c-0410-9148-cb99ea01b6c8
2008-06-06 08:01:59 +00:00
Abdelrazak Younes
ccea2a5cd9 Move inset lookup to Dialog class as this is generic enough to be reused by other dialogs.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@25147 a592a061-630c-0410-9148-cb99ea01b6c8
2008-06-05 16:03:08 +00:00
Abdelrazak Younes
b9c526aaa2 * Delegates.h: clarify some comments.
* Dialog: get rid of updateData()


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24589 a592a061-630c-0410-9148-cb99ea01b6c8
2008-05-02 21:38:23 +00:00
André Pönitz
ca33681577 forward decalaration is sufficient
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24336 a592a061-630c-0410-9148-cb99ea01b6c8
2008-04-19 07:58:50 +00:00
André Pönitz
a98f82c292 s/kb_action/FuncCode/g
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23749 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-15 01:20:36 +00:00
André Pönitz
990df4924a more of that
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23497 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-06 00:07:19 +00:00
André Pönitz
a500e62902 do what the FIXME suggested
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23486 a592a061-630c-0410-9148-cb99ea01b6c8
2008-03-05 20:11:47 +00:00
Jean-Marc Lasgouttes
049dea1eb1 compilation fix
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22792 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-05 15:16:49 +00:00
Stefan Schimanski
4a6a7fbe55 * GCC: "QString is an incomplete type"
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22788 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-05 13:22:50 +00:00
Abdelrazak Younes
6bb94129d8 Factorize out the way window titles are handled.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22784 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-05 12:43:19 +00:00
Abdelrazak Younes
41681e7185 Add common session handling infrastructure for dialogs.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22061 a592a061-630c-0410-9148-cb99ea01b6c8
2007-12-10 13:05:00 +00:00
Abdelrazak Younes
604c1148ea Factorize general code out of GuiDialog and into the base Dialog class. This is now possible thanks to the moving of Dialog.{cpp,h} to qt4/. Any dialog must inherit QWidget within Qt so it is safe to use Dialog::asQWidget() method (which is similar to dynamic casting).
* GuiDialog now inherits DialogView. GuiDialog is only there to bring the ButtonController archaeological interface; any new dialog should inherit DialogView and any new dock widget should inherit DockView.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22049 a592a061-630c-0410-9148-cb99ea01b6c8
2007-12-09 22:35:04 +00:00
Abdelrazak Younes
db95e2cb85 * Dialog: name_ is const and is ascii.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22014 a592a061-630c-0410-9148-cb99ea01b6c8
2007-12-08 14:24:11 +00:00
Abdelrazak Younes
20e21c1818 Fix bug 4413 (http://bugzilla.lyx.org/show_bug.cgi?id=4413)
The problem was that name_ was a const pointer and the pointer pointed to nothing after leaving the ctor.
Andre': <docstring> is included in every dialog anyway via GuiDialog.h -> InsetCommandParams.h -> docstring.h"; so this change won't affect compilation time.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@22012 a592a061-630c-0410-9148-cb99ea01b6c8
2007-12-08 13:59:32 +00:00
Abdelrazak Younes
10cc0a8842 Simplify Dialog::name() handling.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21736 a592a061-630c-0410-9148-cb99ea01b6c8
2007-11-23 10:45:14 +00:00
Abdelrazak Younes
42015a8ebd Transfer some more dialog related code from core to frontend:
- LFUN_INSET_APPLY handling goes to GuiView.
- Dialog needs a GuiView instead of a LyXView.




git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21734 a592a061-630c-0410-9148-cb99ea01b6c8
2007-11-23 09:44:02 +00:00
Abdelrazak Younes
baa9153134 Remove unused code.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21717 a592a061-630c-0410-9148-cb99ea01b6c8
2007-11-22 22:20:51 +00:00
Abdelrazak Younes
b9d2666b98 Move Dialog.{h,cpp} and ButtonPolicy.{h,cpp} to frontends/qt4/
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@21714 a592a061-630c-0410-9148-cb99ea01b6c8
2007-11-22 08:01:09 +00:00