Commit Graph

3555 Commits

Author SHA1 Message Date
Pavel Sanda
a7b921aeeb Fix unsafe use of fixed width arrays.
Fix crash when MathMatrix has more than 80 columns

Patch from John McCabe-Dansted, approved from Andre.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33641 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-06 14:57:16 +00:00
Richard Heck
1fcc1c0f18 Fix bug 6522 and its relatives in trunk. I am not absolutely sure this
is right, though. Someone please check.

The problem, in branch, was that (in Qt 4.6.x, anyway) the call to
reset() eventually triggers the on_typeCO_currentIndexChanged() method,
which eventually leads to GuiView::setFocus(), which leads to
GuiWorkArea::focusInEvent(), which tries to start the cursor, whose
position hasn't been updated yet, from what I can see.

The problem in trunk is similar. The crash happens, I think, because,
while we are in the middle of resetting the model, the same method is
triggered, which leads us to try to access the model while we are in the
middle of resetting it.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33630 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-05 20:47:50 +00:00
Peter Kümmel
d58b4ead47 fix bug 6578, use tabs
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33627 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-05 18:07:05 +00:00
Pavel Sanda
59c980e6e5 Start preparations for alpha
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33623 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-05 08:05:20 +00:00
Richard Heck
afb8365d82 Some cleanup for the Floating class.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33617 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-04 13:42:05 +00:00
Richard Heck
d65020b293 s/updateLabels/updateBuffer/g, per a suggestion of Abdel's.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33613 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-03 22:13:45 +00:00
Abdelrazak Younes
81d2d239c3 Document Settings: fix Float placement dialog. The float type is not
needed here.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33602 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-01 09:03:15 +00:00
Jürgen Spitzmüller
4def0c2a52 * Menus.cpp: add accelerator to "More Languages ..."
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33591 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-28 10:23:06 +00:00
Jürgen Spitzmüller
5c6c8dc25f " Menus.cpp: sort languages. Based on a patch by John McCabe-Dansted.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33590 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-28 10:06:05 +00:00
Richard Heck
3906792378 We were doing this twice, and I think there's also a bug here, namely,
that we weren't re-enabling if we returned early.

Someone tell me if this is wrong.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33585 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 19:56:08 +00:00
Richard Heck
805231ccbe This can just take a FuncCode.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33584 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 19:51:06 +00:00
Richard Heck
c127d83b66 A little cleanup while perusing TocWidget....
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33583 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 19:48:20 +00:00
Vincent van Ravesteijn
834115c920 Fix bug #6552: Crash when inserting TeX-code in math mode and scrolling
Avoid an assertion when accessing the CoordCache while the Inset is in a paragraph which is not visible on screen.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33582 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 15:59:08 +00:00
Jean-Marc Lasgouttes
6d671bf5f2 Fix compilation with qt 4.2: QString::operator[] returns a QCharRef,
which is supposedly like a QChar... except that some methods like isUpper 
were forgotten in the process.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33580 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 14:46:42 +00:00
Vincent van Ravesteijn
4aeca63887 Fix bug #6464: Crash when exiting LyX from second window when first window has changed buffer.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33579 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 14:07:21 +00:00
Jürgen Spitzmüller
f31298fd7c * GuiSpellchecker.cpp:
- fix bug #6561 (null pointer).

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33578 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-26 13:34:36 +00:00
Jürgen Spitzmüller
9f67cede58 Menus.cpp: priorize capitals as language accelerators.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33566 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-25 12:56:12 +00:00
Jürgen Spitzmüller
ea6b96dfc5 * Menus.cpp: hide Language item if only one language is used.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33565 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-25 12:46:16 +00:00
Jean-Marc Lasgouttes
04336d45d8 fix compilation with qt 4.2
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33563 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-25 11:35:41 +00:00
Vincent van Ravesteijn
ccf2080ae8 Fix bug #6556: Exporting .lyx to .lyx15 or lyx16 report error, yet succeeds.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33557 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-24 17:02:52 +00:00
Jürgen Spitzmüller
a15a58b51c * Menus.cpp:
- exclude spaces from accelerator construction.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33556 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-24 14:21:30 +00:00
Jürgen Spitzmüller
1f97351716 * Menus.cpp:
- add accelerators to the language selector submenu (bug 6558)

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33555 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-24 14:06:40 +00:00
Abdelrazak Younes
85c782bde8 Migrate GuiBibitem to InsetParamsWidget.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33547 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-23 21:24:24 +00:00
Pavel Sanda
06b4dfb24d Revert r33533.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33543 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-23 03:51:49 +00:00
Uwe Stöhr
1c9a6f8b49 GuiView.cpp: fix compilation after r33533
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33540 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-22 20:31:13 +00:00
Pavel Sanda
21379cbef9 At least basic capability for VC comparison.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33533 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-22 02:01:04 +00:00
Abdelrazak Younes
5d235f5251 Migrate GuiHSPace to InsetParamsDialog.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33525 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-21 09:28:33 +00:00
Abdelrazak Younes
4db2685cbe Migrate Branch dialog to InsetParamsWidget
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33521 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-19 20:57:25 +00:00
Abdelrazak Younes
bebd53821a Implement Vincent's suggestions:
- [New Inset] button even in non synchronous mode
- Get rid of the horizontal spacer for improved layout under Windows.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33520 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-19 20:44:59 +00:00
Abdelrazak Younes
10e22f9eab Following previous commit, the dialog now needs to be reinitialized when
called...


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33510 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-19 11:17:00 +00:00
Abdelrazak Younes
3efb329cb0 InsetParamsDialog: don't update the inset widget if we are not un
synchronised mode.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33509 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-19 11:04:15 +00:00
Abdelrazak Younes
3776d8ec89 Fix cell width initial fill-in.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33508 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-19 10:25:20 +00:00
Abdelrazak Younes
addba25b98 r33506: better fix for table borders.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33507 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-19 10:03:03 +00:00
Abdelrazak Younes
15e19deed3 Really fix table borders toggling.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33506 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-19 09:03:39 +00:00
Abdelrazak Younes
98ed6f399e Tabular dialog: fix border setting/unsetting bug.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33505 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-19 08:20:58 +00:00
Abdelrazak Younes
b5049e769b * InsetTabular cleanup:
- proper message passing for all tabular features
- properly define which feature needs an argument

* replace LFUN_TABULAR_FEATURE with LFUN_INSET_MODIFY
- The math tables are also affected. In the future a common base class
between math and text table will solve this inconsistency.
- There is a hack in GuiApplication in order to not rename the toolbar
icons. This will have to be cleaned up with a general icon naming for
LFUN_INSET_MODIFY... to be discussed.

* Tabular Dialog:
- big cleanup, lots and lots of bug fixing here
- migrated to InsetParamsWidget


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33495 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-18 08:28:46 +00:00
Abdelrazak Younes
8613f66a1d InsetParamsWidget(): fix method constness.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33493 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-18 07:56:38 +00:00
Abdelrazak Younes
3a26a8d9d7 some moreInsetParamsDialog bug fixing...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33485 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-16 10:50:06 +00:00
Abdelrazak Younes
c775690b58 InsetParamsDialog bug fixing:
* OK button now creates an inset if none is present
* Fix some enabling/disabling of buttons.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33484 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-16 09:39:14 +00:00
Abdelrazak Younes
06e19de13b Fix autotools for r33480.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33483 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-16 08:05:49 +00:00
Abdelrazak Younes
f345feeced Fix compilation with Qt4.2
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33481 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-15 23:19:31 +00:00
Abdelrazak Younes
bbda43a400 Attempt to simplify as much as possible Inset parameter dialog creation. We now just need an ui file and a class that inherits InsetParamsWidget and implement 4 methods. Then InsetParamsDialog will take care of the rest. InsetParamsDialog has 2 running mode: "immediate apply" and "Restore/OK/Close" which is the default; I hope this is enough to satisfy all users. The checkbox status might be saved later in session settings.
This new attempt replace the previous attempt with InsetDialog which was still too tight with the older framework.
Status:
float, ert, box, info: migrated
vspace: migrated but buggy. To be fixed later.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33480 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-15 23:17:45 +00:00
Pavel Sanda
c30a82d94d Glitch in LFUN
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33476 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-15 09:05:16 +00:00
Pavel Sanda
3309cdca59 Allow revision to be string.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33474 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-15 07:10:59 +00:00
Jürgen Spitzmüller
bd57d5ea56 * add pref option to exclude notes and comments from spell checking (bug 1509).
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33468 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-13 16:22:39 +00:00
Jürgen Spitzmüller
23a58c0214 * TocWidget.{cpp,h}:
* TocWidgetUi.ui:
	- add filter bar.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33457 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-13 08:30:16 +00:00
Jean-Marc Lasgouttes
a56b03e4fd Do not show spelling suggestions in contextual menu when spellcheck_continuouslyis off.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33451 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-12 15:46:48 +00:00
Pavel Sanda
3788adf6ce Prepare VCS part for comparison.
We probably need to enhance comparison API for external calls.

Closing the party for today.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33449 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-12 14:09:44 +00:00
Jürgen Spitzmüller
6f3e447afa * GuiApplication.cpp: prevent null pointer.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33447 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-12 12:32:15 +00:00
Jean-Marc Lasgouttes
09ef9c67ef Fix bug #6217: Replacing a word in spellcheck does not update toolbar
Use the dispatch machinery when replacing a word in the spellchecker. Note that this implies a slight hack with lyxrc.auto_region_delete setting.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33445 a592a061-630c-0410-9148-cb99ea01b6c8
2010-02-12 11:25:44 +00:00