Richard Kimberly Heck
56a5a8280e
Null pointers.
2020-02-29 00:06:35 -05:00
Kornel Benko
b399cfc7a2
Cmake build: Use correct include if using internal hunspell
...
This way also "HAVE_HUNSPELL_CXXABI" is correctly set to 1
2020-02-28 21:48:54 +01:00
Richard Kimberly Heck
8d26ae57ba
Use ranges, fix warning
2020-02-28 01:55:05 -05:00
Richard Kimberly Heck
5baca8171f
Use ranges, fix warning
2020-02-28 01:48:10 -05:00
Richard Kimberly Heck
969a1bab7d
Use range
2020-02-28 01:44:48 -05:00
Richard Kimberly Heck
12d164393e
Fix nullptr warnings
2020-02-28 01:42:32 -05:00
Richard Kimberly Heck
cf37ad8c80
Use ranges, fix warnings
2020-02-28 01:40:30 -05:00
Richard Kimberly Heck
084baebbf9
Fix nullptr warnings
2020-02-28 01:28:08 -05:00
Richard Kimberly Heck
3f9aa81452
Use ranges, fix warnings
2020-02-28 01:25:30 -05:00
Richard Kimberly Heck
94f64cd304
Fix warnings
2020-02-28 01:21:02 -05:00
Richard Kimberly Heck
5728625b65
Fix warnings
2020-02-28 01:16:21 -05:00
Richard Kimberly Heck
a9e663546b
Use range
2020-02-28 01:16:10 -05:00
Richard Kimberly Heck
31c511d2ce
Fix warnings
2020-02-28 01:09:45 -05:00
Richard Kimberly Heck
83779e7972
Use range and rename private variable
2020-02-28 01:08:28 -05:00
Richard Kimberly Heck
5b5b6998cb
Use more ranges
2020-02-28 01:06:22 -05:00
Richard Kimberly Heck
7a66c93265
Use ranges
2020-02-28 00:52:38 -05:00
Richard Kimberly Heck
81597aabdb
Polish
2020-02-28 00:39:50 -05:00
Richard Kimberly Heck
62af7ee772
More requires --> required, for C++2a.
2020-02-28 00:36:55 -05:00
Richard Kimberly Heck
21b4ecca7f
Apparently, "requires" is a keyword in C++2a.
2020-02-28 00:28:18 -05:00
Richard Kimberly Heck
0dc9fca86e
Remove code that has not been used since 2010.
...
See 208acbc72
.
2020-02-28 00:21:48 -05:00
Richard Kimberly Heck
b750941910
Stop dialogs from updating twice all the time.
...
I've long wondered why dialogs seem to update twice when it seems
they just need to update once. It seems it was this code. But it
was only put there to deal with a problem with code in the button
controllers that was disabled in 2007! So I'm going to try removing
it. If we start seeing weird behavior with dialogs in master, then
this will be why.
2020-02-28 00:11:45 -05:00
Richard Kimberly Heck
f53243f81b
Fix warnings
2020-02-28 00:10:23 -05:00
Richard Kimberly Heck
78ade7e6ec
Remove code that has not been used for 13 years.
2020-02-28 00:08:30 -05:00
Richard Kimberly Heck
1948391a94
Fix warnings.
2020-02-28 00:07:53 -05:00
Richard Kimberly Heck
c483565522
Fix a bunch of warnings.
2020-02-27 23:58:01 -05:00
Richard Kimberly Heck
2165855d5e
Revert unintended change
2020-02-27 14:36:46 -05:00
Richard Kimberly Heck
f4d5122a10
Fix null pointer warnings.
2020-02-27 00:05:41 -05:00
Richard Kimberly Heck
79bcf68018
Fix warning (and simplify)
2020-02-26 23:37:24 -05:00
Richard Kimberly Heck
64f7da961a
Fix bug #11748 .
...
Track the last chosen citation style when we clear the entries.
2020-02-26 23:00:09 -05:00
Richard Kimberly Heck
ca40d1f92a
Fix a bunch of warnings
2020-02-26 22:29:40 -05:00
Richard Kimberly Heck
2e444dd657
Fix problem with validation when using InsetLayout.
2020-02-26 22:19:36 -05:00
Enrico Forestieri
f28334ac8b
Cleaner fix to ensure 32-bit XCB events
...
This fix still satisfies Valgrind and is cleaner than the approach
at 19c41bd0
: instead of using calloc we now use the C++11 specifier
alignas. For more info, see the following ML thread:
https://www.mail-archive.com/search?l=mid&q=20200219024908.5n4x4osni55gylo3%40tallinn
2020-02-25 12:37:51 +01:00
Enrico Forestieri
8977296078
Revert "Fix write to uninitialized bytes for XCB event"
...
This reverts commit 19c41bd095
.
A more efficient fix is on the way.
2020-02-25 12:32:10 +01:00
Richard Kimberly Heck
9d8dfe934b
Fix bug #11750 .
...
Unfortunately, stat.st_ino returns 0 on Windows, at least on Python 2.7, so we can't use that way of telling when we're seeing the same directory again. Surely the real pathname should work.
2020-02-24 19:07:31 -05:00
Jean-Marc Lasgouttes
74540c9896
Fixup d207e85c
: paint sublabel with the correct background color
...
The above mentionned patch did paint the background of the sublabel to
avoid "bold-like" effect. However the correct backgound color is the
row's one, not the inset's one.
2020-02-24 10:41:18 +01:00
Richard Kimberly Heck
a9d9fdc9bf
Fix alignment warnings from clang.
2020-02-23 17:15:01 -05:00
Richard Kimberly Heck
34f9ea8275
Use C++11 construct.
2020-02-23 16:59:59 -05:00
Enrico Forestieri
5873a382de
Fix FileName::realPath() on Windows
...
The realPath() implementation on Windows works only for files and
not for directories. By using an API available starting from Vista
it is possible to fix it in a simple way.
I also took into account using the Qt QFileInfo::canonicalFilePath(),
but it turns out to not work when a path component is a junction
(tested with Qt 5.14.1).
Due to this, it is not possible compiling or using LyX on Windows
versions earlier than Vista.
2020-02-23 22:59:03 +01:00
Richard Kimberly Heck
0daceae649
Try again to fix memory leak reported by Scott.
...
This time, use a shared_ptr.
2020-02-23 16:56:43 -05:00
Richard Kimberly Heck
72c581ebdb
Revert "Fix memory leak reported by Scott."
...
It leads to a double delete error.
This reverts commit 11397a2e82
.
2020-02-23 16:29:58 -05:00
Richard Kimberly Heck
11397a2e82
Fix memory leak reported by Scott.
2020-02-23 15:54:13 -05:00
Richard Kimberly Heck
86f95062bd
Fix some clang warnings.
...
The first one, a comma instead of a semi-colon, is a weird one.
2020-02-23 15:52:15 -05:00
Richard Kimberly Heck
d11a27a611
Fix nullptr warnings
2020-02-23 15:52:15 -05:00
Richard Kimberly Heck
608b927daf
Fix "no extern declaration" warning.
2020-02-23 15:52:15 -05:00
Kornel Benko
f152302275
Cmake build: Remove unused option
...
LYX_USE_FILEDIALOG is not used since af795b80
2020-02-22 21:13:43 +01:00
Jean-Marc Lasgouttes
57b400cdff
Make sure that spelling marks do not spill ouside of row
...
This avoids annoying remnants of dotted red lines.
Fixes bug #11755 .
2020-02-22 18:02:13 +01:00
Stephan Witt
a891a1ba20
Avoid UTF8 "no-break space" and use the space inset instead.
2020-02-22 15:21:26 +01:00
Stephan Witt
90079857fe
Provide predefined key binding for LFUN "forward-search" on Mac
2020-02-22 12:24:41 +01:00
Stephan Witt
f2f861f017
Use real path names for buffer lookup by name of temporary external files.
...
In case of path names for external files containing symbolic links the real path
and the logical path name may be different for the same file or directory.
LyX is using QDir::tempPath() to create the path name of the temporary directory.
The Qt implementation is free to return the logical or the real path name here and
it happens to be different for various platforms and versions.
The most stable and clean solution is to use the real path name consistently.
2020-02-22 12:11:42 +01:00
Stephan Witt
ca7defab45
Make the directories in LyX application bundle read only.
...
Python produces files with cached on-the-fly compiled code on disk inside the bundle.
This should be avoided in case of a signed application bundle.
2020-02-21 18:04:28 +01:00