Jean-Marc Lasgouttes
2b0841b0c9
Move LYX_(BEGIN|END)_MUTE_GCC_WARNING macros to their own header.
...
It was not nice to other build systems to define that in configure.ac.
2023-11-10 13:14:34 +01:00
Jean-Marc Lasgouttes
c2653e451c
Avoid dangling-reference warning in several places
...
This new warning in gcc 13 is annoying because it happens in certain
parts of our code where it is harmless to pass a temporary variable to
a function that returns a reference.
This patch introduces a new pair of macros,
LYX_BEGIN_MUTE_GCC_WARNING(warn) and LYX_END_MUTE_GCC_WARNING, which
can be used to define a block of code where a given GCC warning is disabled.
The macros are no-ops with compilers other than gcc, although some
compilers that pretend to be GCC make be mis-detected. The worse that
can happen AFAIU is a bunch of warnings.
The macro relies on an intimidating set of for nested macros. The goal
of these macros is to build a nested string bit by bit. Here is how it
works:
PRAGMA_IGNORE(dangling-reference)
=> PRAGMA_IGNORE_1(-Wdangling-reference)
=> PRAGMA_IGNORE_2("-Wdangling-reference")
=> PRAGMA_IGNORE_3(GCC diagnostic ignored "-Wdangling-reference")
=> _Pragma("GCC diagnostic ignored \""-Wdangling-reference\"")
The next question is: what is _Pragma() good for? Well, it is a
version of #pragma that can be used in a macro.
And finally, what are those pragmas good for? The 'push' and 'pop'
ones make changes to warnings local. The 'ignored' ones allow
to disable some warnings. And disabling -Wpragmas ensures that we do
not have a warning if we try to disable a warning that is not
supported by the compiler.
2023-11-10 10:36:52 +01:00
Yuriy Skalko
53784b90ae
Better dialog resizing behavior
2023-11-09 00:15:16 +01:00
Juergen Spitzmueller
27033f41aa
Fix comment
2023-11-05 12:38:09 +01:00
Juergen Spitzmueller
098b4f3348
Amend ec2da3a509
2023-11-05 12:28:27 +01:00
Juergen Spitzmueller
ec2da3a509
Prevent data loss when closing LyX while document dialog has unapplied changes ( #12955 )
...
Entails new strings, but I think the severity allows for that.
2023-11-05 12:09:33 +01:00
Juergen Spitzmueller
bf0152185b
Make string translatable
2023-10-21 12:52:49 +02:00
Juergen Spitzmueller
4658cf95f7
Disambiguate "Language"
...
Some translations need a different term for programming languages.
2023-10-21 12:34:47 +02:00
Juergen Spitzmueller
72e242267b
Only apply ui_style if it has changed
2023-10-15 11:20:49 +02:00
Juergen Spitzmueller
81fda3ac55
Warn user that uistyle reset to default requires restart
2023-10-15 11:02:45 +02:00
Juergen Spitzmueller
cfcc57bd89
Simplify
2023-10-15 11:02:35 +02:00
Juergen Spitzmueller
462a701e62
Make new gui element translatable
2023-10-15 09:40:58 +02:00
Juergen Spitzmueller
41e3f1ec98
complement tooltip
2023-10-15 09:17:31 +02:00
Eugene Chornyi
d2132751a7
Implement ui style selection dialog 12832 attempt 2
2023-10-15 08:46:12 +02:00
Daniel Ramoeller
5a9ea580e4
Correctly update Outliner icon size
...
Fix for #12453
2023-10-14 12:48:09 +02:00
Eugene Chornyi
a99a16ae58
Revert 072ba7bd
and f1deb1c6
2023-10-11 23:22:17 +02:00
Pavel Sanda
c9c5a2a9d8
Add space padding around word count forgotten part of ( #12625 ).
...
Again from Daniel.
2023-10-11 21:07:12 +02:00
Pavel Sanda
5ed59b3c09
Remove ugly frame around word count ( #12625 ).
...
Requested and tested by Daniel.
2023-10-11 21:01:56 +02:00
Eugene Chornyi
072ba7bd2e
Implement ui style selection dialog 12832
2023-10-11 20:06:52 +02:00
Pavel Sanda
cc257b4927
Few string fixes from Dan.
2023-10-09 20:41:57 +02:00
Juergen Spitzmueller
5cb53606b6
Introduce color_selectionmath
...
To have a distinctive color for selected math which works in both modes
Also, link color_selectionmath with QPalette::HighlightedText, so we
won't need to special-case on lyxrc.use_system_colors any longer
2023-10-04 13:10:07 +02:00
Juergen Spitzmueller
087f6bce71
Introduce default box frame color ( #12921 )
...
This better aligns with dark mode
2023-09-30 09:56:27 +02:00
Juergen Spitzmueller
7aa00f0b92
Fix quote menu item, from Dan
...
Current language is relevant here, not main language
2023-09-29 13:09:20 +02:00
Jean-Marc Lasgouttes
94c6d45b74
When drawing macro names, enforce LtR direction
...
Add a Direction parameter to the Painter::text methods that take a
FontInfo parameter.
In drawStrRed and drawStrBlack, force the direction to LtR.
Fixes bug #12905 .
2023-09-22 12:41:44 +02:00
Juergen Spitzmueller
cd5a88029c
Remove unneeded method
...
which is also not available in Qt < 5.13, as it turns out.
2023-09-18 11:36:16 +02:00
Juergen Spitzmueller
b13685d9bb
Prefer following, not previous, item in selection manager after deletion ( #12871 )
2023-09-18 10:02:34 +02:00
Juergen Spitzmueller
d3102380bc
Amend ac275a66b5
...
Set depth correctly in the active branch
2023-09-18 09:27:38 +02:00
Juergen Spitzmueller
63b99beedd
Bit refactoring
2023-09-18 08:13:23 +02:00
Juergen Spitzmueller
ac275a66b5
Get rid of unnecessary flickering when clicking in outliner
...
No need to collapse and re-expand the node where the currently selected
item is in.
2023-09-17 19:17:12 +02:00
Juergen Spitzmueller
610e2f501b
Fix double-click expansion of outliner
2023-09-17 16:45:19 +02:00
Juergen Spitzmueller
013d52ed2b
Fix readability
...
here, "custom" was exactly the opposite (non-custom, i.e., default
margins)
2023-09-17 14:31:36 +02:00
Juergen Spitzmueller
d99a13da18
Amend c8d4b99559
2023-09-17 14:17:05 +02:00
Juergen Spitzmueller
c8d4b99559
Fix display of disabled page margins ( #12887 )
...
while preserving input values on geometry toggle
2023-09-16 11:00:10 +02:00
Daniel Ramoeller
ceb1a4c393
Only split view rather than split and move
...
Fix for #12893
2023-09-15 14:05:33 +02:00
Juergen Spitzmueller
ac59b04922
Only create a new view for lyxfiles-open if no view is open ( #12894 )
2023-09-08 17:47:47 +02:00
Juergen Spitzmueller
90e05de396
Revert "No need (any longer?) to create a new view for lyxfiles-open"
...
This reverts commit 9f238ca201
.
2023-09-08 16:37:06 +02:00
Juergen Spitzmueller
9f238ca201
No need (any longer?) to create a new view for lyxfiles-open
2023-09-08 16:16:01 +02:00
Juergen Spitzmueller
117e259f0a
Handle multiple files in file and localfile BibTeX field ( #12896 )
2023-09-08 14:02:23 +02:00
Daniel Ramoeller
3318febd0c
Improve Open External Target dialog text
...
Fix for #12897
2023-09-08 10:39:45 +02:00
Daniel Ramoeller
fdcb160ed8
Fix bug #11497
2023-09-06 22:52:42 -04:00
Jean-Marc Lasgouttes
100e759f17
When splitting a bufferview, keep the scrollbar position
...
This is actually better thean making sure that the cursor is visible.
Fixes bug #12689 .
2023-09-05 14:33:18 +02:00
Juergen Spitzmueller
375bb32a3d
More style polishing
2023-09-05 12:07:05 +02:00
Juergen Spitzmueller
6bb72cc28c
With Qt6 on linux, we need to catch StyleChange here
2023-09-05 12:01:17 +02:00
Juergen Spitzmueller
7c8c3657fd
Also change pdf module highlighting on the fly on mode change
2023-09-05 11:48:53 +02:00
Juergen Spitzmueller
51fd28ed4d
Update highlighting colors in runtime (dark/light) mode change
...
Until now, this required a restart.
2023-09-05 11:14:59 +02:00
Juergen Spitzmueller
32f89cbbf5
Style only
2023-09-05 11:13:58 +02:00
Pavel Sanda
625c61f1d5
Output python version in About dialog.
...
Patch from Jose.
2023-09-04 21:50:51 +02:00
Juergen Spitzmueller
b11164524d
GuiLyXFiles: make sure language selector is disabled when dialog is reopened
2023-09-04 07:58:59 +02:00
Juergen Spitzmueller
4393382f02
GuiLyXFiles: fix button controller handling
2023-09-03 15:09:13 +02:00
Enrico Forestieri
1cbcb30353
Fix assertion when canceling file dialog
...
Without this patch, when a file has to be loaded (for example,
after "Document->Settings->Local Class" or "Insert->Graphics")
and the file dialog is canceled, both Qt5 and Qt6 assert:
ASSERT failure in QList::at: "index out of range"
2023-09-02 18:15:09 +02:00