Open new document; LyX > Preferences; change
anything; click on "Save" button --> Crash. Backtrace is below.
Once again, this does not happen when no document is open.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31486 a592a061-630c-0410-9148-cb99ea01b6c8
The list of dialog edited inset is now stored in BufferView.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31472 a592a061-630c-0410-9148-cb99ea01b6c8
For reasons unknown to me, this also fixes the scroll bar issue!
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31463 a592a061-630c-0410-9148-cb99ea01b6c8
* Add a recenter() call to BufferView::setCursorFromRow() in order to get the screen centered around the found position.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31455 a592a061-630c-0410-9148-cb99ea01b6c8
I tested this on Windows and Linux/X11 but not on Mac so...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31451 a592a061-630c-0410-9148-cb99ea01b6c8
This commit also move the Selection saving to QEvent::WindowActivate in GuiView.cpp.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31443 a592a061-630c-0410-9148-cb99ea01b6c8
- implement an UI to specify the size of InstantPreview images
- change the default size to 1.0 because we've got many complaints that the former default size of 0.9 was too low
Both changes fix#6176.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31425 a592a061-630c-0410-9148-cb99ea01b6c8
* GuiView:openChildDocument(): New helper method, I removed the comment about bug 3970 because it doesn't apply anymore with this change.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31409 a592a061-630c-0410-9148-cb99ea01b6c8
There is a FIXME in there that says that if some LFUN need to be dispatched even if the Buffer is internal then we should add some code. But I couldn't find any for now.
* Move LFUN_BUFFER_IMPORT status to GuiView where it belongs.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31398 a592a061-630c-0410-9148-cb99ea01b6c8
got conflated with autosaving, with the result that it became impossible to
disable autosaving, as reported on the user list. This patch disentangles
the two again.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31395 a592a061-630c-0410-9148-cb99ea01b6c8
We have to prevent that two views share the same ID, also when an id was supplied (because we can open the same document twice).
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31381 a592a061-630c-0410-9148-cb99ea01b6c8
- use itemDoubleClicked() instead of itemActivated(). The latter is traditionally defined as single click
on UNIX, which is not desired here (bug 6204)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31319 a592a061-630c-0410-9148-cb99ea01b6c8
In r31286, view() was changed in currentBufferView(), but in r31290 buffer() was changed in documentBufferView()->buffer().
Please be careful with this!
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31300 a592a061-630c-0410-9148-cb99ea01b6c8
Fixes crash when opening both Toc Panel and Advanced Find and Replace Panel.
Fixes preview of document (as opposed of previewing the search/replace text) while search/replace WorkArea selected.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31203 a592a061-630c-0410-9148-cb99ea01b6c8
Maybe this parameter should be killed after last cleanup Vicent?
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31177 a592a061-630c-0410-9148-cb99ea01b6c8
The previous fix was nonsense. It appeared to be a shameful copy-paste error. GuiView::disconnectBufferView() was exactly the same as GuiView::disconnectBuffer().
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31150 a592a061-630c-0410-9148-cb99ea01b6c8
We don't want a master buffer to release all its children immediately because that would close dirty childs without saving and would make it impossible to store the childs in a proper way in the session file.
As, we close all children of a buffer together with the master itself, it is also no longer necessary to do it automatically.
I'll leave it commented out for a while in case someone objects to it.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31130 a592a061-630c-0410-9148-cb99ea01b6c8
For now, I stick to the convention that closing a buffer, will close it in all tabworkareas and all views. Therefore, when choosing File->Close All, we still close all buffers.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31126 a592a061-630c-0410-9148-cb99ea01b6c8
Closing a tab group will now hide the buffers, but if buffers are dirty it will first ask you to save it.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31124 a592a061-630c-0410-9148-cb99ea01b6c8
This fixes yet another bug. Previously, when a master was closed, its child buffers were also released without asking to save dirty buffers. (What a mess!).
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31104 a592a061-630c-0410-9148-cb99ea01b6c8
to add small width so all bullets are again inside the area.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31090 a592a061-630c-0410-9148-cb99ea01b6c8
Besides that, this can also been seen in 1.6.3. If you have a master and a dirty child, and the dirty child is the second tab, you'll see that when closing LyX, LyX will ask twice whether you want to save the file. Once if the file itself is closed, a second time if the master is closing all his children.
See also the previous commit that treats the case in which the tabs were switched around.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31074 a592a061-630c-0410-9148-cb99ea01b6c8
Now we can also pass the WorkArea we would like to close. This fixes also the problem that hideWorkArea still wasn't correct. That's a consequence of the fact that we relied on currentMainWorkArea(). I wanted to get rid of that anyway.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31063 a592a061-630c-0410-9148-cb99ea01b6c8
The first thing that bformat does is to check whether the string contains "%1$s". Otherwise it asserts.
Why didn't we see this happen before ? This was revealed by the emergency saves that Richard introduced in the Buffer dtor.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31062 a592a061-630c-0410-9148-cb99ea01b6c8
Use this function in closeBufferAll, and use closeBuffer to hide the buffer. Now, closeBuffer will decide whether we need to save the buffer or not. Previously, the buffer got hidden even if it was dirty.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31059 a592a061-630c-0410-9148-cb99ea01b6c8
In setCurrentWorkArea d.current_work_area_ is used which is invalidated by deleting the TabWorkArea.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31054 a592a061-630c-0410-9148-cb99ea01b6c8
The problem is that all toolbars are deleted and thus also the LayoutBox, which I made a member of GuiView.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31051 a592a061-630c-0410-9148-cb99ea01b6c8