Commit Graph

100 Commits

Author SHA1 Message Date
Jean-Marc Lasgouttes
a756403301 "Performance" fixes suggested by cppcheck
While cppcheck did not turn out any suspicious error messages, using
the "performance" flag highlighted several nitpicks in three categories
 * do not use it++ for iterators, ++it is better
 * do not use size() to test for emptyness, empty() is here
 * do not use "const T" as a function parameter, "const & T" is better

I doubt that any of these is a real performance problem, but the code is cleaner anyway.
2012-05-28 22:42:44 +02:00
Vincent van Ravesteijn
3c0e3c16c8 Fix bug #8078: Assertions in xhtml output on Windows 2012-04-30 12:58:32 +02:00
Richard Heck
7c5f28ad26 The logic of the endParagraph() routine is wrong. We should first
check if the parsep_tag is pending.
2012-04-08 10:05:44 -04:00
Richard Heck
8dd436b7dc We need to check, in closeFontTags(), for the case where we haven't
had any content.
2012-04-08 10:05:44 -04:00
Richard Heck
29cf7af6d3 The isTagOpen() routine can be const. 2012-04-08 10:05:44 -04:00
Richard Heck
313c9e0e5a Debugging code for the tag stack, disabled by default. 2012-04-08 10:05:43 -04:00
Richard Heck
d78560832a Fix error output for XHTML a bit. 2012-04-03 18:13:59 -04:00
Richard Heck
b3475e9fac Fix bug #7634. Make sure we clear the tag deque if we are keeping
empty paragraphs.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@39152 a592a061-630c-0410-9148-cb99ea01b6c8
2011-06-20 15:55:41 +00:00
Richard Heck
7d9b8a464f Fix bug #7463: XHTML View>Source now shows only the paragraph with the
cursor. Fix is fairly simple.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38572 a592a061-630c-0410-9148-cb99ea01b6c8
2011-05-03 14:05:42 +00:00
Richard Heck
e0bc4efcff Revert r38431 for now, at least. Thanks to Enrico for pointing out
why that is a good idea.



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38451 a592a061-630c-0410-9148-cb99ea01b6c8
2011-04-19 00:50:24 +00:00
Richard Heck
5d60eea4ba Now how do you think that happened?
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38433 a592a061-630c-0410-9148-cb99ea01b6c8
2011-04-18 02:23:09 +00:00
Richard Heck
c8c5ae29aa Remove pointless variable.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38432 a592a061-630c-0410-9148-cb99ea01b6c8
2011-04-18 02:11:24 +00:00
Richard Heck
1cdd1dc0c0 Remove pointless variable.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38431 a592a061-630c-0410-9148-cb99ea01b6c8
2011-04-18 01:49:23 +00:00
Pavel Sanda
6df859f35a Fix compilation, Richard please check this.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38222 a592a061-630c-0410-9148-cb99ea01b6c8
2011-04-03 08:02:08 +00:00
Richard Heck
a673aa3428 The mechanism for closing font tags at the end of a paragraph was
throwing errors in the case where we are inside a charstyle that itself
uses a font tag, e.g., strong from the logical markup module. This at
least gets rid of most of the errors, and doesn't seem to cause any
other problems.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38220 a592a061-630c-0410-9148-cb99ea01b6c8
2011-04-03 01:56:20 +00:00
Richard Heck
8165e63acf More font tags.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38217 a592a061-630c-0410-9148-cb99ea01b6c8
2011-04-03 00:03:10 +00:00
Richard Heck
ff782f993a Style.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38186 a592a061-630c-0410-9148-cb99ea01b6c8
2011-04-01 19:27:30 +00:00
Richard Heck
461c973d62 Clean up XHTML output a bit.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38185 a592a061-630c-0410-9148-cb99ea01b6c8
2011-04-01 19:18:25 +00:00
Vincent van Ravesteijn
5846e0eb7b Compile fix for r36670.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@36672 a592a061-630c-0410-9148-cb99ea01b6c8
2010-12-03 02:42:25 +00:00
Richard Heck
a81bf77314 Change the escaping mechanism for XHTML output and so allow a fix for
bug #7061.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@36455 a592a061-630c-0410-9148-cb99ea01b6c8
2010-11-24 15:27:36 +00:00
Richard Heck
0940cd77d4 Better way of doing these checks, suggested by Enrico.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@36356 a592a061-630c-0410-9148-cb99ea01b6c8
2010-11-17 22:17:53 +00:00
Richard Heck
4bf281106b Be more careful here about isalpha and isalnum. Per Enrico's suggestion,
we first do a range test, then check the status. I think this is right
in both cases.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@36351 a592a061-630c-0410-9148-cb99ea01b6c8
2010-11-17 21:19:01 +00:00
Richard Heck
680b6e78e4 Fix bug #6953.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35673 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-17 18:46:35 +00:00
Pavel Sanda
eaf1e371c7 Revert 35400 for the time being, crashes here.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35402 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 20:32:58 +00:00
Richard Heck
c4c210cc6e Minor simplification.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35400 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 17:33:15 +00:00
Richard Heck
ca9ff9e430 Allow alignment customization in environments.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35399 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 17:32:05 +00:00
Richard Heck
3c08472b0c Allow alignment customization in environments.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35398 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 17:29:51 +00:00
Richard Heck
64241a6d6d Add XHTMLStream::operator<<(char). Failure to have it was causing things
like:
	xs << ' ';
to send an int. 

32, Pavel.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35397 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 17:19:29 +00:00
Richard Heck
b743c226ca Handle forced alignments, at least in ordinary paragraphs.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35395 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 14:42:50 +00:00
Richard Heck
a5e4f310fe Add alignment to default CSS.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35392 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 14:06:36 +00:00
Richard Heck
4528307de6 Fix HTMLLabelFirst handling in non-list environments. Simplify code,
while we're at it.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35380 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 12:08:00 +00:00
Pavel Sanda
a5cb2afc1b Next headers
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33976 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-31 19:38:05 +00:00
Richard Heck
3794f7c753 Use cached label.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33136 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-21 18:55:02 +00:00
Richard Heck
b18bfcf3cc Kill a (public) magic boolean.
The point of this will become clear shortly. I hope.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33133 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-21 18:46:20 +00:00
Richard Heck
0568e46eea Proper output of counters in appendix.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33121 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-20 21:20:30 +00:00
Richard Heck
caa4e94bf0 Get rid of some magic booleans in updateLabels() and related routines.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33110 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-20 19:42:12 +00:00
Richard Heck
cf086092e2 Add a FIXME.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33102 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-19 22:51:20 +00:00
Richard Heck
4600e6c0b8 Remove half a comment?
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33101 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-19 22:29:52 +00:00
Richard Heck
3e654186d2 Move the StartTag, EndTag, and CompTag classes into the html namespace.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33099 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-19 22:08:04 +00:00
Richard Heck
59c04f7096 The fortoc argument I introduced earlier should all along have gone into
OutputParams. So now it is there.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33044 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-14 22:24:43 +00:00
Richard Heck
22b1ef0295 Don't access empty iterators.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33033 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-14 17:10:40 +00:00
Richard Heck
2e349ff103 This sorts the index entries and writes each one's tags together, like:
AMS Math 1, 2, 3
where the numbers are links.

The only thing left to do here is to parse the index entries so that we
can do something with "this ! that" and similar things.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33001 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-12 21:06:55 +00:00
Richard Heck
5214a9271c Unnecessary whitespace is bad in XHTML.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@32888 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-08 18:13:07 +00:00
Richard Heck
c216adead9 Whitespace.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@32804 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-06 20:13:07 +00:00
Richard Heck
175973629b Move into proper scope.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@32803 a592a061-630c-0410-9148-cb99ea01b6c8
2010-01-06 20:12:54 +00:00
Richard Heck
673858b182 These add extra whitespace where we don't want it.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@32529 a592a061-630c-0410-9148-cb99ea01b6c8
2009-12-14 16:45:11 +00:00
Richard Heck
f162067a61 Now how do you think that happened?
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@32463 a592a061-630c-0410-9148-cb99ea01b6c8
2009-12-10 20:11:46 +00:00
Richard Heck
ffe73b795b Initial work for InsetTOC. This does actually write a TOC, but without
any links. That is the next step.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@32459 a592a061-630c-0410-9148-cb99ea01b6c8
2009-12-10 18:30:48 +00:00
Vincent van Ravesteijn
e6d1759340 CitationUI and InsetMathChar:
squeeze warnings

output_xhtml:
  fix whitespace

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@32380 a592a061-630c-0410-9148-cb99ea01b6c8
2009-12-07 01:28:14 +00:00
Richard Heck
5e440ef668 Only step counters we have.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@32292 a592a061-630c-0410-9148-cb99ea01b6c8
2009-12-03 19:35:31 +00:00