25063 Commits

Author SHA1 Message Date
Juergen Spitzmueller
e20389ed6b UI improvement to math matrix dialog, suggested by magistere (#11888) 2020-06-11 17:29:37 +02:00
Jean-Marc Lasgouttes
f01c23bd5a Fixup d207e85c: paint sublabel with the correct background color
The above mentionned patch did paint the background of the sublabel to
avoid "bold-like" effect. However the correct backgound color is the
row's one, not the inset's one.

To fix this, extend MetricsInfo::backgroundColor to work when no inset
is specified. The code is also simplified as in master.

(cherry picked from commit 74540c9896892b8f956f52258a59613af83a5cf8)
(cherry picked from commit a71b96ac426438abb4fe835d0ad000c769693421)
2020-06-07 14:25:48 +02:00
Richard Kimberly Heck
774bbbe1b6 Fix bug #11405.
We don't actually prevent hidden buffers from being dirty, so we need
to save them if they are.

(cherry picked from commit b2517d60b8d05ad68c007e120e3b10059d043845)
2020-06-05 15:48:44 -04:00
Richard Kimberly Heck
a355cd82c2 Fix bug #10316.
By sending the request through the usual dispatch machinery, we
make sure the cursor is valid when we're done.

(cherry picked from commit e5b6be0712a245901ec54aee44da45db77594382)
2020-06-05 15:45:07 -04:00
Jean-Marc Lasgouttes
0fde27465d Fix first draw of auto-open inset
note-next and reference-next should trigger an update so that metrics
are updated when the cursor ends up in an auto-open inset.

Fixes bug #11870.

(cherry picked from commit 7761e1317eaa2c880446f05b707b03067d665681)
2020-06-05 15:40:44 -04:00
Richard Kimberly Heck
092bc93903 Update lyx-build script and add header file for Windows. 2020-06-01 16:10:47 -04:00
Richard Kimberly Heck
96dea61f22 Internal buffers are valid 2020-06-01 12:25:07 -04:00
Juergen Spitzmueller
2975a869d4 update tex2lyx tests after d13e3193b32ec 2020-05-30 09:32:10 +02:00
Juergen Spitzmueller
d13e3193b3 tex2lyx: reset language after polyglossia lang environment has been closed
Fixes #11878

(cherry picked from commit 5b2479176b0bb8bc3e9a2946e15922e0623e120e)
2020-05-26 17:49:17 +02:00
Juergen Spitzmueller
89d42a68f5 Disable bookmarksopenlevel SL when bookmarksopen is false
Fixes #11289

(cherry picked from commit f2243a3bc72b896ac0dad3499d60c47b9bd4e251)
2020-05-18 09:15:56 +02:00
Richard Kimberly Heck
1741eb9c2c Fix bug #11456.
Add cancel button and take no action if we're canceled.

(cherry picked from commit 2de99c5dd9ebdc47f7f569ddf71e44557745f413)
2020-05-18 00:30:13 -04:00
Juergen Spitzmueller
af4e5aefe0 Check class options for uncodable glyphs
Fixes #11865

(cherry picked from commit 11dc817e9d13ab065908d99ba6dd5f0b9b4f6e64)
2020-05-16 09:05:36 +02:00
Juergen Spitzmueller
991ef3840e Assign InsetBibtex to appropriate toc level
Fixes #11863

(cherry picked from commit 92ba05c53b572de0be27c66818a6e10ee6719280)
2020-05-16 09:02:55 +02:00
Juergen Spitzmueller
119d38bedf Move \PassOptionsToPackage before the first package loaded
Fixes #11862

(cherry picked from commit 2663e3845e6cc33ec543510aec16c7a37841e26d)
2020-05-14 09:18:16 +02:00
Richard Kimberly Heck
94c2466c4c Fix bug #11864 2020-05-13 14:44:08 -04:00
Scott Kostyshak
7a158055fe Only set dummy X11 selection if we do not own it
Before, we would continually set the selection to the empty string,
to maintain ownership. This causes problems with clipboard managers
GPaste and CopyQ. Further, in theory this should have better
performance since checking ownership should be faster than setting.

A disadvantage of this change is that the timestamp of the selection
will be old at this point in the code. However, when the selection
is requested, we put the selection contents at that point so the
selection timestamp should be accurate then. Further, the selection
contents are not accurate at this point in the code (they are just
the empty string), so it is not clear whether having an accurate
timestamp is beneficial.

Fixes #11715.

(cherry picked from commit af4ee1a487c4d899b71df02ba57c2f024fea6786)
(cherry picked from commit 23abb5aaa36af07aadfa5e565869104778ba0d6d)
2020-05-06 08:29:00 -04:00
Juergen Spitzmueller
584550a732 Remap typographical apostrophe from Hunspell to plain apostrophe (#11832)
(cherry picked from commit ca28c9866a916494c6613076842aa32e8d572c37)
2020-05-04 23:40:18 -04:00
Richard Kimberly Heck
b4e613828e Fix bug #11787.
Make sure we are actually at the end of the document before issuing
\maketitle because we are at the end of the document.

(cherry picked from commit 7af6575cf6cd764b8b567b358907ac9a7a8e322b)
2020-05-04 23:30:52 -04:00
Jean-Marc Lasgouttes
e47834104a Adopt a 'belt and braces' approach to bidi forcing
There are two techniques that I know of for forcing the direction of a
string, regardlessly of whether its contents is naturally LtR, RtL or
undecided.

1/ The unicode LTR/LTR override characters. This is supposed to be the
   clean way, however, it does not seem to work with Qt 5.14 (see
   #11691).

2/ The undocumented QTextLayout::setFlags method. This is used
   internally and allows to pass the (undocumented) flags
   Qt::TextForceRightToLeft and Qt::TextForceLeftToRight. This was
   used until we had issues with Qt 5.11 (see #11284).

In order to get the best of both worlds, this patch allows to enable
those two methods separately, and actually enables both at the same
time by default!

Fixes bug #11691.

(cherry picked from commit 4d6041a7b68de5856b657cfd3b735596b3d7e0e0)
2020-04-29 22:55:25 +02:00
Juergen Spitzmueller
a80ecb3820 Improve reporting of undefined control sequences in preamble
Fixes #11844

(cherry picked from commit 05c7c65d9345c4cd88b9c34b8e30beb96a268963)
2020-04-19 17:32:33 +02:00
Juergen Spitzmueller
f3f0b53ba6 Reset failedtoload_ bool when include inset params are changed (#11842)
(cherry picked from commit d9b884341c6c8a3addb95071bc0f203519bfbe0d)
2020-04-18 07:59:23 +02:00
Juergen Spitzmueller
e41c790f91 Fix tablefootnote loading order (#11841)
(cherry picked from commit 5bc66b5f4564633d1c87fb6b00e0700d5aa1bca2)
2020-04-18 07:40:45 +02:00
Jean-Marc Lasgouttes
8bb317c8db Fix embarassing crash caused by debug message
After commit 6a936d63, the helpful debug message tries to display
non-existing elements and crashes the program :(

Fix by radical simplification of the message.

Part of bug #11777.

(cherry picked from commit b5d6caac4149cc72cd5a734ffc8e9da1382bc9ee)
2020-04-17 10:41:50 +02:00
Jean-Marc Lasgouttes
cc5d3bd9f4 Do not try to put cursor after space if no space was kept
The logic was wrong and could cause crashes

Fixes bug #11777.
2020-04-17 10:40:54 +02:00
Richard Kimberly Heck
f293de29d9 Make it nicer, thanks to JMarc
(cherry picked from commit 86a4c79dc4002344fba9ebe28c5cd8574f55845c)
2020-04-16 21:12:30 -04:00
Richard Kimberly Heck
d1feeaaf2d Fix bug #11635
(cherry picked from commit 46f1f6f1cbf2ddb4de8c4d96e76e3a1bd74f2e07)
2020-04-16 17:20:14 -04:00
Jean-Marc Lasgouttes
b7f6b979d0 Do not compute caret geometry when we are not ready to do so.
This avoid crashes with invalid cache.

Fixes bug #11763.
2020-04-09 12:51:38 +02:00
Richard Kimberly Heck
1264934898 Fix bug #11817.
Preserve line spacing when breaking a paragraph at the beginning.

(cherry picked from commit f7065fa22ece25f72107dfa9c78e21a250153514)
2020-04-08 17:28:10 -04:00
Juergen Spitzmueller
97516cf2f4 Fix quotation marks in PDF TOC
(cherry picked from commit c0adb03a7ae15cf6409ee3cb64f4cc91c24c052e)
2020-04-06 16:41:21 +02:00
Juergen Spitzmueller
aede56fa20 Strip polyglossia options from pdf string
Fixes #11813

(cherry picked from commit f9999039ac7278a719513fdd15c34f12846a1189)
2020-04-05 17:29:04 +02:00
Juergen Spitzmueller
3d0dd488c3 Disable append-column with gathered
Fixes #11812

(cherry picked from commit ed137ee435ea2e9e1d38b6095e8ce51c0c48204a)
2020-04-05 17:18:15 +02:00
Jean-Marc Lasgouttes
ee7c607b5e Avoid bleeding of inset background outside of inset
As a consequence of fix e64ea357 to ticket #10797, we draw a bit too
much of the inset background outside of the inset (visible for insets
with colored background). #10797 is a ticket that triggers when the
cursor has a width larger than 1.

This patch limits the problems in two respects

* nothing is done on the left, since the cursor width only expands on
  the right.

* on the right, the extra width is limited to cursor width.

Fixes bug #11786.

(cherry picked from commit eb92f74d1f7ae63112b9439058d746f7ff93e8f4)
2020-04-03 19:02:29 +02:00
Richard Kimberly Heck
df2abff913 Remove newlines from shortcut LFUNs.
(cherry picked from commit c5c16830242aa120448b2a226107073ef1703b1d)
2020-03-28 15:26:40 -04:00
Juergen Spitzmueller
76e71c5fdd Add hint to warning.
(cherry picked from commit 957e8669c74b45542606d8271ef49d592a3704f1)
2020-03-26 07:52:37 +01:00
Juergen Spitzmueller
ee69752d61 Fix warning message
(cherry picked from commit c77be6146bceab43b5bd9d1ed67ab054b3e0121e)
2020-03-26 07:52:22 +01:00
Juergen Spitzmueller
e1c29a0510 Check character encodability with pass-thru in command insets
Fixes: #11584
(cherry picked from commit ebc2b1295a0464dde6c20a09ddc249c463a21c79)
2020-03-26 07:52:01 +01:00
Juergen Spitzmueller
cca83a320b Don't omit ZERO WIDTH NON-JOINER on clipboard paste
Fixes #11790

(cherry picked from commit 7b3404fcab0e2530964444261d411814c03eaeba)
2020-03-23 17:25:04 +01:00
Richard Kimberly Heck
7c0cbe68bc Fix bug #11748.
Track the last chosen citation style when we clear the entries.

(cherry picked from commit 64f7da961a853f4ea60716129f0f22f39e451aa7)
2020-03-17 02:01:37 -04:00
Richard Kimberly Heck
429d2171b1 Fix bug #11780.
The preamble snippets are for LaTeX and do not need to be output
with HTML.

(cherry picked from commit f044d3a3595912415806707582e8aa6b0890bbe7)
2020-03-14 19:19:04 -04:00
Juergen Spitzmueller
48cb1aa3b7 Fix UI quirk in IncludeOnly settings
Fixes #11564

(cherry picked from commit b568a49593b6d52f267d8fcfbc0a46dc7ecb613d)
2020-03-13 08:45:45 +01:00
Richard Kimberly Heck
2ece10f327 Fix problem with validation when using InsetLayout.
(cherry picked from commit 2e444dd6570804d33c1fd44713dc3b3f15ec9c5c)
2020-02-26 22:30:34 -05:00
Richard Kimberly Heck
0be206c976 Fix bug #11737.
We need to use the FileName methods when moving or removing a file,
so that refresh() gets called.

No status entry since this will be in 2.3.4.3.

(cherry picked from commit d93091389896cddcd83de83dfd4ee8a9b4e9c7f1)
2020-02-13 00:06:17 -05:00
Stephan Witt
058283515a Fix a crash with uninitialized buffer member of MathData
See the details here: https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg210294.html
2020-02-08 16:33:51 +01:00
Juergen Spitzmueller
6617d492e8 Properly resize columns of child document table widget 2020-02-08 09:27:21 +01:00
Juergen Spitzmueller
b2604aa840 Fix encoding inheritance with CJKUtf8 as custom document encoding
Fixes #11579
2020-02-07 16:18:47 +01:00
Richard Kimberly Heck
e60d5df4b3 Don't need to remove the file if it doesn't exist. (This would cause a five second delay in that case.)
(cherry picked from commit 5188f0fcff49bbbee35193c25b726425c8c02287)
2020-02-06 13:54:13 -05:00
Juergen Spitzmueller
b0a2868938 Ignore geometry-related settings if the class provides geometry
Fixes #11724

(cherry picked from commit dce9e44a1421350f275c9a3131f7e0532477c3a6)
2020-01-29 16:06:44 +01:00
Enrico Forestieri
15949fc99a Fix bug #11716
Force closing and reopening of \lyxdeleted after deleted
display math so that the following deleted text can be
correctly striked out.
2020-01-27 11:21:26 +01:00
Juergen Spitzmueller
81af6062cb Fix backspace deletion of selected items with change tracking
Move cursor at beginning of selection after deletion. Else backspace
operation gets stuck in a loop (tries to remove the selection again
and again).

This also fixes backspace deletion of insets with confirmDeletion() == true.

Fixes #11630

(cherry picked from commit adfd38e4efd1180df164fa2c75cf15210f366e94)
2020-01-27 08:42:11 +01:00
Juergen Spitzmueller
2deabd0fbd Fix issues with tilde in inputpath
Fixes #11699

(cherry picked from commit a426b33067ae4e9d5452f13284f3e223d87ac45d)
2020-01-27 08:32:11 +01:00