While cppcheck did not turn out any suspicious error messages, using
the "performance" flag highlighted several nitpicks in three categories
* do not use it++ for iterators, ++it is better
* do not use size() to test for emptyness, empty() is here
* do not use "const T" as a function parameter, "const & T" is better
I doubt that any of these is a real performance problem, but the code is cleaner anyway.
- rename [add|remove]Item(unit) to [add|remove]Unit(unit)
- remove now unnecessary reimplemantations of QComboBox functions
- new member setCurrentItem(QString)
* GuiBox.cpp:
- set ItemData for special lengths, which simplifies the logic a lot.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@28152 a592a061-630c-0410-9148-cb99ea01b6c8
- use model/view infrastructure to store reliable data
- use real unit name, not i18n strings, for all comparision purposes
- remove unit "mu" in default contruction (bug 5682)
- add some helpers to add and remove units
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@28146 a592a061-630c-0410-9148-cb99ea01b6c8
