1. When a listing is inserted in a bit of text, the line above the listing is not drawn over the full width like it is done for lines above other insets. This is because InsetListing has a AlignLeft alignment. Now, if you start selecting downwards with the mouse in this empty area, strange selection drawings appear (see attachment).
This is caused by the fact that starting your selection at such a place, causes beg.boundary() to be true in TextMetrics::drawRowSelection(..). This is correct, but this value is true for _all_ selected lines. Now, the selection acts as if it is RTL text. Therefore, just like for end.boundary, this value needs to be reset for every line.
2. Starting your selection in an end margin often causes the selection in this end margin to be painted later. This is because when starting your selection in an end margin, you may have set a (possible empty) selection before really selecting the end margin. The problem is that the checksum (computed later) is the same for this empty selection and for the end margin selection. Therfore, we need a call to cur.setSelection() before evaluating cur.selection().
3. In the following two lines, it is assumed that there is only an end margin to be painted if the selection extends to the next paragraph. This is not true for the above described case of an AlignLeft Inset. Then, the margin has also be drawn within a paragraph
4. The end and begin margins are only painted when the selection extends into the following or previous paragraph. This difference is not resembled in the checksum if you first select a row completely and then procede to the next or previous paragraph as the selection remains at the end of a row. This also holds for the AlignLeft case. Therefore I added a term to the checksum to monitor whether the end and begin margins need to be drawn.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26399 a592a061-630c-0410-9148-cb99ea01b6c8
anchor is incorrectly set to be equal to the cur. This is because comparing two
CursorSlices does not take into account the boundary property (because the
CursorSlice does not know this).
Patch by Vincent.
http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg143572.html
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26393 a592a061-630c-0410-9148-cb99ea01b6c8
sort of repaint, because if the selection is adjusted, we may have to draw the
selection again.
Patch by Vincent.
http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg143572.html
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26392 a592a061-630c-0410-9148-cb99ea01b6c8
- a hopefully somewhat clearer description of what valign is supposed to do.:
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26382 a592a061-630c-0410-9148-cb99ea01b6c8
* src/Inset.h:
- new member content Alignment that indicates whether the content
of text insets should be displayed with a specific alignment
* src/TextMetrics.cpp:
- handle inset's contentAlignment
* src/insets/InsetTabular.{cpp,h}:
- set contentAlignment for tabular cells.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26380 a592a061-630c-0410-9148-cb99ea01b6c8
pair of uninitialized variables. The reason the crash doesn't happen when
you open the User Guide is that they get set in TocModel::populate() before
the slider's maximum value is fixed. It was setting that value to some huge
number that caused the problem.
I've added an assertion to make sure we don't run into this kind of problem
again. Probably not necessary, but it can't hurt.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26356 a592a061-630c-0410-9148-cb99ea01b6c8
Introduce OutputParams::inTableCell, to track when we are in a table cell.
Use this information to output \newline rather than \\ when in one.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26349 a592a061-630c-0410-9148-cb99ea01b6c8
I've left mathbf in the symbols file. We should perhaps restore it as something that can be toggled.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26348 a592a061-630c-0410-9148-cb99ea01b6c8
- Texts that are entered in the search and replace fields of the
GuiSearch dialog are added to the bottom of the ComboBox. With this
patch they are added to the top as it probably most intuitive.
(patch from Vincent)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26346 a592a061-630c-0410-9148-cb99ea01b6c8
- The GuiRef dialog does not respond to keyboard events if the
reference list is empty. This is because the reference list has the
focus proxy and is disabled when the list is empty. Therefore I removed
the focus proxy from the list if it is disabled.
(patch from Vincent)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26345 a592a061-630c-0410-9148-cb99ea01b6c8
