lyx_mirror/src/frontends/qt4
Vincent van Ravesteijn 0faafa47bf Fix bug #5082: Outline visibility not remembered.
When a document with a InsetTOC was closed, the outline was closed. But this shouldn't happen because editedInset("toc") does never return something.

The reason that this happened was that if currentBufferView() is 0, we don't even care wehther inset was specified. If inset is specified, it should match the editedInset.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37094 a592a061-630c-0410-9148-cb99ea01b6c8
2011-01-03 23:23:09 +00:00
..
ui lyx_pot.py cannot deal with raw newlines in ui files. So, use the 2010-12-28 23:29:51 +00:00
Action.cpp * FuncStatus: unify naming of functions. 2010-04-16 10:51:20 +00:00
Action.h
BulletsModule.cpp
BulletsModule.h
ButtonController.cpp
ButtonController.h
ButtonPolicy.cpp Revert r35760, as suggested by Vincent. 2010-10-21 19:33:29 +00:00
ButtonPolicy.h fix compiler warnings in pedantic mode: remove trailing comma after last enum member 2010-12-17 19:56:51 +00:00
ColorCache.cpp Set url color from system theme. 2010-09-09 13:04:02 +00:00
ColorCache.h Finish implementation of "use system colors" checkbox. 2010-08-09 12:15:02 +00:00
CustomizedWidgets.cpp
CustomizedWidgets.h
Dialog.cpp Dialog::bufferFilepath -> Dialog::bufferFilePath 2010-04-21 01:19:30 +00:00
Dialog.h Fix bug #6451 (last part): Crash when interacting with buffer-dependent dialog with no buffer open. 2010-04-26 02:12:10 +00:00
DialogView.h DialogView: make GuiView the parent widget to partly solve bug #6710. 2010-10-21 13:40:49 +00:00
DockView.h Fix bug #3871: Shortcut to switch from TOC to text pane. 2010-04-26 10:03:09 +00:00
EmptyTable.cpp
EmptyTable.h
FileDialog.cpp Proper camel case for FileName.absFilename 2010-04-21 01:19:09 +00:00
FileDialog.h
FindAndReplace.cpp Fix bug 7137: Main WA disappears on wrap-around dialog. 2011-01-03 20:04:03 +00:00
FindAndReplace.h hopefully fix the (re)sizing of the adv search/replace 2010-03-27 17:37:41 +00:00
FloatPlacement.cpp More include frenzy. 2010-10-31 01:04:03 +00:00
FloatPlacement.h InsetParamsWidget(): fix method constness. 2010-02-18 07:56:38 +00:00
GuiAbout.cpp Proper camel case for FileName.absFilename 2010-04-21 01:19:09 +00:00
GuiAbout.h
GuiAlert.cpp Typo. 2010-10-22 17:08:57 +00:00
GuiApplication.cpp Revert r36465 and r36467. Soon to be replaced by proper code for correctly 2011-01-01 19:19:32 +00:00
GuiApplication.h typo 2010-11-04 15:35:12 +00:00
GuiBibitem.cpp Remove the name parameter from string2params and params2string. We can always derive the name with insetName(params.code()). 2010-10-29 00:25:28 +00:00
GuiBibitem.h Migrate GuiBibitem to InsetParamsWidget. 2010-02-23 21:24:24 +00:00
GuiBibtex.cpp Remove the name parameter from string2params and params2string. We can always derive the name with insetName(params.code()). 2010-10-29 00:25:28 +00:00
GuiBibtex.h
GuiBox.cpp remove unused include of FuncRequest 2010-08-24 03:07:09 +00:00
GuiBox.h * GuiBoc.{cpp,h}: 2010-06-26 07:57:54 +00:00
GuiBranch.cpp Migrate Branch dialog to InsetParamsWidget 2010-02-19 20:57:25 +00:00
GuiBranch.h Migrate Branch dialog to InsetParamsWidget 2010-02-19 20:57:25 +00:00
GuiBranches.cpp BranchList: 2010-04-21 01:19:35 +00:00
GuiBranches.h Fix unnecessary dependencies on GuiDocument.h. 2010-07-12 21:42:25 +00:00
GuiChanges.cpp
GuiChanges.h
GuiCharacter.cpp
GuiCharacter.h
GuiCitation.cpp Towards a proper fix for bug #6846, this just disentangles a couple 2010-12-03 19:00:55 +00:00
GuiCitation.h
GuiClipboard.cpp Fix bug #6538 (Figure: relative path changed to absolute on copy/paste) 2010-12-11 23:04:24 +00:00
GuiClipboard.h Fix bug #6538 (Figure: relative path changed to absolute on copy/paste) 2010-12-11 23:04:24 +00:00
GuiCommandBuffer.cpp Seems boost also includes all std headers. Not including boost therefore produces errors. 2010-04-22 11:45:34 +00:00
GuiCommandBuffer.h
GuiCommandEdit.cpp
GuiCommandEdit.h
GuiCompare.cpp Turn on sliding when starting comparison 2010-09-08 15:12:55 +00:00
GuiCompare.h Some cosmetics (from my local cosmetics branch). 2010-10-18 14:20:03 +00:00
GuiCompareHistory.cpp Ui glitches 2010-09-07 11:58:42 +00:00
GuiCompareHistory.h These things need to be updated for each dialog opening 2010-09-07 11:29:05 +00:00
GuiCompleter.cpp Fix part of bug #7072 by opening undo groups as needed. 2010-11-29 16:38:13 +00:00
GuiCompleter.h remove unused include of FuncRequest 2010-08-24 03:07:09 +00:00
GuiDelimiter.cpp * GuiDelimiter.cpp: disable cut and paste inside the listviews (bug 6942). 2010-10-15 07:12:49 +00:00
GuiDelimiter.h
GuiDialog.cpp remove unused include of FuncRequest 2010-08-24 03:07:09 +00:00
GuiDialog.h Fix bug #6451 (last part): Crash when interacting with buffer-dependent dialog with no buffer open. 2010-04-26 02:12:10 +00:00
GuiDocument.cpp * GuiDocument.cpp (paramsToDialog): 2010-12-11 15:28:02 +00:00
GuiDocument.h Rename a bunch of BufferParams to conform to our usual style. 2010-11-26 18:32:29 +00:00
GuiErrorList.cpp Whitespace. 2010-10-14 20:49:34 +00:00
GuiErrorList.h Fix bug #6462: Out-of-bounds index in GuiErrorList::goTo when new buffer is active. 2010-03-12 15:06:13 +00:00
GuiERT.cpp remove unused include of FuncRequest 2010-08-24 03:07:09 +00:00
GuiERT.h InsetParamsWidget(): fix method constness. 2010-02-18 07:56:38 +00:00
GuiExternal.cpp Dialog::bufferFilepath -> Dialog::bufferFilePath 2010-04-21 01:19:30 +00:00
GuiExternal.h
GuiFontExample.cpp
GuiFontExample.h
GuiFontLoader.cpp Add some extra information about bug #3684. 2010-12-29 05:50:50 +00:00
GuiFontLoader.h
GuiFontMetrics.cpp Fix bug #7187: Font painting problems with emulated scaling. 2010-12-29 05:35:03 +00:00
GuiFontMetrics.h
GuiGraphics.cpp Disentangle various "in"s 2010-11-30 00:55:34 +00:00
GuiGraphics.h
GuiGraphicsUi.h
GuiHSpace.cpp remove unused include of FuncRequest 2010-08-24 03:07:09 +00:00
GuiHSpace.h Migrate GuiHSPace to InsetParamsDialog. 2010-02-21 09:28:33 +00:00
GuiHyperlink.cpp Fix assert in all InsetParamsWidget's for unicode characters (bug #7017) 2010-11-07 17:38:39 +00:00
GuiHyperlink.h Migrate GuiHyperlink to InsetParamsDialog. 2010-10-27 17:02:42 +00:00
GuiIdListModel.cpp
GuiIdListModel.h
GuiImage.cpp Proper camel case for FileName.absFilename 2010-04-21 01:19:09 +00:00
GuiImage.h
GuiInclude.cpp Remove the name parameter from string2params and params2string. We can always derive the name with insetName(params.code()). 2010-10-29 00:25:28 +00:00
GuiInclude.h fix compiler warnings in pedantic mode: remove trailing comma after last enum member 2010-12-17 19:56:51 +00:00
GuiIndex.cpp
GuiIndex.h
GuiIndices.cpp
GuiIndices.h Fix unnecessary dependencies on GuiDocument.h. 2010-07-12 21:42:25 +00:00
GuiInfo.cpp More include frenzy. 2010-10-31 01:04:03 +00:00
GuiInfo.h InsetParamsWidget(): fix method constness. 2010-02-18 07:56:38 +00:00
GuiKeySymbol.cpp Fix #6966. 2010-10-23 20:17:41 +00:00
GuiKeySymbol.h
GuiLabel.cpp Fix assert in all InsetParamsWidget's for unicode characters (bug #7017) 2010-11-07 17:38:39 +00:00
GuiLabel.h Revert r35933. There are insets not based upon InsetCommand, such as 2010-10-31 18:56:32 +00:00
GuiLine.cpp fix typo: double semicolon at line end of code 2010-12-21 15:28:55 +00:00
GuiLine.h GuiLine: honor Abdel as author 2010-09-17 01:32:23 +00:00
GuiListings.cpp CMake: fix merged build, seems GCC could not handle the namespaces correctly 2010-01-30 11:34:28 +00:00
GuiListings.h
GuiLog.cpp * GuiLog.cpp: refine warning detection: 2010-08-02 16:38:41 +00:00
GuiLog.h
GuiMathMatrix.cpp This should be fixed. 2010-11-13 23:01:30 +00:00
GuiMathMatrix.h GuiMathMatrix: 2010-09-24 03:44:34 +00:00
GuiNomenclature.cpp Fix assert in all InsetParamsWidget's for unicode characters (bug #7017) 2010-11-07 17:38:39 +00:00
GuiNomenclature.h GuiNomencl.xxx: Rename to be in line with class name. 2010-10-27 20:05:38 +00:00
GuiNote.cpp
GuiNote.h
GuiPainter.cpp GuiPainter.cpp: correct attempt from r35491 2010-09-25 14:14:50 +00:00
GuiPainter.h use one place to adjust width of thin lines 2010-09-07 05:14:57 +00:00
GuiParagraph.cpp
GuiParagraph.h
GuiPhantom.cpp
GuiPhantom.h
GuiPrefs.cpp Fix UI glitch in the prefs dialog (bug 7190). 2011-01-03 17:21:22 +00:00
GuiPrefs.h Fix UI glitch in the prefs dialog (bug 7190). 2011-01-03 17:21:22 +00:00
GuiPrint.cpp Dialog::bufferFilepath -> Dialog::bufferFilePath 2010-04-21 01:19:30 +00:00
GuiPrint.h
GuiPrintindex.cpp Remove the name parameter from string2params and params2string. We can always derive the name with insetName(params.code()). 2010-10-29 00:25:28 +00:00
GuiPrintindex.h
GuiPrintNomencl.cpp Migrate GuiPrintNomencl to InsetParamsDialog. 2010-10-30 20:14:57 +00:00
GuiPrintNomencl.h Revert r35933. There are insets not based upon InsetCommand, such as 2010-10-31 18:56:32 +00:00
GuiProgress.cpp Compil fix 2010-11-06 00:34:03 +00:00
GuiProgress.h don't block GUI when showing all debug messages 2010-06-07 20:25:41 +00:00
GuiProgressView.cpp fix bug #6748: queue LyXErrMessages so any other stuff is done 2010-06-03 21:24:20 +00:00
GuiProgressView.h Coding style, thanks Abdel. 2010-05-17 08:15:04 +00:00
GuiRef.cpp Remove the name parameter from string2params and params2string. We can always derive the name with insetName(params.code()). 2010-10-29 00:25:28 +00:00
GuiRef.h * GuiRef: improve filter UI 2010-01-30 11:19:48 +00:00
GuiSearch.cpp
GuiSearch.h
GuiSelection.cpp
GuiSelection.h
GuiSelectionManager.cpp fix (again) monolithic build 2010-04-08 10:23:54 +00:00
GuiSelectionManager.h Take Andre's advice and implement the focus tracking using the event 2010-03-24 14:34:44 +00:00
GuiSendto.cpp
GuiSendto.h
GuiSetBorder.cpp * GuiSetBorder.cpp: lighter colour for disabled borders (not used currently). 2010-01-31 13:15:26 +00:00
GuiSetBorder.h
GuiShowFile.cpp support: 2010-04-21 01:19:28 +00:00
GuiShowFile.h
GuiSpellchecker.cpp avoid recursive check calls triggered by updateView(); show summary and close window when forward move not possible anymore 2010-12-05 06:51:32 +00:00
GuiSpellchecker.h #6917 move forward after adding a word to personal dictionary or the list of ignored words 2010-09-28 15:09:06 +00:00
GuiSymbols.cpp
GuiSymbols.h
GuiTabular.cpp GuiTabular.cpp: typo 2010-12-10 06:25:52 +00:00
GuiTabular.h Fix #7021: the problem was that activating the border combo was triggering dialogToParams() and thus disallowed because of the empty value. 2010-12-04 10:55:03 +00:00
GuiTabularCreate.cpp
GuiTabularCreate.h
GuiTexinfo.cpp support: 2010-04-21 01:19:28 +00:00
GuiTexinfo.h
GuiThesaurus.cpp * GuiThesaurus: do not show irritating messages if nothing is to be looked up. 2010-04-20 09:59:16 +00:00
GuiThesaurus.h
GuiToc.cpp Fix bug #3871: Shortcut to switch from TOC to text pane. 2010-04-26 10:03:09 +00:00
GuiToc.h
GuiToolbar.cpp This comment introduced in r37075 was wrong. We should never end up here! 2011-01-03 15:56:27 +00:00
GuiToolbar.h Remove unused member variable GuiToolbar::name_. 2011-01-03 12:39:56 +00:00
GuiView.cpp Fix bug #5082: Outline visibility not remembered. 2011-01-03 23:23:09 +00:00
GuiView.h Fix bug #7099: Fix bug #7099: Math toolbars don't autoshow. 2011-01-03 16:49:15 +00:00
GuiViewSource.cpp Add the option to select the output format in Source View. 2010-12-10 10:34:24 +00:00
GuiViewSource.h Add the option to select the output format in Source View. 2010-12-10 10:34:24 +00:00
GuiVSpace.cpp remove unused include of FuncRequest 2010-08-24 03:07:09 +00:00
GuiVSpace.h InsetParamsWidget(): fix method constness. 2010-02-18 07:56:38 +00:00
GuiWorkArea.cpp Fix part 3 of bug #7182: LyX truncates file names to about 25 chars. 2011-01-03 18:50:37 +00:00
GuiWorkArea.h Update the cursor shape also when the cursor shape changes without a mouse move actions. 2010-10-24 22:14:31 +00:00
GuiWrap.cpp
GuiWrap.h
IconPalette.cpp correct icon size in math panels 2010-09-24 12:59:43 +00:00
IconPalette.h
InGuiThread.cpp check also if there is a QApplication instance 2010-11-01 21:32:59 +00:00
InGuiThread.h Be compatible with Qt 4.2 and 4.3 (Q_EMIT). 2010-11-03 00:38:35 +00:00
InsertTableWidget.cpp Transfer LyXfunc code to GuiApplication::dispatch() and getStatus(). Now 2010-02-09 16:11:13 +00:00
InsertTableWidget.h
InsetParamsDialog.cpp set eol-style 2010-11-18 19:50:29 +00:00
InsetParamsDialog.h set eol-style 2010-11-18 19:50:29 +00:00
InsetParamsWidget.cpp set eol-style 2010-11-18 19:50:29 +00:00
InsetParamsWidget.h set eol-style 2010-11-18 19:50:29 +00:00
LaTeXHighlighter.cpp
LaTeXHighlighter.h
LayoutBox.cpp Transfer LyXfunc code to GuiApplication::dispatch() and getStatus(). Now 2010-02-09 16:11:13 +00:00
LayoutBox.h
LengthCombo.cpp According to André, QLatin1String is cheaper. 2010-02-01 01:07:32 +00:00
LengthCombo.h
LyXFileDialog.cpp
LyXFileDialog.h
Makefile.am GuiNomencl.xxx: Rename to be in line with class name. 2010-10-27 20:05:38 +00:00
Menus.cpp Fix part 2 of bug #7182: LyX truncates file names to about 25 chars. 2011-01-03 18:44:52 +00:00
Menus.h
PanelStack.cpp
PanelStack.h
pch.h
qt_helpers.cpp TR1: use std::tr1 regex with msvc10 2010-06-29 17:09:40 +00:00
qt_helpers.h support: 2010-04-21 01:19:28 +00:00
qt_i18n.h
README
TocModel.cpp Make sure the Table of Contents is always on top in the model combobox of the TocWidget. 2010-04-26 01:36:24 +00:00
TocModel.h Make sure the Table of Contents is always on top in the model combobox of the TocWidget. 2010-04-26 01:36:24 +00:00
TocWidget.cpp Make outliner delays again more invisible in some cases. 2010-12-26 23:23:48 +00:00
TocWidget.h Attempt to workaround movement and editation slowness. 2010-12-19 22:27:21 +00:00
Toolbars.cpp Fix another instance of "visibility >= MATH". This was forgotten in r37068. 2011-01-03 12:14:44 +00:00
Toolbars.h Remove GuiToolbar::allowauto_ and define this property in the Toolbars.h::Visibility enum. 2011-01-03 11:42:01 +00:00
Validator.cpp
Validator.h

This file contains some do's and dont's for the Qt4 frontend.

General rules
-------------

Every editable field that affects the state of the dialog contents
from LyX's point of view should connect its xxxChanged() signal to
a the dialog's changed_adaptor() slot, which in turn should call
changed(). If you are using a more complicated thing anyway,
then remember to call changed() at the end (if it has changed!)

Every non-trivial widget should have a tooltip. If you don't know
what to write, write "FIXME", and it can fixed later. Don't be afraid
to use QWhatsThis too, but this must be done in the derived class's
constructor, and use _("..."). Non-trivial means that things like "OK"
/must not/ have a tooltip.

moc needs a fully qualified "std::string" for .connect() statements
to work. Be very, very careful.

Remember to check tab order on a dialog (third icon, with blue bars in
designer).

Remember to check sensible resizing behaviour on a dialog. This is
usually done by adding a top-level layout to the dialog in Designer.

Remember to use Edit->Check Accelerators

If necessary, you should override Qt2Base::isValid() for determining the
validity of the current dialog's contents.

OK/Apply/Restore/Close should be connected in the derived class's
constructor to call slotOK() etc. Refer to close/cancel as close in the
source.

Override update_contents() to update the dialog, not update().  Only
these functions may change dialog widgets that may emit changed() during
initialisation, to prevent the button controller from changing its
state.

Never call buttoncontroller functions directly from dialogs. In general,
you should use Qt2Base::changed() in all circumstances. However, if you
must call the buttoncontroller, make sure to respect Qt2Base::updating_

Naming conventions
------------------

QFoo.{cpp,h}     The file that interacts with the controller _and_
the implementation of the dialog, derived from the generated files
ui/FooDialog.ui  The designer file
ui_FooDialog.h   Generated files from FooDialog.ui

slots should be named e.g. slotFooClicked(), slotFooSelected(), where
foo is the name of the widget.

Widgets should be named like "fooXX", where XX is one of the following
widget types :

CB - check box
CO - combo box
ED - line edit
GB - group box
LA - label
LC - LengthCombo
LV - QListView
ML - QTextBrowser
PB - push button
RB - radio button
SB - spin box
SL - slider
TE - text edit
TW - tree widget (FIXME: also TV in some files)


Qt, Unicode, and LyX
--------------------

LyX uses a different encoding (UCS4) than Qt (UTF16), therefore there are a
number of conversion functions in qt_helpers.{cpp,h}. Read the doxygen
documentation for details when to use which function.

Additionally, you should follow these simple rules :

o Use qt_() not _() in code
o Use the conversion functions of qt_helpers.h, NOT .latin1() / .c_str() etc.