anne/lyx_mirror
1
0
Fork 0
mirror of https://git.lyx.org/repos/lyx.git synced 2024-12-27 06:19:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
107e105ecd
lyx_mirror/src
History
Richard Heck 2bf904ca34 Fix bug #7490. 
As the bug report notes, you do NOT get this crash if you move up or
down in the table a bit before you do the rest. The reason is that
moving up and down sets the cursor's x_target_, and it is because that
is not set that we enter the other code at all and eventually crash.
That is, in InsetTabular's dispatch, we have:

(*) cur.pos() = tm.x2pos(cur.pit(), pm.rows().size()-1, cur.targetX());

You can see the potential for trouble here already. cur.pit() is in the
NEW cell, i.e., the one to which we are moving; it was changed a few
lines previously, and cur.idx() points to the new cell, too. But we are
trying to calculate cur.pos(), which means that cur.pos() is currently
the one from the OLD cell. So the cursor is in an inconsistent state.
Calling cur.targetX() leads us to call Cursor::getPos(), and that is
what causes the crash.

We fix the problem by making sure we call targetX() on the original
cursor. The same problem clearly exists in the DOWN stuff, so we fix
that, too.

By the way, should we be setting x_target_ here once we have calculated
it?


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38530 a592a061-630c-0410-9148-cb99ea01b6c8
2011-04-26 22:41:48 +00:00
..
client Infrastructure for choosing different icon sets. This currently works 2011-03-25 01:59:34 +00:00
frontends Fix #7479 2011-04-20 20:52:53 +00:00
graphics revert r37696 and apply a fallback mechanism to pdflatex 2011-04-04 14:33:45 +00:00
insets Fix bug #7490. 2011-04-26 22:41:48 +00:00
lyxled
mathed Fix deletion of empty last row for \smallmatrix (part of bug #7484). 2011-04-22 15:06:59 +00:00
support move call stack code, add TODOs 2011-04-25 09:14:50 +00:00
tex2lyx Fix bug #7402. Many thanks to Vincent who found the wrong revision. 2011-04-11 20:11:27 +00:00
AppleSpellChecker.cpp use unique LyX language name for map to apple spell checker language 2011-02-21 06:22:37 +00:00
AppleSpellChecker.h add cache of spell checker results to speed up native speller engine on macosx 2010-09-14 05:24:04 +00:00
AspellChecker.cpp #7170 simplify the hunspell dictionary lookup; use Language::lang() instead of Language::id() as speller index 2011-02-18 11:54:14 +00:00
AspellChecker.h #7043 add the implementation of a persistent personal word list for LyX spell checker, aspell and hunspell backend 2010-12-02 18:52:31 +00:00
Author.cpp Author: cosmetics. 2010-11-17 16:12:43 +00:00
Author.h Author: cosmetics. 2010-11-17 16:12:43 +00:00
BiblioInfo.cpp Fix problem with citation dialog. The code changes here missed the need 2011-04-12 17:32:16 +00:00
BiblioInfo.h Fix output of HTML tags in bibliography info. 2010-09-15 13:50:17 +00:00
Bidi.cpp remove some explicit tests against ERT_CODE; more to come 2009-07-16 10:08:13 +00:00
Bidi.h
boost.cpp
Box.cpp
Box.h
BranchList.cpp Fix crash in lyx -e latex lib/doc/Shortcuts.lyx: theApp() is 0 in batch mode. 2011-01-06 18:40:39 +00:00
BranchList.h make branch-add-insert aware of the separator ("|") [bug #6621] 2010-06-14 13:39:08 +00:00
buffer_funcs.cpp #7357 correct the numbers by introducing two modes of word count 2011-03-18 12:50:09 +00:00
buffer_funcs.h #7357 correct the numbers by introducing two modes of word count 2011-03-18 12:50:09 +00:00
Buffer.cpp Forgot this part of r38496. See 2011-04-25 22:30:22 +00:00
Buffer.h Complete integration of texrow with otexstream and allow automatic line 2011-02-13 21:41:44 +00:00
BufferList.cpp Added possibility to retrieve internal buffers (by their tmp file-name) from the Model. 2011-02-07 20:31:09 +00:00
BufferList.h Added possibility to retrieve internal buffers (by their tmp file-name) from the Model. 2011-02-07 20:31:09 +00:00
BufferParams.cpp try to clarify a comment. 2011-03-23 14:15:46 +00:00
BufferParams.h Introduce BufferParam to control whether CSS is output in the header of 2011-02-15 17:44:17 +00:00
BufferView.cpp Add a FIXME regarding remaining anchor issue. 2011-04-15 02:26:22 +00:00
BufferView.h Revert wrong previous commit. 2011-03-19 10:34:59 +00:00
Bullet.cpp
Bullet.h
Changes.cpp Introduce a wrapper class for odocstream to help ensuring that no 2011-01-29 02:41:13 +00:00
Changes.h Introduce a wrapper class for odocstream to help ensuring that no 2011-01-29 02:41:13 +00:00
Chktex.cpp support: 2010-04-21 01:19:28 +00:00
Chktex.h
Citation.h
CmdDef.cpp Make members of FuncRequest private, per the FIXME there. Again, this is 2010-04-09 19:00:42 +00:00
CmdDef.h
Color.cpp Import notefontcolor (one more step towards a working roundtrip for the LyX documentation) 2011-01-14 20:00:55 +00:00
Color.h Import notefontcolor (one more step towards a working roundtrip for the LyX documentation) 2011-01-14 20:00:55 +00:00
ColorCode.h Removal of this color was forgotten. 2010-12-04 22:41:50 +00:00
ColorSet.h
Compare.cpp Next headers 2010-03-31 19:38:05 +00:00
Compare.h Fix doxygen output for grouped items. Without the /name tag doxygen shows the group name as the name of the first item. Moreover, the comment styles are somewhat standardized. 2010-01-27 18:10:33 +00:00
CompletionList.h
Converter.cpp Given how we are using this exclusion list, it makes more sense for it 2011-03-31 13:03:29 +00:00
Converter.h Given how we are using this exclusion list, it makes more sense for it 2011-03-31 13:03:29 +00:00
ConverterCache.cpp support: 2010-04-21 01:19:28 +00:00
ConverterCache.h Cosmetics and constify. 2009-06-29 23:43:23 +00:00
CoordCache.cpp Just whitespace and a comment. 2011-04-25 01:46:37 +00:00
CoordCache.h Do not give access to the actual data of the CoordCache. This prevents the use of the stored pointers which might be invalid. 2011-03-23 17:43:13 +00:00
Counters.cpp Extracting translation information does not help if you don't actually 2011-04-15 11:34:06 +00:00
Counters.h OK, the previous idea, that we don't need to check the masters of other 2011-01-13 01:47:41 +00:00
Cursor.cpp improve the method naming for "mark new word position", move the mark operation out of bookmarkEditPosition up one level to LFUN_SELF_INSERT of the text inset dispatch 2011-04-01 05:49:04 +00:00
Cursor.h improve the method naming for "mark new word position", move the mark operation out of bookmarkEditPosition up one level to LFUN_SELF_INSERT of the text inset dispatch 2011-04-01 05:49:04 +00:00
CursorSlice.cpp
CursorSlice.h Fix doxygen output for grouped items. Without the /name tag doxygen shows the group name as the name of the first item. Moreover, the comment styles are somewhat standardized. 2010-01-27 18:10:33 +00:00
CutAndPaste.cpp This is intended to be a pure renaming of the Inset::name() routine, 2011-03-28 22:33:04 +00:00
CutAndPaste.h
DepTable.cpp Proper camel case for FileName.absFilename 2010-04-21 01:19:09 +00:00
DepTable.h
Dimension.cpp
Dimension.h
DispatchResult.h Use DispatchResult also in GuiView::dispatchVC to handle messages. 2010-10-17 10:44:53 +00:00
DocIterator.cpp fix a crash when the inset containing the new word at cursor is deleted 2011-02-08 09:42:00 +00:00
DocIterator.h Cleanup the SpellChecker dialog (fixes #7375 and #7379): 2011-03-23 23:10:12 +00:00
EnchantChecker.cpp add forgotten implementation of "remove from personal dictionary" for enchant spell checker backend 2011-04-13 10:55:51 +00:00
EnchantChecker.h add forgotten implementation of "remove from personal dictionary" for enchant spell checker backend 2011-04-13 10:55:51 +00:00
Encoding.cpp fix compiler warnings in pedantic mode: remove trailing comma after last enum member 2010-12-17 19:56:51 +00:00
Encoding.h Avoid unnecessary exceptions. 2010-02-19 16:31:15 +00:00
ErrorList.cpp Fix bug #7331 (No error highlighting in child documents) 2011-03-04 13:37:14 +00:00
ErrorList.h Fix bug #7331 (No error highlighting in child documents) 2011-03-04 13:37:14 +00:00
Exporter.cpp Exporter.cpp: revert r34230 because this interferes with Enrico's new LyXVC feature to setup what LyX should do on export 2010-04-21 01:54:08 +00:00
Exporter.h Style. 2009-11-14 13:16:08 +00:00
factory.cpp fix bug 6698 2010-11-26 17:14:21 +00:00
factory.h Uniformize Inset construction (passing Buffer * everywhere). Lots of cleanup to do still... 2009-11-08 15:53:21 +00:00
Floating.cpp whitespace only. 2011-03-19 17:52:00 +00:00
Floating.h Change NeedsFloatPkg to UsesFloatPkg and introduce a new float tag 2011-02-02 22:28:47 +00:00
FloatList.cpp Some cleanup for the Floating class. 2010-03-04 13:42:05 +00:00
FloatList.h
Font.cpp Introduce a wrapper class for odocstream to help ensuring that no 2011-01-29 02:41:13 +00:00
Font.h Introduce a wrapper class for odocstream to help ensuring that no 2011-01-29 02:41:13 +00:00
FontEnums.h support for formal math script 2010-07-17 15:51:11 +00:00
FontInfo.cpp support for formal math script 2010-07-17 15:51:11 +00:00
FontInfo.h Fix doxygen output for grouped items. Without the /name tag doxygen shows the group name as the name of the first item. Moreover, the comment styles are somewhat standardized. 2010-01-27 18:10:33 +00:00
FontList.cpp add cache of spell checker results to speed up native speller engine on macosx 2010-09-14 05:24:04 +00:00
FontList.h add cache of spell checker results to speed up native speller engine on macosx 2010-09-14 05:24:04 +00:00
Format.cpp Remove unused header. Thanks Julien. 2011-04-14 18:33:50 +00:00
Format.h Fix export of new LaTeX formats: xetex and luatex. Prior to this, child 2011-04-14 18:32:42 +00:00
FuncCode.h Fix inserting subscript/superscript with nonempty selection by creating a dedicated lfun: 2010-11-23 20:09:08 +00:00
FuncRequest.cpp whitespace 2010-11-29 10:48:40 +00:00
FuncRequest.h Swap the argument_ and action_ variables, so that r34105 really does do 2010-04-12 15:40:51 +00:00
FuncStatus.cpp Remove the unclear FuncStatus::operator|=. Without knowing the internals of FuncStatus it is unsafe to use this operator, so let's not use it. 2010-04-16 12:15:27 +00:00
FuncStatus.h Remove the unclear FuncStatus::operator|=. Without knowing the internals of FuncStatus it is unsafe to use this operator, so let's not use it. 2010-04-16 12:15:27 +00:00
Graph.cpp Given how we are using this exclusion list, it makes more sense for it 2011-03-31 13:03:29 +00:00
Graph.h Given how we are using this exclusion list, it makes more sense for it 2011-03-31 13:03:29 +00:00
HSpace.cpp support to specify the paragraph indentation in the document settings dialog; introduces the new class HSpace; - file format change 2009-07-19 21:13:27 +00:00
HSpace.h support to specify the paragraph indentation in the document settings dialog; introduces the new class HSpace; - file format change 2009-07-19 21:13:27 +00:00
HunspellChecker.cpp #7170 simplify the hunspell dictionary lookup; use Language::lang() instead of Language::id() as speller index 2011-02-18 11:54:14 +00:00
HunspellChecker.h #7043 add the implementation of a persistent personal word list for LyX spell checker, aspell and hunspell backend 2010-12-02 18:52:31 +00:00
IndicesList.cpp Fix crash in lyx -e latex lib/doc/Shortcuts.lyx: theApp() is 0 in batch mode. 2011-01-06 18:40:39 +00:00
IndicesList.h *List.h: Move the class documentation into the lyx::namespace to be picked up correctly by doxy. 2010-05-03 13:36:19 +00:00
InsetIterator.cpp
InsetIterator.h
InsetList.cpp
InsetList.h
Intl.cpp
Intl.h
KeyMap.cpp #7292 make the modifiers Option and Control act on there own on mac - adjust the key bindings to apple standards where possible 2011-02-23 14:30:41 +00:00
KeyMap.h Conversion routines for bind files. 2011-01-16 19:53:36 +00:00
KeySequence.cpp #7292 make the modifiers Option and Control act on there own on mac - adjust the key bindings to apple standards where possible 2011-02-23 14:30:41 +00:00
KeySequence.h
Language.cpp support language variants like german (old spelling) or british english 2011-03-24 19:40:54 +00:00
Language.h support language variants like german (old spelling) or british english 2011-03-24 19:40:54 +00:00
LaTeX.cpp * LaTeX.cpp: fix another variant of bug #7344 (delete aux files and rerun LaTeX if hyperref has been toggled) 2011-03-13 11:57:01 +00:00
LaTeX.h Fix bug #7331 (No error highlighting in child documents) 2011-03-04 13:37:14 +00:00
LaTeXFeatures.cpp fix another bug spotted by Pavel 2011-04-07 19:17:30 +00:00
LaTeXFeatures.h * resolve conflicts of XeTeX with AMS by loading all AMS packages before fontspec. See 2010-12-08 18:42:10 +00:00
Layout.cpp Remove obsolete layout tags. 2011-03-28 15:11:57 +00:00
Layout.h Remove obsolete layout tags. 2011-03-28 15:11:57 +00:00
LayoutEnums.h add support for decimal alignment in tables 2010-06-05 07:44:44 +00:00
LayoutFile.cpp Move the error message out of LayoutFileList::load() and have it be 2010-07-28 21:03:27 +00:00
LayoutFile.h Grant a long-standing wish of Lars's: LyX now functions even if we have 2010-04-07 17:02:44 +00:00
LayoutModuleList.cpp Typo from Sven 2010-05-17 20:56:12 +00:00
LayoutModuleList.h Comment. 2009-08-15 18:45:54 +00:00
Length.cpp Length.cpp: fix sort order - in all other files we have PTH before PPH 2010-07-25 00:17:48 +00:00
Length.h Length.h: revert unintended change 2009-07-17 01:01:37 +00:00
lengthcommon.cpp Disentangle various "in"s 2010-11-30 00:55:34 +00:00
Lexer.cpp Fix bug #6868: LYXCMD:xxx:inset-insert:graphics does not parse correctly 2010-08-28 16:46:54 +00:00
Lexer.h Clarify and add some comments. 2010-03-29 18:00:26 +00:00
LyX.cpp Messages::init(); needs Package. this fixes a crash on windows which presents parsing of the argument 2011-03-29 22:18:21 +00:00
LyX.h Don't try to convert any of the preference files except the user's own. 2011-01-17 15:54:51 +00:00
LyXAction.cpp * doxy 2011-03-27 22:50:19 +00:00
LyXAction.h Move bind file format tag to LyXAction.cpp, and rename it. 2011-01-18 15:07:26 +00:00
lyxfind.cpp Nearly cosmetics. 2011-04-16 10:48:55 +00:00
lyxfind.h Completing r37549. 2011-02-07 23:55:02 +00:00
LyXRC.cpp *LyXER.cpp: 2011-04-04 09:43:39 +00:00
LyXRC.h Infrastructure for choosing different icon sets. This currently works 2011-03-25 01:59:34 +00:00
LyXVC.cpp Fix bug #7338 2011-03-07 00:37:26 +00:00
LyXVC.h Load mhchem if it is requested unconditionally, fix some typos 2010-11-21 18:07:04 +00:00
lyxwinres.rc Update years 2011-01-21 13:24:23 +00:00
main.cpp Remove unneeded include. 2010-11-17 16:14:26 +00:00
Makefile.am fix bug #7288: add configure option for external mythes library 2011-02-10 20:31:07 +00:00
MetricsInfo.cpp Sanitize ColorChanger 2010-09-09 13:02:20 +00:00
MetricsInfo.h Sanitize ColorChanger 2010-09-09 13:02:20 +00:00
ModuleList.cpp Fix bug #7044: Better error messages when modules are unavailable. Patch 2011-01-13 21:19:14 +00:00
ModuleList.h Fix bug #7044: Better error messages when modules are unavailable. Patch 2011-01-13 21:19:14 +00:00
Mover.cpp Proper camel case for FileName.absFilename 2010-04-21 01:19:09 +00:00
Mover.h
output_docbook.cpp Next headers 2010-03-31 19:38:05 +00:00
output_docbook.h Move depthHook(), outerHook(), isFirstInSequence(), outerFont() to Text methods. 2009-08-09 18:35:39 +00:00
output_latex.cpp Integrate texrow with otexstream in order to perform automatic line 2011-02-10 20:02:48 +00:00
output_latex.h Integrate texrow with otexstream in order to perform automatic line 2011-02-10 20:02:48 +00:00
output_plaintext.cpp
output_plaintext.h
output_xhtml.cpp Revert r38431 for now, at least. Thanks to Enrico for pointing out 2011-04-19 00:50:24 +00:00
output_xhtml.h The mechanism for closing font tags at the end of a paragraph was 2011-04-03 01:56:20 +00:00
output.cpp
output.h
OutputEnums.h Add OutputEnums.h. This enum will shortly replace some magic booleans 2010-01-20 19:41:44 +00:00
OutputParams.cpp When an error occurs, don't highlight more than necessary. 2011-03-12 01:40:01 +00:00
OutputParams.h When an error occurs, don't highlight more than necessary. 2011-03-12 01:40:01 +00:00
paper.h support for the ISO C-series paper formats; fileformat change 2010-07-13 01:06:20 +00:00
Paragraph.cpp avoid the single dash (hard hyphen) or apostrophe enclosed by white space is treated as a real word 2011-04-08 13:20:26 +00:00
Paragraph.h avoid the single dash (hard hyphen) or apostrophe enclosed by white space is treated as a real word 2011-04-08 13:20:26 +00:00
ParagraphList.h
ParagraphMetrics.cpp * Introduce polyglossia support (bug 6576). 2010-11-22 12:10:16 +00:00
ParagraphMetrics.h
ParagraphParameters.cpp
ParagraphParameters.h
ParIterator.cpp
ParIterator.h
pch.h
PDFOptions.cpp * PDFOptions.cpp: 2011-04-18 10:55:11 +00:00
PDFOptions.h Complete integration of texrow with otexstream and allow automatic line 2011-02-13 21:41:44 +00:00
PersonalWordList.cpp fix msvc warning, somehow msvc thinks !line[0] is a boolean 2011-02-14 19:54:04 +00:00
PersonalWordList.h #7043 add the implementation of a persistent personal word list for LyX spell checker, aspell and hunspell backend 2010-12-02 18:52:31 +00:00
PrinterParams.cpp
PrinterParams.h
Row.cpp
Row.h
rowpainter.cpp *rowpainter.cpp: Squeeze warnings. 2011-03-13 21:06:16 +00:00
rowpainter.h #7120 use separate line thickness for solid and dotted lines to mark foreign, changed and misspelled text parts 2011-02-20 07:50:28 +00:00
Server.cpp Force a paragraph update after lyxserver communication (part of bug #6871) 2011-03-04 21:57:42 +00:00
Server.h The "single instance" patch. 2010-11-13 11:55:05 +00:00
ServerSocket.cpp Force a paragraph update after lyxserver communication (part of bug #6871) 2011-03-04 21:57:42 +00:00
ServerSocket.h msvcUsing "using namespace std" with msvc10 makes also std::tr1::shared_ptr visible and generates conflicts with boost::shared_ptr. 2010-04-22 11:37:32 +00:00
Session.cpp No need for a deque here. 2010-12-04 23:18:52 +00:00
Session.h No need for a deque here. 2010-12-04 23:18:52 +00:00
sgml.cpp Make the new argument to step() mandatory, and add a comment to 2010-01-20 19:47:27 +00:00
sgml.h
Spacing.cpp
Spacing.h remove special TEX2LYX code in Spacing,h 2009-10-28 10:07:10 +00:00
SpellChecker.h remove not needed class name for enums, whitespace 2010-12-01 08:25:17 +00:00
TexRow.cpp Make sure to associate each line of the exported latex code to the id/pos 2011-03-10 04:05:49 +00:00
TexRow.h Make sure to associate each line of the exported latex code to the id/pos 2011-03-10 04:05:49 +00:00
TexStream.cpp
TexStream.h
Text2.cpp Fix bug #6919 by splitting Inset::noFontChange() into inheritFont() and 2011-02-22 19:41:04 +00:00
Text3.cpp improve the method naming for "mark new word position", move the mark operation out of bookmarkEditPosition up one level to LFUN_SELF_INSERT of the text inset dispatch 2011-04-01 05:49:04 +00:00
Text.cpp Remove obsolete comments. 2011-01-12 13:40:47 +00:00
Text.h Fix bug #6919 by splitting Inset::noFontChange() into inheritFont() and 2011-02-22 19:41:04 +00:00
TextClass.cpp Fix bug #7080. 2011-03-28 23:11:54 +00:00
TextClass.h Fix problem reported by Vincent, that absence of python can cause 2010-07-18 11:58:38 +00:00
TextMetrics.cpp Just whitespace and a comment. 2011-04-25 01:46:37 +00:00
TextMetrics.h Remove leftover of r36485. 2010-12-06 00:25:45 +00:00
Thesaurus.cpp fix bug #7288: add configure option for external mythes library 2011-02-10 20:31:07 +00:00
Thesaurus.h * Spellchecker dialog: 2010-02-10 08:10:31 +00:00
TocBackend.cpp Finish disentangling tocString(). We introduce a new method, forToc(), 2010-12-20 21:55:09 +00:00
TocBackend.h Fix bug #6672 (part 2): Add tooltips to the outliner. 2010-04-26 00:43:08 +00:00
Trans.cpp fix compiler warnings in pedantic mode: remove trailing comma after last enum member 2010-12-17 19:56:51 +00:00
Trans.h
Undo.cpp #7208 reset undo group level in Undo::clear() too 2011-01-10 09:44:55 +00:00
Undo.h Clear undo/redo stack when reloading buffer. This fixes #7208. 2011-01-09 17:55:16 +00:00
update_flags.h
VCBackend.cpp Stephan, I changed this string since the previous version was strange. 2010-11-30 00:23:34 +00:00
VCBackend.h Comment 2010-11-06 12:32:47 +00:00
version.cpp So, let's constify all globals in version.cpp... 2011-02-11 00:46:49 +00:00
version.h seems the other have different compilers ;) 2011-02-11 02:09:22 +00:00
VSpace.cpp Initialize number_index and unit_index in isValidGlueLength(). This is now the same as in isValidLength(), so I assume it's OK. 2010-03-10 16:35:40 +00:00
VSpace.h HTML output for InsetVSpace. 2009-06-12 15:07:04 +00:00
WordLangTuple.h Fix bug #6561: Crash when using Spellchecker's language box when cursor is in math. 2010-11-10 20:06:21 +00:00
WordList.cpp Fix bug #6378: Word completion (in texted) should be language-sensitive. 2009-12-18 14:48:56 +00:00
WordList.h Fix bug #6378: Word completion (in texted) should be language-sensitive. 2009-12-18 14:48:56 +00:00