lyx_mirror/src/frontends/qt4
Enrico Forestieri 3fe8463ddf Fix bug http://bugzilla.lyx.org/show_bug.cgi?id=5467
(too much C++, I presume :)


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@27352 a592a061-630c-0410-9148-cb99ea01b6c8
2008-11-08 23:44:43 +00:00
..
ui fix broken layout 2008-10-31 18:21:46 +00:00
Action.cpp
Action.h
BulletsModule.cpp cosmetics; 2008-09-20 11:47:38 +00:00
BulletsModule.h cosmetics; 2008-09-20 11:47:38 +00:00
ButtonController.cpp pimpl ButtonController 2008-04-19 09:12:34 +00:00
ButtonController.h pimpl ButtonController 2008-04-19 09:12:34 +00:00
ButtonPolicy.cpp pimply buttonpolicy data 2008-04-19 08:42:56 +00:00
ButtonPolicy.h pimply buttonpolicy data 2008-04-19 08:42:56 +00:00
ColorCache.cpp fix my color cache "improvements" 2008-05-31 22:39:52 +00:00
ColorCache.h fix my color cache "improvements" 2008-05-31 22:39:52 +00:00
CustomizedWidgets.cpp More work on the Shortcuts UI: 2008-07-22 09:49:38 +00:00
CustomizedWidgets.h remove superflous lyx:: qualification 2008-08-24 20:29:20 +00:00
Dialog.cpp Dialogs: discourage non const access to buffer() and bufferview(). 2008-09-29 10:52:17 +00:00
Dialog.h Dialogs: discourage non const access to lyxview(). 2008-09-29 11:01:53 +00:00
DialogView.h Fix citation bug: In certain circumstances, attempts to insert a new citation 2008-08-13 14:32:30 +00:00
DockView.h Don't show the dock widget at construction time. This should fix bug http://bugzilla.lyx.org/show_bug.cgi?id=5273 2008-10-03 13:45:56 +00:00
EmptyTable.cpp
EmptyTable.h
FileDialog.cpp Remove traces of Q_CYGWIN_WIN 2008-10-15 23:00:42 +00:00
FileDialog.h move the filefilter stuff closer to the only place where it is used 2008-04-20 19:56:01 +00:00
FloatPlacement.cpp cosmetics. remoe strange dependency of GuiDocument.h 2008-09-20 13:44:51 +00:00
FloatPlacement.h cosmetics. remoe strange dependency of GuiDocument.h 2008-09-20 13:44:51 +00:00
GuiAbout.cpp Fix bug http://bugzilla.lyx.org/show_bug.cgi?id=4943 . 2008-07-07 23:41:19 +00:00
GuiAbout.h
GuiAlert.cpp Fix http://bugzilla.lyx.org/show_bug.cgi?id=5430 . 2008-10-30 13:47:41 +00:00
GuiApplication.cpp Fix bug http://bugzilla.lyx.org/show_bug.cgi?id=5467 2008-11-08 23:44:43 +00:00
GuiApplication.h * Fix for http://bugzilla.lyx.org/show_bug.cgi?id=5387 2008-11-05 14:04:37 +00:00
GuiBibitem.cpp move GuiCommand into hedar of its own. InsetCommandParams.h is expensive 2008-04-20 08:19:26 +00:00
GuiBibitem.h move GuiCommand into hedar of its own. InsetCommandParams.h is expensive 2008-04-20 08:19:26 +00:00
GuiBibtex.cpp * GuiBibtex.cpp: 2008-04-28 12:57:41 +00:00
GuiBibtex.h merge GuiCommand into its users. 2008-04-20 09:24:14 +00:00
GuiBox.cpp Box fixes from Vincent and me. 2008-10-04 09:24:40 +00:00
GuiBox.h remove InsetBoxMailer. 2008-03-27 07:26:37 +00:00
GuiBranch.cpp cosmetics 2008-09-21 19:27:20 +00:00
GuiBranch.h
GuiBranches.cpp cosmetics 2008-09-21 19:27:20 +00:00
GuiBranches.h cosmetics 2008-09-21 19:27:20 +00:00
GuiChanges.cpp
GuiChanges.h
GuiCharacter.cpp fix http://bugzilla.lyx.org/show_bug.cgi?id=4870 2008-05-22 15:20:43 +00:00
GuiCharacter.h LFUN_FONT_FREE_* -> LFUN_TEXSTYLE_* 2008-06-11 08:35:15 +00:00
GuiCitation.cpp * GuiCitation.cpp: 2008-11-04 07:27:02 +00:00
GuiCitation.h Fix citation bug: In certain circumstances, attempts to insert a new citation 2008-08-13 14:32:30 +00:00
GuiClipboard.cpp X dependency cleanup (2/3) 2008-10-09 07:21:48 +00:00
GuiClipboard.h cleanup export of mime type strings 2008-05-25 07:49:16 +00:00
GuiCommandBuffer.cpp
GuiCommandBuffer.h
GuiCommandEdit.cpp
GuiCommandEdit.h
GuiCompleter.cpp Paragraph: 2008-10-19 07:03:44 +00:00
GuiCompleter.h Fix item delegate for qt 4.2: 2008-06-03 22:00:47 +00:00
GuiDelimiter.cpp Get rid of GuiMath layer. 2008-06-02 10:05:29 +00:00
GuiDelimiter.h Get rid of GuiMath layer. 2008-06-02 10:05:29 +00:00
GuiDialog.cpp bug 4652: better fix. 2008-05-15 08:06:32 +00:00
GuiDialog.h move GuiCommand into hedar of its own. InsetCommandParams.h is expensive 2008-04-20 08:19:26 +00:00
GuiDocument.cpp * GuiDocument.cpp (formatStrVec): 2008-11-05 18:37:47 +00:00
GuiDocument.h This patch introduces ProvidesModule and ExcludesModule layout tags. 2008-10-23 00:27:03 +00:00
GuiErrorList.cpp make error dialog more comprehensible: 2008-10-21 09:07:15 +00:00
GuiErrorList.h Fix for 5429 from Vincent. 2008-10-30 11:49:18 +00:00
GuiERT.cpp this feels more natural... 2008-03-27 23:37:59 +00:00
GuiERT.h
GuiExternal.cpp - Simplify prefs, graphics and external display options which are now true or false. 2008-06-13 07:34:55 +00:00
GuiExternal.h basic context menu for InsetExternal. 2008-04-28 05:12:28 +00:00
GuiFloat.cpp remove remaining MailInsets. 2008-03-27 22:26:24 +00:00
GuiFloat.h
GuiFontExample.cpp
GuiFontExample.h
GuiFontLoader.cpp cosmetics 2008-05-02 22:07:51 +00:00
GuiFontLoader.h Pimpl stuff in GuiApplication. 2008-05-23 08:43:07 +00:00
GuiFontMetrics.cpp Coding style 2008-09-08 01:18:33 +00:00
GuiFontMetrics.h
GuiGraphics.cpp move code to unify graphics groups from GuiGraphics to InsetGraphics 2008-09-25 13:24:52 +00:00
GuiGraphics.h Fix 4603 for GuiGraphics. I guess most GuiDialog based dialog need fixing... 2008-05-06 15:18:50 +00:00
GuiGraphicsUi.h
GuiHSpace.cpp support for rightarrowfill, leftarrowfill, upbracefill, downbracefill, by Helge Hafting. 2008-04-30 20:11:57 +00:00
GuiHSpace.h Erase unimplemented methods. 2008-09-13 15:41:33 +00:00
GuiHyperlink.cpp fix a bunch of harmless warnings 2008-09-16 11:33:07 +00:00
GuiHyperlink.h cosmetics 2008-09-03 18:30:05 +00:00
GuiIdListModel.cpp rename assert.h to lassert.h 2008-04-30 08:26:40 +00:00
GuiIdListModel.h Fix a bug noticed by Stefan: that the module UI was broken. The problem was introduced at r23981. The data() and setData() methods must be kept in sync. 2008-04-17 02:43:57 +00:00
GuiImage.cpp * GuiImage::scale(): simplify. 2008-09-19 14:36:45 +00:00
GuiImage.h Simplify image creation with a new factory function: newImage(). 2008-09-19 12:01:01 +00:00
GuiInclude.cpp * GuiInclude.cpp: 2008-09-30 06:51:08 +00:00
GuiInclude.h cosmetics 2008-09-03 18:30:05 +00:00
GuiInfo.cpp Dialogs: discourage non const access to buffer() and bufferview(). 2008-09-29 10:52:17 +00:00
GuiInfo.h InsetInfo: Some fixes... 2008-06-06 08:45:58 +00:00
GuiKeySymbol.cpp Fix bug http://bugzilla.lyx.org/show_bug.cgi?id=5421 2008-11-03 09:55:50 +00:00
GuiKeySymbol.h
GuiLabel.cpp merge GuiCommand into its users. 2008-04-20 09:24:14 +00:00
GuiLabel.h merge GuiCommand into its users. 2008-04-20 09:24:14 +00:00
GuiListings.cpp add support for TABs in Listings, fileformat change, fixes http://bugzilla.lyx.org/show_bug.cgi?id=3629 , patch by Vincent, lyx2lyx and UI stuff by me 2008-09-30 18:00:02 +00:00
GuiListings.h
GuiLog.cpp Revision control log is not visible after launching, moreover the title didn't 2008-07-20 22:48:48 +00:00
GuiLog.h
GuiMathMatrix.cpp Get rid of GuiMath layer. 2008-06-02 10:05:29 +00:00
GuiMathMatrix.h Get rid of GuiMath layer. 2008-06-02 10:05:29 +00:00
GuiNomencl.cpp fix a bunch of harmless warnings 2008-09-16 11:33:07 +00:00
GuiNomencl.h cosmetics 2008-09-03 18:30:05 +00:00
GuiNote.cpp remove remaining MailInsets. 2008-03-27 22:26:24 +00:00
GuiNote.h
GuiPainter.cpp * fix for r27091: draw the newly created pixmap. The reordering of the code has removed this case. So much about trivial program transformation. 2008-11-03 07:40:18 +00:00
GuiPainter.h
GuiParagraph.cpp remove mutable property 2008-09-29 10:56:45 +00:00
GuiParagraph.h remove mutable property 2008-09-29 10:56:45 +00:00
GuiPrefs.cpp fix bug 5332: preferences opens wrong folder for keyboard maps when there is no valid map 2008-10-05 14:11:04 +00:00
GuiPrefs.h Move the ItemType enum out of GuiPref and into KeyMap, where it belongs. 2008-09-23 13:53:38 +00:00
GuiPrint.cpp compile fix 2008-04-21 06:53:00 +00:00
GuiPrint.h
GuiRef.cpp A little const'ness. 2008-10-28 16:02:33 +00:00
GuiRef.h From Vincent: 2008-10-28 15:38:28 +00:00
GuiSearch.cpp * GuiSearch.cpp: 2008-09-09 13:20:44 +00:00
GuiSearch.h
GuiSelection.cpp X dependency cleanup (2/3) 2008-10-09 07:21:48 +00:00
GuiSelection.h GuiSelection: make sure the initial check is done 2008-07-29 10:25:35 +00:00
GuiSelectionManager.cpp save a few cycles. 2008-09-21 01:35:43 +00:00
GuiSelectionManager.h cosmetics. remoe strange dependency of GuiDocument.h 2008-09-20 13:44:51 +00:00
GuiSendto.cpp fix a bunch of harmless warnings 2008-09-16 11:33:07 +00:00
GuiSendto.h Some GuiSendto polishing by Vincent and me. 2008-09-04 09:36:44 +00:00
GuiSetBorder.cpp
GuiSetBorder.h
GuiShowFile.cpp
GuiShowFile.h
GuiSpellchecker.cpp Dialogs: discourage non const access to buffer() and bufferview(). 2008-09-29 10:52:17 +00:00
GuiSpellchecker.h
GuiSymbols.cpp Pimpl stuff in GuiApplication. 2008-05-23 08:43:07 +00:00
GuiSymbols.h use cheaper includes in ui files 2008-04-20 16:32:40 +00:00
GuiTabular.cpp Dialogs: discourage non const access to buffer() and bufferview(). 2008-09-29 10:52:17 +00:00
GuiTabular.h fix: http://bugzilla.lyx.org/show_bug.cgi?id=4688 2008-05-04 07:51:50 +00:00
GuiTabularCreate.cpp
GuiTabularCreate.h
GuiTexinfo.cpp
GuiTexinfo.h
GuiThesaurus.cpp
GuiThesaurus.h
GuiToc.cpp * fix fullscreen TOC switching between dock and drawer mode on Mac 2008-10-23 20:46:03 +00:00
GuiToc.h Fix initial focus problem with outline and view-source panes. 2008-06-09 14:52:38 +00:00
GuiToolbar.cpp fix crash when filtering layout combox with non-ascii character 2008-10-31 09:26:59 +00:00
GuiToolbar.h Clean up the unknown layout stuff some more. Please test to make sure this works with translated layout names, especially when one of them is "unknown". The use of "unknown" with RTL is also wrong, probably, as it will appear on the wrong side. But I'm not sure how to fix that. 2008-07-16 15:52:10 +00:00
GuiView.cpp * Fix for http://bugzilla.lyx.org/show_bug.cgi?id=5387 2008-11-05 14:04:37 +00:00
GuiView.h Avoid a complete Toc reset in case when only a toc item update is needed. 2008-09-30 09:50:54 +00:00
GuiViewSource.cpp Fix part of http://bugzilla.lyx.org/show_bug.cgi?id=5347 2008-10-18 14:14:58 +00:00
GuiViewSource.h Code shuffling in order to fix http://bugzilla.lyx.org/show_bug.cgi?id=5347 2008-10-18 13:20:17 +00:00
GuiVSpace.cpp remove InsetVSpaceMailer class 2008-03-27 00:21:35 +00:00
GuiVSpace.h Erase unimplemented methods. 2008-09-13 15:41:33 +00:00
GuiWorkArea.cpp Fix whitespaces so the diff between branches is not so huge. 2008-10-13 11:25:37 +00:00
GuiWorkArea.h * Some more clever elide mode for the LyX buffer tabs. In trunk 2008-04-29 15:44:07 +00:00
GuiWrap.cpp Fix http://bugzilla.lyx.org/show_bug.cgi?id=4603 2008-05-06 14:53:54 +00:00
GuiWrap.h Fix http://bugzilla.lyx.org/show_bug.cgi?id=4603 2008-05-06 14:53:54 +00:00
IconPalette.cpp * attempt to fix bug 5189. 2008-09-19 10:04:06 +00:00
IconPalette.h
InsertTableWidget.cpp
InsertTableWidget.h
LaTeXHighlighter.cpp
LaTeXHighlighter.h
LengthCombo.cpp
LengthCombo.h
LyXFileDialog.cpp move the filefilter stuff closer to the only place where it is used 2008-04-20 19:56:01 +00:00
LyXFileDialog.h move the filefilter stuff closer to the only place where it is used 2008-04-20 19:56:01 +00:00
Makefile.am Create new Module panel in document settings and decrease vertical 2008-10-19 01:21:59 +00:00
Menus.cpp Fix for another part of 5403, and related bugs, anyway. The InsetLayout 2008-10-25 13:32:54 +00:00
Menus.h GuiApplication::resetGui(): reset as many things as possible, including menus and toolbars (not sure about Mac global menubar yet). This means that except for already opened dialog, all ui rc settings are taken into account without the need to restart. 2008-06-25 18:03:38 +00:00
PanelStack.cpp cosmetics 2008-09-21 09:11:21 +00:00
PanelStack.h cosmetics 2008-09-21 09:11:21 +00:00
pch.h
qt_helpers.cpp X dependency cleanup (2/3) 2008-10-09 07:21:48 +00:00
qt_helpers.h X dependency cleanup (2/3) 2008-10-09 07:21:48 +00:00
qt_i18n.h move the filefilter stuff closer to the only place where it is used 2008-04-20 19:56:01 +00:00
README
TocModel.cpp Avoid a complete Toc reset in case when only a toc item update is needed. 2008-09-30 09:50:54 +00:00
TocModel.h Avoid a complete Toc reset in case when only a toc item update is needed. 2008-09-30 09:50:54 +00:00
TocWidget.cpp Fix http://bugzilla.lyx.org/show_bug.cgi?id=5409 2008-10-28 06:46:27 +00:00
TocWidget.h Add persistent view switch to the outliner. 2008-10-02 15:00:43 +00:00
Toolbars.cpp Fix crash when the Gui Name of a toolbar is not plain ascii. This 2008-08-15 18:43:46 +00:00
Toolbars.h Fix crash when the Gui Name of a toolbar is not plain ascii. This 2008-08-15 18:43:46 +00:00
Validator.cpp * Validator.cpp: 2008-09-19 09:40:14 +00:00
Validator.h

This file contains some do's and dont's for the Qt4 frontend.

General rules
-------------

Every editable field that affects the state of the dialog contents
from LyX's point of view should connect its xxxChanged() signal to
a the dialog's changed_adaptor() slot, which in turn should call
changed(). If you are using a more complicated thing anyway,
then remember to call changed() at the end (if it has changed!)

Every non-trivial widget should have a tooltip. If you don't know
what to write, write "FIXME", and it can fixed later. Don't be afraid
to use QWhatsThis too, but this must be done in the derived class's
constructor, and use _("..."). Non-trivial means that things like "OK"
/must not/ have a tooltip.

moc needs a fully qualified "std::string" for .connect() statements
to work. Be very, very careful.

Remember to check tab order on a dialog (third icon, with blue bars in
designer).

Remember to check sensible resizing behaviour on a dialog. This is
usually done by adding a top-level layout to the dialog in Designer.

Remember to use Edit->Check Accelerators

If necessary, you should override Qt2Base::isValid() for determining the
validity of the current dialog's contents.

OK/Apply/Restore/Close should be connected in the derived class's
constructor to call slotOK() etc. Refer to close/cancel as close in the
source.

Override update_contents() to update the dialog, not update().  Only
these functions may change dialog widgets that may emit changed() during
initialisation, to prevent the button controller from changing its
state.

Never call buttoncontroller functions directly from dialogs. In general,
you should use Qt2Base::changed() in all circumstances. However, if you
must call the buttoncontroller, make sure to respect Qt2Base::updating_

Naming conventions
------------------

QFoo.{cpp,h}     The file that interacts with the controller _and_
the implementation of the dialog, derived from the generated files
ui/FooDialog.ui  The designer file
ui_FooDialog.h   Generated files from FooDialog.ui

slots should be named e.g. slotFooClicked(), slotFooSelected(), where
foo is the name of the widget.

Widgets should be named like "fooXX", where XX is one of the following
widget types :

CB - check box
CO - combo box
ED - line edit
GB - group box
LA - label
LC - LengthCombo
LV - QListView
ML - QTextBrowser
PB - push button
RB - radio button
SB - spin box
SL - slider
TE - text edit
TW - tree widget (FIXME: also TV in some files)


Qt, Unicode, and LyX
--------------------

LyX uses a different encoding (UCS4) than Qt (UTF16), therefore there are a
number of conversion functions in qt_helpers.{cpp,h}. Read the doxygen
documentation for details when to use which function.

Additionally, you should follow these simple rules :

o Use qt_() not _() in code
o Use the conversion functions of qt_helpers.h, NOT .latin1() / .c_str() etc.