mirror of
https://git.lyx.org/repos/lyx.git
synced 2024-12-23 13:31:49 +00:00
4d99112056
Replace the member reference to FuncRequest in Action.cpp with a shared_ptr. Compared to copying the FuncRequest, the shared_ptr has two advantages: * Recreating the menu each time creates a lot of new actions, so we avoid a lot of copies. * FuncRequest can remain forward-declared in Action.h.
65 lines
1.2 KiB
C++
65 lines
1.2 KiB
C++
// -*- C++ -*-
|
|
/**
|
|
* \file Action.h
|
|
* This file is part of LyX, the document processor.
|
|
* Licence details can be found in the file COPYING.
|
|
*
|
|
* \author Abdelrazak Younes
|
|
*
|
|
* Full author contact details are available in file CREDITS.
|
|
*/
|
|
|
|
#ifndef ACTION_H
|
|
#define ACTION_H
|
|
|
|
#include <QAction>
|
|
#include <memory>
|
|
|
|
class QIcon;
|
|
|
|
namespace lyx {
|
|
|
|
class FuncRequest;
|
|
|
|
namespace frontend {
|
|
|
|
/**
|
|
* Action - Qt interface with LyX' FuncRequest.
|
|
*
|
|
* Action can be used in LyX menubar and/or toolbars.
|
|
*/
|
|
class Action : public QAction
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
// Makes a copy of func
|
|
Action(FuncRequest func, QIcon const & icon, QString const & text,
|
|
QString const & tooltip, QObject * parent);
|
|
|
|
// Takes shared ownership of func.
|
|
// Use for perf-sensitive code such as populating menus.
|
|
Action(std::shared_ptr<FuncRequest const> func,
|
|
QIcon const & icon, QString const & text,
|
|
QString const & tooltip, QObject * parent);
|
|
|
|
void update();
|
|
|
|
Q_SIGNALS:
|
|
/// the current action is triggered
|
|
void triggered(QAction *);
|
|
|
|
private Q_SLOTS:
|
|
void action();
|
|
|
|
private:
|
|
void init(QIcon const & icon, QString const & text, QString const & tooltip);
|
|
std::shared_ptr<FuncRequest const> func_;
|
|
};
|
|
|
|
|
|
} // namespace frontend
|
|
} // namespace lyx
|
|
|
|
#endif // ACTION_H
|