lyx_mirror/src/frontends/qt4
Jean-Marc Lasgouttes 740c83637d Correctly initialize a member variable
This has be diagnosed by valgrind, I do not know how important it is.
2012-09-08 16:59:19 +02:00
..
ui BoxUi.ui: revert unintended commit [a6e42e50/lyxgit] 2012-06-26 22:46:06 +02:00
.gitignore Setup .gitignore for generated files 2012-03-22 02:16:12 +01:00
Action.cpp * FuncStatus: unify naming of functions. 2010-04-16 10:51:20 +00:00
Action.h
BulletsModule.cpp Update status when bullet size is changed. 2011-06-04 12:50:39 +00:00
BulletsModule.h
ButtonController.cpp
ButtonController.h Fix doxygen output for grouped items. Without the /name tag doxygen shows the group name as the name of the first item. Moreover, the comment styles are somewhat standardized. 2010-01-27 18:10:33 +00:00
ButtonPolicy.cpp Revert r35760, as suggested by Vincent. 2010-10-21 19:33:29 +00:00
ButtonPolicy.h fix compiler warnings in pedantic mode: remove trailing comma after last enum member 2010-12-17 19:56:51 +00:00
CMakeLists.txt cmake: move CMakeLists.txt into source dir (multiple steps) 2011-05-10 17:44:41 +00:00
ColorCache.cpp Set url color from system theme. 2010-09-09 13:04:02 +00:00
ColorCache.h Finish implementation of "use system colors" checkbox. 2010-08-09 12:15:02 +00:00
CustomizedWidgets.cpp
CustomizedWidgets.h
Dialog.cpp Added method for easy reach of main document buffer. 2011-05-27 21:53:23 +00:00
Dialog.h Added method for easy reach of main document buffer. 2011-05-27 21:53:23 +00:00
DialogView.h DialogView: make GuiView the parent widget to partly solve bug #6710. 2010-10-21 13:40:49 +00:00
DockView.h close floating dock widgets (not currently docked) with escape keypress event 2011-09-29 18:52:36 +00:00
EmptyTable.cpp
EmptyTable.h
FancyLineEdit.cpp Another unused variable. 2011-09-23 17:52:11 +00:00
FancyLineEdit.h Compile fix for Qt 4.5 and earlier. The other build systems should update 2011-06-08 19:45:52 +00:00
FileDialog.cpp Take Vincent's advice: using a pointer for selectedFilter 2011-10-15 13:32:14 +00:00
FileDialog.h Take Vincent's advice: using a pointer for selectedFilter 2011-10-15 13:32:14 +00:00
FindAndReplace.cpp Fix crash reported by Tommaso: 2012-06-04 13:39:24 -04:00
FindAndReplace.h This makes the FindAndReplace replace-related buttons de-activate 2012-01-07 11:41:04 +00:00
FloatPlacement.cpp More include frenzy. 2010-10-31 01:04:03 +00:00
FloatPlacement.h InsetParamsWidget(): fix method constness. 2010-02-18 07:56:38 +00:00
GuiAbout.cpp Proper camel case for FileName.absFilename 2010-04-21 01:19:09 +00:00
GuiAbout.h About box: Migrate to DialogView. 2010-01-23 20:29:00 +00:00
GuiAlert.cpp Avoid that, if an error dialog pops up during a long operation, it freezes LyX. 2012-08-18 22:45:21 +01:00
GuiApplication.cpp Correctly initialize a member variable 2012-09-08 16:59:19 +02:00
GuiApplication.h Avoid that, if an error dialog pops up during a long operation, it freezes LyX. 2012-08-18 22:45:21 +01:00
GuiBibitem.cpp Remove the name parameter from string2params and params2string. We can always derive the name with insetName(params.code()). 2010-10-29 00:25:28 +00:00
GuiBibitem.h Migrate GuiBibitem to InsetParamsWidget. 2010-02-23 21:24:24 +00:00
GuiBibtex.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiBibtex.h
GuiBox.cpp remove unused include of FuncRequest 2010-08-24 03:07:09 +00:00
GuiBox.h * GuiBoc.{cpp,h}: 2010-06-26 07:57:54 +00:00
GuiBranch.cpp Migrate Branch dialog to InsetParamsWidget 2010-02-19 20:57:25 +00:00
GuiBranch.h Migrate Branch dialog to InsetParamsWidget 2010-02-19 20:57:25 +00:00
GuiBranches.cpp Fix monolithic build (bug #8079) 2012-03-24 15:25:30 +01:00
GuiBranches.h Fix handling of the add branch textfield in GuiBranches 2012-03-03 14:39:32 +00:00
GuiChanges.cpp Fix bug #4213: Change tracking support for tex2lyx. 2011-11-06 17:03:59 +00:00
GuiChanges.h
GuiCharacter.cpp
GuiCharacter.h Fix doxygen output for grouped items. Without the /name tag doxygen shows the group name as the name of the first item. Moreover, the comment styles are somewhat standardized. 2010-01-27 18:10:33 +00:00
GuiCitation.cpp Move the citation engine machinery to layouts. 2012-03-01 00:41:30 +00:00
GuiCitation.h Move the citation engine machinery to layouts. 2012-03-01 00:41:30 +00:00
GuiClipboard.cpp Fix bug #6538 (Figure: relative path changed to absolute on copy/paste) 2010-12-11 23:04:24 +00:00
GuiClipboard.h Fix bug #6538 (Figure: relative path changed to absolute on copy/paste) 2010-12-11 23:04:24 +00:00
GuiCommandBuffer.cpp Revert "Don't allow newline characters in the command buffer." 2011-10-19 22:52:34 +00:00
GuiCommandBuffer.h
GuiCommandEdit.cpp
GuiCommandEdit.h
GuiCompare.cpp Fix bug #7540. Patch based upon one added to bug report by Max Funk. 2011-06-01 13:18:08 +00:00
GuiCompare.h Some cosmetics (from my local cosmetics branch). 2010-10-18 14:20:03 +00:00
GuiCompareHistory.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiCompareHistory.h These things need to be updated for each dialog opening 2010-09-07 11:29:05 +00:00
GuiCompleter.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiCompleter.h The Cursor argument here was not being used, so there is no need 2011-12-02 22:44:38 +00:00
GuiDelimiter.cpp * GuiDelimiter.cpp: disable cut and paste inside the listviews (bug 6942). 2010-10-15 07:12:49 +00:00
GuiDelimiter.h
GuiDialog.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiDialog.h Typos in the comment. 2011-02-13 09:59:14 +00:00
GuiDocument.cpp Fix thinkos in LaTeX font reading 2012-08-25 10:48:37 +02:00
GuiDocument.h Clean up LaTeX font handling (#4999) 2012-08-16 13:23:39 +02:00
GuiErrorList.cpp Generalize check to generic non-editable insets. 2011-04-05 15:40:00 +00:00
GuiErrorList.h Fix bug #6462: Out-of-bounds index in GuiErrorList::goTo when new buffer is active. 2010-03-12 15:06:13 +00:00
GuiERT.cpp remove unused include of FuncRequest 2010-08-24 03:07:09 +00:00
GuiERT.h InsetParamsWidget(): fix method constness. 2010-02-18 07:56:38 +00:00
GuiExternal.cpp Move readBB_from_PSFile() out of support (no code change), 2012-02-15 20:50:52 +00:00
GuiExternal.h
GuiFontExample.cpp
GuiFontExample.h
GuiFontLoader.cpp Add some extra information about bug #3684. 2010-12-29 05:50:50 +00:00
GuiFontLoader.h
GuiFontMetrics.cpp Fix bug #7187: Font painting problems with emulated scaling. 2010-12-29 05:35:03 +00:00
GuiFontMetrics.h Avoid narrowing in array initializator 2012-01-07 18:29:07 +00:00
GuiGraphics.cpp "Performance" fixes suggested by cppcheck 2012-05-28 22:42:44 +02:00
GuiGraphics.h
GuiGraphicsUi.h
GuiHSpace.cpp Simplify code a bit. 2011-11-23 16:49:34 +00:00
GuiHSpace.h InsetSpace support for 2011-08-29 14:07:30 +00:00
GuiHyperlink.cpp Fix assert in all InsetParamsWidget's for unicode characters (bug #7017) 2010-11-07 17:38:39 +00:00
GuiHyperlink.h Migrate GuiHyperlink to InsetParamsDialog. 2010-10-27 17:02:42 +00:00
GuiIdListModel.cpp Fix a couple of compilation issues with gcc 4.6. See bug #7285. 2011-02-07 22:47:02 +00:00
GuiIdListModel.h
GuiImage.cpp Proper camel case for FileName.absFilename 2010-04-21 01:19:09 +00:00
GuiImage.h
GuiInclude.cpp Fix the file filters for InsetInclude. 2011-09-13 20:43:06 +00:00
GuiInclude.h fix compiler warnings in pedantic mode: remove trailing comma after last enum member 2010-12-17 19:56:51 +00:00
GuiIndex.cpp
GuiIndex.h
GuiIndices.cpp Don't allow newline characters in document settings. 2011-09-24 16:39:23 +00:00
GuiIndices.h Rename QLineEdit widgets to have a LE suffix (consistent within GuiDocument). 2011-09-24 16:39:20 +00:00
GuiInfo.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiInfo.h InsetParamsWidget(): fix method constness. 2010-02-18 07:56:38 +00:00
GuiKeySymbol.cpp Allow dead caron to be recognized in our key bindings. 2012-06-14 12:44:16 +02:00
GuiKeySymbol.h
GuiLabel.cpp Fix assert in all InsetParamsWidget's for unicode characters (bug #7017) 2010-11-07 17:38:39 +00:00
GuiLabel.h Revert r35933. There are insets not based upon InsetCommand, such as 2010-10-31 18:56:32 +00:00
GuiLine.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiLine.h GuiLine: honor Abdel as author 2010-09-17 01:32:23 +00:00
GuiListings.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiListings.h
GuiLog.cpp * GuiLog.cpp: refine warning detection: 2010-08-02 16:38:41 +00:00
GuiLog.h
GuiMathMatrix.cpp This should be fixed. 2010-11-13 23:01:30 +00:00
GuiMathMatrix.h GuiMathMatrix: 2010-09-24 03:44:34 +00:00
GuiNomenclature.cpp Implement GuiNomenclature::initialiseParams(), thus restoring the 2011-09-11 14:14:04 +00:00
GuiNomenclature.h Implement GuiNomenclature::initialiseParams(), thus restoring the 2011-09-11 14:14:04 +00:00
GuiNote.cpp
GuiNote.h
GuiPainter.cpp Factor out painting of text decorations 2012-05-02 18:02:17 +02:00
GuiPainter.h Factor out painting of text decorations 2012-05-02 18:02:17 +02:00
GuiParagraph.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiParagraph.h
GuiPhantom.cpp
GuiPhantom.h
GuiPrefs.cpp Tracking correctly available translations (take 2) 2012-09-08 16:59:19 +02:00
GuiPrefs.h Use libmagic for file format detection if available. 2012-02-21 20:29:44 +00:00
GuiPrint.cpp Fix bug #7540. Patch based upon one added to bug report by Max Funk. 2011-06-01 13:18:08 +00:00
GuiPrint.h
GuiPrintindex.cpp Remove the name parameter from string2params and params2string. We can always derive the name with insetName(params.code()). 2010-10-29 00:25:28 +00:00
GuiPrintindex.h
GuiPrintNomencl.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiPrintNomencl.h Revert r35933. There are insets not based upon InsetCommand, such as 2010-10-31 18:56:32 +00:00
GuiProgress.cpp Fix bug #8032 (timeout when using the Sweave module) 2012-02-18 14:16:25 +00:00
GuiProgress.h Fix bug #8032 (timeout when using the Sweave module) 2012-02-18 14:16:25 +00:00
GuiProgressView.cpp fix bug #6748: queue LyXErrMessages so any other stuff is done 2010-06-03 21:24:20 +00:00
GuiProgressView.h Coding style, thanks Abdel. 2010-05-17 08:15:04 +00:00
GuiRef.cpp Remove the name parameter from string2params and params2string. We can always derive the name with insetName(params.code()). 2010-10-29 00:25:28 +00:00
GuiRef.h * GuiRef: improve filter UI 2010-01-30 11:19:48 +00:00
GuiSearch.cpp
GuiSearch.h
GuiSelection.cpp
GuiSelection.h
GuiSelectionManager.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiSelectionManager.h Take Andre's advice and implement the focus tracking using the event 2010-03-24 14:34:44 +00:00
GuiSendto.cpp Fix the outstanding part of #7764, which involves sorting the file lists 2011-10-30 20:02:14 +00:00
GuiSendto.h
GuiSetBorder.cpp * GuiSetBorder.cpp: lighter colour for disabled borders (not used currently). 2010-01-31 13:15:26 +00:00
GuiSetBorder.h
GuiShowFile.cpp support: 2010-04-21 01:19:28 +00:00
GuiShowFile.h
GuiSpellchecker.cpp Fix bug #8238: correct the forward argument of replace2string() in on_replacePB_clicked(). 2012-07-27 00:34:17 +02:00
GuiSpellchecker.h Fixes the following issues: 2011-04-08 13:26:45 +00:00
GuiSymbols.cpp
GuiSymbols.h
GuiTabular.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiTabular.h Fix #7021: the problem was that activating the border combo was triggering dialogToParams() and thus disallowed because of the empty value. 2010-12-04 10:55:03 +00:00
GuiTabularCreate.cpp
GuiTabularCreate.h
GuiTexinfo.cpp Also display the info about BibTeX databases in the TeX info panel. 2011-12-03 22:24:58 +00:00
GuiTexinfo.h Also display the info about BibTeX databases in the TeX info panel. 2011-12-03 22:24:58 +00:00
GuiThesaurus.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiThesaurus.h Implement access to hunspell's stemming function and let the Thesaurus use that (part of bug #8060). 2012-03-02 10:20:09 +00:00
GuiToc.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
GuiToc.h
GuiToolbar.cpp An IPA toolbar 2012-08-21 14:56:34 +02:00
GuiToolbar.h An IPA toolbar 2012-08-21 14:56:34 +02:00
GuiView.cpp Fix forward search with okular 2012-08-26 11:42:43 +02:00
GuiView.h Fix the messaging after an autosave 2011-10-30 21:34:12 +00:00
GuiViewSource.cpp Allow LyX format to be written to View>Source window. 2012-06-05 10:24:15 -04:00
GuiViewSource.h The View->Source pane resets the format every time you click into 2011-12-09 19:48:50 +00:00
GuiVSpace.cpp remove unused include of FuncRequest 2010-08-24 03:07:09 +00:00
GuiVSpace.h InsetParamsWidget(): fix method constness. 2010-02-18 07:56:38 +00:00
GuiWorkArea_Private.h Introduce new RC option for QImage backend instead of macro. This can later be changed at runtime though a command line option or by auto detecting the X11 remote status. 2011-12-17 21:53:46 +00:00
GuiWorkArea.cpp compile fix 2012-05-26 10:16:20 +02:00
GuiWorkArea.h Fix painting of hidden tabbar on gtk 2012-05-25 19:17:48 +02:00
GuiWrap.cpp
GuiWrap.h
IconPalette.cpp correct icon size in math panels 2010-09-24 12:59:43 +00:00
IconPalette.h
InGuiThread.cpp check also if there is a QApplication instance 2010-11-01 21:32:59 +00:00
InGuiThread.h Be compatible with Qt 4.2 and 4.3 (Q_EMIT). 2010-11-03 00:38:35 +00:00
InsertTableWidget.cpp Transfer LyXfunc code to GuiApplication::dispatch() and getStatus(). Now 2010-02-09 16:11:13 +00:00
InsertTableWidget.h
InsetParamsDialog.cpp Revert a6e42e5079. 2012-06-28 20:52:20 +02:00
InsetParamsDialog.h InsetParamsDialog: update the dialog settings on context change (on user request). 2011-01-31 14:48:16 +00:00
InsetParamsWidget.cpp set eol-style 2010-11-18 19:50:29 +00:00
InsetParamsWidget.h set eol-style 2010-11-18 19:50:29 +00:00
LaTeXHighlighter.cpp
LaTeXHighlighter.h
LayoutBox.cpp Fix crash reported by Scott. Forgot to change some pointers to 2012-06-04 13:04:26 -04:00
LayoutBox.h Cleanup private part of Layout Box on destructor (probably not really an 2011-10-15 13:34:14 +00:00
LengthCombo.cpp "Performance" fixes suggested by cppcheck 2012-05-28 22:42:44 +02:00
LengthCombo.h "Performance" fixes suggested by cppcheck 2012-05-28 22:42:44 +02:00
LyXFileDialog.cpp
LyXFileDialog.h
Makefile.am compilation fix; a couple of warnings 2011-10-17 08:57:28 +00:00
Menus.cpp Fix bug #8238: correct the forward argument of replace2string() in on_replacePB_clicked(). 2012-07-27 00:34:17 +02:00
Menus.h Remove extra whitespace. 2011-12-03 22:15:11 +00:00
PanelStack.cpp Fix the tab ordering of PanelStack and PrefsUi. 2011-09-24 16:39:26 +00:00
PanelStack.h Add a search box to the Document Settings and Preferences dialog. 2011-06-05 17:54:27 +00:00
pch.h
qt_helpers.cpp We don't need to rescan everything from the BibTeX dialog, just 2012-05-01 12:54:17 -04:00
qt_helpers.h We don't need to rescan everything from the BibTeX dialog, just 2012-05-01 12:54:17 -04:00
qt_i18n.h
README
TocModel.cpp Fix bug #7709. Seems we need to reset the source model here. 2011-11-23 16:52:46 +00:00
TocModel.h Make sure the Table of Contents is always on top in the model combobox of the TocWidget. 2010-04-26 01:36:24 +00:00
TocWidget.cpp Native support for \lstlistoflistings 2012-04-16 21:40:59 +02:00
TocWidget.h Attempt to workaround movement and editation slowness. 2010-12-19 22:27:21 +00:00
Toolbars.cpp An IPA toolbar 2012-08-21 14:56:34 +02:00
Toolbars.h An IPA toolbar 2012-08-21 14:56:34 +02:00
Validator.cpp "Performance" fixes suggested by cppcheck 2012-05-28 22:42:44 +02:00
Validator.h "Performance" fixes suggested by cppcheck 2012-05-28 22:42:44 +02:00

This file contains some do's and dont's for the Qt4 frontend.

General rules
-------------

Every editable field that affects the state of the dialog contents
from LyX's point of view should connect its xxxChanged() signal to
a the dialog's changed_adaptor() slot, which in turn should call
changed(). If you are using a more complicated thing anyway,
then remember to call changed() at the end (if it has changed!)

Every non-trivial widget should have a tooltip. If you don't know
what to write, write "FIXME", and it can fixed later. Don't be afraid
to use QWhatsThis too, but this must be done in the derived class's
constructor, and use _("..."). Non-trivial means that things like "OK"
/must not/ have a tooltip.

moc needs a fully qualified "std::string" for .connect() statements
to work. Be very, very careful.

Remember to check tab order on a dialog (third icon, with blue bars in
designer).

Remember to check sensible resizing behaviour on a dialog. This is
usually done by adding a top-level layout to the dialog in Designer.

Remember to use Edit->Check Accelerators

If necessary, you should override Qt2Base::isValid() for determining the
validity of the current dialog's contents.

OK/Apply/Restore/Close should be connected in the derived class's
constructor to call slotOK() etc. Refer to close/cancel as close in the
source.

Override update_contents() to update the dialog, not update().  Only
these functions may change dialog widgets that may emit changed() during
initialisation, to prevent the button controller from changing its
state.

Never call buttoncontroller functions directly from dialogs. In general,
you should use Qt2Base::changed() in all circumstances. However, if you
must call the buttoncontroller, make sure to respect Qt2Base::updating_

Naming conventions
------------------

QFoo.{cpp,h}     The file that interacts with the controller _and_
the implementation of the dialog, derived from the generated files
ui/FooDialog.ui  The designer file
ui_FooDialog.h   Generated files from FooDialog.ui

slots should be named e.g. slotFooClicked(), slotFooSelected(), where
foo is the name of the widget.

Widgets should be named like "fooXX", where XX is one of the following
widget types :

CB - check box
CO - combo box
ED - line edit
GB - group box
LA - label
LC - LengthCombo
LV - QListView
ML - QTextBrowser
PB - push button
RB - radio button
SB - spin box
SL - slider
TE - text edit
TW - tree widget (FIXME: also TV in some files)


Qt, Unicode, and LyX
--------------------

LyX uses a different encoding (UCS4) than Qt (UTF16), therefore there are a
number of conversion functions in qt_helpers.{cpp,h}. Read the doxygen
documentation for details when to use which function.

Additionally, you should follow these simple rules :

o Use qt_() not _() in code
o Use the conversion functions of qt_helpers.h, NOT .latin1() / .c_str() etc.