mirror of
https://git.lyx.org/repos/lyx.git
synced 2024-09-22 16:04:07 +00:00
4d5ae916ad
This changes the semantics of isOK() and operator(), comments from Bernhard below:
With the old version of lyxlex it was _impossible_ to check whether reading an integer, float, ... succeeded or not. The current solution to check for is.bad() in some cases and in other cases use is.good() does not give the desired information. Moreover the result of is.bad() depends on the stl implementation and behaves different for linux and windows.
the bug was introduced by the patch that fixed the bug that crashed lyx when "inset-insert ert" was executed from the command buffer.
The lexer has the method isOK() which reflects the status of the stream is.
The operators void* and ! are not really well defined (they depend on the value of is.bad()). What is missing is a test if the last reading operation was successful and thus the returned value is valid.
That's what i implemented in this patch.
The new rule for using the lexer:
if you want to know if the lexer still has data to read (either from the stream or from the pushed token) then use "lex.isOK()".
If you want to test if the last reading operation was successful then use eg. "if (lex) {...}" or unsuccessful then use eg. "if (!lex) {...}"
an example:
int readParam(LyxLex &lex) {
int param = 1; // default value
if (lex.isOK()) { // the lexer has data to read
int p; // temporary variable
lex >> p;
if (lex) param = p; // only use the input if the reading operation was successful
}
return param;
}
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@17569 a592a061-630c-0410-9148-cb99ea01b6c8
|
||
|---|---|---|
| .. | ||
| controllers | ||
| qt4 | ||
| Alert_pimpl.h | ||
| Alert.C | ||
| Alert.h | ||
| Application.C | ||
| Application.h | ||
| ChangeLog | ||
| Clipboard.h | ||
| Dialogs.C | ||
| Dialogs.h | ||
| FileDialog.h | ||
| FontLoader.h | ||
| FontMetrics.h | ||
| Gui.h | ||
| key_state.h | ||
| LyXKeySym.h | ||
| LyXKeySymFactory.h | ||
| LyXView.C | ||
| LyXView.h | ||
| Makefile.am | ||
| Menubar.h | ||
| mouse_state.h | ||
| NoGuiFontLoader.h | ||
| NoGuiFontMetrics.h | ||
| Painter.C | ||
| Painter.h | ||
| pch.h | ||
| Selection.h | ||
| Timeout.C | ||
| Timeout.h | ||
| Toolbars.C | ||
| Toolbars.h | ||
| WorkArea.C | ||
| WorkArea.h | ||