ASCEE/pyqtgraph
5
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Minor edits

Browse Source
This commit is contained in:
Luke Campagnola 2014-03-03 13:48:31 -05:00
parent c4880863b9
commit 3e764b00c2
3 changed files with 9 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG
View File

@ -64,6 +64,7 @@ pyqtgraph-0.9.9 [unreleased]
- Fixed MeshData exception caused when vertexes have no matching faces
- Fixed GLViewWidget exception handler
- Fixed unicode support in Dock
- Fixed PySide crash caused by emitting signal from GraphicsObject.itemChange
pyqtgraph-0.9.8 2013-11-24

1
README.md
View File

@ -27,6 +27,7 @@ Contributors
* Mattias Põldaru
* Thomas S.
* Mikhail Terekhov
* fabioz
Requirements
------------

26
pyqtgraph/graphicsItems/ViewBox/ViewBox.py
View File

@ -37,25 +37,13 @@ class ChildGroup(ItemGroup):
def __init__(self, parent):
ItemGroup.__init__(self, parent)
# Changed from the signal to a listener-weak-list because it was Crashing with PySide 1.2.1
#
# Seems to be related to the fact that sigItemsChanged is there but in the hierarchy it
# starts with 'object' and not 'QObject', as it's a
# pyqtgraph.graphicsItems.GraphicsItem.GraphicsItem.
#
# Crash (gotten with faulthandler):
# Current thread 0x00001adc:
# File "X:\pyqtgraph\pyqtgraph\graphicsItems\ViewBox\ViewBox.py", line 35 in itemChange
# File "X:\pyqtgraph\pyqtgraph\WidgetGroup.py", line 197 in acceptsType
# File "X:\pyqtgraph\pyqtgraph\WidgetGroup.py", line 187 in autoAdd
# File "X:\pyqtgraph\pyqtgraph\WidgetGroup.py", line 194 in autoAdd
# File "X:\pyqtgraph\pyqtgraph\WidgetGroup.py", line 132 in __init__
# File "X:\pyqtgraph\pyqtgraph\graphicsItems\ViewBox\ViewBoxMenu.py", line 41 in __init__
# File "X:\pyqtgraph\pyqtgraph\graphicsItems\ViewBox\ViewBox.py", line 185 in __init__
#
# Could not reproduce crash after changing to weak list (and note that crash didn't always
# happen even with signals, but when it did happen, it was always in the same place).
# Used as callback to inform ViewBox when items are added/removed from
# the group.
# Note 1: We would prefer to override itemChange directly on the
# ViewBox, but this causes crashes on PySide.
# Note 2: We might also like to use a signal rather than this callback
# mechanism, but this causes a different PySide crash.
self.itemsChangedListeners = WeakList()
# excempt from telling view when transform changes