ASCEE/pyqtgraph
5
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix TickSliderItem: Avoid ghost ticks | Improved customPlot.py code (#1459)

Browse Source 
* Fix TickSliderItem: Avoid ghost ticks | Improved customPlot.py code

If `TickSliderItem.setTickValue` was called when a full repaint of the `TickSliderItem` was
not already scheduled, the tick was visible at the old and the new position. This could e.g. be seen
when using the autoscale button in the `customPlot.py` example.

Further, code from `customPlot.py` is improved to make use of `Tick.setVisible` instead of adding and
removing ticks based on their visibility.

* customPlot.py: Explain bool conversion

Co-authored-by: 2xB <2xB@users.noreply.github.com>
This commit is contained in:
2xB 2020-11-27 07:28:03 +01:00 committed by GitHub
parent d2255228ba
commit 433b061e81
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
examples/customPlot.py
View File

@ -34,16 +34,16 @@ class CustomTickSliderItem(pg.TickSliderItem):
def __init__(self, *args, **kwds):
pg.TickSliderItem.__init__(self, *args, **kwds)
self.all_ticks = []
self.visible_ticks = {}
self.all_ticks = {}
self._range = [0,1]
def setTicks(self, ticks):
for tick, pos in self.listTicks():
self.removeTick(tick)
self.visible_ticks = {}
self.all_ticks = ticks
for pos in ticks:
tickItem = self.addTick(pos, movable=False, color="333333")
self.all_ticks[pos] = tickItem
self.updateRange(None, self._range)
@ -56,23 +56,17 @@ class CustomTickSliderItem(pg.TickSliderItem):
self._range = viewRange
for pos in self.all_ticks:
if pos not in self.visible_ticks:
self.visible_ticks[pos] = self.addTick(pos, movable=False, color="333333")
tick = self.visible_ticks[pos]
tickValueIncludingPadding = (pos - viewRange[0]) / (viewRange[1] - viewRange[0])
tickValue = (tickValueIncludingPadding*lengthIncludingPadding - origin) / length
visible = tickValue >= 0 and tickValue <= 1
# Convert from np.bool_ to bool for setVisible
visible = bool(tickValue >= 0 and tickValue <= 1)
tick = self.all_ticks[pos]
tick.setVisible(visible)
if visible:
self.setTickValue(tick, tickValue)
elif pos in self.visible_ticks:
self.removeTick(self.visible_ticks[pos])
del self.visible_ticks[pos]
app = pg.mkQApp()

1
pyqtgraph/graphicsItems/GradientEditorItem.py
View File

@ -342,6 +342,7 @@ class TickSliderItem(GraphicsWidget):
tick.setPos(pos)
self.ticks[tick] = val
self.update()
self.sigTicksChanged.emit(self)
self.sigTicksChangeFinished.emit(self)