ASCEE/pyqtgraph
5
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ScatterPlotItem: Fix a GC memory leak due to numpy issue 6581

Browse Source
This commit is contained in:
Ales Erjavec 2018-03-29 12:03:57 +02:00
parent ee0877170d
commit b3a579fd00
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pyqtgraph/graphicsItems/ScatterPlotItem.py
View File

@ -857,11 +857,18 @@ class SpotItem(object):
def __init__(self, data, plot): def __init__(self, data, plot):
#GraphicsItem.__init__(self, register=False) #GraphicsItem.__init__(self, register=False)
self._data = data self._data = data
self._plot = plot # SpotItems are kept in plot.data["items"] numpy object array which
# does not support cyclic garbage collection (numpy issue 6581).
# Keeping a strong ref to plot here would leak the cycle
self.__plot_ref = weakref.ref(plot)
#self.setParentItem(plot) #self.setParentItem(plot)
#self.setPos(QtCore.QPointF(data['x'], data['y'])) #self.setPos(QtCore.QPointF(data['x'], data['y']))
#self.updateItem() #self.updateItem()
@property
def _plot(self):
return self.__plot_ref()
def data(self): def data(self):
"""Return the user data associated with this spot.""" """Return the user data associated with this spot."""
return self._data['data'] return self._data['data']