Commit Graph

40953 Commits

Author SHA1 Message Date
Jean-Marc Lasgouttes
912704511b Make some constructors explicit
Spotted by cppcheck.
2019-09-17 23:15:09 +02:00
Jean-Marc Lasgouttes
3fffa6eb83 Fix cut-n-paste error
Spotted by cppcheck.
2019-09-16 00:47:47 +02:00
Jean-Marc Lasgouttes
3aba81cf6a Many small code cleanups suggested by cppcheck 2019-09-16 00:45:20 +02:00
Jean-Marc Lasgouttes
7c1891e0b4 Remove unused private members.
Spotted by cppcheck.
2019-09-16 00:17:08 +02:00
Jean-Marc Lasgouttes
a7c6940f14 Get rid of useless affectation
Spotted by cppcheck.
2019-09-16 00:03:56 +02:00
Jean-Marc Lasgouttes
c6d8592ffb Mark constructors with only one parameter as explicit
Spotted by cppcheck
2019-09-16 00:01:48 +02:00
Jean-Marc Lasgouttes
8d080364d2 Clarify calculation precedence for '&' and '?'
Spotted by cppcheck
2019-09-15 23:57:57 +02:00
Jean-Marc Lasgouttes
decd2c74f1 Mark constructors with only one parameter as explicit
Spotted by cppcheck
2019-09-15 23:56:17 +02:00
Jean-Marc Lasgouttes
19fb4db71e Make code more obvious
- use propoer parenthesis
- do not store in variable something we do not use

Spotted by cppcheck.
2019-09-15 23:31:32 +02:00
Jean-Marc Lasgouttes
02d55ab0b3 Avoid useless test
Spotted by cppcheck
2019-09-15 23:30:29 +02:00
Jean-Marc Lasgouttes
b42e6e96d8 Pass variable by reference
Spotted by cppcheck
2019-09-15 23:29:47 +02:00
Jean-Marc Lasgouttes
17c827d177 Various fixes suggested by cppcheck
Rename local variables the hide other ones: get_binary_path, find_python_binary

Use unsigned int for conversion from hex using sscanf().

FileName::checksum(), parsecmd (SystemCall): use explcit values rather
than variable which value is known.
2019-09-13 22:37:16 +02:00
Jean-Marc Lasgouttes
e3c5987806 Forgot to test aspell and hunspell support 2019-09-13 19:01:26 +02:00
Richard Kimberly Heck
c2f5c850d9 Use const & 2019-09-13 11:49:29 -04:00
Jean-Marc Lasgouttes
714113655a Follow some of the performance advice from cppcheck
Most of that is changing string to string const &.
2019-09-13 16:23:49 +02:00
Richard Kimberly Heck
94896166d4 Fix bug #11619. 2019-09-11 22:13:58 -04:00
Richard Kimberly Heck
e71280221f Fix nullptr warnings 2019-09-11 22:13:25 -04:00
Richard Kimberly Heck
fb79552ae0 Minor renaming for clarity. 2019-09-11 20:54:51 -04:00
Richard Kimberly Heck
05a446b77c Fix bug #11636.
Directories are created when files are copied, so we do not need
to do it prospectively here.
2019-09-11 20:54:42 -04:00
Richard Kimberly Heck
a20f3a0d52 Revert last two commits, which we pushed accidentally. 2019-09-11 20:47:07 -04:00
Richard Kimberly Heck
1fb308cd02 Whoops, forgot this part 2019-09-11 20:30:31 -04:00
Richard Kimberly Heck
26813996e2 Constify, largely for debugging purposes 2019-09-11 20:29:58 -04:00
Richard Kimberly Heck
2c0421f00c Constify 2019-09-11 19:39:03 -04:00
Jean-Marc Lasgouttes
7c1c50d737 Enable dissolve in undefined Flex inset context menu
This is a hackish special case, so I had to add a hack...

Fixes bug #8650.
2019-09-11 15:49:50 +02:00
Jean-Marc Lasgouttes
e1be71da59 Reset layout when inserting an inset over full paragraph(s)
1/ When inserting an inset over a selection, it makes sense if the
selection covers a complete or several paragraphs to reset the layout of
the paragraph that contains the inset to plain layout. In general the
inner inset will have the needed layout information and it does not
make sense to keep this information outside.

However, when the inset forces plain layout, it does not make sense to
do that and the outer layout is preserved.

Some code that duplicates what is done in pasteSelectionHelper is also
removed.

2/ Similarly, when dissolving an inset, do not reset the layout of the
first paragraph if the inset was alone in its own paragraph.

Note that this does not work as intended when change tracking is enabled.

Fixes bugs #10266 and #10369.
2019-09-11 10:39:02 +02:00
Juergen Spitzmueller
d76cef70a0 Allow to hide formats from menus
Fixes: #11657
2019-09-11 10:29:50 +02:00
Juergen Spitzmueller
9a0c52ed7e ru/Tutorial.lyx: update by Yuriy 2019-09-11 10:22:01 +02:00
Juergen Spitzmueller
ae67e54501 UserGuide: some typos fixed by Yuriy 2019-09-11 10:21:15 +02:00
Scott Kostyshak
ef6d83bc06 Give error if undefined citations with Biblatex
This commit catches situations when one key in a multi-key citation
is not defined. This commit causes an error to be given, but the
name of the key that is undefined is not provided in the error
dialog.

This commit is consistent with bf99ece7.

For more information, and possible follow-up discussion (e.g., on
putting the key in the error dialog), see the following ML thread:

https://www.mail-archive.com/search?l=mid&q=20190908165644.qnz6xu5bm5eqiko6%40boogie
2019-09-10 10:43:40 -04:00
Patrick de Visschere
b70c3796a1 #6961 correct the big-endian conversion of UInt32
This is a patch from Patrick de Visschere. Thanks.
2019-09-08 11:11:17 +02:00
Günter Milde
01ee3bf1e5 Minor update for supported-languages test. 2019-09-05 09:44:18 +02:00
Günter Milde
cec04267b2 Make preview skript Python-3 compatible. 2019-09-05 09:42:56 +02:00
Jean-Marc Lasgouttes
726ac31895 Reset directory after os.chdir
Related to bug #10454
2019-09-04 16:51:52 +02:00
Scott Kostyshak
db65b1a3c3 Port gnuplot2pdf.py to Python 3
Instead of wait(), use communicate(), as mentioned here:

  https://docs.python.org/3/library/subprocess.html

Otherwise, the process seems to hang as cautioned in the above URL.

Also, use byte strings.
2019-09-04 09:12:09 -04:00
Günter Milde
c138210672 ctests: update supported-languages tests.
Simplify user preamble.

Use common test document for Xe- and LuaTeX with polyglossia
and special one for languages only supported by XeTeX.

Update tagging patterns and comments.
2019-09-04 14:00:39 +02:00
Scott Kostyshak
48f88d550e Obs. APA: fix missing citations
The document now compiles and the ctests pass.
2019-09-02 22:22:20 -04:00
Scott Kostyshak
0344284e9b Fix origin path of three obsolete docs 2019-09-02 22:20:45 -04:00
Scott Kostyshak
80a675cd52 ctests: invert a test failing due to babel bug
This test fails with an updated TL, although it passes on some older
systems.
2019-09-02 20:55:38 -04:00
Günter Milde
3d0f39ea6a Update test document for supported languages. 2019-09-02 16:07:10 +02:00
Juergen Spitzmueller
8bfe3d7198 lyx2lyx: Fix revert_new_languages 2019-08-31 11:20:10 +02:00
Juergen Spitzmueller
38f4a77410 ru.po: Update from Yuriy 2019-08-31 10:40:57 +02:00
Scott Kostyshak
27f89144bb Enable change tracking if paragraph break change
When a selection spans more than one line, we now check for whether
there is a change at one position after the last position of each
fully selected line.

This fixes #11629.
2019-08-30 22:31:24 -04:00
Kornel Benko
91f7c3aacf Partially revert 6b014ec7
Allow use for font MonomakhUnicode. The font is available in texlive
and making a symbolic link in ~/.fonts/fonts to point to the appropriate
directory makes the font available to the system too.
2019-08-30 17:38:19 +02:00
Günter Milde
d2370de461 ctests: update unreliableTests 2019-08-30 16:24:49 +02:00
Scott Kostyshak
983fa4d9d8 ctests: uninvert AA tests thanks to recent fixes
Thanks to 54fd0a70, all AA tests can be uninverted except for two
texF tests.
2019-08-30 07:53:30 -04:00
Juergen Spitzmueller
087b4e39bb Hooked in one year too early 2019-08-30 08:27:34 +02:00
Juergen Spitzmueller
54fd0a70f4 Fix encoding in aa class, which is preset via class options
Hook into nearby file format change.
2019-08-30 08:09:57 +02:00
Scott Kostyshak
9efa348232 J of Acoustical Society: add a space before cite
Without the space, the citation followed directly the word "in".
2019-08-29 17:09:20 -04:00
Kornel Benko
6b014ec73b Autotests: Try to not use hard available fonts 2019-08-29 12:54:31 +02:00
Kornel Benko
3f543d2545 Fix test BATCH_outline-beamer 2019-08-29 10:54:02 +02:00