Commit Graph

3943 Commits

Author SHA1 Message Date
Vincent van Ravesteijn
573500dd04 Remove unneccessary uses of dynamic_cast from the code.
A dynamic_cast is necessary when:

- the object to be casted is from an external library because we can't add Qxxx::asXxxx() to Qt e.g.:
    * QAbstractListModel to GuiIdListModel,
    * QValidator to PathValidator,
    * QWidget to TabWorkArea,
    * QWidget to GuiWorkArea;

- the object is to be casted from an interface to the implementing class, because the Interface does not know by whom it is implemented:
    * ProgressInterface to GuiProgress,
    * Application to GuiApplication.

A dynamic_cast can be replaced by:
  - already existing as***Inset() functions, e.g.:
    * asHullInset(),
    * asInsetMath()->asMacro(),
    * asInsetText();

  - a static_cast when we are sure this can't go wrong, e.g.:
    * we are sure that CellData::inset->clone() is an InsetTableCell,
    * in cases where we explicitly check it->lyxCode().


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35855 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-26 15:03:51 +00:00
Uwe Stöhr
dbe3d79e15 InsetTabular.cpp: remove comment, we already discussed this and the star as default was the result
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35847 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-26 02:02:10 +00:00
Vincent van Ravesteijn
8693ae474b Proper implementatiom of isInToc()
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35846 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-26 01:10:19 +00:00
Vincent van Ravesteijn
2e42a7b645 We don't want InsetCommand to have a function updateCommand while this is not a special function of an InsetCommand, but only accidentally a shared function of two children. So, in this case I think we should just (dynamically) cast these objecten and call their own insetCommand function.
This also fixes compilation again. I forgot to cherry-pick all commits in git ;)...

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35845 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-25 23:20:05 +00:00
Uwe Stöhr
b7764dbe42 InsetCommand.h: revert my last commit - makes it worse than it helps as quick workaround
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35843 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-25 22:13:52 +00:00
Uwe Stöhr
8a4933f250 InsetCommand.h: reintroduce updateCommand from r35840 to make it compilable (this void is used in CutAndPaste.cpp); Vincent, can you please have a look?
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35842 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-25 21:51:28 +00:00
Vincent van Ravesteijn
6e0f8f89b0 InsetCommand.h: Reorder and add comments.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35840 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-25 20:20:44 +00:00
Vincent van Ravesteijn
f270358904 Correct toc to floatlist
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35839 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-25 19:53:40 +00:00
Vincent van Ravesteijn
75773f3c22 Use Buffer::ReadStatus as a return value for Buffer::loadLyXFile.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35818 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-25 10:18:42 +00:00
Stephan Witt
a2c998d5d0 avoid warnings for unused parameters
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35816 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-25 08:12:01 +00:00
Vincent van Ravesteijn
ba19e8b5dd Fix bug #1839: Ctrl+arrows don't move to next/prev table cell.
Patch from Punyashloka Biswal.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35812 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-25 01:18:48 +00:00
Pavel Sanda
0590c77d47 gcc spits out million warnings
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35807 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-24 21:46:28 +00:00
Vincent van Ravesteijn
72a93582b0 Add virtual bool Inset::clickable(..) to be used to change the cursor.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35804 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-24 20:11:40 +00:00
Vincent van Ravesteijn
72569c42ba Implement mouse hovering for InsetExternal.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35803 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-24 19:25:36 +00:00
Vincent van Ravesteijn
a77d991e24 setMouseHover() functions can be const.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35802 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-24 19:24:36 +00:00
Richard Heck
5aba6f4fab Make this a switch.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35758 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-21 18:01:06 +00:00
Richard Heck
bfa9991f93 Fix bug #6962. I hadn't see how these were being escaped.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35757 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-21 17:56:00 +00:00
Jürgen Spitzmüller
2cf666e3cd * InsetCommandParams.cpp (prepareCommand):
- properly terminate LaTeX macros (reported in bug 6959). 

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35746 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-21 13:16:28 +00:00
Vincent van Ravesteijn
152491f916 Some cosmetics (from my local cosmetics branch).
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35708 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-18 14:20:03 +00:00
Richard Heck
4ff48f1d54 Need ifthen for this, too.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35647 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-14 14:02:49 +00:00
Richard Heck
85904c550d Add ResetsFont tag to InsetLayout, toward fixing bug #5657.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35626 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-13 15:54:39 +00:00
Richard Heck
01013c0785 Refstyle support. The user can now choose between prettyref and restyle
for formatted references. Fixes #2295, in so far as it makes it possible
to translate formatted references.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35623 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-13 12:36:53 +00:00
Richard Heck
2a63b2d1cb Customize getLayout for InsetFlex and change how we report name() back
to the simple version. We need to do it this way because we should NOT
really require the "Flex" prefix and, in fact, should permit other
prefixes to be used. Next commit for that.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35613 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-12 15:37:02 +00:00
Richard Heck
226853c060 style
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35611 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-12 15:07:27 +00:00
Richard Heck
d4634167cc Get rid of "CharStyle:", "Custom:", and "Element:" prefixes, per a
suggestion of JMarc's. Docs to follow.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35608 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-12 14:46:17 +00:00
Uwe Stöhr
e8a1fed47c InsetBibtex.cpp:
- fix #1881, fileformat change
- fix #6470

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35590 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-11 01:05:20 +00:00
Uwe Stöhr
5606b7d875 InsetBibitem.cpp: fix #5786
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35582 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-09 16:02:19 +00:00
Uwe Stöhr
27423f93ba InsetTabular.cpp: fix #6907, patch by goriccardo
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35561 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-05 01:14:34 +00:00
Uwe Stöhr
03a2216981 InsetGraphics.cpp and InsetInclude.cpp: whitespace fixes
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35517 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-27 03:21:59 +00:00
Uwe Stöhr
b33182bc3d filetools.cpp: introduce a new method to be able to distinguish between valid LaTeX filenames and filenames causing troubles on some DVI viewers.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35514 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-27 02:39:22 +00:00
Pavel Sanda
f2c388a519 Allow InsetPreview in no math preview mode.
Patch from Ronen Abravanel
http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg161966.html

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35456 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-19 22:33:55 +00:00
Pavel Sanda
65962da47b Add support for feyn package and Diagram inset.
Patch from Ronen Abravanel.
http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg161952.html

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35455 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-19 22:12:06 +00:00
Jürgen Spitzmüller
0b17cb1135 * ExternalSupport.cpp:
- do not popup invalid path warning with View Source (bug 6904).

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35449 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-19 16:30:17 +00:00
Uwe Stöhr
3a400812e1 InsetLine.h revert changes made in r35417
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35428 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-17 23:12:19 +00:00
Uwe Stöhr
92c8604313 InsetLine:
- honor Abdel as author
- reintroduce the /// spacers in the header file because it makes it better readable and we do this in all other inset header files

GuiLine: honor Abdel as author

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35417 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-17 01:28:08 +00:00
Abdelrazak Younes
17ab5f5a38 InsetLine: Fix vertical positioning, offset is really an offset from the
text baseline, not from the middle of the line.

We are now getting much closer to LateX drawing...


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35413 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-16 10:40:19 +00:00
Abdelrazak Younes
3b512d5915 header cleanup and doxy.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35412 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-16 10:14:46 +00:00
Abdelrazak Younes
31c75d260e Remove uneeded hack.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35411 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-16 09:49:43 +00:00
Abdelrazak Younes
08453ceba4 Fix InsetLine painting for exotic offset and heigth.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35407 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-16 07:36:20 +00:00
Richard Heck
fbc092639c Part of #6893.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35389 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 13:51:06 +00:00
Richard Heck
b5d2e9d285 Fix output of HTML tags in bibliography info.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35388 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 13:50:17 +00:00
Richard Heck
7f0b1d1cbb Fix i18n for InsetBibtex.
It would be better to get the paragraph language here. How to do that?


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35386 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 13:28:55 +00:00
Abdelrazak Younes
c01de9fd41 * add InsetLine::dimension() to avoid calling InsetCommand::dimension()
* InsetLine::draw() bit of code shuffling.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35384 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 12:43:07 +00:00
Abdelrazak Younes
15679c3e82 revert r35374 and further improve the metrics and drawing code.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35377 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 11:19:29 +00:00
Richard Heck
14015ec434 Void functions don't return things. ;-)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35376 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-15 01:03:13 +00:00
Uwe Stöhr
573abee2b5 InsetLine.cpp: correct coding style
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35375 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-14 23:35:12 +00:00
Uwe Stöhr
e33e3dd815 InsetLine.cpp: restore the drawing routine after r35373, see http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg161800.html
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35374 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-14 23:24:57 +00:00
Abdelrazak Younes
d1f08cbc57 Fix InsetLine metrics and drawing.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35373 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-14 14:56:41 +00:00
Abdelrazak Younes
24ff65acc4 coding style and C++ fixes.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35370 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-14 13:42:09 +00:00
Stephan Witt
c4d00e85eb implement isChar() in header like all other insets
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35368 a592a061-630c-0410-9148-cb99ea01b6c8
2010-09-14 12:39:33 +00:00