Jean-Marc Lasgouttes
4b8e5a9d53
Another unreachable `return' that is not needed
...
The compilers we use now do not care, but coverity complains.
2017-03-09 15:12:03 +01:00
Jean-Marc Lasgouttes
ce0c11ba4e
Remove unreachable return statements
...
They were needed long ago to avoid gcc warnings, but now all they do
is create coverity warnings.
2017-03-09 15:05:33 +01:00
Jean-Marc Lasgouttes
5a62e37add
Handle the case where doc_bv is null
...
It might only happens in specific cases where no file is open and for
some reason the new file cannot be opened.
2017-03-09 14:41:27 +01:00
Jean-Marc Lasgouttes
f7ab893def
Avoid dereferencing an iterator at the end
...
Found by coverity, could lead to a crash with badly formed kmap file.
2017-03-09 14:26:17 +01:00
Richard Heck
4569010b66
Add a comment.
2017-03-08 17:34:07 -05:00
Jean-Marc Lasgouttes
dee0ea0c21
Make a test clearer
...
This should hopefully please coverity now. For some reason, the
annotation did not work. Should it be in lower case?
2017-03-08 17:03:48 +01:00
Jean-Marc Lasgouttes
000dcb8672
Make a false positive explicit
...
Pleases coverity
2017-03-08 16:50:03 +01:00
Jean-Marc Lasgouttes
2d86b2debb
Fix missing initialization
...
This was already fixed after coverity report at bad511f3fe
,
but this part was missing.
2017-03-08 16:41:42 +01:00
Jean-Marc Lasgouttes
f0ab93c4b8
Initialize members spotted by coverity
2017-03-08 16:37:53 +01:00
Jean-Marc Lasgouttes
ed15c31bf8
Make a dummier LyXRC for tex2lyx
...
The old version made coverity complain about uninitialized members.
The new one is the same as in support/tests/dummy_impl.cpp.
2017-03-08 16:37:53 +01:00
Scott Kostyshak
37290fdb61
Describe the use of '*' in -e/-E CL options
...
The use of '*' in buffer-export was implemented at 494ce664
.
2017-03-08 00:36:28 -05:00
Scott Kostyshak
24ad64c406
Implement '*' in "buffer-export <FORMAT> <DEST>"
...
For the variant of buffer-export that allows a format and a
filename, the substitution must be done after the argument is split.
Related to 494ce664
.
2017-03-08 00:36:28 -05:00
Kornel Benko
2136887ea2
Typo: Copy/Paste error
2017-03-07 14:40:56 +01:00
Kornel Benko
5d3d26b024
Cmake build: Adapt handling of mytheslib to automek behaviour
...
The added cmake-parameter is:
-DLYX_EXTERNAL_MYTHES=<value>
where <value> is one of
AUTO (Default) Search first on system for mythes (lib and include)
ON Use installed only (errors if not installed)
OFF Compile the provided source in 3rdparty
2017-03-07 14:27:08 +01:00
Jean-Marc Lasgouttes
dc126bad04
Fix typo found by coverity
...
We were not testing for the right end(), although it is not sure that
an actual bug could be triggered because of that.
2017-03-07 12:02:54 +01:00
Jean-Marc Lasgouttes
25d64bf43a
Fix test to make coverity happy
...
It is not obvious that cur is not null iff thisSlice is not -1, but
this is what happens in the caller.
2017-03-07 11:56:59 +01:00
Jean-Marc Lasgouttes
55957c4576
Fix test to make coverity happy
...
It is not obvious that cur is not null iff thisSlice is not -1, but
this is what happens in the caller.
2017-03-07 11:48:32 +01:00
Jean-Marc Lasgouttes
bb7551258c
Fix distcheck for mythes
...
For some reason, I mistyped "myspell" instead of "mythes" as a reflex. I
thought that I fixed all occurences, but it appears that I missed
one...
2017-03-07 11:14:58 +01:00
Kornel Benko
15babdc0f1
Amend 0e50ad8
'move mythes sources to 3rdparty' for cmake build.
2017-03-06 19:31:23 +01:00
Jean-Marc Lasgouttes
0e50ad8b16
Update bundled mythes to version 1.2.5
...
Move it to 3rdparty/ directory alongside the other ones.
2017-03-06 17:08:38 +01:00
Jean-Marc Lasgouttes
8cb021b32f
Rewrite detection of MyThes library
...
Now configure searches in this order
1. system-installed library
2. code bundled with LyX
If --with-included-mythes or if no mythes library is installed, then
the script selects the bundled version. There should be no cases
leading to error message.
2017-03-06 16:10:11 +01:00
Guillaume Munch
3d2d02510a
Amend 841825aa56
...
sort alphabetically
2017-03-06 01:01:11 +01:00
Guillaume Munch
3d06c09d8d
Fix color of todo notes
...
Yellow on blue causes display issues (some text elements that become black on
blue, math insets that are no longer readable). Switch to black on orange to
match the pdf output.
2017-03-05 08:45:52 +01:00
Guillaume Munch
841825aa56
Add default export to the menu
2017-03-05 08:45:52 +01:00
Guillaume Munch
76f3f6eb01
Fix warning
2017-03-05 08:45:52 +01:00
Guillaume Munch
a0ce37147c
Allow Ctrl+Enter in GuiCitation even if the citation is already there
2017-03-05 08:45:52 +01:00
Guillaume Munch
354897f6d9
Tabular::editXY should not touch the selection
2017-03-05 08:45:52 +01:00
Guillaume Munch
494ce6647a
buffer-export * synonymous to buffer-export
2017-03-05 08:45:52 +01:00
Uwe Stöhr
79241febf6
ja.po: update for master from Koji
2017-03-05 01:07:53 +01:00
Enrico Forestieri
5940dc53aa
Fix bug #10579
...
The \lyxdeleted macro cannot cope with empty lines.
2017-03-03 13:00:32 +01:00
Jean-Marc Lasgouttes
aa6619237d
Fixup to 2f701e6a1
...
Use the bundled mythes by default again, since the current situaiton
create an error for anybody who does not have the system one
installed.
This is a stop gap measure and I'll return to it later (in a hurry now).
2017-03-03 12:01:54 +01:00
Kornel Benko
ef05496ce9
Cmake tests: Add visual indication if a test is ignoring some latex error messages
2017-03-02 15:53:34 +01:00
Jean-Marc Lasgouttes
1de8ab6ed5
Try to see if coverity annotations should be in lower case
...
The current one did not work.
2017-03-02 15:24:12 +01:00
Jean-Marc Lasgouttes
f4f84ef9a3
Initialisize properly member variables
...
Instead of using a coverity annotation (that does not work) it is
better to really iinitialize the members of the object, just in case
somebody decides to actually use the DisplayPath() constructor.
2017-03-02 15:20:46 +01:00
Jean-Marc Lasgouttes
5ad8815a51
Please coverity properly
2017-03-02 14:47:31 +01:00
Jean-Marc Lasgouttes
2f701e6a1c
Clarify configure help for 3rd party code
...
The configure code suggests that the default for
--with-included-(iconv|zlib|hunspell) is "yes", which is wrong: by
default is indeed to use the system libraries.
Change the MyThes detection to use the system version by default.
Also add to the verison information a line which lists the bundled libraries.
2017-03-02 14:35:39 +01:00
Günter Milde
5637c9b321
ctests: Add test file for "exotic" inputencoding cp858.
...
Encoding cp858 is only supported by some iconv variants
Gnu iconv only supports it, if configured with "--enable-extra-encodings"
(see https://www.gnu.org/software/libiconv/ )
Maybe drop support or add a configuration check?
2017-03-01 23:16:59 +01:00
Kornel Benko
513bb5dad0
Remove regex which does mot mach any test
2017-03-01 18:49:22 +01:00
Günter Milde
42e9c448b0
ctests: Fix some "unreliable" patterns.
2017-03-01 18:31:44 +01:00
Jean-Marc Lasgouttes
ae6e6b3e47
Try another way to signal a false positive to coverity
2017-03-01 17:44:02 +01:00
Jean-Marc Lasgouttes
5453e00cfa
Do not return a reference to a temporary variable
...
Coverity correctly spotted that the existing code creates a temporary
map and returns a value from it. It is not possible to make the map
const& directly because operator[] may change the map.
Therefore, we use map::find instead.
2017-03-01 17:37:41 +01:00
Jean-Marc Lasgouttes
1f10969bb5
Add missing initialization
...
Spotted by coverity
2017-03-01 17:25:03 +01:00
Jean-Marc Lasgouttes
a2425c7121
Initialize properly TextEntry variable
...
Not sure it fixes a bug, but it should calm down coverity.
2017-03-01 17:18:19 +01:00
Jean-Marc Lasgouttes
91d8a3982d
Initialize properly several InsetQuote members
...
Spotted by coverity
2017-03-01 17:02:20 +01:00
Jean-Marc Lasgouttes
dc385a8b97
Fix coverity false positive
...
The fall through was intended at db889bc6
.
2017-03-01 16:42:28 +01:00
Jean-Marc Lasgouttes
e8b744ad2e
Fix broken logic
...
Spotted by coverity.
2017-03-01 16:36:46 +01:00
Jean-Marc Lasgouttes
f52325f051
Initialize pointer class member
...
Found by coverity.
2017-03-01 16:34:01 +01:00
Jean-Marc Lasgouttes
9251a360a9
Initialize class member to please coverity
2017-03-01 16:31:00 +01:00
Jean-Marc Lasgouttes
af45bfaee1
Initialize class members to please coverity
2017-03-01 16:28:30 +01:00
Jean-Marc Lasgouttes
ea8f0d2076
Initialize properly a class member
...
This was forgotten at 0552563c99
, and it only meant to keep coverity happy.
2017-03-01 16:21:45 +01:00