Pavel Sanda
b7af21ad7c
Fix memory leak.
...
Spotted by Scott.
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg210447.html
2020-02-18 10:03:42 +01:00
Stephan Witt
fc790bc1f5
Add missing check for nullptr on check of language encoding of next paragraph.
2020-02-18 09:03:20 +01:00
Stephan Witt
f904fb2d61
Add missing initialization for local variable.
...
The autoargs variable is random for empty macro argument lists otherwise.
2020-02-18 08:59:20 +01:00
Stephan Witt
fe02f151f9
Remove useless assignments to a local variables never read later.
2020-02-18 08:55:45 +01:00
Stephan Witt
225de7830e
Remove useless assignment to a local variables never read later.
2020-02-18 08:55:00 +01:00
Stephan Witt
febbc3537a
Avoid crashes in case of missing document buffer for buffer based conversions.
2020-02-18 08:43:22 +01:00
Richard Kimberly Heck
731feb9f18
Silence some clang warnings.
2020-02-17 12:31:38 -05:00
Richard Kimberly Heck
fb03f2a5ec
Fix a strange warning in QtCreator:
...
/cvs/lyx/lyx-devel/src/frontends/qt/TocModel.cpp:356: warning: loop variable 'toc' has type 'const pair<std::string, shared_ptr<lyx::Toc> > &' (aka 'const pair<basic_string<char>, shared_ptr<vector<lyx::TocItem> > > &') but is initialized with type 'const std::pair<const std::__cxx11::basic_string<char>, std::shared_ptr<std::vector<lyx::TocItem, std::allocator<lyx::TocItem> > > >' resulting in a copy
/cvs/lyx/lyx-devel/src/frontends/qt/TocModel.cpp:356: use non-reference type 'pair<std::string, shared_ptr<lyx::Toc> >' (aka 'pair<basic_string<char>, shared_ptr<vector<lyx::TocItem> > >') to keep the copy or type 'const std::pair<const std::__cxx11::basic_string<char>, std::shared_ptr<std::vector<lyx::TocItem, std::allocator<lyx::TocItem> > > > &' to prevent copying
Easier just to use 'auto'.
2020-02-17 12:31:38 -05:00
Stephan Witt
f12c4dbcd9
Remove unnecessary assertion after explicit buffer pointer check.
2020-02-17 14:35:03 +01:00
Stephan Witt
a1d68511ac
Avoid potential crashes with missing document buffer in dispatch of buffer based LFUNs.
...
Use LASSERT with appropriate action instead of LATTEST assertions.
Debug build is unchanged and asserts, release build skips the action gracefully.
2020-02-17 13:36:37 +01:00
Stephan Witt
0f1f00db27
Code cleanup: avoid repeating temp_dir method calls while local variable has a result already.
2020-02-17 13:25:35 +01:00
Juergen Spitzmueller
4debbdd6b6
Restore custom tmp directory
...
Fixes #1174
2020-02-17 09:00:08 +01:00
Scott Kostyshak
562917dc1c
lyxpreview_tools.py: fix a regular expression
...
Three backslashes are needed before a LaTeX command, not one. Before
this commit, the code gave the following error with Python >= 3.6:
re.error: bad escape \g at position 29
This error was introduced with Python 3.6, as documented [1] by the
following line of documentation:
Changed in version 3.6: Unknown escapes in pattern consisting of
'\' and an ASCII letter now are errors.
Although previous Python versions did not give an error, the regular
expression was not working as intended: for example, the "\\n" in
"\\newcommandx" would be interpreted as a new line.
[1] https://docs.python.org/3.6/library/re.html#re.sub
2020-02-15 21:57:30 -05:00
Pavel Sanda
2db6a81156
Unify handling in dispatchVC.
...
All these check could be actually dropped, because unless dispatchVC
is called directly, getstatus would already handle it.
2020-02-15 20:55:14 +01:00
Kornel Benko
f5551bec15
Amend 43dfd12f
2020-02-15 12:21:32 +01:00
Kornel Benko
3f2c315530
Cmake tests: Correct test BATCH_outline-beamer
2020-02-15 10:26:33 +01:00
Kornel Benko
43dfd12fd7
Cmake build: Files already removed, but in 'git status' still present.
...
This is a try to really remove them.
2020-02-15 10:11:28 +01:00
Juergen Spitzmueller
e31364fdcb
whitespace
2020-02-15 09:26:43 +01:00
Juergen Spitzmueller
195393f401
Fix Python detection on windows
...
Patch by Eugene Chornyi
2020-02-15 09:26:08 +01:00
Stephan Witt
6dab8739eb
Avoid uninitialized position variables in case of current inset not doing the assignment
2020-02-14 12:11:10 +01:00
Stephan Witt
ab877352e7
Use the application id of lyx to address the running LyX instance
2020-02-14 12:06:08 +01:00
Stephan Witt
983da7d6de
Put the LyX window frontmost automatically on Mac on successful reverse search
2020-02-13 16:39:14 +01:00
Stephan Witt
aca95619b8
Avoid potential leak of memory pointed to by QStandardItem catItem
2020-02-13 16:39:14 +01:00
Juergen Spitzmueller
c4da8d38c9
Handle encoding error in layout file parsing more gracefully
...
Issue a warning about non-decodable files, but do not break
completely.
Addresses #11736
2020-02-13 08:13:22 +01:00
Richard Kimberly Heck
b175f5a315
Fix bug #11737 .
...
We need to use the FileName methods when moving or removing a file,
so that refresh() gets called.
(cherry picked from commit d930913898
)
2020-02-13 00:11:23 -05:00
Juergen Spitzmueller
40b1a6f9b1
Revert "Fix bug #11712."
...
This breaks on Linux
This reverts commit fdf81a9bab
.
2020-02-12 16:11:01 +01:00
Richard Kimberly Heck
fdf81a9bab
Fix bug #11712 .
...
Fixes some escaping issues on Windows especially
Patch from Eugene.
2020-02-12 09:25:13 -05:00
Stephan Witt
e900b61d46
Make cell index of tabular local for column loop.
2020-02-12 12:32:31 +01:00
Stephan Witt
3ee1bcad04
Remove another unnecessary assignment
2020-02-12 12:28:18 +01:00
Kornel Benko
cd3f11e585
Cmake build: Amend 1c097e56
, correctly respect the patch-level
...
Handle also the case of creating from tar-file _and_ having 'git' installed
2020-02-12 12:02:36 +01:00
Enrico Forestieri
926c846abb
Remove unnecessary assignments
2020-02-10 21:59:52 +01:00
Enrico Forestieri
536d476d38
Make sure to not dereference a null pointer.
2020-02-10 21:54:07 +01:00
Juergen Spitzmueller
b8546139c8
Properly resize columns of child document table widget
2020-02-07 17:23:14 +01:00
Juergen Spitzmueller
4fd4310ea7
Indentation fixes
2020-02-07 16:03:56 +01:00
Stephan Witt
59fa0b2592
Fix a crash with uninitialized buffer member of MathData
...
See the details here: https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg210294.html
2020-02-07 10:17:33 +01:00
Stephan Witt
2817439ddd
Allow externally provided list of components to skip for Qt framework builds on macOS
2020-02-06 22:19:15 +01:00
Stephan Witt
6e54c86a86
More flexible definition of Qt libraries to include as frameworks for macOS
2020-02-06 22:17:35 +01:00
Stephan Witt
a3e14fe6cd
Care for Qt library source directory rename for 5.12.x
2020-02-06 22:16:13 +01:00
Stephan Witt
6b48c45c54
Enhanced version string extraction for 3rd party libraries.
2020-02-06 22:15:08 +01:00
Stephan Witt
a50e07db46
update canAutoOpenFile/autoOpenFile implementation to new MacOSX API, avoid deprecated calls
2020-02-06 21:52:46 +01:00
Enrico Forestieri
4e3567523a
Fix syntax error with Python 2
...
Python 2 wants b"..." and gives error win rb"...".
2020-02-06 10:50:02 +01:00
Richard Kimberly Heck
5188f0fcff
Don't need to remove the file if it doesn't exist. (This would cause a five second delay in that case.)
2020-02-03 11:37:12 -05:00
Scott Kostyshak
05f2494008
Remove a finishUndo() after a recordUndo()
...
finishUndo() is only helpful in the presence of undos of type INSERT
or DELETE.
See the following ML thread for details:
https://www.mail-archive.com/search?l=mid&q=b721c098-c7ee-d12f-1cdf-067dda9aa5cf%40lyx.org
2020-02-02 16:10:59 -05:00
Juergen Spitzmueller
dce9e44a14
Ignore geometry-related settings if the class provides geometry
...
Fixes #11724
2020-01-29 11:25:01 +01:00
Jean-Marc Lasgouttes
4d6041a7b6
Adopt a 'belt and braces' approach to bidi forcing
...
There are two techniques that I know of for forcing the direction of a
string, regardlessly of whether its contents is naturally LtR, RtL or
undecided.
1/ The unicode LTR/LTR override characters. This is supposed to be the
clean way, however, it does not seem to work with Qt 5.14 (see
#11691 ).
2/ The undocumented QTextLayout::setFlags method. This is used
internally and allows to pass the (undocumented) flags
Qt::TextForceRightToLeft and Qt::TextForceLeftToRight. This was
used until we had issues with Qt 5.11 (see #11284 ).
In order to get the best of both worlds, this patch allows to enable
those two methods separately, and actually enables both at the same
time by default!
(hopefully) Fixes bug #11691 .
2020-01-27 23:23:10 +01:00
Juergen Spitzmueller
a6f9c6ae43
move lyx-fedora script to attic/
2020-01-27 18:43:40 +01:00
Jean-Marc Lasgouttes
c5530589bb
Fix missing backspace in msgstr
2020-01-27 15:40:40 +01:00
Jean-Marc Lasgouttes
4f4d52e8c0
Fix warning with --disable-nls
2020-01-27 15:34:27 +01:00
Juergen Spitzmueller
b2b7e5cac1
Amend 400706ad05
2020-01-27 11:15:49 +01:00
Kornel Benko
9fdc00fe2a
Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()
2020-01-27 10:44:14 +01:00