Jean-Marc Lasgouttes
ce0c11ba4e
Remove unreachable return statements
...
They were needed long ago to avoid gcc warnings, but now all they do
is create coverity warnings.
2017-03-09 15:05:33 +01:00
Jean-Marc Lasgouttes
5a62e37add
Handle the case where doc_bv is null
...
It might only happens in specific cases where no file is open and for
some reason the new file cannot be opened.
2017-03-09 14:41:27 +01:00
Jean-Marc Lasgouttes
f7ab893def
Avoid dereferencing an iterator at the end
...
Found by coverity, could lead to a crash with badly formed kmap file.
2017-03-09 14:26:17 +01:00
Richard Heck
4569010b66
Add a comment.
2017-03-08 17:34:07 -05:00
Jean-Marc Lasgouttes
dee0ea0c21
Make a test clearer
...
This should hopefully please coverity now. For some reason, the
annotation did not work. Should it be in lower case?
2017-03-08 17:03:48 +01:00
Jean-Marc Lasgouttes
000dcb8672
Make a false positive explicit
...
Pleases coverity
2017-03-08 16:50:03 +01:00
Jean-Marc Lasgouttes
2d86b2debb
Fix missing initialization
...
This was already fixed after coverity report at bad511f3fe
,
but this part was missing.
2017-03-08 16:41:42 +01:00
Jean-Marc Lasgouttes
f0ab93c4b8
Initialize members spotted by coverity
2017-03-08 16:37:53 +01:00
Jean-Marc Lasgouttes
ed15c31bf8
Make a dummier LyXRC for tex2lyx
...
The old version made coverity complain about uninitialized members.
The new one is the same as in support/tests/dummy_impl.cpp.
2017-03-08 16:37:53 +01:00
Scott Kostyshak
37290fdb61
Describe the use of '*' in -e/-E CL options
...
The use of '*' in buffer-export was implemented at 494ce664
.
2017-03-08 00:36:28 -05:00
Scott Kostyshak
24ad64c406
Implement '*' in "buffer-export <FORMAT> <DEST>"
...
For the variant of buffer-export that allows a format and a
filename, the substitution must be done after the argument is split.
Related to 494ce664
.
2017-03-08 00:36:28 -05:00
Kornel Benko
5d3d26b024
Cmake build: Adapt handling of mytheslib to automek behaviour
...
The added cmake-parameter is:
-DLYX_EXTERNAL_MYTHES=<value>
where <value> is one of
AUTO (Default) Search first on system for mythes (lib and include)
ON Use installed only (errors if not installed)
OFF Compile the provided source in 3rdparty
2017-03-07 14:27:08 +01:00
Jean-Marc Lasgouttes
dc126bad04
Fix typo found by coverity
...
We were not testing for the right end(), although it is not sure that
an actual bug could be triggered because of that.
2017-03-07 12:02:54 +01:00
Jean-Marc Lasgouttes
25d64bf43a
Fix test to make coverity happy
...
It is not obvious that cur is not null iff thisSlice is not -1, but
this is what happens in the caller.
2017-03-07 11:56:59 +01:00
Jean-Marc Lasgouttes
55957c4576
Fix test to make coverity happy
...
It is not obvious that cur is not null iff thisSlice is not -1, but
this is what happens in the caller.
2017-03-07 11:48:32 +01:00
Kornel Benko
15babdc0f1
Amend 0e50ad8
'move mythes sources to 3rdparty' for cmake build.
2017-03-06 19:31:23 +01:00
Jean-Marc Lasgouttes
0e50ad8b16
Update bundled mythes to version 1.2.5
...
Move it to 3rdparty/ directory alongside the other ones.
2017-03-06 17:08:38 +01:00
Guillaume Munch
3d2d02510a
Amend 841825aa56
...
sort alphabetically
2017-03-06 01:01:11 +01:00
Guillaume Munch
841825aa56
Add default export to the menu
2017-03-05 08:45:52 +01:00
Guillaume Munch
76f3f6eb01
Fix warning
2017-03-05 08:45:52 +01:00
Guillaume Munch
a0ce37147c
Allow Ctrl+Enter in GuiCitation even if the citation is already there
2017-03-05 08:45:52 +01:00
Guillaume Munch
354897f6d9
Tabular::editXY should not touch the selection
2017-03-05 08:45:52 +01:00
Guillaume Munch
494ce6647a
buffer-export * synonymous to buffer-export
2017-03-05 08:45:52 +01:00
Enrico Forestieri
5940dc53aa
Fix bug #10579
...
The \lyxdeleted macro cannot cope with empty lines.
2017-03-03 13:00:32 +01:00
Jean-Marc Lasgouttes
1de8ab6ed5
Try to see if coverity annotations should be in lower case
...
The current one did not work.
2017-03-02 15:24:12 +01:00
Jean-Marc Lasgouttes
f4f84ef9a3
Initialisize properly member variables
...
Instead of using a coverity annotation (that does not work) it is
better to really iinitialize the members of the object, just in case
somebody decides to actually use the DisplayPath() constructor.
2017-03-02 15:20:46 +01:00
Jean-Marc Lasgouttes
5ad8815a51
Please coverity properly
2017-03-02 14:47:31 +01:00
Jean-Marc Lasgouttes
ae6e6b3e47
Try another way to signal a false positive to coverity
2017-03-01 17:44:02 +01:00
Jean-Marc Lasgouttes
5453e00cfa
Do not return a reference to a temporary variable
...
Coverity correctly spotted that the existing code creates a temporary
map and returns a value from it. It is not possible to make the map
const& directly because operator[] may change the map.
Therefore, we use map::find instead.
2017-03-01 17:37:41 +01:00
Jean-Marc Lasgouttes
1f10969bb5
Add missing initialization
...
Spotted by coverity
2017-03-01 17:25:03 +01:00
Jean-Marc Lasgouttes
a2425c7121
Initialize properly TextEntry variable
...
Not sure it fixes a bug, but it should calm down coverity.
2017-03-01 17:18:19 +01:00
Jean-Marc Lasgouttes
91d8a3982d
Initialize properly several InsetQuote members
...
Spotted by coverity
2017-03-01 17:02:20 +01:00
Jean-Marc Lasgouttes
dc385a8b97
Fix coverity false positive
...
The fall through was intended at db889bc6
.
2017-03-01 16:42:28 +01:00
Jean-Marc Lasgouttes
e8b744ad2e
Fix broken logic
...
Spotted by coverity.
2017-03-01 16:36:46 +01:00
Jean-Marc Lasgouttes
f52325f051
Initialize pointer class member
...
Found by coverity.
2017-03-01 16:34:01 +01:00
Jean-Marc Lasgouttes
9251a360a9
Initialize class member to please coverity
2017-03-01 16:31:00 +01:00
Jean-Marc Lasgouttes
af45bfaee1
Initialize class members to please coverity
2017-03-01 16:28:30 +01:00
Jean-Marc Lasgouttes
ea8f0d2076
Initialize properly a class member
...
This was forgotten at 0552563c99
, and it only meant to keep coverity happy.
2017-03-01 16:21:45 +01:00
Enrico Forestieri
17ab47b3e6
Allow Input of local includes from local layout files
...
When including files, LyX always searches the user and the system
directory, in that order. This means that when using local layout
files broken down into multiple includes, the various includes should
be specified with a path relative to the user layouts directory
(typically ~/.lyx/layouts), making this very impractical.
This commit allows including local files by specifying their path
as explicitly relative to the main layout file position, i.e., by
specifying their path with either "./" or "../". If the main layout
is not loaded from a local file, the usual search order is used,
even if the path are explicitly relative. So, for system layouts,
both "Input ./name.inc" and "Input name.inc" are equivalent.
2017-03-01 09:19:18 +01:00
Guillaume Munch
a1faa41c83
buffer-export without argument exports the default format
...
buffer-export is proposed as a default binding in the preferences so now it does
what a user expects when binding it to a key.
2017-02-28 00:46:33 +01:00
Guillaume Munch
887722dbfa
Remove LyXToolBox
...
It extended QToolBox with size calculation to fix UI issues with the previous
design of GuiCitation. Since it always needed some kind of hack and since
QToolBoxes do not appear so popular, it probably won't be used anymore.
2017-02-26 22:16:10 +01:00
Guillaume Munch
06416763ac
Give focus to the filter in GuiRef
...
This is now consistent with GuiCitation. Compared to the previous behaviour
there is only one down key press difference.
2017-02-26 22:16:10 +01:00
Guillaume Munch
750c48eda3
Fix focus events in GuiCitation
2017-02-26 22:16:10 +01:00
Guillaume Munch
d50b66fc88
Whitespace and remove obsolete #ifdef.
2017-02-26 22:16:10 +01:00
Guillaume Munch
eab83ec678
Implement down key press in FancyLineEdit
2017-02-26 22:16:10 +01:00
Guillaume Munch
e6180e9914
Implement left-right navigation in GuiCitation
2017-02-26 22:16:10 +01:00
Guillaume Munch
26b2cc89d3
Fix 18 memory leaks
...
Also whitespace.
2017-02-26 22:16:10 +01:00
Enrico Forestieri
3c329db0a5
Allow inserting consecutive dashes
...
Because latex allows to do so, and there is no easy way to achieve this.
This was apparently implemented to allow cycling between the various dash
types, but it was a bad idea bringing no benefit and causing griefs.
2017-02-25 14:13:02 +01:00
Juergen Spitzmueller
73ccee113e
rename BufferParams::font_encoding() to ::main_font_encoding()
...
Because that's what's actually returned.
2017-02-25 12:49:49 +01:00
Jean-Marc Lasgouttes
83cf59cf94
Remove unreachable return statement
...
ALso re-indent a bit.
Fixes coverity issue 134137
2017-02-25 00:32:58 +01:00