Commit Graph

76 Commits

Author SHA1 Message Date
Richard Heck
75bfed5507 Fix trailing whitespace in cpp files. 2017-07-03 13:53:14 -04:00
Jean-Marc Lasgouttes
2d86b2debb Fix missing initialization
This was already fixed after coverity report at bad511f3fe,
but this part was missing.
2017-03-08 16:41:42 +01:00
Guillaume Munch
e1492a3ab1 Use the new infrastructure to select rows during error reporting 2016-10-22 23:24:00 +02:00
Juergen Spitzmueller
ad9887da9c Simplify BufferParams::bufferFormat()
The differentiation of "xetex" and "platex" is not needed here,
is ambiguous and confusing (see #10013). The code that relies on
it can/should get its information otherwise.

Furthermore, polyglossia-exclusive languages now also work with
LuaTeX, since we support LuaTeX + polyglossia.
2016-07-11 11:18:55 +02:00
Juergen Spitzmueller
65173b26d5 Generate a proper error dialog title for XeTeX/LuaTeX
(see bug #10013)

Candidate for stable
2016-07-10 11:14:03 +02:00
Jean-Marc Lasgouttes
bad511f3fe Initialize correctly GuiErrorList::from_master_ in constructor
Found by Coverity
2016-06-09 16:58:13 +02:00
Juergen Spitzmueller
80f992fc29 Show Anyway button needs to be enabled/disabled in paramsToDialog.
Else, the state set on first launch persists, notwithstanding the change of function state.
2015-04-05 10:50:30 +02:00
Scott Kostyshak
09700d5b71 Button for showing PDF if compilation error
Building on cd8be655, we still allow viewing a produced PDF even if
there were compilation errors. However, now the user must click the
"Show Output Anyway" button in the LaTeX Errors dialog. The reason
is that before, there was a chance that the user would not realize
there was an error (because the PDF would be shown over the error
dialog). The approach in this commit makes it more clear that there
is an error.

A new LFUN is introduced, LFUN_BUFFER_VIEW_CACHE. It is useful not
just for the implementation of the "Show Output Anyway" button, but
also to show the last compiled version of a document, which can save
time if a document takes a long time to compile (e.g. heavy use of
knitr).
2015-04-04 13:13:19 -04:00
Jean-Marc
93a43742a5 Fix a bunch of small performance issues spotted by cppcheck
Most of these are about passing const strings parameters as references.
2014-07-05 19:13:10 +02:00
Juergen Spitzmueller
a70571258d Fix assertion when ChkTeX hit math.
The problem here was that we used texted-only methods (via paragraph()), which triggered the assertion as soon as we were inside math.

Fixes: #8798
2014-04-21 11:51:57 -04:00
Enrico Forestieri
13dd04602a Generalize check to generic non-editable insets.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38257 a592a061-630c-0410-9148-cb99ea01b6c8
2011-04-05 15:40:00 +00:00
Enrico Forestieri
bd744cac00 Fix bug #7420 (ASSERTION when moving paragraph up in info inset)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@38251 a592a061-630c-0410-9148-cb99ea01b6c8
2011-04-05 01:00:30 +00:00
Vincent van Ravesteijn
eec88b7e5e Revert wrong previous commit.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37959 a592a061-630c-0410-9148-cb99ea01b6c8
2011-03-19 10:34:59 +00:00
Vincent van Ravesteijn
e52af5f897 Simplify logic in InsetRef::latex().
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37958 a592a061-630c-0410-9148-cb99ea01b6c8
2011-03-19 10:31:43 +00:00
Enrico Forestieri
397c03b433 Fix bug #7361 (Assertion when a latex error occurs in the first (empty) paragraph)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37954 a592a061-630c-0410-9148-cb99ea01b6c8
2011-03-18 17:26:17 +00:00
Enrico Forestieri
32ea651007 Revert r37801 and r37870. They are superseded by r37894.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37895 a592a061-630c-0410-9148-cb99ea01b6c8
2011-03-10 04:10:21 +00:00
Enrico Forestieri
d5f56e67e0 Each line of the exported latex code is associated to a particular par.id()
of a lyx document. What par.id() is associated to the line depends on the
last call of TexRow::start() before a newline is actually issued.
If the par.id() of an ert is the one associated to the exported line,
when an error occurs, that ert is always returned by Buffer::getParFromID()
(and thus would be highlighted) whether the error actually occurred there
or elsewhere in the same paragraph.
So, better highlighting the whole paragraph when the error seems to have
occurred in ert.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37870 a592a061-630c-0410-9148-cb99ea01b6c8
2011-03-07 20:15:04 +00:00
Enrico Forestieri
2e18f6a671 Fix bug #7331 (No error highlighting in child documents)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37845 a592a061-630c-0410-9148-cb99ea01b6c8
2011-03-04 13:37:14 +00:00
Enrico Forestieri
b8cdbc7be8 Partial fix for bug #7330 (No error notification with 'View master document')
With this patch, the bug is fixed when export-in-thread is disabled.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37842 a592a061-630c-0410-9148-cb99ea01b6c8
2011-03-03 13:57:46 +00:00
Enrico Forestieri
25e98edd00 Please Abdel
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37802 a592a061-630c-0410-9148-cb99ea01b6c8
2011-02-28 15:45:53 +00:00
Enrico Forestieri
2761cd67bb Fix bug #7325 (ASSERTION when moving paragraph down in info inset)
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37801 a592a061-630c-0410-9148-cb99ea01b6c8
2011-02-28 15:35:29 +00:00
Enrico Forestieri
f8446ecd41 Improve comment
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37780 a592a061-630c-0410-9148-cb99ea01b6c8
2011-02-24 02:01:31 +00:00
Enrico Forestieri
3891b7ae06 If a paragraph has zero size, highlight the previous one.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37779 a592a061-630c-0410-9148-cb99ea01b6c8
2011-02-24 01:31:20 +00:00
Enrico Forestieri
9866d2a097 Compile fix for those systems where pos_type is not typedef'd to int.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37751 a592a061-630c-0410-9148-cb99ea01b6c8
2011-02-21 16:08:02 +00:00
Enrico Forestieri
a6ed69049d If the latex log points to an error at the end of a paragraph, we highlight
the last thing in the paragraph (an inset, generally), as the end of
paragraph cannot be highlighted.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37749 a592a061-630c-0410-9148-cb99ea01b6c8
2011-02-21 10:27:50 +00:00
Enrico Forestieri
7569903af6 For some reason, when a latex error occurs, it may happen that
err.pos_start > err.pos_end such that range == 0 and nothing
gets highlighted, even if the paragraph id is correct.
In this case, it is better to highlight everything.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@37586 a592a061-630c-0410-9148-cb99ea01b6c8
2011-02-10 21:28:43 +00:00
Richard Heck
ee7dd4a11e Whitespace.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35653 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-14 20:49:34 +00:00
Richard Heck
aa473bb568 Comments.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35652 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-14 15:04:57 +00:00
Richard Heck
b1df2bd306 Move the screen redraw call out of the selection-setting routine. This
avoids multiple screen redraws in some cases.

If someone knows how to fix the FIXMEs in GuiErrorList and
GuiSpellcheker, I'd really appreciate it.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35651 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-14 15:02:48 +00:00
Richard Heck
f0833aa774 This is already done by the previous call.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@35632 a592a061-630c-0410-9148-cb99ea01b6c8
2010-10-13 18:03:10 +00:00
Richard Heck
5e0de68db5 Minor cleanup, and some const-ness.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33734 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-13 16:55:59 +00:00
Pavel Sanda
9be4767f27 Fix Error dialog. Patch from Richard and Abdel.
http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg158649.html
http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg158658.html


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33732 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-13 11:39:50 +00:00
Vincent van Ravesteijn
7d30e34b08 Fix bug #6462: Out-of-bounds index in GuiErrorList::goTo when new buffer is active.
Cache the buffer and errorList in the GuiErrorList dialog. Now, we can check whether the active buffer is also the buffer for which the errors are shown. We switch back to the correct buffer, when one clicks on an item or clicks "View complete log".

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33726 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-12 15:06:13 +00:00
Vincent van Ravesteijn
2ef545a250 Fix bug #6397: use GUIfied strings in the error dialog.
Forward port of r33408 (commit by Juergen).

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33725 a592a061-630c-0410-9148-cb99ea01b6c8
2010-03-12 13:47:28 +00:00
Vincent van Ravesteijn
0422422caf Fix bug #2179: GuiErrorList resets to first item.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@32222 a592a061-630c-0410-9148-cb99ea01b6c8
2009-11-28 00:52:08 +00:00
Jürgen Spitzmüller
b7c0fe942b * direct access from the error dialog to the LaTeX log.
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@31980 a592a061-630c-0410-9148-cb99ea01b6c8
2009-11-14 15:52:54 +00:00
Jürgen Spitzmüller
5a54d11157 * Pop up error dialog if issuing master-buffer-[view|update] and errors occured.
Navigating in such dialogs does not work yet, but at least the user is informed
  at all that LaTeX wasn't succesful.

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@30209 a592a061-630c-0410-9148-cb99ea01b6c8
2009-06-21 12:26:41 +00:00
Jürgen Spitzmüller
b394f9998f * GuiErrorList.cpp (showEvent):
- add missing dialog update to fix a problem reported on the users list
	  and here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=506183
	  (missing package error not shown).

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@27679 a592a061-630c-0410-9148-cb99ea01b6c8
2008-11-23 10:55:41 +00:00
André Pönitz
6192345f60 add Buffer * member to DocIterator
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@27603 a592a061-630c-0410-9148-cb99ea01b6c8
2008-11-17 11:46:07 +00:00
André Pönitz
1fc477efac thrid attempt at changing the naming pattern of the intermediated 'mocced' files
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@27420 a592a061-630c-0410-9148-cb99ea01b6c8
2008-11-14 14:28:50 +00:00
Edwin Leuven
29f052bc3d make error dialog more comprehensible:
1. selects the 1st error so that the error message shows
2. adds labels to the listwidgets in the dialog
3. adds a tooltip to the error listwidget

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@27007 a592a061-630c-0410-9148-cb99ea01b6c8
2008-10-21 09:07:15 +00:00
Abdelrazak Younes
53acfb8351 Dialogs: discourage non const access to buffer() and bufferview().
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26620 a592a061-630c-0410-9148-cb99ea01b6c8
2008-09-29 10:52:17 +00:00
Jean-Marc Lasgouttes
f3a1cdabe9 for some reason, itemSelectionChanged does not trigger in a reliable way and the error descriptions are bogus
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26545 a592a061-630c-0410-9148-cb99ea01b6c8
2008-09-25 16:16:25 +00:00
Jürgen Spitzmüller
855c185881 * GuiErrorList.cpp:
- fix display of error description for preamble errors (bug 5007).

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@25728 a592a061-630c-0410-9148-cb99ea01b6c8
2008-07-20 17:05:58 +00:00
André Pönitz
7934e9c224 wrong editor settings from wrong project...
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@25460 a592a061-630c-0410-9148-cb99ea01b6c8
2008-07-06 10:56:47 +00:00
André Pönitz
6ee64a4812 fix crash.
that's not a proper solution, though.


git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@25459 a592a061-630c-0410-9148-cb99ea01b6c8
2008-07-06 10:55:47 +00:00
Jürgen Spitzmüller
fb69a2e3e4 * GuiErrorList.{cpp,h}:
- Fix error navigation with the keyboard (bug 4895).

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@24998 a592a061-630c-0410-9148-cb99ea01b6c8
2008-05-29 12:37:22 +00:00
Jean-Marc Lasgouttes
6f5e86e065 more compile fixes
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23052 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-18 09:55:14 +00:00
Abdelrazak Younes
2bf1c09376 header cleanup
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23049 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-18 07:14:42 +00:00
Abdelrazak Younes
ba76bf5eb8 header cleanup
git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23048 a592a061-630c-0410-9148-cb99ea01b6c8
2008-02-17 20:47:04 +00:00