Commit Graph

37644 Commits

Author SHA1 Message Date
Juergen Spitzmueller
9b128671a5 {Over,under}full [hv]box warning is a warning.
Since this is something one should be aware of, make it more prominent
in the Log dialog.
2017-07-24 09:09:48 +02:00
Juergen Spitzmueller
a40868510d Do not error on missing ZWNJ (ligature break) characters.
Since TeXLive 2016, "fontspec" maps the ligature break command
\textcompwordmark to the ZWNJ character (U+200C).
This character is missing in many fonts (including the default: Latin
Modern) which leads to "Missing character" warnings in the XeTeX/LuaTeX
log file if a document using non-TeX fonts contains a ligature break.

LyX reports missing characters as error since fixing #9610.
In case of "invisible" characters, there is no data loss, in case of the
ZWNJ the functionality is kept: ligatures are prevented also if the ZWNJ
is missing in a font.

Therefore, a missing ZWNJ is now treated similar to missing characters
in "nullfont" (see [63f41711/lyxgit], bug #10394) and does not trigger
an error.

Fixes: #10727
2017-07-23 18:41:06 +02:00
Juergen Spitzmueller
3c7b75c5bc Properly import \newtheorem*
Fixes: #10622
2017-07-23 13:20:56 +02:00
Christian Ridderström
e30f3d76d2 Bulk cleanup/fix incorrect annotation at the end of namespaces.
This commit does a bulk fix of incorrect annotations (comments) at the
end of namespaces.

The commit was generated by initially running clang-format, and then
from the diff of the result extracting the hunks corresponding to
fixes of namespace comments. The changes being applied and all the
results have been manually reviewed. The source code successfully
builds on macOS.

Further details on the steps below, in case they're of interest to
someone else in the future.

1. Checkout a fresh and up to date version of src/

    git pull && git checkout -- src && git status src

2. Ensure there's a suitable .clang-format in place, i.e. with options
   to fix the comment at the end of namespaces, including:

    FixNamespaceComments:                           true
    SpacesBeforeTrailingComments:                   1

and that clang-format is >= 5.0.0, by doing e.g.:

    clang-format -dump-config | grep Comments:
    clang-format --version

3. Apply clang-format to the source:

    clang-format -i $(find src -name "*.cpp" -or -name "*.h")

4. Create and filter out hunks related to fixing the namespace

    git diff -U0 src > tmp.patch
    grepdiff '^} // namespace' --output-matching=hunk tmp.patch  > fix_namespace.patch

5. Filter out hunks corresponding to simple fixes into to a separate patch:

    pcregrep -M -e '^diff[^\n]+\nindex[^\n]+\n--- [^\n]+\n\+\+\+ [^\n]+\n'  \
        -e '^@@ -[0-9]+ \+[0-9]+ @@[^\n]*\n-\}[^\n]*\n\+\}[^\n]*\n'         \
        fix_namespace.patch > fix_namespace_simple.patch

6. Manually review the simple patch and then apply it, after first
   restoring the source.

    git checkout -- src
    patch -p1 < fix_namespace_simple.path

7. Manually review the (simple) changes and then stage the changes

    git diff src
    git add src

8. Again apply clang-format and filter out hunks related to any
   remaining fixes to the namespace, this time filter with more
   context. There will be fewer hunks as all the simple cases have
   already been handled:

    clang-format -i $(find src -name "*.cpp" -or -name "*.h")
    git diff src > tmp.patch
    grepdiff '^} // namespace' --output-matching=hunk tmp.patch  > fix_namespace2.patch

9. Manually review/edit the resulting patch file to remove hunks for files
   which need to be dealt with manually, noting the file names and
   line numbers. Then restore files to as before applying clang-format
   and apply the patch:

    git checkout src
    patch -p1 < fix_namespace2.patch

10. Manually fix the files noted in the previous step. Stage files,
    review changes and commit.
2017-07-23 13:11:54 +02:00
Juergen Spitzmueller
d50e2aa7bf typo in comment 2017-07-23 12:11:03 +02:00
Juergen Spitzmueller
94d45d9c56 Some comments wrt log file encoding (#10728) 2017-07-23 12:06:58 +02:00
Juergen Spitzmueller
7609221ada Use appropriate conv. method
These are plain ASCII strings, no need for local8bit conversion.
2017-07-23 09:37:11 +02:00
Kornel Benko
d3b2cb0922 Select Latin Modern fonts for beamer lyx-files
On TL17, the original default fonts used to work only with help of fix-cm package.
Only the Japanese bemer files are unchanged, because the output was only a mix
of Latin letters and thus not readable. Probably missing font on my side.
2017-07-22 00:22:00 +02:00
Uwe Stöhr
a425b37dd2 pt_BR.po: updates for 2.3 from Georger 2017-07-21 02:28:33 +02:00
Jean-Marc Lasgouttes
c7647eb394 Make InsetInfo active agin (aka the vengeance of the neverending saga)
This is a fixup to fc7fb6a564. The fix in there seems perfectly
correct (up to now), but for some reason, I could not refrain from
making InsetInfo not active. "What could possibly go wrong?", I heard
myself think.

Now I know: this causes an assertion error in InsetText::updateBuffer
because DocIterator::forwardPos does not enter the inset anymore.
2017-07-20 23:56:45 +02:00
Jean-Marc Lasgouttes
fc7fb6a564 Try to end the neverending fixIfBroken saga
This is a fixup to the  series of commits 522516d9, d0acc3e5, 13c3c148.

Actually the right thing to consider in all situations is isActive(),
which really means `can a cursor be in there?'.

Improve the description of isActive() and editable() in Inset.h.

Set isActive() to false for InsetInfo, since no cursor should ever go there.

Again part of #10667.
2017-07-20 11:18:20 +02:00
Pavel Sanda
4d09650e93 Changes approved by Juergen. 2017-07-19 14:38:46 +02:00
Juergen Spitzmueller
59a6552bb3 de and de-alt reviewed. 2017-07-19 14:30:51 +02:00
Juergen Spitzmueller
943da868a4 de.po: review of 'list of listings' 2017-07-19 14:27:37 +02:00
Pavel Sanda
a69e3df7b2 layouttranslations.review: "it" was obviously checked by Enrico (coming from minted) 2017-07-19 13:53:57 +02:00
Pavel Sanda
cd7b22221d We have new translation which slipped through the cracks. 2017-07-19 13:36:06 +02:00
Pavel Sanda
2cfc970015 layouttranslations: new untracked movements for "List of listings".
Likely follow-up from ab47e48dcc.
2017-07-19 13:29:57 +02:00
Kornel Benko
57f6a95e90 Update some translation by Jari-Matti Mäkelä 2017-07-19 12:40:15 +02:00
Pavel Sanda
0dbfa04c15 Typo in lib/layouttranslations makefile machinery. 2017-07-19 12:38:13 +02:00
Kornel Benko
5fc1837e2d Update fi.po
Translations from Jari-Matti Mäkelä <jmjmak@utu.fi>
2017-07-19 12:02:01 +02:00
Juergen Spitzmueller
9bc47b83cb Some minor polishment and comments. 2017-07-19 10:22:13 +02:00
Juergen Spitzmueller
e79782c4cc Scripts for connecting LyX with evince for backward/forward search
The scripts have been initially developed by Benjamin Kellermann (2011)
as a derivation of gedit-synctex-plugin by José Aliste
(https://github.com/jaliste/gedit-synctex-plugin, 2010) and published on
https://ubuntuforums.org/showthread.php?t=1716268.

The work here is based on a further derivation of this work for Sublime
Text LaTeX Tools
(https://github.com/SublimeText/LaTeXTools/tree/master/evince).

Adaptations for the use with LyX as well as the initial translation of
the evince_sync bash script to python have been done by myself.

The python code (particularly evince_sync_lyx) needs audit!
2017-07-18 19:08:44 +02:00
Christian Ridderström
5078448111 Fix minor whitespace error.
Fix the whitespace in e.g. 'QString&' to 'QString &' as this
incorrect, but primarily to simplify a comparison related to
later possibly introducing the use of .clang-format.
2017-07-17 22:23:17 +02:00
Guillaume MM
47612b3839 Accept modifications in R examples 2017-07-17 22:15:12 +02:00
Guillaume MM
6b0381b386 Define theorem counter for acmart layout 2017-07-17 21:57:39 +02:00
Juergen Spitzmueller
272cb6b464 Add some notes on forward/reverse search with evince.
Evince is a special case, since it provides f/r search not via command
line switches and pref settings, but via DBUS. On Linux at least, this
can be used by LyX via some external scripts. The possibility is now
mentioned here, the details (and the scripts) are provided on the wiki.
2017-07-17 10:26:43 +02:00
Enrico Forestieri
aeead38d90 Update lib/Makefile.am 2017-07-16 11:22:05 +02:00
Jean-Marc Lasgouttes
a39a98f422 Fix comment 2017-07-15 18:41:56 +02:00
Enrico Forestieri
8ee2d74def Classic icon for toolbar-toggle-review 2017-07-15 16:43:18 +02:00
Jean-Marc Lasgouttes
ebb9d7b058 Avoid multiple execution of AddToPreamble and friends
When trying to read a textclass, read(Lexer, Readtype) parses and
executes the first token and only then verifies that its effect was to
set format properly. Otherwise it exits.

This is wrong, because if the first tag is "AddToPreamble", then it will
have modified the preamble by the time we notice it was not "Format" and
therefore exit.

The new code starts by requiring a correct "Format" tag.

Fixes bug #10725.
2017-07-15 16:34:48 +02:00
Enrico Forestieri
bebfa84d79 Oxygen icon for toolbar-toggle-review 2017-07-15 16:12:40 +02:00
Enrico Forestieri
2460d5904d Tweak some icons
- Move down the ERT icon
- Remove the transparent background from note icons as it turns out
  not to be transparent on some combinations of platform/Qt version
2017-07-15 15:27:36 +02:00
Enrico Forestieri
d0989c9a53 Better icon for toolbar-toggle-review 2017-07-15 15:04:00 +02:00
Scott Kostyshak
bc7aa4062b sv.po: translation update from Jim Rotmalm 2017-07-15 04:45:07 -04:00
Scott Kostyshak
8bde9e15c0 Update of Swedish splash.lyx from Jim Rotmalm 2017-07-15 04:22:33 -04:00
Scott Kostyshak
4d0c29d58a uk.gmo: update to match latest po
This amends ca0ba098 and f01ca45d.
2017-07-15 04:13:06 -04:00
Kornel Benko
12a2565b97 Cmake build: Use the same destination for lyx-tex-files as in automake 2017-07-14 11:24:20 +02:00
Juergen Spitzmueller
271cea8665 de.po: address shortcut clash 2017-07-14 09:23:22 +02:00
Jean-Marc Lasgouttes
04eef3480f Fix generation of lyx_commit_hash.h
The code in the Makefile was incorrect.
2017-07-13 18:14:03 +02:00
jpc
c9f398d7c5 Copy documentation of new features of Additional.lyx in de, es, fr and ja documentation files
as change tracking and remove chnage tracking in Additional.lyx
2017-07-12 22:31:30 +02:00
jpc
5cf91ca811 Translations of backports from 2.2 from Uwe 2017-07-12 21:44:05 +02:00
jpc
c5ea42efe5 Typo in fr.po 2017-07-12 18:20:52 +02:00
Jean-Marc Lasgouttes
f6e37a8ca0 TextMetrics::leftMargin does not need a max_width parameter
Additionally move it to private: section.
2017-07-12 10:29:27 +02:00
Jean-Marc Lasgouttes
0d565f7b35 When cleaning up before quitting, take care of exceptions
We do not want the cleanup work to be interrupted by a buffer exception.

Spotted by coverity. See bug #9979 for discussion.
2017-07-11 15:30:32 +02:00
Jean-Marc Lasgouttes
fc75cbd88f Remove copy-and-paste error 2017-07-11 13:43:32 +02:00
Jean-Marc Lasgouttes
cfd27dd219 Do not record undo when typing two spaces has been blocked
Move the code that forbids character insertion in its own helper function.

Call this function before doing a recordUndo. This avoids to mark the
document dirty in cases where nothing happens.

Part of bug #10721.
2017-07-11 12:15:29 +02:00
Juergen Spitzmueller
7945ba0cb0 Load color before polyglossia also in preview snippets
This fixes an error in the preview generation with polyglossia
and bidi that prevents snippet generation (and consequently also
"math as image" xhtml output).

Fixes: #10716.
2017-07-11 10:03:03 +02:00
Kornel Benko
e23e65a973 Cmake build: Install lyx-provided fonts to where GuiFontLoader.cpp expects them 2017-07-10 13:17:29 +02:00
jpc
56f11bf5fd Forgot 1 fuzzy in fr.po 2017-07-10 11:45:31 +02:00
jpc
cdb65e852c Update fr.po for beta 2017-07-10 11:10:06 +02:00